Mercurial > hg > xemacs-beta
changeset 5360:46b53e84ea7a
#'substring-no-properties: check STRING's type, get_string_range_char won't.
src/ChangeLog addition:
2011-02-24 Aidan Kehoe <kehoea@parhasard.net>
* fns.c (Fsubstring_no_properties):
Sigh, get_string_range_char checks the type of its START and END
arguments, but doesn't check the type of its STRING
argument. Thank you Raymond Toy!
tests/ChangeLog addition:
2011-02-24 Aidan Kehoe <kehoea@parhasard.net>
* automated/lisp-tests.el (substring-no-properties):
Make sure this function checks its arguments' types, the absence
of which was revealed by Raymond Toy's bug report of
http://mid.gmane.org/4D65D413.5050103@gmail.com .
| author | Aidan Kehoe <kehoea@parhasard.net> |
|---|---|
| date | Thu, 24 Feb 2011 09:36:19 +0000 |
| parents | f5a5501814f5 |
| children | 1cfe6b84efbf |
| files | src/ChangeLog src/fns.c tests/ChangeLog tests/automated/lisp-tests.el |
| diffstat | 4 files changed, 19 insertions(+), 0 deletions(-) [+] |
line wrap: on
line diff
--- a/src/ChangeLog Sat Feb 19 11:03:46 2011 +0000 +++ b/src/ChangeLog Thu Feb 24 09:36:19 2011 +0000 @@ -1,3 +1,10 @@ +2011-02-24 Aidan Kehoe <kehoea@parhasard.net> + + * fns.c (Fsubstring_no_properties): + Sigh, get_string_range_char checks the type of its START and END + arguments, but doesn't check the type of its STRING + argument. Thank you Raymond Toy! + 2011-02-19 Aidan Kehoe <kehoea@parhasard.net> * fns.c (Fset_exclusive_or):
--- a/src/fns.c Sat Feb 19 11:03:46 2011 +0000 +++ b/src/fns.c Thu Feb 24 09:36:19 2011 +0000 @@ -2095,6 +2095,7 @@ Bytecount bstart, blen; Lisp_Object val; + CHECK_STRING (string); get_string_range_char (string, start, end, &ccstart, &ccend, GB_HISTORICAL_STRING_BEHAVIOR); bstart = string_index_char_to_byte (string, ccstart);
--- a/tests/ChangeLog Sat Feb 19 11:03:46 2011 +0000 +++ b/tests/ChangeLog Thu Feb 24 09:36:19 2011 +0000 @@ -1,3 +1,10 @@ +2011-02-24 Aidan Kehoe <kehoea@parhasard.net> + + * automated/lisp-tests.el (substring-no-properties): + Make sure this function checks its arguments' types, the absence + of which was revealed by Raymond Toy's bug report of + http://mid.gmane.org/4D65D413.5050103@gmail.com . + 2011-02-10 Aidan Kehoe <kehoea@parhasard.net> * automated/lisp-tests.el:
--- a/tests/automated/lisp-tests.el Sat Feb 19 11:03:46 2011 +0000 +++ b/tests/automated/lisp-tests.el Thu Feb 24 09:36:19 2011 +0000 @@ -1339,6 +1339,10 @@ (Check-Error args-out-of-range (subseq [1 2 3] -42)) (Check-Error args-out-of-range (subseq [1 2 3] 0 42)) +(Check-Error wrong-type-argument (substring-no-properties nil 4)) +(Check-Error wrong-type-argument (substring-no-properties "hi there" pi)) +(Check-Error wrong-type-argument (substring-no-properties "hi there" 0)) + ;;----------------------------------------------------- ;; Time-related tests ;;-----------------------------------------------------