Mercurial > hg > xemacs-beta

annotate tests/frame.el @ 5044:e84a30b0e4a2

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
remove duplicative code in change_frame_size() -------------------- ChangeLog entries follow: -------------------- src/ChangeLog addition: 2010-02-15 Ben Wing <ben@xemacs.org> * frame.c (change_frame_size_1): Simplify the logic in this function. (1) Don't allow 0 as the value of height or width. The old code that tried to allow this was totally broken, anyway, so obviously this never happens any more. (2) Don't duplicate the code in frame_conversion_internal() that converts displayable pixel size to total pixel size -- just call that function.
author Ben Wing <ben@xemacs.org>
date Mon, 15 Feb 2010 22:58:10 -0600
parents 931aaa7a6b37
children 308d34e9f07d
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
4980
931aaa7a6b37 Martin Buchholz claims tests/frame.el.
Jerry James <james@xemacs.org>
parents: 108
diff changeset
1 ;;; Test geometry setting for frames.
931aaa7a6b37 Martin Buchholz claims tests/frame.el.
Jerry James <james@xemacs.org>
parents: 108
diff changeset
2 ;;;
931aaa7a6b37 Martin Buchholz claims tests/frame.el.
Jerry James <james@xemacs.org>
parents: 108
diff changeset
3 ;;; Copyright (C) 1997 Martin Buchholz
931aaa7a6b37 Martin Buchholz claims tests/frame.el.
Jerry James <james@xemacs.org>
parents: 108
diff changeset
4 ;;;
931aaa7a6b37 Martin Buchholz claims tests/frame.el.
Jerry James <james@xemacs.org>
parents: 108
diff changeset
5 ;;; This file is part of XEmacs.
931aaa7a6b37 Martin Buchholz claims tests/frame.el.
Jerry James <james@xemacs.org>
parents: 108
diff changeset
6 ;;;
931aaa7a6b37 Martin Buchholz claims tests/frame.el.
Jerry James <james@xemacs.org>
parents: 108
diff changeset
7 ;;; XEmacs is free software; you can redistribute it and/or modify it
931aaa7a6b37 Martin Buchholz claims tests/frame.el.
Jerry James <james@xemacs.org>
parents: 108
diff changeset
8 ;;; under the terms of the GNU General Public License as published by
931aaa7a6b37 Martin Buchholz claims tests/frame.el.
Jerry James <james@xemacs.org>
parents: 108
diff changeset
9 ;;; the Free Software Foundation; either version 2, or (at your
931aaa7a6b37 Martin Buchholz claims tests/frame.el.
Jerry James <james@xemacs.org>
parents: 108
diff changeset
10 ;;; option) any later version.
931aaa7a6b37 Martin Buchholz claims tests/frame.el.
Jerry James <james@xemacs.org>
parents: 108
diff changeset
11 ;;;
931aaa7a6b37 Martin Buchholz claims tests/frame.el.
Jerry James <james@xemacs.org>
parents: 108
diff changeset
12 ;;; XEmacs is distributed in the hope that it will be useful, but
931aaa7a6b37 Martin Buchholz claims tests/frame.el.
Jerry James <james@xemacs.org>
parents: 108
diff changeset
13 ;;; WITHOUT ANY WARRANTY; without even the implied warranty of
931aaa7a6b37 Martin Buchholz claims tests/frame.el.
Jerry James <james@xemacs.org>
parents: 108
diff changeset
14 ;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
931aaa7a6b37 Martin Buchholz claims tests/frame.el.
Jerry James <james@xemacs.org>
parents: 108
diff changeset
15 ;;; General Public License for more details.
931aaa7a6b37 Martin Buchholz claims tests/frame.el.
Jerry James <james@xemacs.org>
parents: 108
diff changeset
16 ;;;
931aaa7a6b37 Martin Buchholz claims tests/frame.el.
Jerry James <james@xemacs.org>
parents: 108
diff changeset
17 ;;; You should have received a copy of the GNU General Public License
931aaa7a6b37 Martin Buchholz claims tests/frame.el.
Jerry James <james@xemacs.org>
parents: 108
diff changeset
18 ;;; along with XEmacs; see the file COPYING. If not, write to the Free
931aaa7a6b37 Martin Buchholz claims tests/frame.el.
Jerry James <james@xemacs.org>
parents: 108
diff changeset
19 ;;; Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
931aaa7a6b37 Martin Buchholz claims tests/frame.el.
Jerry James <james@xemacs.org>
parents: 108
diff changeset
20 ;;; Boston, MA 02110-1301, USA.
931aaa7a6b37 Martin Buchholz claims tests/frame.el.
Jerry James <james@xemacs.org>
parents: 108
diff changeset
21
108
360340f9fd5f Import from CVS: tag r20-1b6
cvs
parents:
diff changeset
22 (defmacro check-frame-geometry (xx yy)
360340f9fd5f Import from CVS: tag r20-1b6
cvs
parents:
diff changeset
23 `(loop for frame in (list nil (selected-frame))
360340f9fd5f Import from CVS: tag r20-1b6
cvs
parents:
diff changeset
24 do
360340f9fd5f Import from CVS: tag r20-1b6
cvs
parents:
diff changeset
25 (assert (eq (frame-property frame 'top) ,yy))
360340f9fd5f Import from CVS: tag r20-1b6
cvs
parents:
diff changeset
26 (assert (eq (frame-property frame 'left) ,xx))
360340f9fd5f Import from CVS: tag r20-1b6
cvs
parents:
diff changeset
27 (assert (eq (frame-property frame 'top) ,yy))
360340f9fd5f Import from CVS: tag r20-1b6
cvs
parents:
diff changeset
28 (assert (eq (frame-property frame 'left) ,xx))
360340f9fd5f Import from CVS: tag r20-1b6
cvs
parents:
diff changeset
29 (loop for plist in
360340f9fd5f Import from CVS: tag r20-1b6
cvs
parents:
diff changeset
30 (list (frame-properties)
360340f9fd5f Import from CVS: tag r20-1b6
cvs
parents:
diff changeset
31 (frame-properties nil)
360340f9fd5f Import from CVS: tag r20-1b6
cvs
parents:
diff changeset
32 (frame-properties (selected-frame)))
360340f9fd5f Import from CVS: tag r20-1b6
cvs
parents:
diff changeset
33 do
360340f9fd5f Import from CVS: tag r20-1b6
cvs
parents:
diff changeset
34 (assert (eq (plist-get plist 'top) ,yy))
360340f9fd5f Import from CVS: tag r20-1b6
cvs
parents:
diff changeset
35 (assert (eq (plist-get plist 'left) ,xx)))))
360340f9fd5f Import from CVS: tag r20-1b6
cvs
parents:
diff changeset
36
360340f9fd5f Import from CVS: tag r20-1b6
cvs
parents:
diff changeset
37 (loop for (x y) in '((0 0) (1 1) (3 3) (9 9) (10 20) (20 40) (40 80) (100 200))
360340f9fd5f Import from CVS: tag r20-1b6
cvs
parents:
diff changeset
38 do
360340f9fd5f Import from CVS: tag r20-1b6
cvs
parents:
diff changeset
39 (loop for frame in (list nil (selected-frame))
360340f9fd5f Import from CVS: tag r20-1b6
cvs
parents:
diff changeset
40 do
360340f9fd5f Import from CVS: tag r20-1b6
cvs
parents:
diff changeset
41 (set-frame-properties frame `(left ,x top ,y))
360340f9fd5f Import from CVS: tag r20-1b6
cvs
parents:
diff changeset
42 (check-frame-geometry x y)
360340f9fd5f Import from CVS: tag r20-1b6
cvs
parents:
diff changeset
43 (set-frame-property frame 'top (+ y 3))
360340f9fd5f Import from CVS: tag r20-1b6
cvs
parents:
diff changeset
44 (check-frame-geometry x (+ y 3))
360340f9fd5f Import from CVS: tag r20-1b6
cvs
parents:
diff changeset
45 (set-frame-property frame 'left (+ x 3))
360340f9fd5f Import from CVS: tag r20-1b6
cvs
parents:
diff changeset
46 (check-frame-geometry (+ x 3) (+ y 3))))