Mercurial > hg > xemacs-beta
view tests/frame.el @ 5044:e84a30b0e4a2
remove duplicative code in change_frame_size()
-------------------- ChangeLog entries follow: --------------------
src/ChangeLog addition:
2010-02-15 Ben Wing <ben@xemacs.org>
* frame.c (change_frame_size_1):
Simplify the logic in this function.
(1) Don't allow 0 as the value of height or width. The old code
that tried to allow this was totally broken, anyway, so obviously
this never happens any more.
(2) Don't duplicate the code in frame_conversion_internal() that
converts displayable pixel size to total pixel size -- just call
that function.
author | Ben Wing <ben@xemacs.org> |
---|---|
date | Mon, 15 Feb 2010 22:58:10 -0600 |
parents | 931aaa7a6b37 |
children | 308d34e9f07d |
line wrap: on
line source
;;; Test geometry setting for frames. ;;; ;;; Copyright (C) 1997 Martin Buchholz ;;; ;;; This file is part of XEmacs. ;;; ;;; XEmacs is free software; you can redistribute it and/or modify it ;;; under the terms of the GNU General Public License as published by ;;; the Free Software Foundation; either version 2, or (at your ;;; option) any later version. ;;; ;;; XEmacs is distributed in the hope that it will be useful, but ;;; WITHOUT ANY WARRANTY; without even the implied warranty of ;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU ;;; General Public License for more details. ;;; ;;; You should have received a copy of the GNU General Public License ;;; along with XEmacs; see the file COPYING. If not, write to the Free ;;; Software Foundation, Inc., 51 Franklin Street, Fifth Floor, ;;; Boston, MA 02110-1301, USA. (defmacro check-frame-geometry (xx yy) `(loop for frame in (list nil (selected-frame)) do (assert (eq (frame-property frame 'top) ,yy)) (assert (eq (frame-property frame 'left) ,xx)) (assert (eq (frame-property frame 'top) ,yy)) (assert (eq (frame-property frame 'left) ,xx)) (loop for plist in (list (frame-properties) (frame-properties nil) (frame-properties (selected-frame))) do (assert (eq (plist-get plist 'top) ,yy)) (assert (eq (plist-get plist 'left) ,xx))))) (loop for (x y) in '((0 0) (1 1) (3 3) (9 9) (10 20) (20 40) (40 80) (100 200)) do (loop for frame in (list nil (selected-frame)) do (set-frame-properties frame `(left ,x top ,y)) (check-frame-geometry x y) (set-frame-property frame 'top (+ y 3)) (check-frame-geometry x (+ y 3)) (set-frame-property frame 'left (+ x 3)) (check-frame-geometry (+ x 3) (+ y 3))))