Mercurial > hg > ietf

annotate satp-core-review.txt @ 23:2eda17d4debf default tip

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
as submitted
author Henry S. Thompson <ht@inf.ed.ac.uk>
date Wed, 21 Oct 2026 17:24:38 +0100
parents f2743a0a4eb7
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
19
7f1bd15f2d23 getting started
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
1 https://datatracker.ietf.org/doc/draft-ietf-satp-core/
7f1bd15f2d23 getting started
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
2 Document: https://www.ietf.org/archive/id/draft-ietf-satp-core-17.html
7f1bd15f2d23 getting started
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
3 Title: Secure Asset Transfer Protocol (SATP) Core
7f1bd15f2d23 getting started
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
4 Reviewer: Henry S. Thompson
23
2eda17d4debf as submitted
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 22
diff changeset
5 Review Date: Wed Oct 21 17:12:16 2026
19
7f1bd15f2d23 getting started
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
6
7f1bd15f2d23 getting started
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
7 *Summary*
7f1bd15f2d23 getting started
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
8
7f1bd15f2d23 getting started
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
9 This draft is part of a package of at least three parts, including
7f1bd15f2d23 getting started
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
10 also _Secure Asset Transfer (SAT) Interoperability Architecture_ and
7f1bd15f2d23 getting started
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
11 _Secure Asset Transfer (SAT) Use Cases_.
7f1bd15f2d23 getting started
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
12
23
2eda17d4debf as submitted
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 22
diff changeset
13 Its aim is to present a concrete instantiation of the SAT
2eda17d4debf as submitted
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 22
diff changeset
14 Interoperability Architecture in terms of a specific set of message
2eda17d4debf as submitted
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 22
diff changeset
15 formats. As far as I can tell as a non-specialist, it achieves that
2eda17d4debf as submitted
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 22
diff changeset
16 goal.
2eda17d4debf as submitted
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 22
diff changeset
17
2eda17d4debf as submitted
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 22
diff changeset
18 But in my opinion it needs work on the presentation, particularly in
2eda17d4debf as submitted
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 22
diff changeset
19 the area of consistency and transparency of terminology, both
2eda17d4debf as submitted
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 22
diff changeset
20 internally and in relation to the terminology established by the SAT
2eda17d4debf as submitted
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 22
diff changeset
21 Interoperability Architecture, which I take to be the senior party in
2eda17d4debf as submitted
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 22
diff changeset
22 the trilogy.
2eda17d4debf as submitted
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 22
diff changeset
23
2eda17d4debf as submitted
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 22
diff changeset
24 All of my comments below under 'Minor points' bar the very first are
2eda17d4debf as submitted
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 22
diff changeset
25 there, rather than under a more serious heading, only because this is
2eda17d4debf as submitted
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 22
diff changeset
26 a matter of presentation, not substance, but I think it's important
2eda17d4debf as submitted
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 22
diff changeset
27 that they be addressed.
2eda17d4debf as submitted
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 22
diff changeset
28
19
7f1bd15f2d23 getting started
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
29 *Minor points*
7f1bd15f2d23 getting started
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
30
7f1bd15f2d23 getting started
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
31 1.
7f1bd15f2d23 getting started
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
32
7f1bd15f2d23 getting started
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
33 The restriction to just HTTPS with TLS1.3 is almost certainly not
7f1bd15f2d23 getting started
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
34 what you want. The use of HTTP/2 or QUIC, which requires use of
7f1bd15f2d23 getting started
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
35 TLS1.3, should be allowed.
7f1bd15f2d23 getting started
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
36
7f1bd15f2d23 getting started
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
37 In the Introduction, all that's needed is something along these lines:
7f1bd15f2d23 getting started
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
38
7f1bd15f2d23 getting started
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
39 Secure transfer mechanisms such as HTTPS with TLS no less than 1.3
7f1bd15f2d23 getting started
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
40 must be used.
7f1bd15f2d23 getting started
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
41
7f1bd15f2d23 getting started
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
42 5.3.9 and 5.4 can actually be simplified by switching to language
7f1bd15f2d23 getting started
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
43 which allows for successor messaging systems which offer the same or
7f1bd15f2d23 getting started
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
44 better security than HTTPS with TLS1.3.
7f1bd15f2d23 getting started
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
45
7f1bd15f2d23 getting started
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
46 There might be an argument for a SHOULD support HTTPS with TLS 1.3,
20
7cf0c76e9749 hacking away
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 19
diff changeset
47 but only if there is a strong case for encouraging interop between
7cf0c76e9749 hacking away
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 19
diff changeset
48 different gateway implementations.
7cf0c76e9749 hacking away
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 19
diff changeset
49
7cf0c76e9749 hacking away
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 19
diff changeset
50 5.3
7cf0c76e9749 hacking away
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 19
diff changeset
51
7cf0c76e9749 hacking away
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 19
diff changeset
52 The use of the word 'client' here and and client/server terminology
7cf0c76e9749 hacking away
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 19
diff changeset
53 in 5.4 is unnecessarily confusing with respect to the use of
7cf0c76e9749 hacking away
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 19
diff changeset
54 'client' as defined in section 3 and used in section 4 (the SATP
7cf0c76e9749 hacking away
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 19
diff changeset
55 model) and 5.3.8.
7cf0c76e9749 hacking away
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 19
diff changeset
56
7cf0c76e9749 hacking away
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 19
diff changeset
57 The fact that 'client' is used with two different meanings in the
7cf0c76e9749 hacking away
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 19
diff changeset
58 section headings of 5.3.8 and 5.3.10 illustrates this unnecessary
7cf0c76e9749 hacking away
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 19
diff changeset
59 confusion.
7cf0c76e9749 hacking away
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 19
diff changeset
60
7cf0c76e9749 hacking away
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 19
diff changeset
61 ARCH uses 'client' only in the 'client application' sense, and
7cf0c76e9749 hacking away
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 19
diff changeset
62 'server' not at all, and it would be a good idea to stick with that.
7cf0c76e9749 hacking away
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 19
diff changeset
63 Following ARCH, Section 3 defines "sender gateway" and "recipient
7cf0c76e9749 hacking away
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 19
diff changeset
64 gateway" and I would very much encourage their use throughout, as
7cf0c76e9749 hacking away
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 19
diff changeset
65 already done in 5.3.2.
7cf0c76e9749 hacking away
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 19
diff changeset
66
7cf0c76e9749 hacking away
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 19
diff changeset
67 For example, 5.3 para 1 could read
7cf0c76e9749 hacking away
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 19
diff changeset
68
7cf0c76e9749 hacking away
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 19
diff changeset
69 SATP messages are exchanged between peer gateways, where depending
7cf0c76e9749 hacking away
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 19
diff changeset
70 on the message type one is the sender gateway and the other the
7cf0c76e9749 hacking away
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 19
diff changeset
71 recipient gateway.
7cf0c76e9749 hacking away
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 19
diff changeset
72
7cf0c76e9749 hacking away
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 19
diff changeset
73 and in 5.3.9
7cf0c76e9749 hacking away
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 19
diff changeset
74
7cf0c76e9749 hacking away
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 19
diff changeset
75 If the sender gateway transmits a list of supported credential
7cf0c76e9749 hacking away
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 19
diff changeset
76 schemes, the recipient gateway selects one acceptable credential
7cf0c76e9749 hacking away
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 19
diff changeset
77 scheme from the offered schemes.
7cf0c76e9749 hacking away
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 19
diff changeset
78
7cf0c76e9749 hacking away
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 19
diff changeset
79 and in 5.3.10
19
7f1bd15f2d23 getting started
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
80
20
7cf0c76e9749 hacking away
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 19
diff changeset
81 *5.3.10. Sender Gateway Offers Other Supported TLS Schemes*
7cf0c76e9749 hacking away
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 19
diff changeset
82
7cf0c76e9749 hacking away
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 19
diff changeset
83 If a sender gateway wishes to use TLS schemes other than the basic
7cf0c76e9749 hacking away
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 19
diff changeset
84 scheme (AES-128 in GCM mode with SHA-256), then the gateway may
7cf0c76e9749 hacking away
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 19
diff changeset
85 may choose to send a JSON object listing the client's supported
7cf0c76e9749 hacking away
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 19
diff changeset
86 TLS schemes.
7cf0c76e9749 hacking away
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 19
diff changeset
87
7cf0c76e9749 hacking away
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 19
diff changeset
88 Also, later on the terminology used changes from 'recipient gateway'
7cf0c76e9749 hacking away
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 19
diff changeset
89 to 'receiver gateway' -- this should be reverted throughout.
7cf0c76e9749 hacking away
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 19
diff changeset
90
7cf0c76e9749 hacking away
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 19
diff changeset
91 5.4.1
7cf0c76e9749 hacking away
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 19
diff changeset
92
7cf0c76e9749 hacking away
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 19
diff changeset
93 See above. Here's a simpler version of this whole section:
7cf0c76e9749 hacking away
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 19
diff changeset
94
7cf0c76e9749 hacking away
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 19
diff changeset
95 5.4.1. Protocol requirements
7cf0c76e9749 hacking away
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 19
diff changeset
96
7cf0c76e9749 hacking away
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 19
diff changeset
97 Gateways MUST use a secure protocol, HTTPS or successors, in this stage.
7cf0c76e9749 hacking away
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 19
diff changeset
98
7cf0c76e9749 hacking away
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 19
diff changeset
99 Gateways MUST use the HTTPS POST method or equivalent idempotent
7cf0c76e9749 hacking away
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 19
diff changeset
100 [RFC 9110] method in this stage.
7cf0c76e9749 hacking away
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 19
diff changeset
101
7cf0c76e9749 hacking away
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 19
diff changeset
102 7.
7cf0c76e9749 hacking away
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 19
diff changeset
103
7cf0c76e9749 hacking away
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 19
diff changeset
104 remove ' (client)' and ' (sender)'
7cf0c76e9749 hacking away
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 19
diff changeset
105
7cf0c76e9749 hacking away
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 19
diff changeset
106 8., 9., 10.
7cf0c76e9749 hacking away
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 19
diff changeset
107
7cf0c76e9749 hacking away
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 19
diff changeset
108 remove and/or replace 'client', 'server' and 'receiver' so that all
21
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 20
diff changeset
109 and only 'sender gateway' and 'recipient gateway' are used.
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 20
diff changeset
110
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 20
diff changeset
111 8.3. and others
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 20
diff changeset
112
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 20
diff changeset
113 Starting here there are many sentences of the form
20
7cf0c76e9749 hacking away
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 19
diff changeset
114
21
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 20
diff changeset
115 "This message is sent from ... to the ... Endpoint at ... ."
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 20
diff changeset
116
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 20
diff changeset
117 The typography implies that these are formal properties of SATP, but
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 20
diff changeset
118 as far as I can see there is no definition of 'endpoint' or how the
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 20
diff changeset
119 many different ... Endpoints are to be identified between the two
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 20
diff changeset
120 gateways. Is this information meant to be included in the 'transfer
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 20
diff changeset
121 context' as defined in 5.3.6?
19
7f1bd15f2d23 getting started
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
122
22
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 21
diff changeset
123 8.4. and others
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 21
diff changeset
124
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 21
diff changeset
125 8.3. and 8.4. define the *Transfer Proposal Message* and *Transfer
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 21
diff changeset
126 Proposal Receipt Message*. There are a number of message pairs with
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 21
diff changeset
127 similar pairs of names, with the second part being variously named
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 21
diff changeset
128 ... Receipt Message or ... Response Message.
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 21
diff changeset
129
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 21
diff changeset
130 Language along the lines of "The message is sent from the [recipient
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 21
diff changeset
131 gateway] to the ... EndPoint at the [sender gateway]" appears in
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 21
diff changeset
132 many if not all of them
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 21
diff changeset
133
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 21
diff changeset
134 It's never made clear if this just e.g. requires *Transfer Proposal
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 21
diff changeset
135 Receipt Message* as the form which the HTTPS response body should
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 21
diff changeset
136 adopt when responding to an HTTPS POST request in the *Transfer
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 21
diff changeset
137 Proposal Message* form or, as I read it at first, actually means a
23
2eda17d4debf as submitted
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 22
diff changeset
138 _separate_ HTTPS POST request in the *Transfer Proposal Receipt
22
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 21
diff changeset
139 Message* format is sent from the recipient gateway.
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 21
diff changeset
140
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 21
diff changeset
141 That is, are we being told about a single HTTPS exchange, or two?
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 21
diff changeset
142 Or is the intent to allow for either? I think either at the
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 21
diff changeset
143 beginning of section 8, or somewhere earlier, perhaps section 6,
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 21
diff changeset
144 this should be explained. Indeed Figure 2 in section 6 might
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 21
diff changeset
145 encourage one to think that the Transfer Proposal exchange requires
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 21
diff changeset
146 one HTTPS exchange, whereas the Lock Assertion exchange involves
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 21
diff changeset
147 two.
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 21
diff changeset
148
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 21
diff changeset
149 11.
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 21
diff changeset
150
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 21
diff changeset
151 The discussion of time-outs and aborts leaves it unclear whether a
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 21
diff changeset
152 gateway which times out waiting at some point in a session should
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 21
diff changeset
153 send a session-abort-msg or not, but I would think it should.
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 21
diff changeset
154
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 21
diff changeset
155 Note that the phrase "time-outs due to gateway crashes" doesn't make
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 21
diff changeset
156 any sense: from the point-of-view of a gateway (G1) which times out
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 21
diff changeset
157 waiting for a response, there is no way to detect the _reason_ for
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 21
diff changeset
158 the timeout. In case a timeout is _not_ because of a crash on the
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 21
diff changeset
159 part of the other gateway (G2), surely notification that the session
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 21
diff changeset
160 is being terminated by G1 should be sent, to enable an orderly
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 21
diff changeset
161 close-down by G2, instead of it having to time-out itself.
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 21
diff changeset
162
19
7f1bd15f2d23 getting started
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
163 *Nits*
7f1bd15f2d23 getting started
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
164
20
7cf0c76e9749 hacking away
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 19
diff changeset
165 3.
7cf0c76e9749 hacking away
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 19
diff changeset
166
7cf0c76e9749 hacking away
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 19
diff changeset
167 Since you use them both, I suggest including the ARCH definitions of
7cf0c76e9749 hacking away
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 19
diff changeset
168 'originator' and 'beneficiary' here.
7cf0c76e9749 hacking away
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 19
diff changeset
169
7cf0c76e9749 hacking away
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 19
diff changeset
170 5.3.15
22
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 21
diff changeset
171 immobile => immobilize [twice]
20
7cf0c76e9749 hacking away
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 19
diff changeset
172
7cf0c76e9749 hacking away
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 19
diff changeset
173 'uses Hashed Time-lock' => 'use Hashed Time-lock'
7cf0c76e9749 hacking away
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 19
diff changeset
174
21
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 20
diff changeset
175 8.1., 8.2., 8.6., 9.1, 10., 11.3., 11.4.
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 20
diff changeset
176
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 20
diff changeset
177 must => MUST [throughout]
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 20
diff changeset
178
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 20
diff changeset
179 8.4., 8.6. and 9 others
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 20
diff changeset
180
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 20
diff changeset
181 The example JSON ends with a comma, which is strictly speaking not
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 20
diff changeset
182 allowed, and may cause errors in some tools (e.g. jq). It would be
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 20
diff changeset
183 best to remove them.
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 20
diff changeset
184
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 20
diff changeset
185 11.3.
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 20
diff changeset
186
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 20
diff changeset
187 The example JSON is missing a comma after
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 20
diff changeset
188 "urn:ietf:params:satp:core:msgtype:transfer-proposal-msg"
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 20
diff changeset
189
22
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 21
diff changeset
190 11.3.
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 21
diff changeset
191
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 21
diff changeset
192 errror => error
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 21
diff changeset
193
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 21
diff changeset
194 11.4.
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 21
diff changeset
195
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 21
diff changeset
196 I think *Protocol Error Codes* would be better...
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 21
diff changeset
197
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 21
diff changeset
198 11.5.
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 21
diff changeset
199
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 21
diff changeset
200 'maybe' => 'may be'
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 21
diff changeset
201
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 21
diff changeset
202 12.
21
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 20
diff changeset
203
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 20
diff changeset
204 'such a' => 'such as'
Henry S. Thompson <ht@inf.ed.ac.uk>
parents: 20
diff changeset
205
19
7f1bd15f2d23 getting started
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
206 15.1
7f1bd15f2d23 getting started
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
207
7f1bd15f2d23 getting started
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
208 RFC 8446 is obsolete, should refer to 9846.
7f1bd15f2d23 getting started
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
209
7f1bd15f2d23 getting started
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
210
7f1bd15f2d23 getting started
Henry S. Thompson <ht@inf.ed.ac.uk>
parents:
diff changeset
211