Mercurial > hg > xemacs-beta

changeset 5834:7984e732829e

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
Fix file descriptor leak in pop.c. See <CAHCOHQkUhtC7netdxqCkDy3vqtctbLBwxWC7ucmvLhRaPkAsDw@mail.gmail.com> in xemacs-patches.
author Jerry James <james@xemacs.org>
date Fri, 05 Dec 2014 16:22:57 -0700
parents b8316d3409cd
children e24390bd4235
files lib-src/ChangeLog lib-src/pop.c
diffstat 2 files changed, 6 insertions(+), 0 deletions(-) [+]
line wrap: on
line diff
--- a/lib-src/ChangeLog	Fri Nov 28 00:18:03 2014 +0000
+++ b/lib-src/ChangeLog	Fri Dec 05 16:22:57 2014 -0700
@@ -1,3 +1,8 @@
+2014-12-05  Jerry James  <james@xemacs.org>
+
+	* pop.c (socket_connection): Do not leak a socket if the POP
+	server's address cannot be determined.
+
 2014-10-18  Aidan Kehoe  <kehoea@parhasard.net>
 
 	* ootags.c (substitute):
--- a/lib-src/pop.c	Fri Nov 28 00:18:03 2014 +0000
+++ b/lib-src/pop.c	Fri Dec 05 16:22:57 2014 -0700
@@ -1075,6 +1075,7 @@
       try_count++;
       if ((! hostent) && ((h_errno != TRY_AGAIN) || (try_count == 5)))
 	{
+	  CLOSESOCKET (sock);
 	  strcpy (pop_error, "Could not determine POP server's address");
 	  return (-1);
 	}