changeset 2552:166ed8151e62

[xemacs-hg @ 2005-02-03 16:30:33 by james] Don't define this to c_this, and rename variables currently named this. See xemacs-patches message with ID <psbrb1ehjl.fsf@diannao.ittc.ku.edu>.
author james
date Thu, 03 Feb 2005 16:30:38 +0000
parents 9f70af3ac939
children b880fa9b5d8a
files src/ChangeLog src/config.h.in src/device-x.c src/eval.c src/frame.c src/gui-gtk.c src/gui-x.c src/lisp.h src/redisplay.c
diffstat 9 files changed, 69 insertions(+), 62 deletions(-) [+]
line wrap: on
line diff
--- a/src/ChangeLog	Thu Feb 03 16:14:08 2005 +0000
+++ b/src/ChangeLog	Thu Feb 03 16:30:38 2005 +0000
@@ -1,3 +1,16 @@
+2005-02-03  Jerry James  <james@xemacs.org>
+
+	* config.h.in: Remove #define this c_this.
+	* device-x.c (construct_name_list): Rename this -> this_widget.
+	* eval.c (wants_debugger): Rename this -> curr.
+	* frame.c (delete_frame_internal): Rename this -> this_frame.
+	* gui-gtk.c (ungcpro_popup_callbacks): Rename this -> this_callback.
+	* gui-gtk.c (get_gcpro_popup_callbacks): Ditto.
+	* gui-x.c (gcpro_popup_callbacks): Ditto.
+	* gui-x.c (ungcpro_popup_callbacks): Ditto.
+	* lisp.h: Remove #undef this and #defin this c_this.
+	* redisplay.c (generate_fstring_runes): Rename this -> this_str.
+
 2005-02-01  Jerry James  <james@xemacs.org>
 
 	* dumper.c: Olivier Galibert's changes to enable dumping data via
--- a/src/config.h.in	Thu Feb 03 16:14:08 2005 +0000
+++ b/src/config.h.in	Thu Feb 03 16:30:38 2005 +0000
@@ -1018,7 +1018,6 @@
 # if defined (__cplusplus)
 /* Avoid C++ keywords used as ordinary C identifiers */
 #  define new   c_new
-#  define this  c_this
 #  define catch c_catch
 
 #  define EXTERN_C extern "C"
--- a/src/device-x.c	Thu Feb 03 16:14:08 2005 +0000
+++ b/src/device-x.c	Thu Feb 03 16:30:38 2005 +0000
@@ -1238,16 +1238,17 @@
 		     char *fake_class, char *name, char *class_)
 {
   char *stack [100][2];
-  Widget this;
+  Widget this_widget;
   int count = 0;
   char *name_tail, *class_tail;
 
   if (widget)
     {
-      for (this = widget; this; this = XtParent (this))
+      for (this_widget = widget; this_widget;
+	   this_widget = XtParent (this_widget))
 	{
-	  stack [count][0] = this->core.name;
-	  stack [count][1] = XtClass (this)->core_class.class_name;
+	  stack [count][0] = this_widget->core.name;
+	  stack [count][1] = XtClass (this_widget)->core_class.class_name;
 	  count++;
 	}
       count--;
--- a/src/eval.c	Thu Feb 03 16:14:08 2005 +0000
+++ b/src/eval.c	Thu Feb 03 16:30:38 2005 +0000
@@ -587,10 +587,10 @@
 
   while (CONSP (conditions))
     {
-      Lisp_Object this, tail;
-      this = XCAR (conditions);
+      Lisp_Object curr, tail;
+      curr = XCAR (conditions);
       for (tail = list; CONSP (tail); tail = XCDR (tail))
-	if (EQ (XCAR (tail), this))
+	if (EQ (XCAR (tail), curr))
 	  return 1;
       conditions = XCDR (conditions);
     }
--- a/src/frame.c	Thu Feb 03 16:14:08 2005 +0000
+++ b/src/frame.c	Thu Feb 03 16:30:38 2005 +0000
@@ -1445,12 +1445,12 @@
 
       FRAME_LOOP_NO_BREAK (frmcons, devcons, concons)
 	{
-	  Lisp_Object this = XCAR (frmcons);
-
-	  if (! EQ (this, frame)
+	  Lisp_Object this_frame = XCAR (frmcons);
+
+	  if (! EQ (this_frame, frame)
 	      && EQ (frame, (WINDOW_FRAME
 			     (XWINDOW
-			      (FRAME_MINIBUF_WINDOW (XFRAME (this)))))))
+			      (FRAME_MINIBUF_WINDOW (XFRAME (this_frame)))))))
 	    {
 	      /* We've found another frame whose minibuffer is on
 		 this frame. */
@@ -1467,14 +1467,14 @@
 
     FRAME_LOOP_NO_BREAK (frmcons, devcons, concons)
       {
-	Lisp_Object this = XCAR (frmcons);
-
-
-	if (! EQ (this, frame))
+	Lisp_Object this_frame = XCAR (frmcons);
+
+
+	if (! EQ (this_frame, frame))
 	  {
 	    struct device *devcons_d = XDEVICE (XCAR (devcons));
 	    if (EQ (frame, DEVMETH_OR_GIVEN (devcons_d, get_frame_parent,
-					     (XFRAME (this)),
+					     (XFRAME (this_frame)),
 					     Qnil)))
 	      /* We've found a popup frame whose parent is this frame. */
 	      gui_error
@@ -1715,22 +1715,22 @@
 
       CONSOLE_FRAME_LOOP_NO_BREAK (frmcons, devcons, con)
 	{
-	  Lisp_Object this;
+	  Lisp_Object this_frame;
 	  struct frame *f1;
 
-	  this = XCAR (frmcons);
-	  f1 = XFRAME (this);
+	  this_frame = XCAR (frmcons);
+	  f1 = XFRAME (this_frame);
 
 	  /* Consider only frames on the same console
 	     and only those with minibuffers.  */
 	  if (FRAME_HAS_MINIBUF_P (f1))
 	    {
-	      frame_with_minibuf = this;
+	      frame_with_minibuf = this_frame;
 	      if (FRAME_MINIBUF_ONLY_P (f1))
 		goto double_break_2;
 	    }
 
-	  frame_on_same_console = this;
+	  frame_on_same_console = this_frame;
 	}
     double_break_2:
 
--- a/src/gui-gtk.c	Thu Feb 03 16:14:08 2005 +0000
+++ b/src/gui-gtk.c	Thu Feb 03 16:30:38 2005 +0000
@@ -57,19 +57,19 @@
 ungcpro_popup_callbacks (GUI_ID id)
 {
   Lisp_Object lid = make_int (id);
-  Lisp_Object this = assq_no_quit (lid, Vpopup_callbacks);
-  Vpopup_callbacks = delq_no_quit (this, Vpopup_callbacks);
+  Lisp_Object this_callback = assq_no_quit (lid, Vpopup_callbacks);
+  Vpopup_callbacks = delq_no_quit (this_callback, Vpopup_callbacks);
 }
 
 Lisp_Object
 get_gcpro_popup_callbacks (GUI_ID id)
 {
   Lisp_Object lid = make_int (id);
-  Lisp_Object this = assq_no_quit (lid, Vpopup_callbacks);
+  Lisp_Object this_callback = assq_no_quit (lid, Vpopup_callbacks);
 
-  if (!NILP (this))
+  if (!NILP (this_callback))
     {
-      return (XCDR (this));
+      return (XCDR (this_callback));
     }
   return (Qnil);
 }
--- a/src/gui-x.c	Thu Feb 03 16:14:08 2005 +0000
+++ b/src/gui-x.c	Thu Feb 03 16:30:38 2005 +0000
@@ -111,12 +111,12 @@
 gcpro_popup_callbacks (LWLIB_ID id)
 {
   Lisp_Object lid = make_int (id);
-  Lisp_Object this = assq_no_quit (lid, Vpopup_callbacks);
+  Lisp_Object this_callback = assq_no_quit (lid, Vpopup_callbacks);
 
-  if (!NILP (this))
+  if (!NILP (this_callback))
     {
-      free_list (XCDR (this));
-      XCDR (this) = snarf_widget_values_for_gcpro (id);
+      free_list (XCDR (this_callback));
+      XCDR (this_callback) = snarf_widget_values_for_gcpro (id);
     }
   else
     Vpopup_callbacks = Fcons (Fcons (lid, snarf_widget_values_for_gcpro (id)),
@@ -130,11 +130,11 @@
 ungcpro_popup_callbacks (LWLIB_ID id)
 {
   Lisp_Object lid = make_int (id);
-  Lisp_Object this = assq_no_quit (lid, Vpopup_callbacks);
+  Lisp_Object this_callback = assq_no_quit (lid, Vpopup_callbacks);
 
-  assert (!NILP (this));
-  free_list (XCDR (this));
-  Vpopup_callbacks = delq_no_quit (this, Vpopup_callbacks);
+  assert (!NILP (this_callback));
+  free_list (XCDR (this_callback));
+  Vpopup_callbacks = delq_no_quit (this_callback, Vpopup_callbacks);
 }
 
 int
--- a/src/lisp.h	Thu Feb 03 16:14:08 2005 +0000
+++ b/src/lisp.h	Thu Feb 03 16:30:38 2005 +0000
@@ -516,8 +516,6 @@
    we don't want by creating overloaded versions of them and declaring them
    private. */
    
-#undef this
-
 class Bytecount;
 class Bytebpos;
 class Bytexpos;
@@ -942,8 +940,6 @@
   { return Bytecount (x - y); }
 #endif
 
-#define this c_this
-
 #endif /* __cplusplus */
 
 /* Counts of elements */
@@ -3235,9 +3231,7 @@
   gcpro (const gcpro& g) : next (g.next), var (g.var), nvars (g.nvars) { }
   gcpro& operator= (const gcpro& g) { next = g.next; var = g.var;
 				      nvars = g.nvars;
-#undef this
 				      return *this;}
-#define this c_this
   ~gcpro () { assert (!next); }
 #endif /* defined (__cplusplus) && defined (ERROR_CHECK_GC) */
 };
--- a/src/redisplay.c	Thu Feb 03 16:14:08 2005 +0000
+++ b/src/redisplay.c	Thu Feb 03 16:30:38 2005 +0000
@@ -4106,20 +4106,20 @@
       /* A string.  Add to the display line and check for %-constructs
          within it. */
 
-      Ibyte *this = XSTRING_DATA (elt);
-
-      while ((pos < max_pos || max_pos == -1) && *this)
+      Ibyte *this_str = XSTRING_DATA (elt);
+
+      while ((pos < max_pos || max_pos == -1) && *this_str)
         {
-          Ibyte *last = this;
-
-          while (*this && *this != '%')
-            this++;
-
-          if (this != last)
+          Ibyte *last = this_str;
+
+          while (*this_str && *this_str != '%')
+            this_str++;
+
+          if (this_str != last)
             {
               /* No %-construct */
               Charcount size =
-		bytecount_to_charcount (last, this - last);
+		bytecount_to_charcount (last, this_str - last);
 
 	      if (size <= *offset)
 		*offset -= size;
@@ -4134,32 +4134,32 @@
 		  *offset = 0;
 		}
             }
-          else /* *this == '%' */
+          else /* *this_str == '%' */
             {
               Charcount spec_width = 0;
 
-              this++; /* skip over '%' */
+              this_str++; /* skip over '%' */
 
               /* We can't allow -ve args due to the "%-" construct.
                * Argument specifies minwidth but not maxwidth
                * (maxwidth can be specified by
                * (<negative-number> . <stuff>) modeline elements)
                */
-              while (isdigit (*this))
+              while (isdigit (*this_str))
                 {
-                  spec_width = spec_width * 10 + (*this - '0');
-                  this++;
+                  spec_width = spec_width * 10 + (*this_str - '0');
+                  this_str++;
                 }
               spec_width += pos;
 
-              if (*this == 'M')
+              if (*this_str == 'M')
                 {
                   pos = generate_fstring_runes (w, data, pos, spec_width,
                                                 max_pos, Vglobal_mode_string,
                                                 depth, max_pixsize, findex,
                                                 type, offset, cur_ext);
                 }
-              else if (*this == '-')
+              else if (*this_str == '-')
                 {
                   Charcount num_to_add;
 
@@ -4186,9 +4186,9 @@
                     pos = add_string_to_fstring_db_runes
                       (data, (const Ibyte *) "-", pos, pos, max_pos);
                 }
-              else if (*this != 0)
+              else if (*this_str != 0)
                 {
-                  Ichar ch = itext_ichar (this);
+                  Ichar ch = itext_ichar (this_str);
                   Ibyte *str;
 		  Charcount size;
 
@@ -4215,9 +4215,9 @@
 		    }
                 }
 
-              /* NOT this++.  There could be any sort of character at
+              /* NOT this_str++.  There could be any sort of character at
                  the current position. */
-              INC_IBYTEPTR (this);
+              INC_IBYTEPTR (this_str);
             }
 
           if (max_pixsize > 0)