Mercurial > hg > xemacs-beta

changeset 2062:00f374c78661

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
[xemacs-hg @ 2004-05-06 12:12:12 by malcolmp] GIF library crash fix.
author malcolmp
date Thu, 06 May 2004 12:12:13 +0000
parents b75af0ab66f3
children cc3ed6690621
files src/ChangeLog src/dgif_lib.c
diffstat 2 files changed, 7 insertions(+), 2 deletions(-) [+]
line wrap: on
line diff
--- a/src/ChangeLog	Wed May 05 22:09:18 2004 +0000
+++ b/src/ChangeLog	Thu May 06 12:12:13 2004 +0000
@@ -1,3 +1,8 @@
+2004-05-05  Chuck Hines <chuck.hines@baesystems.com>
+
+	* dgif_lib.c (DGifSlurp): Changed do-while to while to stop
+	coredump from deref of NULL ptr (ExtData)
+
 2004-05-05  Jerry James  <james@xemacs.org>
 
 	* number.c: Use DEFINE_BASIC_LRECORD_IMPLEMENTATION instead of
--- a/src/dgif_lib.c	Wed May 05 22:09:18 2004 +0000
+++ b/src/dgif_lib.c	Thu May 06 12:12:13 2004 +0000
@@ -740,11 +740,11 @@
 	    case EXTENSION_RECORD_TYPE:
 		DGifGetExtension(GifFile,&sp->Function,&ExtData);
 		
-		do {
+		while (ExtData != NULL) {
     		    if (AddExtensionBlock(sp, ExtData[0], ExtData+1) == GIF_ERROR)
 			GifInternError(GifFile, D_GIF_ERR_NOT_ENOUGH_MEM);
 		    DGifGetExtensionNext(GifFile, &ExtData);
-		} while (ExtData != NULL);
+		}
 		break;
 
 	    case TERMINATE_RECORD_TYPE: