# HG changeset patch
# User stephent
# Date 1130331705 0
# Node ID 986cd22006a9e2e21c317704b1199ee4375400e8
# Parent  4c9fa8e2237bd40a04103cb4ce594c117747e0d7
[xemacs-hg @ 2005-10-26 13:01:37 by stephent]
Warning elimination and documentation improvements.
<878xwgh1u7.fsf@tleepslib.sk.tsukuba.ac.jp>
<87d5lsh1xa.fsf@tleepslib.sk.tsukuba.ac.jp>

diff -r 4c9fa8e2237b -r 986cd22006a9 modules/ChangeLog
--- a/modules/ChangeLog	Tue Oct 25 21:51:23 2005 +0000
+++ b/modules/ChangeLog	Wed Oct 26 13:01:45 2005 +0000
@@ -1,3 +1,11 @@
+2005-10-22  Stephen J. Turnbull  <stephen@xemacs.org>
+
+	Warning elimination:
+
+	* ldap/eldap.c (Fldap_add): Remove declaration of `current', which
+	is now declared by EXTERNAL_LIST_LOOP_2.
+	(Fldap_modify): Remove redundant variable `gcpro2',
+
 2005-10-25  Ben Wing  <ben@xemacs.org>
 
 	* postgresql/postgresql.c (allocate_pgconn):
diff -r 4c9fa8e2237b -r 986cd22006a9 modules/ldap/eldap.c
--- a/modules/ldap/eldap.c	Tue Oct 25 21:51:23 2005 +0000
+++ b/modules/ldap/eldap.c	Wed Oct 26 13:01:45 2005 +0000
@@ -619,7 +619,6 @@
   int i, j;
   Elemcount len;
 
-  Lisp_Object current = Qnil;
   Lisp_Object values  = Qnil;
   struct gcpro gcpro1;
 
@@ -720,7 +719,7 @@
   Elemcount len;
 
   Lisp_Object values  = Qnil;
-  struct gcpro gcpro1, gcpro2;
+  struct gcpro gcpro1;
 
   /* Do all the parameter checking  */
   CHECK_LIVE_LDAP (ldap);
diff -r 4c9fa8e2237b -r 986cd22006a9 src/ChangeLog
--- a/src/ChangeLog	Tue Oct 25 21:51:23 2005 +0000
+++ b/src/ChangeLog	Wed Oct 26 13:01:45 2005 +0000
@@ -1,3 +1,7 @@
+2005-10-22  Stephen J. Turnbull  <stephen@xemacs.org>
+
+	* lrecord.h: Explain the EXTERNAL_LRECORD macros better.
+
 2005-10-25  Ben Wing  <ben@xemacs.org>
 
 	* config.h.in (EXTERN_C):
diff -r 4c9fa8e2237b -r 986cd22006a9 src/lrecord.h
--- a/src/lrecord.h	Tue Oct 25 21:51:23 2005 +0000
+++ b/src/lrecord.h	Wed Oct 26 13:01:45 2005 +0000
@@ -1373,7 +1373,8 @@
 Note: Object types defined in external dynamically-loaded modules (not
 part of the XEmacs main source code) should use DECLARE_EXTERNAL_LRECORD
 and DEFINE_EXTERNAL_LRECORD_IMPLEMENTATION rather than DECLARE_LRECORD
-and DEFINE_LRECORD_IMPLEMENTATION.
+and DEFINE_LRECORD_IMPLEMENTATION.  The EXTERNAL versions declare and
+allocate an enumerator for the type being defined.
 
 */