# HG changeset patch # User Ben Wing # Date 1263359793 21600 # Node ID 5f1c6ca4d05e21c6983fa363625aa423de3571ae # Parent d08fc2e159c9f9611602c2d27a82b470bca11bee fix bad change to default_query_method, rewrite conditional for more correctness diff -r d08fc2e159c9 -r 5f1c6ca4d05e src/ChangeLog --- a/src/ChangeLog Tue Jan 12 01:53:35 2010 -0600 +++ b/src/ChangeLog Tue Jan 12 23:16:33 2010 -0600 @@ -1,3 +1,9 @@ +2010-01-12 Ben Wing + + * file-coding.c (default_query_method): Single = is intended. + Rewrite using comma operator to make this clearer and avoid + dependency on the value of an enum. + 2010-01-11 Ben Wing * database.c: @@ -164,11 +170,6 @@ 2010-01-11 Ben Wing - * file-coding.c (default_query_method): - OOOOOPS! Had = instead of ==. - -2010-01-11 Ben Wing - * config.h.in: * config.h.in (ERROR_CHECK_GLYPHS): Trying to avoid link errors referring to the ERROR_CHECK_TYPES diff -r d08fc2e159c9 -r 5f1c6ca4d05e src/file-coding.c --- a/src/file-coding.c Tue Jan 12 01:53:35 2010 -0600 +++ b/src/file-coding.c Tue Jan 12 23:16:33 2010 -0600 @@ -500,9 +500,9 @@ fail_range_start = pos; while ((pos < end) && (EQ (Qnil, get_char_table (ch, safe_chars)) - && (failed_reason == query_coding_unencodable)) - && (previous_failed_reason == query_coding_succeeded - || previous_failed_reason == failed_reason)) + && (failed_reason = query_coding_unencodable, + (previous_failed_reason == query_coding_succeeded + || previous_failed_reason == failed_reason)))) { pos++; INC_BYTEBPOS (buf, pos_byte);