# HG changeset patch # User Aidan Kehoe # Date 1299784465 0 # Node ID 4141aeddc55bc1be01e8649810b136f7022208bc # Parent ed74d2ca7082ba4e2478792b7ba2a70a34899d25 Eliminate byte-compile warnings, core Lisp. 2011-03-10 Aidan Kehoe * etags.el (buffer-tag-table-list): * files.el (find-file-read-only): * files.el (find-file-read-only-other-window): * info.el (Info-dir-outdated-p): * info.el (Info-dump-dir-entries): * info.el (Info-rebuild-dir): * menubar-items.el (default-menubar): * mouse.el (drag-window-divider): * mouse.el (vertical-divider-map): * test-harness.el (emacs-lisp-file-regexp): Eliminate byte-compile warnings, again aside from those linked to Stephen's various non-defined fontconfig functions. diff -r ed74d2ca7082 -r 4141aeddc55b lisp/ChangeLog --- a/lisp/ChangeLog Thu Mar 10 18:51:15 2011 +0000 +++ b/lisp/ChangeLog Thu Mar 10 19:14:25 2011 +0000 @@ -1,3 +1,18 @@ +2011-03-10 Aidan Kehoe + + * etags.el (buffer-tag-table-list): + * files.el (find-file-read-only): + * files.el (find-file-read-only-other-window): + * info.el (Info-dir-outdated-p): + * info.el (Info-dump-dir-entries): + * info.el (Info-rebuild-dir): + * menubar-items.el (default-menubar): + * mouse.el (drag-window-divider): + * mouse.el (vertical-divider-map): + * test-harness.el (emacs-lisp-file-regexp): + Eliminate byte-compile warnings, again aside from those linked to + Stephen's various non-defined fontconfig functions. + 2011-03-10 Aidan Kehoe * cmdloop.el (yes-or-no-p): diff -r ed74d2ca7082 -r 4141aeddc55b lisp/etags.el --- a/lisp/etags.el Thu Mar 10 18:51:15 2011 +0000 +++ b/lisp/etags.el Thu Mar 10 19:14:25 2011 +0000 @@ -250,8 +250,8 @@ (and (file-readable-p name) ;; get-tag-table-buffer has side-effects (list (symbol-value-in-buffer 'buffer-file-name - (get-tag-table-buffer name)))))) - result) + (get-tag-table-buffer name))))) + result)) ;; If no TAGS file has been found, ask the user explicitly. ;; #### tags-file-name is *evil*. (or result tags-file-name diff -r ed74d2ca7082 -r 4141aeddc55b lisp/files.el --- a/lisp/files.el Thu Mar 10 18:51:15 2011 +0000 +++ b/lisp/files.el Thu Mar 10 19:14:25 2011 +0000 @@ -998,9 +998,9 @@ (read-coding-system "Coding system: ")) t)) (let ((value (find-file filename codesys wildcards))) - (mapcar #'(lambda (buffer) - (set-symbol-value-in-buffer 'buffer-read-only t buffer)) - (if (listp value) value (list value))) + (mapc #'(lambda (buffer) + (set-symbol-value-in-buffer 'buffer-read-only t buffer)) + (if (listp value) value (list value))) value)) (defun find-file-read-only-other-window (filename &optional codesys wildcards) diff -r ed74d2ca7082 -r 4141aeddc55b lisp/info.el --- a/lisp/info.el Thu Mar 10 18:51:15 2011 +0000 +++ b/lisp/info.el Thu Mar 10 19:14:25 2011 +0000 @@ -1127,7 +1127,7 @@ (let ((dir-mod-time (nth 5 (file-attributes file))) f-mod-time newer) (setq Info-dir-newer-info-files nil) - (mapcar + (mapc #'(lambda (f) (prog2 (setq f-mod-time (nth 5 (file-attributes f))) @@ -1191,23 +1191,23 @@ (let ((tab-width 8) (description-col 0) len) - (mapcar #'(lambda (e) - (setq e (cdr e)) ; Drop filename - (setq len (length (concat (car e) - (car (cdr e))))) - (if (> len description-col) - (setq description-col len))) - entries) + (mapc #'(lambda (e) + (setq e (cdr e)) ; Drop filename + (setq len (length (concat (car e) + (car (cdr e))))) + (if (> len description-col) + (setq description-col len))) + entries) (setq description-col (+ 5 description-col)) - (mapcar #'(lambda (e) - (setq e (cdr e)) ; Drop filename - (insert "* " (car e) ":" (car (cdr e))) - (setq e (car (cdr (cdr e)))) - (while e - (indent-to-column description-col) - (insert (car e) "\n") - (setq e (cdr e)))) - entries) + (mapc #'(lambda (e) + (setq e (cdr e)) ; Drop filename + (insert "* " (car e) ":" (car (cdr e))) + (setq e (car (cdr (cdr e)))) + (while e + (indent-to-column description-col) + (insert (car e) "\n") + (setq e (cdr e)))) + entries) (insert "\n"))) @@ -1299,7 +1299,7 @@ (narrow-to-region mark next-section) (setq dir-section-contents (nreverse (Info-parse-dir-entries (point-min) (point-max)))) - (mapcar + (mapc #'(lambda (file) (setq dir-entry (assoc (downcase (file-name-sans-extension diff -r ed74d2ca7082 -r 4141aeddc55b lisp/menubar-items.el --- a/lisp/menubar-items.el Thu Mar 10 18:51:15 2011 +0000 +++ b/lisp/menubar-items.el Thu Mar 10 19:14:25 2011 +0000 @@ -262,7 +262,7 @@ (submenu-generate-accelerator-spec (mapcar #'(lambda (bmk) `[,bmk (bookmark-delete ',bmk)]) - (bookmark-all-names))))) + (declare-fboundp (bookmark-all-names)))))) ["%_Edit Bookmark List" bookmark-bmenu-list :active (and-boundp 'bookmark-alist bookmark-alist)] "---" diff -r ed74d2ca7082 -r 4141aeddc55b lisp/mouse.el --- a/lisp/mouse.el Thu Mar 10 18:51:15 2011 +0000 +++ b/lisp/mouse.el Thu Mar 10 19:14:25 2011 +0000 @@ -1781,22 +1781,24 @@ (let ((all-that-bad nil) (new-left-ok nil) (new-right-ok nil)) - (mapcar* (lambda (window old-edges) - (let ((new (car (window-pixel-edges window)))) - (if (/= new (car old-edges)) - (if (and new-left-ok - (/= new-left-ok new)) - (setq all-that-bad t) - (setq new-left-ok new))))) - (window-list) old-edges-all-windows) - (mapcar* (lambda (window old-edges) - (let ((new (caddr (window-pixel-edges window)))) - (if (/= new (caddr old-edges)) - (if (and new-right-ok - (/= new-right-ok new)) - (setq all-that-bad t) - (setq new-right-ok new))))) - (window-list) old-edges-all-windows) + (mapc (lambda (window old-edges) + (let ((new + (car (window-pixel-edges window)))) + (if (/= new (car old-edges)) + (if (and new-left-ok + (/= new-left-ok new)) + (setq all-that-bad t) + (setq new-left-ok new))))) + (window-list) old-edges-all-windows) + (mapc (lambda (window old-edges) + (let ((new + (caddr (window-pixel-edges window)))) + (if (/= new (caddr old-edges)) + (if (and new-right-ok + (/= new-right-ok new)) + (setq all-that-bad t) + (setq new-right-ok new))))) + (window-list) old-edges-all-windows) all-that-bad)) (set-window-configuration backup-conf))))))))) diff -r ed74d2ca7082 -r 4141aeddc55b lisp/test-harness.el --- a/lisp/test-harness.el Thu Mar 10 18:51:15 2011 +0000 +++ b/lisp/test-harness.el Thu Mar 10 19:14:25 2011 +0000 @@ -128,7 +128,7 @@ (defvar test-harness-current-file nil) -(defvar emacs-lisp-file-regexp (purecopy "\\.el\\'") +(defvar emacs-lisp-file-regexp "\\.el\\'" "*Regexp which matches Emacs Lisp source files.") (defconst test-harness-file-summary-template