# HG changeset patch # User Marcus Crestani # Date 1412237940 -7200 # Node ID 36dddf9d90d1c2b7fa2e60bb96c9f8bce365e924 # Parent 7b42a97af782e406d9ebda1890a87479ca1000f5 Fix calculation of time zone string in Fencode_time. diff -r 7b42a97af782 -r 36dddf9d90d1 src/ChangeLog --- a/src/ChangeLog Sat Sep 27 14:16:11 2014 +0200 +++ b/src/ChangeLog Thu Oct 02 10:19:00 2014 +0200 @@ -1,3 +1,9 @@ +2014-09-30 Marcus Crestani + + * editfns.c (Fencode_time): Switch signs when calculating the time + zone string. (The offset indicates the value one must add to the + local time to arrive at UTC.) + 2014-09-23 Jerry James * floatfns.c (round_two_bignum_1): Fix memory leak. diff -r 7b42a97af782 -r 36dddf9d90d1 src/editfns.c --- a/src/editfns.c Sat Sep 27 14:16:11 2014 +0200 +++ b/src/editfns.c Thu Oct 02 10:19:00 2014 +0200 @@ -1190,9 +1190,13 @@ else if (FIXNUMP (zone)) { int abszone = abs (XFIXNUM (zone)); - /* #### I have no idea what this conforms to, - but the compiler has stopped whining. */ - sprintf (tzbuf, "XXX%s%d:%02d:%02d", (XFIXNUM (zone) < 0) ? "-" : "+", + /* We specify the time zone in offset notation (see `man + tzset' for details). The offset indicates the value one + must add to local time to arrive at UTC. Thus, we sign + the offset with a `-' if the time zone is east of GMT; we + sign the offset with a `+' if the time zone is GMT (then + the offset is 0) or if the time zone is west of GMT. */ + sprintf (tzbuf, "XXX%s%d:%02d:%02d", (XFIXNUM (zone) < 0) ? "+" : "-", abszone / (60*60), (abszone/60) % 60, abszone % 60); tzstring = tzbuf; }