[xemacs-hg @ 2003-02-07 11:50:50 by ben] fixes for menu crashes + better preemption behavior This contains two related changes: (1) Fix problems with reentrant calling of lwlib and associated crashes when selecting menu items. (2) Improve redisplay handling of preemption. Turn on lazy lock and hold down page-down or page-up and you'll see what I mean. They are related because they both touch on the code that retrieves events and handles the internal queues. console-msw.h, event-msw.c, event-stream.c, events.h, menubar-msw.c, menubar-x.c, menubar.h: mswindows_protect_modal_loop() has been generalized to event_stream_protect_modal_loop(), and moved to event-stream.c. mswindows_in_modal_loop ->in_modal_loop likewise. Changes in event-msw.c and menubar-msw.c for the new names and calling format (use structures instead of static variables in menubar-msw.c). Delete former in_menu_callback and use in_modal_loop in its place. Remove emacs_mswindows_quit_check_disallowed_p(), superseded by in_modal_loop. Use event_stream_protect_modal_loop() in pre_activate_callback() so that we get no lwlib reentrancy. Rearrange some of the code in event-msw.c to be grouped better. Make mswindows_drain_windows_queue() respect in_modal_loop and do nothing if so. cmdloop.c, event-stream.c: Don't conditionalize on LWLIB_MENUBARS_LUCID when giving error when in_modal_loop, and give better error. event-Xt.c, event-gtk.c: If in_modal_loop, only retrieve process and timeout events. Don't retrieve any X events because processing them can lead to reentrancy in lwlib -> death. event-stream.c: Remove unused parameter to check_event_stream_ok() and change all callers. lisp.h, event-stream.c: Rearrange some functions for increased clarity -- in particular, group all the input-pending/QUIT-related stuff together, and put right next to next-event stuff, to which it's related. Add the concept of "HOW_MANY" -- when asking whether user input is pending, you can ask if at least HOW_MANY events are pending, not just if any are. Add parameter to detect_input_pending() for this. Change recursive_sit_for from a Lisp_Object (which could only be Qt or Qnil) to an int, like it should be. event-Xt.c, event-gtk.c, event-xlike-inc.c: New file. Abstract out similar code in event_{Xt/gtk}_pending_p() and write only once, using include-file tricks. Rewrite this function to implement HOW_MANY and only process events when not in_modal_loop. event-msw.c: Implement HOW_MANY and only process events when not in_modal_loop. event-tty.c: Implement HOW_MANY. redisplay.c: Add var `max-preempts' to control maximum number of preempts. (#### perhaps not useful) Rewrite preemption check so that, rather than preempting when any user events are available, only preempt when a certain number (currently 4) of them are backed up. This effectively allows redisplay to proceed to completion in the presence of a fast auto-repeat (usually the auto-repeating is generated dynamically as necessary), and you get much better display behavior with lazy-lock active. event-unixoid.c: Comment changes. event-stream.c: Rewrite discard-input much more simply and safely using the drain-queue functions. I think the old version might loop forever if called when in_modal_loop. SEMI-UNRELATED CHANGES: ----------------------- event-stream.c: Turn QUIT-checking back on when running the pre-idle hook so it can be quit out of. indent.c: Document exact functioning of `vertical-motion' better, and its differences from GNU Emacs.

This directory contains C header files containing
operating-system-specific definitions.  Each file describes a
particular operating system.  The emacs configuration script edits
../config.h to include the appropriate one of these files, and then
each emacs source file includes config.h.

template.h is a generic template for system descriptions; it describes
the parameters a system file can specify.

General XEmacs Changes
---------------------------
The following is a list of those changes made globally across all
files.  They are not marked individually in each header file.  All
other changes should be preceded by a comment /* XEmacs change */.


1. Removed all #defines of [read|write|open|close].  This is now
   handled automatically by checking the INTERRUPTIBLE_IO etc. flags.

2. Removed all instances of #undef SIGIO and replaced them with
   #define BROKEN_SIGIO.  Jamie says:

   /* use BROKEN_SIGIO instead of this kludge -- jwz */

3. All instances of HAVE_GETWD, HAVE_DUP2, HAVE_UNISTD_H, NEED_UNISTD_H,
   HAVE_GETTIMEOFDAY and NEED_REALPATH removed.  We detect these
   automatically with configure.

4. All instances of HAVE_X11 replaced with HAVE_X_WINDOWS.  We don't
   support X10 or earlier so the HAVE_X11 define was purged.

5. Most of the signal crap (e.g. redefining sigsetmask, defining
   POSIX_SIGNALS) has been removed.  There are four possible
   signal paradigms that all systems fall into, and we auto-detect
   them in configure and handle them in syssignal.h.

6. Removed references to INTERRUPT_INPUT.  XEmacs does not use
   this bizarre way of reading input.

7. Removed references to BROKEN_FIONREAD.  FIONREAD is used only
   in INTERRUPT_INPUT and in the select() emulator, neither of
   which are supported in XEmacs.

8. Removed references to NOMULTIPLEJOBS.  This is unused in XEmacs
   and in FSF Emacs.

9. Removed references to HAVE_WAIT_HEADER and WAIT_USE_INT.
   They are unnecessary with the cleaned up syswait.h in XEmacs.
   (We autodetect sys/wait.h).  Instead, #define or #undef
   HAVE_UNION_WAIT.

10. Removed BSTRING.  Not used anywhere. (If the header file
    says there are bugs in bcopy() or the like, however, a
    #define BROKEN_BCOPY is added for reference.)

11. Removed #defines of bcopy, bzero, bcmp, index, rindex.
    XEmacs makes consistent use of the ANSI-equivalent
    functions memcpy, memset, memcmp, strchr, strrchr.

12. '#define subprocesses' removed.  Use '#define NO_SUBPROCESSES'
    if they don't exist.

13. References to HAVE_VFORK removed.  configure detects this.

14. Removed references to SYSV_SYSTEM_DIR, NONSYSTEM_DIR_LIBRARY,
    HAVE_SOCKETS, HAVE_SYSVIPC.  configure detects these.

15. Removed defines of HAVE_TERMIOS, HAVE_TERMIO, and
    HAVE_TCATTR (when HAVE_TERMIOS was also defined).
    configure detects these and systty.h automatically defines
    HAVE_TCATTR when HAVE_TERMIOS is defined.

16. Removed SETPGRP_RELEASES_CTTY.  Not necessary any more, with
    fixed definitions of EMACS_SEPARATE_PROCESS_GROUP et al.

17. Removed defines of NLIST_STRUCT.  configure detects this.

18. Removed defines of _setjmp and _longjmp.  configure detects this.

19. Removed all '#define static' business.  Defines NO_REMAP instead.

20. Removed defines of HAVE_MACH_MACH_H.  configure detects this.