Mercurial > hg > xemacs-beta
view src/README @ 1268:fffe735e63ee
[xemacs-hg @ 2003-02-07 11:50:50 by ben]
fixes for menu crashes + better preemption behavior
This contains two related changes:
(1) Fix problems with reentrant calling of lwlib and associated
crashes when selecting menu items.
(2) Improve redisplay handling of preemption. Turn on lazy lock
and hold down page-down or page-up and you'll see what I mean.
They are related because they both touch on the code that retrieves
events and handles the internal queues.
console-msw.h, event-msw.c, event-stream.c, events.h, menubar-msw.c, menubar-x.c, menubar.h: mswindows_protect_modal_loop() has been generalized to
event_stream_protect_modal_loop(), and moved to event-stream.c.
mswindows_in_modal_loop ->in_modal_loop likewise. Changes in
event-msw.c and menubar-msw.c for the new names and calling format
(use structures instead of static variables in menubar-msw.c).
Delete former in_menu_callback and use in_modal_loop in its place.
Remove emacs_mswindows_quit_check_disallowed_p(), superseded by
in_modal_loop. Use event_stream_protect_modal_loop() in
pre_activate_callback() so that we get no lwlib reentrancy.
Rearrange some of the code in event-msw.c to be grouped better.
Make mswindows_drain_windows_queue() respect in_modal_loop and
do nothing if so.
cmdloop.c, event-stream.c: Don't conditionalize on LWLIB_MENUBARS_LUCID when giving error when
in_modal_loop, and give better error.
event-Xt.c, event-gtk.c: If in_modal_loop, only retrieve process and timeout events.
Don't retrieve any X events because processing them can lead
to reentrancy in lwlib -> death.
event-stream.c: Remove unused parameter to check_event_stream_ok() and change
all callers.
lisp.h, event-stream.c: Rearrange some functions for increased clarity -- in particular,
group all the input-pending/QUIT-related stuff together, and
put right next to next-event stuff, to which it's related.
Add the concept of "HOW_MANY" -- when asking whether user input
is pending, you can ask if at least HOW_MANY events are pending,
not just if any are. Add parameter to detect_input_pending()
for this. Change recursive_sit_for from a Lisp_Object (which
could only be Qt or Qnil) to an int, like it should be.
event-Xt.c, event-gtk.c, event-xlike-inc.c: New file.
Abstract out similar code in event_{Xt/gtk}_pending_p() and write
only once, using include-file tricks. Rewrite this function to
implement HOW_MANY and only process events when not in_modal_loop.
event-msw.c: Implement HOW_MANY and only process events when not in_modal_loop.
event-tty.c: Implement HOW_MANY.
redisplay.c: Add var `max-preempts' to control maximum number of preempts.
(#### perhaps not useful) Rewrite preemption check so that,
rather than preempting when any user events are available, only
preempt when a certain number (currently 4) of them are backed up.
This effectively allows redisplay to proceed to completion in the
presence of a fast auto-repeat (usually the auto-repeating is
generated dynamically as necessary), and you get much better
display behavior with lazy-lock active.
event-unixoid.c: Comment changes.
event-stream.c: Rewrite discard-input much more simply and safely using the
drain-queue functions. I think the old version might loop
forever if called when in_modal_loop.
SEMI-UNRELATED CHANGES:
-----------------------
event-stream.c: Turn QUIT-checking back on when running the pre-idle hook so it
can be quit out of.
indent.c: Document exact functioning of `vertical-motion' better, and its
differences from GNU Emacs.
author | ben |
---|---|
date | Fri, 07 Feb 2003 11:50:54 +0000 |
parents | abe6d1db359e |
children | 304aebb79cd3 |
line wrap: on
line source
This directory contains the source files for the C component of XEmacs. Nothing in this directory is needed for using XEmacs once it is built and installed, if the dumped Emacs is copied elsewhere. See the files ../README and then ../INSTALL for installation instructions. Under Unix, the file `Makefile.in.in' is used as a template by the script `../configure' to produce `Makefile.in'. The same script then uses `cpp' to produce the machine-dependent `Makefile' from `Makefile.in'; `Makefile' is the file which actually controls the compilation of Emacs. Most of this should work transparently to the user; you should only need to run `../configure', and then type `make'. General changes for XEmacs: --------------------------- 1. Lisp objects. -- XFASTINT has been eliminated. Use of this expression as an lvalue is incompatible with the union form of Lisp objects, and use as an rvalue is likely to lead to errors and doesn't really save much time. Expressions of the form `XFASTINT (obj) = num;' get replaced by `obj = make_int (num);' or `XSETINT (obj, num);' and expressions of the form `num = XFASTINT (obj);' get replaced by `num = XINT (obj);'. Use Qzero in place of `make_int (0)'. -- Use of XTYPE gets replaced by the appropriate predicate. Using XTYPE only works for the small number of types that are not stored using the Lisp_Record type (int, cons, string, and vector). For example, `(XTYPE (foo) == Lisp_Buffer)' gets replaced by `(BUFFERP (foo))'. -- `XSET (obj, Lisp_Int, num)' gets replaced by `XSETINT (obj, num)', for consistency. -- Some occurrences of XSET need to get replaced by XSETR -- specifically, those where the type is not a primitive type (primitive types are int, cons, string, and vector). -- References to `XSTRING (obj)->size' get replaced with `XSTRING_LENGTH (obj)'. This is currently for cosmetic reasons but there may be other reasons in the future. (This change is currently incomplete in the source files.) 2. Storage classes: -- All occurrences of `register' should be replaced by `REGISTER'. It interferes with backtraces so we disable it if DEBUG_XEMACS is defined. 3. Errors, messages, I18N3 snarfing: -- Errors are continuable in XEmacs but are not in FSF Emacs. Therefore, it's important that functions do something reasonable if an error gets continued. If you want to signal a non- continuable error, the call to Fsignal() gets put inside a `while (1)' loop. To facilitate this, and also for proper I18N3 message snarfing, most calls to Fsignal() have been replaced by calls to signal_error(), signal_simple_error(), etc. Look at eval.c for a classification of various error functions. -- Constant strings occurring in source files need to get wrapped in a call to GETTEXT (or if inside of a call to `build_string', change that function to `build_translated_string') if they don't occur in certain places where the I18N3 message snarfer will see them. For a complete discussion of this, see the file lib-src/make-msgfile.lex. NOTE: I18N3 support is not currently working, so the above may or may not apply. Thus it is not a good idea to add random GETTEXTs, unless you really know what you are doing. -- Calls to `fprintf (stderr, ...)' and `printf (...)' get replaced with calls to `stderr_out' and `stdout_out'. This is for I18N3 message snarfing. 4. Initialization: -- FSF constructs like `obj = intern ("string"); staticpro (&obj);' get replaced by `defsymbol (&obj);'. This is for code cleanness and better purespace usage. -- FSF constructs like obj = intern ("error"); Fput (obj, Qerror_message, "message"); Fput (obj, Qerror_conditions, some list); get replaced by calls to deferror(). See the definition of deferror() for how the correct arguments to pass. This is for code cleanness and I18N3 message snarfing. -- Code in keys_of_foo() functions has been moved into Lisp.