Mercurial > hg > xemacs-beta
view src/select-gtk.c @ 665:fdefd0186b75
[xemacs-hg @ 2001-09-20 06:28:42 by ben]
The great integral types renaming.
The purpose of this is to rationalize the names used for various
integral types, so that they match their intended uses and follow
consist conventions, and eliminate types that were not semantically
different from each other.
The conventions are:
-- All integral types that measure quantities of anything are
signed. Some people disagree vociferously with this, but their
arguments are mostly theoretical, and are vastly outweighed by
the practical headaches of mixing signed and unsigned values,
and more importantly by the far increased likelihood of
inadvertent bugs: Because of the broken "viral" nature of
unsigned quantities in C (operations involving mixed
signed/unsigned are done unsigned, when exactly the opposite is
nearly always wanted), even a single error in declaring a
quantity unsigned that should be signed, or even the even more
subtle error of comparing signed and unsigned values and
forgetting the necessary cast, can be catastrophic, as
comparisons will yield wrong results. -Wsign-compare is turned
on specifically to catch this, but this tends to result in a
great number of warnings when mixing signed and unsigned, and
the casts are annoying. More has been written on this
elsewhere.
-- All such quantity types just mentioned boil down to EMACS_INT,
which is 32 bits on 32-bit machines and 64 bits on 64-bit
machines. This is guaranteed to be the same size as Lisp
objects of type `int', and (as far as I can tell) of size_t
(unsigned!) and ssize_t. The only type below that is not an
EMACS_INT is Hashcode, which is an unsigned value of the same
size as EMACS_INT.
-- Type names should be relatively short (no more than 10
characters or so), with the first letter capitalized and no
underscores if they can at all be avoided.
-- "count" == a zero-based measurement of some quantity. Includes
sizes, offsets, and indexes.
-- "bpos" == a one-based measurement of a position in a buffer.
"Charbpos" and "Bytebpos" count text in the buffer, rather than
bytes in memory; thus Bytebpos does not directly correspond to
the memory representation. Use "Membpos" for this.
-- "Char" refers to internal-format characters, not to the C type
"char", which is really a byte.
-- For the actual name changes, see the script below.
I ran the following script to do the conversion. (NOTE: This script
is idempotent. You can safely run it multiple times and it will
not screw up previous results -- in fact, it will do nothing if
nothing has changed. Thus, it can be run repeatedly as necessary
to handle patches coming in from old workspaces, or old branches.)
There are two tags, just before and just after the change:
`pre-integral-type-rename' and `post-integral-type-rename'. When
merging code from the main trunk into a branch, the best thing to
do is first merge up to `pre-integral-type-rename', then apply the
script and associated changes, then merge from
`post-integral-type-change' to the present. (Alternatively, just do
the merging in one operation; but you may then have a lot of
conflicts needing to be resolved by hand.)
Script `fixtypes.sh' follows:
----------------------------------- cut ------------------------------------
files="*.[ch] s/*.h m/*.h config.h.in ../configure.in Makefile.in.in ../lib-src/*.[ch] ../lwlib/*.[ch]"
gr Memory_Count Bytecount $files
gr Lstream_Data_Count Bytecount $files
gr Element_Count Elemcount $files
gr Hash_Code Hashcode $files
gr extcount bytecount $files
gr bufpos charbpos $files
gr bytind bytebpos $files
gr memind membpos $files
gr bufbyte intbyte $files
gr Extcount Bytecount $files
gr Bufpos Charbpos $files
gr Bytind Bytebpos $files
gr Memind Membpos $files
gr Bufbyte Intbyte $files
gr EXTCOUNT BYTECOUNT $files
gr BUFPOS CHARBPOS $files
gr BYTIND BYTEBPOS $files
gr MEMIND MEMBPOS $files
gr BUFBYTE INTBYTE $files
gr MEMORY_COUNT BYTECOUNT $files
gr LSTREAM_DATA_COUNT BYTECOUNT $files
gr ELEMENT_COUNT ELEMCOUNT $files
gr HASH_CODE HASHCODE $files
----------------------------------- cut ------------------------------------
`fixtypes.sh' is a Bourne-shell script; it uses 'gr':
----------------------------------- cut ------------------------------------
#!/bin/sh
# Usage is like this:
# gr FROM TO FILES ...
# globally replace FROM with TO in FILES. FROM and TO are regular expressions.
# backup files are stored in the `backup' directory.
from="$1"
to="$2"
shift 2
echo ${1+"$@"} | xargs global-replace "s/$from/$to/g"
----------------------------------- cut ------------------------------------
`gr' in turn uses a Perl script to do its real work,
`global-replace', which follows:
----------------------------------- cut ------------------------------------
: #-*- Perl -*-
### global-modify --- modify the contents of a file by a Perl expression
## Copyright (C) 1999 Martin Buchholz.
## Copyright (C) 2001 Ben Wing.
## Authors: Martin Buchholz <martin@xemacs.org>, Ben Wing <ben@xemacs.org>
## Maintainer: Ben Wing <ben@xemacs.org>
## Current Version: 1.0, May 5, 2001
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 2, or (at your option)
# any later version.
#
# This program is distributed in the hope that it will be useful, but
# WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
# General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with XEmacs; see the file COPYING. If not, write to the Free
# Software Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA
# 02111-1307, USA.
eval 'exec perl -w -S $0 ${1+"$@"}'
if 0;
use strict;
use FileHandle;
use Carp;
use Getopt::Long;
use File::Basename;
(my $myName = $0) =~ s@.*/@@; my $usage="
Usage: $myName [--help] [--backup-dir=DIR] [--line-mode] [--hunk-mode]
PERLEXPR FILE ...
Globally modify a file, either line by line or in one big hunk.
Typical usage is like this:
[with GNU print, GNU xargs: guaranteed to handle spaces, quotes, etc.
in file names]
find . -name '*.[ch]' -print0 | xargs -0 $0 's/\bCONST\b/const/g'\n
[with non-GNU print, xargs]
find . -name '*.[ch]' -print | xargs $0 's/\bCONST\b/const/g'\n
The file is read in, either line by line (with --line-mode specified)
or in one big hunk (with --hunk-mode specified; it's the default), and
the Perl expression is then evalled with \$_ set to the line or hunk of
text, including the terminating newline if there is one. It should
destructively modify the value there, storing the changed result in \$_.
Files in which any modifications are made are backed up to the directory
specified using --backup-dir, or to `backup' by default. To disable this,
use --backup-dir= with no argument.
Hunk mode is the default because it is MUCH MUCH faster than line-by-line.
Use line-by-line only when it matters, e.g. you want to do a replacement
only once per line (the default without the `g' argument). Conversely,
when using hunk mode, *ALWAYS* use `g'; otherwise, you will only make one
replacement in the entire file!
";
my %options = ();
$Getopt::Long::ignorecase = 0;
&GetOptions (
\%options,
'help', 'backup-dir=s', 'line-mode', 'hunk-mode',
);
die $usage if $options{"help"} or @ARGV <= 1;
my $code = shift;
die $usage if grep (-d || ! -w, @ARGV);
sub SafeOpen {
open ((my $fh = new FileHandle), $_[0]);
confess "Can't open $_[0]: $!" if ! defined $fh;
return $fh;
}
sub SafeClose {
close $_[0] or confess "Can't close $_[0]: $!";
}
sub FileContents {
my $fh = SafeOpen ("< $_[0]");
my $olddollarslash = $/;
local $/ = undef;
my $contents = <$fh>;
$/ = $olddollarslash;
return $contents;
}
sub WriteStringToFile {
my $fh = SafeOpen ("> $_[0]");
binmode $fh;
print $fh $_[1] or confess "$_[0]: $!\n";
SafeClose $fh;
}
foreach my $file (@ARGV) {
my $changed_p = 0;
my $new_contents = "";
if ($options{"line-mode"}) {
my $fh = SafeOpen $file;
while (<$fh>) {
my $save_line = $_;
eval $code;
$changed_p = 1 if $save_line ne $_;
$new_contents .= $_;
}
} else {
my $orig_contents = $_ = FileContents $file;
eval $code;
if ($_ ne $orig_contents) {
$changed_p = 1;
$new_contents = $_;
}
}
if ($changed_p) {
my $backdir = $options{"backup-dir"};
$backdir = "backup" if !defined ($backdir);
if ($backdir) {
my ($name, $path, $suffix) = fileparse ($file, "");
my $backfulldir = $path . $backdir;
my $backfile = "$backfulldir/$name";
mkdir $backfulldir, 0755 unless -d $backfulldir;
print "modifying $file (original saved in $backfile)\n";
rename $file, $backfile;
}
WriteStringToFile ($file, $new_contents);
}
}
----------------------------------- cut ------------------------------------
In addition to those programs, I needed to fix up a few other
things, particularly relating to the duplicate definitions of
types, now that some types merged with others. Specifically:
1. in lisp.h, removed duplicate declarations of Bytecount. The
changed code should now look like this: (In each code snippet
below, the first and last lines are the same as the original, as
are all lines outside of those lines. That allows you to locate
the section to be replaced, and replace the stuff in that
section, verifying that there isn't anything new added that
would need to be kept.)
--------------------------------- snip -------------------------------------
/* Counts of bytes or chars */
typedef EMACS_INT Bytecount;
typedef EMACS_INT Charcount;
/* Counts of elements */
typedef EMACS_INT Elemcount;
/* Hash codes */
typedef unsigned long Hashcode;
/* ------------------------ dynamic arrays ------------------- */
--------------------------------- snip -------------------------------------
2. in lstream.h, removed duplicate declaration of Bytecount.
Rewrote the comment about this type. The changed code should
now look like this:
--------------------------------- snip -------------------------------------
#endif
/* The have been some arguments over the what the type should be that
specifies a count of bytes in a data block to be written out or read in,
using Lstream_read(), Lstream_write(), and related functions.
Originally it was long, which worked fine; Martin "corrected" these to
size_t and ssize_t on the grounds that this is theoretically cleaner and
is in keeping with the C standards. Unfortunately, this practice is
horribly error-prone due to design flaws in the way that mixed
signed/unsigned arithmetic happens. In fact, by doing this change,
Martin introduced a subtle but fatal error that caused the operation of
sending large mail messages to the SMTP server under Windows to fail.
By putting all values back to be signed, avoiding any signed/unsigned
mixing, the bug immediately went away. The type then in use was
Lstream_Data_Count, so that it be reverted cleanly if a vote came to
that. Now it is Bytecount.
Some earlier comments about why the type must be signed: This MUST BE
SIGNED, since it also is used in functions that return the number of
bytes actually read to or written from in an operation, and these
functions can return -1 to signal error.
Note that the standard Unix read() and write() functions define the
count going in as a size_t, which is UNSIGNED, and the count going
out as an ssize_t, which is SIGNED. This is a horrible design
flaw. Not only is it highly likely to lead to logic errors when a
-1 gets interpreted as a large positive number, but operations are
bound to fail in all sorts of horrible ways when a number in the
upper-half of the size_t range is passed in -- this number is
unrepresentable as an ssize_t, so code that checks to see how many
bytes are actually written (which is mandatory if you are dealing
with certain types of devices) will get completely screwed up.
--ben
*/
typedef enum lstream_buffering
--------------------------------- snip -------------------------------------
3. in dumper.c, there are four places, all inside of switch()
statements, where XD_BYTECOUNT appears twice as a case tag. In
each case, the two case blocks contain identical code, and you
should *REMOVE THE SECOND* and leave the first.
author | ben |
---|---|
date | Thu, 20 Sep 2001 06:31:11 +0000 |
parents | b39c14581166 |
children | 2d3184c89f71 |
line wrap: on
line source
/* GTK selection processing for XEmacs Copyright (C) 1990, 1991, 1992, 1993, 1994 Free Software Foundation, Inc. This file is part of XEmacs. XEmacs is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation; either version 2, or (at your option) any later version. XEmacs is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details. You should have received a copy of the GNU General Public License along with XEmacs; see the file COPYING. If not, write to the Free Software Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ /* Synched up with: Not synched with FSF. */ /* Authorship: Written by Kevin Gallo for FSF Emacs. Rewritten for mswindows by Jonathan Harris, December 1997 for 21.0. Rewritten for GTK by William Perry, April 2000 for 21.1 */ #include <config.h> #include "lisp.h" #include "events.h" #include "buffer.h" #include "device.h" #include "console-gtk.h" #include "select.h" #include "opaque.h" #include "frame.h" static Lisp_Object Vretrieved_selection; static gboolean waiting_for_selection; Lisp_Object Vgtk_sent_selection_hooks; static GdkAtom symbol_to_gtk_atom (struct device *d, Lisp_Object sym, int only_if_exists) { if (NILP (sym)) return GDK_SELECTION_PRIMARY; if (EQ (sym, Qt)) return GDK_SELECTION_SECONDARY; if (EQ (sym, QPRIMARY)) return GDK_SELECTION_PRIMARY; if (EQ (sym, QSECONDARY)) return GDK_SELECTION_SECONDARY; { const Extbyte *nameext; LISP_STRING_TO_EXTERNAL (Fsymbol_name (sym), nameext, Qctext); return gdk_atom_intern (nameext, only_if_exists ? TRUE : FALSE); } } static Lisp_Object atom_to_symbol (struct device *d, GdkAtom atom) { if (atom == GDK_SELECTION_PRIMARY) return (QPRIMARY); if (atom == GDK_SELECTION_SECONDARY) return (QSECONDARY); { CIntbyte *intstr; Extbyte *str = gdk_atom_name (atom); if (! str) return Qnil; TO_INTERNAL_FORMAT (C_STRING, str, C_STRING_ALLOCA, intstr, Qctext); g_free (str); return intern (intstr); } } #define PROCESSING_GTK_CODE #include "select-common.h" #undef PROCESSING_GTK_CODE /* Set the selection data to GDK_NONE and NULL data, meaning we were ** unable to do what they wanted. */ static void gtk_decline_selection_request (GtkSelectionData *data) { gtk_selection_data_set (data, GDK_NONE, 0, NULL, 0); } /* Used as an unwind-protect clause so that, if a selection-converter signals an error, we tell the requestor that we were unable to do what they wanted before we throw to top-level or go into the debugger or whatever. */ struct _selection_closure { GtkSelectionData *data; gboolean successful; }; static Lisp_Object gtk_selection_request_lisp_error (Lisp_Object closure) { struct _selection_closure *cl = (struct _selection_closure *) get_opaque_ptr (closure); free_opaque_ptr (closure); if (cl->successful == TRUE) return Qnil; gtk_decline_selection_request (cl->data); return Qnil; } /* This provides the current selection to a requester. ** ** This is connected to the selection_get() signal of the application ** shell in device-gtk.c:gtk_init_device(). ** ** This is radically different than the old selection code (21.1.x), ** but has been modeled after the X code, and appears to work. ** ** WMP Feb 12 2001 */ void emacs_gtk_selection_handle (GtkWidget *widget, GtkSelectionData *selection_data, guint info, guint time_stamp, gpointer data) { /* This function can GC */ struct gcpro gcpro1, gcpro2; Lisp_Object temp_obj; Lisp_Object selection_symbol; Lisp_Object target_symbol = Qnil; Lisp_Object converted_selection = Qnil; guint32 local_selection_time; Lisp_Object successful_p = Qnil; int count; struct device *d = decode_gtk_device (Qnil); struct _selection_closure *cl = NULL; GCPRO2 (converted_selection, target_symbol); selection_symbol = atom_to_symbol (d, selection_data->selection); target_symbol = atom_to_symbol (d, selection_data->target); #if 0 /* #### MULTIPLE doesn't work yet */ if (EQ (target_symbol, QMULTIPLE)) target_symbol = fetch_multiple_target (selection_data); #endif temp_obj = Fget_selection_timestamp (selection_symbol); if (NILP (temp_obj)) { /* We don't appear to have the selection. */ gtk_decline_selection_request (selection_data); goto DONE_LABEL; } local_selection_time = * (guint32 *) XOPAQUE_DATA (temp_obj); if (time_stamp != GDK_CURRENT_TIME && local_selection_time > time_stamp) { /* Someone asked for the selection, and we have one, but not the one they're looking for. */ gtk_decline_selection_request (selection_data); goto DONE_LABEL; } converted_selection = select_convert_out (selection_symbol, target_symbol, Qnil); /* #### Is this the right thing to do? I'm no X expert. -- ajh */ if (NILP (converted_selection)) { /* We don't appear to have a selection in that data type. */ gtk_decline_selection_request (selection_data); goto DONE_LABEL; } count = specpdl_depth (); cl = (struct _selection_closure *) xmalloc (sizeof (*cl)); cl->data = selection_data; cl->successful = FALSE; record_unwind_protect (gtk_selection_request_lisp_error, make_opaque_ptr (cl)); { UChar_Binary *data; Bytecount size; int format; GdkAtom type; lisp_data_to_selection_data (d, converted_selection, &data, &type, &size, &format); gtk_selection_data_set (selection_data, type, format, data, /* #### is this right? */ (unsigned int) size); successful_p = Qt; /* Tell x_selection_request_lisp_error() it's cool. */ cl->successful = TRUE; xfree (data); } unbind_to (count, Qnil); DONE_LABEL: if (cl) xfree (cl); UNGCPRO; /* Let random lisp code notice that the selection has been asked for. */ { Lisp_Object val = Vgtk_sent_selection_hooks; if (!UNBOUNDP (val) && !NILP (val)) { Lisp_Object rest; if (CONSP (val) && !EQ (XCAR (val), Qlambda)) for (rest = val; !NILP (rest); rest = Fcdr (rest)) call3 (Fcar (rest), selection_symbol, target_symbol, successful_p); else call3 (val, selection_symbol, target_symbol, successful_p); } } } static GtkWidget *reading_selection_reply; static GdkAtom reading_which_selection; static int selection_reply_timed_out; /* Gets the current selection owned by another application */ void emacs_gtk_selection_received (GtkWidget *widget, GtkSelectionData *selection_data, gpointer user_data) { waiting_for_selection = FALSE; Vretrieved_selection = Qnil; reading_selection_reply = NULL; signal_fake_event (); if (selection_data->length < 0) { return; } Vretrieved_selection = selection_data_to_lisp_data (NULL, selection_data->data, selection_data->length, selection_data->type, selection_data->format); } static int selection_reply_done (void *ignore) { return !reading_selection_reply; } /* Do protocol to read selection-data from the server. Converts this to lisp data and returns it. */ static Lisp_Object gtk_get_foreign_selection (Lisp_Object selection_symbol, Lisp_Object target_type) { /* This function can GC */ struct device *d = decode_gtk_device (Qnil); GtkWidget *requestor = DEVICE_GTK_APP_SHELL (d); guint32 requestor_time = DEVICE_GTK_MOUSE_TIMESTAMP (d); GdkAtom selection_atom = symbol_to_gtk_atom (d, selection_symbol, 0); int speccount; GdkAtom type_atom = symbol_to_gtk_atom (d, (CONSP (target_type) ? XCAR (target_type) : target_type), 0); gtk_selection_convert (requestor, selection_atom, type_atom, requestor_time); signal_fake_event (); /* Block until the reply has been read. */ reading_selection_reply = requestor; reading_which_selection = selection_atom; selection_reply_timed_out = 0; speccount = specpdl_depth (); #if 0 /* add a timeout handler */ if (gtk_selection_timeout > 0) { Lisp_Object id = Fadd_timeout (make_int (x_selection_timeout), Qx_selection_reply_timeout_internal, Qnil, Qnil); record_unwind_protect (Fdisable_timeout, id); } #endif /* This is ^Gable */ wait_delaying_user_input (selection_reply_done, 0); if (selection_reply_timed_out) signal_error (Qselection_conversion_error, "timed out waiting for reply from selection owner", Qunbound); unbind_to (speccount, Qnil); /* otherwise, the selection is waiting for us on the requested property. */ return select_convert_in (selection_symbol, target_type, Vretrieved_selection); } #if 0 static void gtk_get_window_property (struct device *d, GtkWidget *window, GdkAtom property, Extbyte **data_ret, int *bytes_ret, GdkAtom *actual_type_ret, int *actual_format_ret, unsigned long *actual_size_ret, int delete_p) { /* deleted */ } static void receive_incremental_selection (Display *display, Window window, Atom property, /* this one is for error messages only */ Lisp_Object target_type, unsigned int min_size_bytes, Extbyte **data_ret, int *size_bytes_ret, Atom *type_ret, int *format_ret, unsigned long *size_ret) { /* deleted */ } static Lisp_Object gtk_get_window_property_as_lisp_data (struct device *d, GtkWidget *window, GdkAtom property, /* next two for error messages only */ Lisp_Object target_type, GdkAtom selection_atom) { /* deleted */ } #endif static Lisp_Object gtk_own_selection (Lisp_Object selection_name, Lisp_Object selection_value, Lisp_Object how_to_add, Lisp_Object selection_type) { struct device *d = decode_gtk_device (Qnil); GtkWidget *selecting_window = GTK_WIDGET (DEVICE_GTK_APP_SHELL (d)); Lisp_Object selection_time; /* Use the time of the last-read mouse or keyboard event. For selection purposes, we use this as a sleazy way of knowing what the current time is in server-time. This assumes that the most recently read mouse or keyboard event has something to do with the assertion of the selection, which is probably true. */ guint32 thyme = DEVICE_GTK_MOUSE_TIMESTAMP (d); GdkAtom selection_atom; CHECK_SYMBOL (selection_name); selection_atom = symbol_to_gtk_atom (d, selection_name, 0); gtk_selection_owner_set (selecting_window, selection_atom, thyme); /* We do NOT use time_to_lisp() here any more, like we used to. That assumed equivalence of time_t and Time, which is not necessarily the case (e.g. under OSF on the Alphas, where Time is a 64-bit quantity and time_t is a 32-bit quantity). Opaque pointers are the clean way to go here. */ selection_time = make_opaque (&thyme, sizeof (thyme)); return selection_time; } static void gtk_disown_selection (Lisp_Object selection, Lisp_Object timeval) { struct device *d = decode_gtk_device (Qnil); GdkAtom selection_atom; guint32 timestamp; CHECK_SYMBOL (selection); selection_atom = symbol_to_gtk_atom (d, selection, 0); if (NILP (timeval)) timestamp = DEVICE_GTK_MOUSE_TIMESTAMP (d); else { time_t the_time; lisp_to_time (timeval, &the_time); timestamp = (guint32) the_time; } gtk_selection_owner_set (NULL, selection_atom, timestamp); } static Lisp_Object gtk_selection_exists_p (Lisp_Object selection, Lisp_Object selection_type) { struct device *d = decode_gtk_device (Qnil); return (gdk_selection_owner_get (symbol_to_gtk_atom (d, selection, 0)) ? Qt : Qnil); } /************************************************************************/ /* initialization */ /************************************************************************/ void syms_of_select_gtk (void) { } void console_type_create_select_gtk (void) { CONSOLE_HAS_METHOD (gtk, own_selection); CONSOLE_HAS_METHOD (gtk, disown_selection); CONSOLE_HAS_METHOD (gtk, selection_exists_p); CONSOLE_HAS_METHOD (gtk, get_foreign_selection); } void vars_of_select_gtk (void) { staticpro (&Vretrieved_selection); Vretrieved_selection = Qnil; DEFVAR_LISP ("gtk-sent-selection-hooks", &Vgtk_sent_selection_hooks /* A function or functions to be called after we have responded to some other client's request for the value of a selection that we own. The function(s) will be called with four arguments: - the name of the selection (typically PRIMARY, SECONDARY, or CLIPBOARD); - the name of the selection-type which we were requested to convert the selection into before sending (for example, STRING or LENGTH); - and whether we successfully transmitted the selection. We might have failed (and declined the request) for any number of reasons, including being asked for a selection that we no longer own, or being asked to convert into a type that we don't know about or that is inappropriate. This hook doesn't let you change the behavior of emacs's selection replies, it merely informs you that they have happened. */ ); Vgtk_sent_selection_hooks = Qunbound; }