Mercurial > hg > xemacs-beta
view lwlib/ChangeLog @ 665:fdefd0186b75
[xemacs-hg @ 2001-09-20 06:28:42 by ben]
The great integral types renaming.
The purpose of this is to rationalize the names used for various
integral types, so that they match their intended uses and follow
consist conventions, and eliminate types that were not semantically
different from each other.
The conventions are:
-- All integral types that measure quantities of anything are
signed. Some people disagree vociferously with this, but their
arguments are mostly theoretical, and are vastly outweighed by
the practical headaches of mixing signed and unsigned values,
and more importantly by the far increased likelihood of
inadvertent bugs: Because of the broken "viral" nature of
unsigned quantities in C (operations involving mixed
signed/unsigned are done unsigned, when exactly the opposite is
nearly always wanted), even a single error in declaring a
quantity unsigned that should be signed, or even the even more
subtle error of comparing signed and unsigned values and
forgetting the necessary cast, can be catastrophic, as
comparisons will yield wrong results. -Wsign-compare is turned
on specifically to catch this, but this tends to result in a
great number of warnings when mixing signed and unsigned, and
the casts are annoying. More has been written on this
elsewhere.
-- All such quantity types just mentioned boil down to EMACS_INT,
which is 32 bits on 32-bit machines and 64 bits on 64-bit
machines. This is guaranteed to be the same size as Lisp
objects of type `int', and (as far as I can tell) of size_t
(unsigned!) and ssize_t. The only type below that is not an
EMACS_INT is Hashcode, which is an unsigned value of the same
size as EMACS_INT.
-- Type names should be relatively short (no more than 10
characters or so), with the first letter capitalized and no
underscores if they can at all be avoided.
-- "count" == a zero-based measurement of some quantity. Includes
sizes, offsets, and indexes.
-- "bpos" == a one-based measurement of a position in a buffer.
"Charbpos" and "Bytebpos" count text in the buffer, rather than
bytes in memory; thus Bytebpos does not directly correspond to
the memory representation. Use "Membpos" for this.
-- "Char" refers to internal-format characters, not to the C type
"char", which is really a byte.
-- For the actual name changes, see the script below.
I ran the following script to do the conversion. (NOTE: This script
is idempotent. You can safely run it multiple times and it will
not screw up previous results -- in fact, it will do nothing if
nothing has changed. Thus, it can be run repeatedly as necessary
to handle patches coming in from old workspaces, or old branches.)
There are two tags, just before and just after the change:
`pre-integral-type-rename' and `post-integral-type-rename'. When
merging code from the main trunk into a branch, the best thing to
do is first merge up to `pre-integral-type-rename', then apply the
script and associated changes, then merge from
`post-integral-type-change' to the present. (Alternatively, just do
the merging in one operation; but you may then have a lot of
conflicts needing to be resolved by hand.)
Script `fixtypes.sh' follows:
----------------------------------- cut ------------------------------------
files="*.[ch] s/*.h m/*.h config.h.in ../configure.in Makefile.in.in ../lib-src/*.[ch] ../lwlib/*.[ch]"
gr Memory_Count Bytecount $files
gr Lstream_Data_Count Bytecount $files
gr Element_Count Elemcount $files
gr Hash_Code Hashcode $files
gr extcount bytecount $files
gr bufpos charbpos $files
gr bytind bytebpos $files
gr memind membpos $files
gr bufbyte intbyte $files
gr Extcount Bytecount $files
gr Bufpos Charbpos $files
gr Bytind Bytebpos $files
gr Memind Membpos $files
gr Bufbyte Intbyte $files
gr EXTCOUNT BYTECOUNT $files
gr BUFPOS CHARBPOS $files
gr BYTIND BYTEBPOS $files
gr MEMIND MEMBPOS $files
gr BUFBYTE INTBYTE $files
gr MEMORY_COUNT BYTECOUNT $files
gr LSTREAM_DATA_COUNT BYTECOUNT $files
gr ELEMENT_COUNT ELEMCOUNT $files
gr HASH_CODE HASHCODE $files
----------------------------------- cut ------------------------------------
`fixtypes.sh' is a Bourne-shell script; it uses 'gr':
----------------------------------- cut ------------------------------------
#!/bin/sh
# Usage is like this:
# gr FROM TO FILES ...
# globally replace FROM with TO in FILES. FROM and TO are regular expressions.
# backup files are stored in the `backup' directory.
from="$1"
to="$2"
shift 2
echo ${1+"$@"} | xargs global-replace "s/$from/$to/g"
----------------------------------- cut ------------------------------------
`gr' in turn uses a Perl script to do its real work,
`global-replace', which follows:
----------------------------------- cut ------------------------------------
: #-*- Perl -*-
### global-modify --- modify the contents of a file by a Perl expression
## Copyright (C) 1999 Martin Buchholz.
## Copyright (C) 2001 Ben Wing.
## Authors: Martin Buchholz <martin@xemacs.org>, Ben Wing <ben@xemacs.org>
## Maintainer: Ben Wing <ben@xemacs.org>
## Current Version: 1.0, May 5, 2001
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 2, or (at your option)
# any later version.
#
# This program is distributed in the hope that it will be useful, but
# WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
# General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with XEmacs; see the file COPYING. If not, write to the Free
# Software Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA
# 02111-1307, USA.
eval 'exec perl -w -S $0 ${1+"$@"}'
if 0;
use strict;
use FileHandle;
use Carp;
use Getopt::Long;
use File::Basename;
(my $myName = $0) =~ s@.*/@@; my $usage="
Usage: $myName [--help] [--backup-dir=DIR] [--line-mode] [--hunk-mode]
PERLEXPR FILE ...
Globally modify a file, either line by line or in one big hunk.
Typical usage is like this:
[with GNU print, GNU xargs: guaranteed to handle spaces, quotes, etc.
in file names]
find . -name '*.[ch]' -print0 | xargs -0 $0 's/\bCONST\b/const/g'\n
[with non-GNU print, xargs]
find . -name '*.[ch]' -print | xargs $0 's/\bCONST\b/const/g'\n
The file is read in, either line by line (with --line-mode specified)
or in one big hunk (with --hunk-mode specified; it's the default), and
the Perl expression is then evalled with \$_ set to the line or hunk of
text, including the terminating newline if there is one. It should
destructively modify the value there, storing the changed result in \$_.
Files in which any modifications are made are backed up to the directory
specified using --backup-dir, or to `backup' by default. To disable this,
use --backup-dir= with no argument.
Hunk mode is the default because it is MUCH MUCH faster than line-by-line.
Use line-by-line only when it matters, e.g. you want to do a replacement
only once per line (the default without the `g' argument). Conversely,
when using hunk mode, *ALWAYS* use `g'; otherwise, you will only make one
replacement in the entire file!
";
my %options = ();
$Getopt::Long::ignorecase = 0;
&GetOptions (
\%options,
'help', 'backup-dir=s', 'line-mode', 'hunk-mode',
);
die $usage if $options{"help"} or @ARGV <= 1;
my $code = shift;
die $usage if grep (-d || ! -w, @ARGV);
sub SafeOpen {
open ((my $fh = new FileHandle), $_[0]);
confess "Can't open $_[0]: $!" if ! defined $fh;
return $fh;
}
sub SafeClose {
close $_[0] or confess "Can't close $_[0]: $!";
}
sub FileContents {
my $fh = SafeOpen ("< $_[0]");
my $olddollarslash = $/;
local $/ = undef;
my $contents = <$fh>;
$/ = $olddollarslash;
return $contents;
}
sub WriteStringToFile {
my $fh = SafeOpen ("> $_[0]");
binmode $fh;
print $fh $_[1] or confess "$_[0]: $!\n";
SafeClose $fh;
}
foreach my $file (@ARGV) {
my $changed_p = 0;
my $new_contents = "";
if ($options{"line-mode"}) {
my $fh = SafeOpen $file;
while (<$fh>) {
my $save_line = $_;
eval $code;
$changed_p = 1 if $save_line ne $_;
$new_contents .= $_;
}
} else {
my $orig_contents = $_ = FileContents $file;
eval $code;
if ($_ ne $orig_contents) {
$changed_p = 1;
$new_contents = $_;
}
}
if ($changed_p) {
my $backdir = $options{"backup-dir"};
$backdir = "backup" if !defined ($backdir);
if ($backdir) {
my ($name, $path, $suffix) = fileparse ($file, "");
my $backfulldir = $path . $backdir;
my $backfile = "$backfulldir/$name";
mkdir $backfulldir, 0755 unless -d $backfulldir;
print "modifying $file (original saved in $backfile)\n";
rename $file, $backfile;
}
WriteStringToFile ($file, $new_contents);
}
}
----------------------------------- cut ------------------------------------
In addition to those programs, I needed to fix up a few other
things, particularly relating to the duplicate definitions of
types, now that some types merged with others. Specifically:
1. in lisp.h, removed duplicate declarations of Bytecount. The
changed code should now look like this: (In each code snippet
below, the first and last lines are the same as the original, as
are all lines outside of those lines. That allows you to locate
the section to be replaced, and replace the stuff in that
section, verifying that there isn't anything new added that
would need to be kept.)
--------------------------------- snip -------------------------------------
/* Counts of bytes or chars */
typedef EMACS_INT Bytecount;
typedef EMACS_INT Charcount;
/* Counts of elements */
typedef EMACS_INT Elemcount;
/* Hash codes */
typedef unsigned long Hashcode;
/* ------------------------ dynamic arrays ------------------- */
--------------------------------- snip -------------------------------------
2. in lstream.h, removed duplicate declaration of Bytecount.
Rewrote the comment about this type. The changed code should
now look like this:
--------------------------------- snip -------------------------------------
#endif
/* The have been some arguments over the what the type should be that
specifies a count of bytes in a data block to be written out or read in,
using Lstream_read(), Lstream_write(), and related functions.
Originally it was long, which worked fine; Martin "corrected" these to
size_t and ssize_t on the grounds that this is theoretically cleaner and
is in keeping with the C standards. Unfortunately, this practice is
horribly error-prone due to design flaws in the way that mixed
signed/unsigned arithmetic happens. In fact, by doing this change,
Martin introduced a subtle but fatal error that caused the operation of
sending large mail messages to the SMTP server under Windows to fail.
By putting all values back to be signed, avoiding any signed/unsigned
mixing, the bug immediately went away. The type then in use was
Lstream_Data_Count, so that it be reverted cleanly if a vote came to
that. Now it is Bytecount.
Some earlier comments about why the type must be signed: This MUST BE
SIGNED, since it also is used in functions that return the number of
bytes actually read to or written from in an operation, and these
functions can return -1 to signal error.
Note that the standard Unix read() and write() functions define the
count going in as a size_t, which is UNSIGNED, and the count going
out as an ssize_t, which is SIGNED. This is a horrible design
flaw. Not only is it highly likely to lead to logic errors when a
-1 gets interpreted as a large positive number, but operations are
bound to fail in all sorts of horrible ways when a number in the
upper-half of the size_t range is passed in -- this number is
unrepresentable as an ssize_t, so code that checks to see how many
bytes are actually written (which is mandatory if you are dealing
with certain types of devices) will get completely screwed up.
--ben
*/
typedef enum lstream_buffering
--------------------------------- snip -------------------------------------
3. in dumper.c, there are four places, all inside of switch()
statements, where XD_BYTECOUNT appears twice as a case tag. In
each case, the two case blocks contain identical code, and you
should *REMOVE THE SECOND* and leave the first.
| author | ben |
|---|---|
| date | Thu, 20 Sep 2001 06:31:11 +0000 |
| parents | 3ab33cd99bbf |
| children | b35d39ece38f |
line wrap: on
line source
2001-09-07 Stephen J. Turnbull <stephen@xemacs.org> * XEmacs 21.5.3 "asparagus" is released. 2001-06-24 Ben Wing <ben@xemacs.org> * lwlib-Xlw.c (xlw_update_tab_control): * lwlib-utils.c (XtApplyUntilToWidgets): * xlwgauge.c (XawGaugeSetValue): * xlwgauge.c (GaugeMercury): * xlwmenu.c (close_to_reference_time): * xlwtabs.c (TabsSetValues): * xlwtabs.c (TabsSelect): * xlwtabs.c (DrawTabs): Fix unsigned warnings. See src/ChangeLog for details. 2001-07-28 Stephen J. Turnbull <stephen@xemacs.org> * XEmacs 21.5.2 "artichoke" is released. 2001-07-26 Andy Piper <andy@xemacs.org> * lwlib-Xm.c (xm_update_progress): new function. Set Scale height and width from normal height and width. * lwlib-Xm.c (xm_create_progress): ditto. * lwlib-Xm.c (xm_update_one_widget): call xm_update_progress. * lwlib.c (lw_get_value_arg): new function. Return an argument based on its name. * lwlib.h: declare it. 2001-05-21 Martin Buchholz <martin@xemacs.org> * lwlib-config.c: Remove. * Makefile.in.in: Remove references to lwlib-config. 2001-05-09 Martin Buchholz <martin@xemacs.org> * XEmacs 21.5.1 "anise" is released. 2001-04-28 Ben Wing <ben@xemacs.org> * lwlib-utils.c (destroy_all_children): fix warning reported by Isaac Hollander <ysh@mindspring.com>. 2001-04-18 Martin Buchholz <martin@xemacs.org> * XEmacs 21.5.0 "alfalfa" is released. 2001-03-30 Stephen J. Turnbull <stephen@xemacs.org> * ChangeLog: Restore logs lost in the GTK merge. 2001-03-21 Martin Buchholz <martin@xemacs.org> * XEmacs 21.2.46 "Urania" is released. 2001-03-15 Stephen J. Turnbull <stephen@xemacs.org> * xlwradio.c: Revert gratuitous whitespace changes from GTK merge. 2001-02-23 Martin Buchholz <martin@xemacs.org> * XEmacs 21.2.45 "Thelxepeia" is released. 2001-02-16 Raymond Toy <toy@rtp.ericsson.se> * lwlib-Xaw.c: Always include ATHENA_AsciiText_h_ to get the text-field widget. (xaw_creation_table): Always include the text-field widget 2001-02-08 Martin Buchholz <martin@xemacs.org> * XEmacs 21.2.44 "Thalia" is released. 2001-02-06 Martin Buchholz <martin@xemacs.org> * xlwgauge.c: * xlwgcs.c: * xlwgcs.c (XtAllocateGC): Fix typo for X11R4. * xlwgcs.h: * xlwradio.c (RadioExpose): * xlwcheckbox.c: Remove use of BSD-specific types. s/u_(char|short|int_long)/unsigned $1/g 2001-02-05 Martin Buchholz <martin@xemacs.org> * lwlib-Xm.c (xm_update_one_value): Obey the man page; use XtFree instead of free. 2001-02-02 Martin Buchholz <martin@xemacs.org> * config.h.in: Use "..." to include config.h 2001-01-26 Martin Buchholz <martin@xemacs.org> * XEmacs 21.2.43 "Terspichore" is released. 2001-01-20 Martin Buchholz <martin@xemacs.org> * XEmacs 21.2.42 "Poseidon" is released. 2001-01-17 Martin Buchholz <martin@xemacs.org> * XEmacs 21.2.41 "Polyhymnia" is released. 2001-01-08 Martin Buchholz <martin@xemacs.org> * XEmacs 21.2.40 is released. 2001-01-06 Martin Buchholz <martin@xemacs.org> * lwlib-Xaw.c (xaw_creation_table): Make const. * lwlib-Xaw.h (xaw_creation_table): Make const. * lwlib-Xlw.c (xlw_creation_table): Make const. * lwlib-Xlw.h (xlw_creation_table): Make const. * lwlib-Xm.c (xm_creation_table): Make const. * lwlib-Xm.h (xm_creation_table): Make const. * lwlib.c (find_in_table): Use const. 2001-01-02 Andy Piper <andy@xemacs.org> * lwlib.h (_widget_args): add args_changed. Necessary because we reference count args. * lwlib.c (lw_add_widget_value_arg): set args_changed flag. (merge_widget_value_args): mark as changed if args_changed is true. (update_all_widget_values): reset args_changed. (initialize_widget_instance): ditto. 2000-12-31 Martin Buchholz <martin@xemacs.org> * XEmacs 21.2.39 is released. 2000-12-30 Andy Piper <andy@xemacs.org> * xlwtabs.c: remove assertion definitions and put them in lwlib-internal.h. This has the effect of enabling assertions which should have been done from the very start. (TabsShuffleRows): fix duff assertion. (PreferredSize3): use dimensions throughout. (PreferredSize2): ditto. (TabLayout): ditto. (DrawFrame): be clever about the enclosing frame if the child height is 0. (TabsResize): don't configure children that are no visible anyway. Make sure geometry calculations don't end up negative. * lwlib-internal.h: put in assertion definitions. 2000-12-05 Martin Buchholz <martin@xemacs.org> * XEmacs 21.2.38 is released. 2000-11-30 Andy Piper <andy@xemacs.org> * lwlib-Xm.c (xm_update_label): Hack to stop %_ labels until someone fixes it properly. 2000-11-24 Andy Piper <andy@xemacs.org> * xlwtabsP.h: add visible flag, realRows and remove displayChildren. * xlwtabs.c (TabVisible): new macro. Consults visible flag. (TabsInit): remove displayChildren, add realRows. (TabsConstraintInitialize): ditto. (TabsResize): ditto. (TabsGeometryManager): ditto. (TabsChangeManaged): ditto. (TabsSelect): ditto. (TabsPage): ditto. (TabsHighlight): ditto. (DrawTabs): ditto. (TabLayout): Caclulate rows for all children and whether they should be visible or not.. (TabsShuffleRows): shuffle rows based on both real and displayed rows. Adjust visibility of all children. (PreferredSize): ditto. 2000-11-19 Martin Buchholz <martin@xemacs.org> * xlwtabs.c (TabsResize): Don't delete `tab', mark unused instead. 2000-11-18 Martin Buchholz <martin@xemacs.org> * xlwmenu.c (make_windows_if_needed): (XlwMenuRealize): The proper type for `mask' is `unsigned long', not `int'. 2000-11-18 Martin Buchholz <martin@xemacs.org> * xlwtabs.c (defaultAccelerators): Add #### to unused var. (TabsResize): Remove unused var. * xlwmenu.c (XlwMenuInitialize): Remove unused vars. * lwlib-Xlw.c (xlw_update_one_widget): Add #### for probable bug. 2000-11-14 Martin Buchholz <martin@xemacs.org> * XEmacs 21.2.37 is released. 2000-11-02 Stephen J. Turnbull <stephen@xemacs.org> * lwlib.h: Typo fixes and tiny clarifications. 2000-10-04 Martin Buchholz <martin@xemacs.org> * XEmacs 21.2.36 is released. 2000-09-21 Andy Piper <andy@xemacs.org> * lwlib.h: declare copy_widget_value_tree. * lwlib.c (copy_widget_value_tree): make non-static. 2000-09-19 Martin Buchholz <martin@xemacs.org> * *: Spelling mega-patch 2000-09-16 Martin Buchholz <martin@xemacs.org> * lwlib.c (ascii_strcasecmp): New. * lwlib.c (find_in_table): Use ascii_strcasecmp. Avoid using non-standard non-portable strcasecmp. 2000-08-02 Stephen J. Turnbull <stephen@xemacs.org> * xlwmenu.c (XlwMenuInitialize): make comment on algorithm for setting fontList match code. Suggest using same algorithm for X Font Set resources in native lw code. 2000-07-30 Ben Wing <ben@xemacs.org> * lwlib-Xaw.c (xaw_update_one_widget): Remove accelerator specs from buttons, since Athena doesn't handle them. * lwlib.c (lw_remove_accelerator_spec): * lwlib.h: Define function and prototype to do this. 2000-07-15 Ben Wing <ben@xemacs.org> * xlwradioP.h: Remove duplicate definition of streq(). 2000-07-19 Martin Buchholz <martin@xemacs.org> * XEmacs 21.2.35 is released. 2000-07-09 Martin Buchholz <martin@xemacs.org> * xlwcheckbox.c: * xlwgauge.h: * xlwgaugeP.h: * xlwradio.h: * xlwradioP.h: * xlwgauge.c: * config.h.in: * xlwradio.c: * lwlib-Xaw.c: Replace SMART_INCLUDE with a dumber, but more reliable method. * xlwmenu.c (parameterize_string): Fix C++ compilation warnings. 2000-06-10 Ben Wing <ben@xemacs.org> * lwlib-Xaw.c (xaw_create_label): add sanity check on arg limit. (xaw_update_one_value): fix crash due to incorrect arg count. 2000-05-28 Martin Buchholz <martin@xemacs.org> * XEmacs 21.2.34 is released. 2000-05-01 Martin Buchholz <martin@xemacs.org> * XEmacs 21.2.33 is released. 2000-04-19 Martin Buchholz <martin@xemacs.org> * lwlib.c (lw_destroy_everything): Always use full ANSI prototypes. * lwlib.c (lw_destroy_all_pop_ups): Always use full ANSI prototypes. 2000-04-12 Andy Piper <andy@xemacs.org> * lwlib-Xaw.c (xaw_update_one_widget): no-op for text widgets. (xaw_update_one_value): Get strings safely. (xaw_create_text_field): add some extra properties. 2000-04-05 Andy Piper <andy@xemacs.org> * lwlib-Xaw.c (lw_xaw_widget_p): include asciiTextWidgetClass as an athena widget. 2000-04-05 Andy Piper <andy@xemacs.org> * xlwradio.c (RadioSetValues): resize if position information has changed. * lwlib-Xm.c (xm_create_text_field): text fields should be enabled even if there is no callback. * lwlib-Xaw.c (xaw_create_text_field): ditto. 2000-04-03 Andy Piper <andy@xemacs.org> * lwlib.c (merge_widget_value_args): only merge when the two args are actually different. 2000-03-21 Didier Verna <didier@xemacs.org> * config.h.in: move INCLUDE_GLUE_1 and INCLUDE_GLUE_2 to src/config.h.in. * config.h.in (ATHENA_INCLUDE): use the `SMART_INCLUDE' macro. 2000-03-20 Martin Buchholz <martin@xemacs.org> * XEmacs 21.2.32 is released. 2000-03-14 Ben Wing <ben@xemacs.org> * xlwmenu.c (massage_resource_name): Handle %_ and %%. 2000-02-20 Gunnar Evermann <ge204@eng.cam.ac.uk> * xlwscrollbar.c (get_gc): Always check for XmUNSPECIFIED_PIXMAP even if we are only 'compatible' with the Motif resources. (XmUNSPECIFIED_PIXMAP): Define unconditionally. 2000-02-23 Martin Buchholz <martin@xemacs.org> * XEmacs 21.2.31 is released. 2000-02-22 Andy Piper <andy@xemacs.org> * lwlib-Xm.c (xm_update_one_widget): set widget args last in case anything messes with them in the meantime. * lwlib-Xlw.c (xlw_update_one_widget): ditto. * lwlib-Xaw.c (xaw_update_one_widget): ditto. 2000-02-21 Martin Buchholz <martin@xemacs.org> * XEmacs 21.2.30 is released. 2000-02-21 Andy Piper <andy@xemacs.org> * lwlib.c (merge_widget_value_args): don't delete the args before copying, lw_copy_widget_value_args will do this for us if necessary. (lw_add_widget_value_arg): Allow existing args to be replaced. (free_widget_value_args): Set args to 0 rather than 0xdeadbeef, reference couting works better that way. (lw_copy_widget_value_args): Do the right thing. * lwlib-Xm.c (xm_create_progress): Make sensitive as this looks much better. * lwlib-Xaw.c (xaw_create_progress): ditto. 2000-02-12 Jan Vroonhof <vroonhof@math.ethz.ch> * xlwmenu.h (XmUNSPECIFIED_PIXMAP): Define this if we are using Motif compatible resource names. * xlwmenu.c (make_shadow_gcs): Always check for XmUNSPECIFIED_PIXMAP even if we are only 'compatible' with the Motif resources. 2000-02-15 Andy Piper <andy@xemacs.org> * xlwgauge.c (GaugeExpose): remove shadows. 2000-02-16 Martin Buchholz <martin@xemacs.org> * XEmacs 21.2.29 is released. 2000-02-09 Valdis Kletnieks <Valdis.Kletnieks@vt.edu> * config.h.in (ATHENA_INCLUDE): Workaround bugs in both xlc and old gccs. 2000-02-07 Martin Buchholz <martin@xemacs.org> * XEmacs 21.2.28 is released. 2000-01-25 Andy Piper <andy@xemacs.org> * xlwtabs.c (TabsChangeManaged): Make sure we unmanage the hilight widget as well. 2000-01-28 Martin Buchholz <martin@xemacs.org> * xlwgauge.c (GaugeConvert): bcopy ==> memcpy 2000-01-24 Andy Piper <andy@xemacs.org> * xlwtabs.c (XawTabsSetTop): Unhighlight before changing the stacking order. (XawTabsSetHighlight): Don't unhighlight here. 2000-01-22 Martin Buchholz <martin@xemacs.org> * *.h: Use consistent C-standards-approved guard macro names. 2000-01-18 Martin Buchholz <martin@xemacs.org> * XEmacs 21.2.27 is released. 2000-01-15 Andy Piper <andy@xemacs.org> * lwlib-Xlw.c (lw_update_one_widget): make sure global properties gets set. 2000-01-07 Martin Buchholz <martin@xemacs.org> * config.h.in (ATHENA_INCLUDE): CPP trickery to make old cpps happy. This extends support for gcc 2.6 (e.g. on BSD/OS 2.0) * lwlib.c: Fix up memset calls. * lwlib-Xm.c (xm_update_text): Warning suppression. (xm_update_text_field): Warning suppression. 2000-01-03 Martin Buchholz <martin@xemacs.org> * lwlib-Xaw.c (xaw_update_one_widget): Emergency fix for this crash: (yes-or-no-p-dialog-box "Yes or No") 1999-12-31 Martin Buchholz <martin@xemacs.org> * XEmacs 21.2.26 is released. 1999-12-29 Andy Piper <andy@xemacs.org> * xlwtabs.c (TabsHighlight): use displayChildren for highlighting not num_children. (TabsPage): ditto. 1999-12-24 Martin Buchholz <martin@xemacs.org> * XEmacs 21.2.25 is released. 1999-12-23 Andy Piper <andy@xemacs.org> * lwlib.c (lw_copy_widget_value_args): don't create empty widget_args just because someone might use them later. This makes all widgets look like they've changed. 1999-12-22 Andy Piper <andy@xemacs.org> * xlwtabs.c: Fix for X11R5 from Damon Lipparelli <lipp@primus.com>. 1999-12-21 Martin Buchholz <martin@xemacs.org> * xlwscrollbar.c (seg_pixel_sizes): ((expr)) ==> (expr) 1999-12-12 Daniel Pittman <daniel@danann.net> * lwlib-Xaw.c: * xlwcheckbox.c: * xlwgauge.h: * xlwgaugeP.h: * xlwradio.c: * xlwradio.h: * xlwradioP.h: Clean up Athena widget support: - Athena headers now use dynamic include paths. 1999-12-08 Andy Piper <andy@xemacs.org> * xlwtabs.c: sync with Tabs 2.2. * xlwtabP.h: ditto. 1999-12-14 Martin Buchholz <martin@xemacs.org> * XEmacs 21.2.24 is released. 1999-12-14 Andy Piper <andy@xemacs.org> * xlwtabs.c (TabsResize): reset need_layout so that we don't go into infloop death. 1999-12-14 Andy Piper <andy@xemacs.org> * xlwtabs.c (TabsSetValues): re-allocate GCs if font has changed. 1999-12-13 Andy Piper <andy@xemacs.org> * xlwtabs.c (TabsResize): We need to expose the tabs after clearing the window they are in. 1999-12-08 Andy Piper <andy@xemacs.org> * xlwtabs.c: sync with Tabs 2.1. 1999-12-07 Andy Piper <andy@xemacs.org> * lwlib-Xlw.c (lw_lucid_widget_p): make sure we pick up the clip-window as well. 1999-12-07 Martin Buchholz <martin@xemacs.org> * XEmacs 21.2.23 is released. 1999-12-05 Andy Piper <andy@xemacs.org> * xlwtabs.c: back up to previous rev to make syncing easier. Fix gcc moans. * lwlib-Xaw.c (xaw_update_one_widget): use XtIsSubclass. 1999-11-29 XEmacs Build Bot <builds@cvs.xemacs.org> * XEmacs 21.2.22 is released 1999-11-28 Martin Buchholz <martin@xemacs.org> * XEmacs 21.2.21 is released. 1999-11-26 Martin Buchholz <martin@xemacs.org> * xlwtabs.c: Remove unused variables. Fix warnings. 1999-11-10 XEmacs Build Bot <builds@cvs.xemacs.org> * XEmacs 21.2.20 is released 1999-09-09 Andy Piper <andy@xemacs.org> * xlwtabs.c: updated tabs widget from Ed Falk. * xlwtabs.h: ditto. * xlwtabsP.h: ditto. 1999-09-22 Martin Buchholz <martin@xemacs.org> * lwlib-internal.h: * lwlib-utils.h: Move declaration of destroy_all_children from lwlib-internal.h to lwlib-utils.h, where it belongs. 1999-09-21 Andy Piper <andy@xemacs.org> * lwlib-Xm.c (xm_update_label): don't clobber pixmap type labels with text. 1999-09-22 Martin Buchholz <martin@xemacs.org> * xlwtabs.c: Fix C++ compilability. 1999-09-18 Andy Piper <andy@xemacs.org> * xlwtabs.c: Put in tabs sync because clipping should fix useability problems. 1999-09-13 Andy Piper <andy@xemacs.org> * xlwtabs.c: Back out tabs sync because of reported useability problems. 1999-09-09 Andy Piper <andy@xemacs.org> * xlwtabs.c: updated tabs widget from Ed Falk. * xlwtabs.h: ditto. * xlwtabsP.h: ditto. * xlwgcs.c: ditto. * xlwgcs.h: ditto. 1999-09-03 Martin Buchholz <martin@xemacs.org> * xlwgauge.c: Ansify. Include <stdlib.h> to get prototype for atoi(). (GaugeSelect): Call GaugeExpose with the right number of args. (GaugeLoseSel): Call GaugeExpose with the right number of args. (GaugeConvert): This is a XtConvertSelectionProc, so 5th parameter must be of type XtPointer, not XPointer. (GaugeGetValue): This is a XtTimerCallbackProc, so 2nd parameter must be of type XtIntervalId *, not XtIntervalId. 1999-09-01 Martin Buchholz <martin@xemacs.org> * lwlib.c (free_widget_value_contents): Use proper type for cast. * xlwradio.c: Use function prototypes everywhere. * xlwcheckbox.c: * xlwradio.c: * xlwradioP.h: Move declarations of non-static functions defined in xlwradio.c into xlwradioP.h. 1999-09-02 Andy Piper <andy@xemacs.org> * xlwgcs.c: include xmu.h 1999-09-01 Andy Piper <andy@xemacs.org> * xlwgauge.c: rearrange headers yet again. * xlwcheckbox.c: ditto. * xlwradio.c: ditto. * xlwtabs.c: ditto. 1999-09-01 Andy Piper <andy@xemacs.org> * xlwgauge.c: use xmu.h * xlwcheckbox.c: ditto. * xlwradio.c: ditto. 1999-08-31 Andy Piper <andy@xemacs.org> * xlwtabs.c: * xlwgcs.c: * xlwradio.c: * xlwcheckbox.c: * xlwgauge.c: Fix for losing systems without Xmu. 1999-08-31 Andy Piper <andy@xemacs.org> * lwlib-Xm.c (xm_update_one_widget): fix for AIX compiler lossage. 1999-08-30 Andy Piper <andy@xemacs.org> * lwlib.c (free_widget_value_contents): be more precise about freeing user defined args. * lwlib-Xaw.c (xaw_update_one_widget): make sure we use val not its contents for hierarchies one deep. 1999-08-29 Andy Piper <andy@xemacs.org> * xlwtabs.c: temporary fixes pending a new release. * xlwtabsP.h: ditto. * lwlib-Xm.c (xm_update_one_widget): update user defined args. (xm_create_label): set args after creation as well as before. * lwlib-Xlw.c (xlw_create_tab_control): orient tabs horizontally. (xlw_update_tab_control): actually update the children rather than the parent. * lwlib-Xaw.c (xaw_update_one_widget): update user defined args. (xaw_create_label): set args after creation as well as before. 1999-08-23 Andy Piper <andy@xemacs.org> * lwlib-Xm.c (xm_update_label): don't concatenate value to itself. * lwlib-Xm.c (xm_create_label_field): new function for creating labels. (xm_creation_table): use it. * lwlib-Xaw.c (xaw_create_label_field): new function for creating labels. (xaw_creation_table): use it. 1999-08-16 Andy Piper <andy@xemacs.org> * lwlib.h: declare free_widget_value_tree. * lwlib.c (free_widget_value_tree): make non-static. * lwlib-Xm.c (xm_update_label): free val_string when updating. 1999-08-04 Andy Piper <andy@xemacs.org> * lwlib-Xm.c (mark_dead_instance_destroyed): change so that its defined for widgets. (xm_nosel_callback): ditto. * xlwtabsP.h: sync with 1.5. * xlwtabs.c: sync with 1.18. 1999-07-28 Andy Piper <andy@xemacs.org> * xlwtabs.c: new lucid tabs widget from Ed Falk. * xlwtabs.h: ditto. * xlwtabsP.h: ditto. * xlwgcs.c: GC manipulation for tab widgets. * xlwgcs.h: ditto. * xlwgauge.c: new athena gauge widget from Ed Falk. * xlwgauge.h: ditto. * xlwgaugeP.h: ditto. * xlwradio.c: new athena radio widget from Ed Falk. * xlwradio.h: ditto. * xlwradioP.h: ditto. * xlwcheckbox.c: new athena checkbox widget from Ed Falk. * xlwcheckbox.h: ditto. * xlwcheckboxP.h: ditto. * lwlib-utils.c (destroy_all_children): moved from lwlib-Xm.c. * lwlib-internal.h: declare destroy_all_children. * lwlib-config.c: add widget checks. * lwlib-Xm.h: declare xm_create_label; * lwlib-Xm.c (destroy_all_children): move to lwlib-utils.c. (xm_update_label): enable for widgets. (xm_update_one_widget): ditto. (xm_create_button): rename in line with lwlib-Xaw.c (xm_create_progress): ditto. (xm_create_text_field): ditto. (xm_create_combo_box): ditto. (xm_create_label): new function. (xm_creation_table): rename widget creation functions. (xm_destroy_instance): enable for widgets. (xm_generic_callback): ditto. (xm_generic_callback): ditto. * lwlib-Xlw.c (xlw_tab_control_callback): new function. a special callback that calls the correct function depending on what tab is selected. (xlw_create_tab_control): new function. (build_tabs_in_widget): new function. puts tabs in a tab widget, uses Xaw or Xm depending on how XEmacs was compiled. (xlw_update_tab_control): update the resources for each tab. optionally rebuild the contents of the tab widget. (xlw_creation_table): add tab widget creation function. (lw_lucid_widget_p): add tab widget. (xlw_update_one_widget): ditto. * lwlib-Xaw.h: declare xaw_create_label; * lwlib-Xaw.c (lw_xaw_widget_p): add widgets classes. (xaw_update_one_widget): ditto. (xaw_update_one_value): add code from the Xm version. (xaw_generic_callback): add Xm hack for setting command states. beef up lookup of call data. (xaw_create_button): new function. (xaw_create_label): new function for use by tab widget. (xaw_create_progress): new function. (xaw_create_text_field): new function. (xaw_creation_table): add new widget type creation functions. * Makefile.in.in: add dependencies for new lw widgets. 1999-07-30 XEmacs Build Bot <builds@cvs.xemacs.org> * XEmacs 21.2.19 is released 1999-07-13 XEmacs Build Bot <builds@cvs.xemacs.org> * XEmacs 21.2.18 is released 1999-07-05 Didier Verna <didier@xemacs.org> * lwlib-Xm.c (xm_update_one_widget): add missing #ifdefs around call to xm_update_label. 1999-06-28 Andy Piper <andy@xemacs.org> * lwlib-Xm.c: unconditionally enable text field & list code. (make_progress): new function. creates a slider. (make_text_field): new function. creates an edit field. (make_combo_box): new function. creates a combo box. (xm_creation_table): add new widget functions. 1999-06-25 Andy Piper <andy@xemacs.org> * lwlib.h (_widget_value): add arglist slots. declare new functions. * lwlib.c (free_widget_value_contents): handle arglists when freeing. (lw_add_value_args_to_args): new function. add arglist entries from a widget_value structure. * lwlib-Xm.c (make_button): new function, create a motif button for display in a buffer as a glyph. (xm_creation_table): add make_button. 1999-06-22 XEmacs Build Bot <builds@cvs.xemacs.org> * XEmacs 21.2.17 is released 1999-06-11 XEmacs Build Bot <builds@cvs.xemacs.org> * XEmacs 21.2.16 is released 1999-06-04 XEmacs Build Bot <builds@cvs.xemacs.org> * XEmacs 21.2.15 is released 1999-05-17 Jerry James <jerry@cs.ucsb.edu> * xlwmenu.c (make_shadow_gcs): Test bottom_shadow_pixmap before using it. 1999-05-14 XEmacs Build Bot <builds@cvs.xemacs.org> * XEmacs 21.2.14 is released 1999-03-12 XEmacs Build Bot <builds@cvs.xemacs.org> * XEmacs 21.2.13 is released 1999-03-05 XEmacs Build Bot <builds@cvs.xemacs.org> * XEmacs 21.2.12 is released 1999-02-18 Martin Buchholz <martin@xemacs.org> * lwlib/xlwmenu.c (massage_resource_name): Fix compiler warning - Have to toupper ((int) (unsigned char) x) to be portable.