view 21.4.4-Changes @ 665:fdefd0186b75

[xemacs-hg @ 2001-09-20 06:28:42 by ben] The great integral types renaming. The purpose of this is to rationalize the names used for various integral types, so that they match their intended uses and follow consist conventions, and eliminate types that were not semantically different from each other. The conventions are: -- All integral types that measure quantities of anything are signed. Some people disagree vociferously with this, but their arguments are mostly theoretical, and are vastly outweighed by the practical headaches of mixing signed and unsigned values, and more importantly by the far increased likelihood of inadvertent bugs: Because of the broken "viral" nature of unsigned quantities in C (operations involving mixed signed/unsigned are done unsigned, when exactly the opposite is nearly always wanted), even a single error in declaring a quantity unsigned that should be signed, or even the even more subtle error of comparing signed and unsigned values and forgetting the necessary cast, can be catastrophic, as comparisons will yield wrong results. -Wsign-compare is turned on specifically to catch this, but this tends to result in a great number of warnings when mixing signed and unsigned, and the casts are annoying. More has been written on this elsewhere. -- All such quantity types just mentioned boil down to EMACS_INT, which is 32 bits on 32-bit machines and 64 bits on 64-bit machines. This is guaranteed to be the same size as Lisp objects of type `int', and (as far as I can tell) of size_t (unsigned!) and ssize_t. The only type below that is not an EMACS_INT is Hashcode, which is an unsigned value of the same size as EMACS_INT. -- Type names should be relatively short (no more than 10 characters or so), with the first letter capitalized and no underscores if they can at all be avoided. -- "count" == a zero-based measurement of some quantity. Includes sizes, offsets, and indexes. -- "bpos" == a one-based measurement of a position in a buffer. "Charbpos" and "Bytebpos" count text in the buffer, rather than bytes in memory; thus Bytebpos does not directly correspond to the memory representation. Use "Membpos" for this. -- "Char" refers to internal-format characters, not to the C type "char", which is really a byte. -- For the actual name changes, see the script below. I ran the following script to do the conversion. (NOTE: This script is idempotent. You can safely run it multiple times and it will not screw up previous results -- in fact, it will do nothing if nothing has changed. Thus, it can be run repeatedly as necessary to handle patches coming in from old workspaces, or old branches.) There are two tags, just before and just after the change: `pre-integral-type-rename' and `post-integral-type-rename'. When merging code from the main trunk into a branch, the best thing to do is first merge up to `pre-integral-type-rename', then apply the script and associated changes, then merge from `post-integral-type-change' to the present. (Alternatively, just do the merging in one operation; but you may then have a lot of conflicts needing to be resolved by hand.) Script `fixtypes.sh' follows: ----------------------------------- cut ------------------------------------ files="*.[ch] s/*.h m/*.h config.h.in ../configure.in Makefile.in.in ../lib-src/*.[ch] ../lwlib/*.[ch]" gr Memory_Count Bytecount $files gr Lstream_Data_Count Bytecount $files gr Element_Count Elemcount $files gr Hash_Code Hashcode $files gr extcount bytecount $files gr bufpos charbpos $files gr bytind bytebpos $files gr memind membpos $files gr bufbyte intbyte $files gr Extcount Bytecount $files gr Bufpos Charbpos $files gr Bytind Bytebpos $files gr Memind Membpos $files gr Bufbyte Intbyte $files gr EXTCOUNT BYTECOUNT $files gr BUFPOS CHARBPOS $files gr BYTIND BYTEBPOS $files gr MEMIND MEMBPOS $files gr BUFBYTE INTBYTE $files gr MEMORY_COUNT BYTECOUNT $files gr LSTREAM_DATA_COUNT BYTECOUNT $files gr ELEMENT_COUNT ELEMCOUNT $files gr HASH_CODE HASHCODE $files ----------------------------------- cut ------------------------------------ `fixtypes.sh' is a Bourne-shell script; it uses 'gr': ----------------------------------- cut ------------------------------------ #!/bin/sh # Usage is like this: # gr FROM TO FILES ... # globally replace FROM with TO in FILES. FROM and TO are regular expressions. # backup files are stored in the `backup' directory. from="$1" to="$2" shift 2 echo ${1+"$@"} | xargs global-replace "s/$from/$to/g" ----------------------------------- cut ------------------------------------ `gr' in turn uses a Perl script to do its real work, `global-replace', which follows: ----------------------------------- cut ------------------------------------ : #-*- Perl -*- ### global-modify --- modify the contents of a file by a Perl expression ## Copyright (C) 1999 Martin Buchholz. ## Copyright (C) 2001 Ben Wing. ## Authors: Martin Buchholz <martin@xemacs.org>, Ben Wing <ben@xemacs.org> ## Maintainer: Ben Wing <ben@xemacs.org> ## Current Version: 1.0, May 5, 2001 # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by # the Free Software Foundation; either version 2, or (at your option) # any later version. # # This program is distributed in the hope that it will be useful, but # WITHOUT ANY WARRANTY; without even the implied warranty of # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU # General Public License for more details. # # You should have received a copy of the GNU General Public License # along with XEmacs; see the file COPYING. If not, write to the Free # Software Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA # 02111-1307, USA. eval 'exec perl -w -S $0 ${1+"$@"}' if 0; use strict; use FileHandle; use Carp; use Getopt::Long; use File::Basename; (my $myName = $0) =~ s@.*/@@; my $usage=" Usage: $myName [--help] [--backup-dir=DIR] [--line-mode] [--hunk-mode] PERLEXPR FILE ... Globally modify a file, either line by line or in one big hunk. Typical usage is like this: [with GNU print, GNU xargs: guaranteed to handle spaces, quotes, etc. in file names] find . -name '*.[ch]' -print0 | xargs -0 $0 's/\bCONST\b/const/g'\n [with non-GNU print, xargs] find . -name '*.[ch]' -print | xargs $0 's/\bCONST\b/const/g'\n The file is read in, either line by line (with --line-mode specified) or in one big hunk (with --hunk-mode specified; it's the default), and the Perl expression is then evalled with \$_ set to the line or hunk of text, including the terminating newline if there is one. It should destructively modify the value there, storing the changed result in \$_. Files in which any modifications are made are backed up to the directory specified using --backup-dir, or to `backup' by default. To disable this, use --backup-dir= with no argument. Hunk mode is the default because it is MUCH MUCH faster than line-by-line. Use line-by-line only when it matters, e.g. you want to do a replacement only once per line (the default without the `g' argument). Conversely, when using hunk mode, *ALWAYS* use `g'; otherwise, you will only make one replacement in the entire file! "; my %options = (); $Getopt::Long::ignorecase = 0; &GetOptions ( \%options, 'help', 'backup-dir=s', 'line-mode', 'hunk-mode', ); die $usage if $options{"help"} or @ARGV <= 1; my $code = shift; die $usage if grep (-d || ! -w, @ARGV); sub SafeOpen { open ((my $fh = new FileHandle), $_[0]); confess "Can't open $_[0]: $!" if ! defined $fh; return $fh; } sub SafeClose { close $_[0] or confess "Can't close $_[0]: $!"; } sub FileContents { my $fh = SafeOpen ("< $_[0]"); my $olddollarslash = $/; local $/ = undef; my $contents = <$fh>; $/ = $olddollarslash; return $contents; } sub WriteStringToFile { my $fh = SafeOpen ("> $_[0]"); binmode $fh; print $fh $_[1] or confess "$_[0]: $!\n"; SafeClose $fh; } foreach my $file (@ARGV) { my $changed_p = 0; my $new_contents = ""; if ($options{"line-mode"}) { my $fh = SafeOpen $file; while (<$fh>) { my $save_line = $_; eval $code; $changed_p = 1 if $save_line ne $_; $new_contents .= $_; } } else { my $orig_contents = $_ = FileContents $file; eval $code; if ($_ ne $orig_contents) { $changed_p = 1; $new_contents = $_; } } if ($changed_p) { my $backdir = $options{"backup-dir"}; $backdir = "backup" if !defined ($backdir); if ($backdir) { my ($name, $path, $suffix) = fileparse ($file, ""); my $backfulldir = $path . $backdir; my $backfile = "$backfulldir/$name"; mkdir $backfulldir, 0755 unless -d $backfulldir; print "modifying $file (original saved in $backfile)\n"; rename $file, $backfile; } WriteStringToFile ($file, $new_contents); } } ----------------------------------- cut ------------------------------------ In addition to those programs, I needed to fix up a few other things, particularly relating to the duplicate definitions of types, now that some types merged with others. Specifically: 1. in lisp.h, removed duplicate declarations of Bytecount. The changed code should now look like this: (In each code snippet below, the first and last lines are the same as the original, as are all lines outside of those lines. That allows you to locate the section to be replaced, and replace the stuff in that section, verifying that there isn't anything new added that would need to be kept.) --------------------------------- snip ------------------------------------- /* Counts of bytes or chars */ typedef EMACS_INT Bytecount; typedef EMACS_INT Charcount; /* Counts of elements */ typedef EMACS_INT Elemcount; /* Hash codes */ typedef unsigned long Hashcode; /* ------------------------ dynamic arrays ------------------- */ --------------------------------- snip ------------------------------------- 2. in lstream.h, removed duplicate declaration of Bytecount. Rewrote the comment about this type. The changed code should now look like this: --------------------------------- snip ------------------------------------- #endif /* The have been some arguments over the what the type should be that specifies a count of bytes in a data block to be written out or read in, using Lstream_read(), Lstream_write(), and related functions. Originally it was long, which worked fine; Martin "corrected" these to size_t and ssize_t on the grounds that this is theoretically cleaner and is in keeping with the C standards. Unfortunately, this practice is horribly error-prone due to design flaws in the way that mixed signed/unsigned arithmetic happens. In fact, by doing this change, Martin introduced a subtle but fatal error that caused the operation of sending large mail messages to the SMTP server under Windows to fail. By putting all values back to be signed, avoiding any signed/unsigned mixing, the bug immediately went away. The type then in use was Lstream_Data_Count, so that it be reverted cleanly if a vote came to that. Now it is Bytecount. Some earlier comments about why the type must be signed: This MUST BE SIGNED, since it also is used in functions that return the number of bytes actually read to or written from in an operation, and these functions can return -1 to signal error. Note that the standard Unix read() and write() functions define the count going in as a size_t, which is UNSIGNED, and the count going out as an ssize_t, which is SIGNED. This is a horrible design flaw. Not only is it highly likely to lead to logic errors when a -1 gets interpreted as a large positive number, but operations are bound to fail in all sorts of horrible ways when a number in the upper-half of the size_t range is passed in -- this number is unrepresentable as an ssize_t, so code that checks to see how many bytes are actually written (which is mandatory if you are dealing with certain types of devices) will get completely screwed up. --ben */ typedef enum lstream_buffering --------------------------------- snip ------------------------------------- 3. in dumper.c, there are four places, all inside of switch() statements, where XD_BYTECOUNT appears twice as a case tag. In each case, the two case blocks contain identical code, and you should *REMOVE THE SECOND* and leave the first.
author ben
date Thu, 20 Sep 2001 06:31:11 +0000
parents e668cb7f5670
children
line wrap: on
line source

The changes in this release candidate (3) are grouped in the following
sections.  Some patches overlap a couple of sections, I (somewhat
arbitrarily) assigned them to the section I thought was most
important.

Please review especially the RELEASE CANDIDATE 3, RELEASE CANDIDATE 2,
UI, and GENERAL sections, and others as you have interest/expertise.
The MISCELLANEOUS and DOCUMENTATION sections are entirely
uncontroversial and may safely be ignored.

To see the changes since 21.4.3, use
cvs diff -r r21-4-3 -r candidate-21-4
To see the changes since release candidate 1, use
cvs diff -r r21-4-4-rc1 -r candidate-21-4

I'm not committed to anything here irrevocably; this is just my first pass
at the next release candidate.  Nor are things I've not included here
necessarily ruled out.  Let me know if anything in needs out, or anything
out needs in, in your opinion.

RELEASE CANDIDATE 3
RELEASE CANDIDATE 2
UI and API CHANGES
GENERAL BUG FIXES
MS WINDOWS - printing
MS WINDOWS - set_file_times
MS WINDOWS - C-g handling
MS WINDOWS - miscellaneous
GTK
MISCELLANEOUS
DOCUMENTATION

RELEASE CANDIDATE 3

<15196.1288.138343.769692@turnbull.sk.tsukuba.ac.jp>
./src/ChangeLog
2001-07-22  Stephen J. Turnbull  <stephen@xemacs.org>

	* event-msw.c (mswindows_wnd_proc): Add GC debugging assert.

<15196.462.687249.746246@turnbull.sk.tsukuba.ac.jp>
./ChangeLog
2001-07-22  Stephen J. Turnbull  <stephen@xemacs.org>

	* configure.in (with_esd_sound): Default to no.

	* configure.usage: Various documentation improvements.

	* configure.in (--with-ipv6-cname): New Boolean option.  Defaults on.
	* configure.usage:
	* PROBLEMS (IPv6 CNAME lookup):
	Document it.

<15196.462.687249.746246@turnbull.sk.tsukuba.ac.jp>
./src/ChangeLog
2001-07-22  Stephen J. Turnbull  <stephen@xemacs.org>

	* config.h.in (IPV6_CANONICALIZE): New #define for --with-ipv6-lookup.
	* process-unix.c (unix_canonicalize_host_name):
	sysdep.c (init_system_name):
	Use it to conditionally support IPv6 canonicalization.

<FENWAY95sao0eCdPap400001472@fenway.corp.soundbite.com>
./src/ChangeLog
2001-06-05  Paul Krause  <pkrause@soundbite.com>

	* event-msw.c: replace unsafe call to stderr_out with
	mswindows_output_console_string

<n162ylx0.fsf@ecf.teradyne.com>
./ChangeLog
2001-07-18  Adrian Aichner  <adrian@xemacs.org>

	* etc\TUTORIAL: Fix minor typo.
	* etc\TUTORIAL.de: Sync with TUTORIAL.

RELEASE CANDIDATE 2

Typo in ChangeLog fix due to Nix.

Change format of in version.sh codename string due to Bill Gates.
Reported by Adrian.

<yosupub9h4de.fsf@jpl.org>
./lisp/ChangeLog
2001-07-10  Katsumi Yamaoka  <yamaoka@jpl.org>

	* mule/kinsoku.el (kinsoku-bol-p): Work with ascii and non-ascii
	mixed text.
	(kinsoku-eol-p): Ditto.

2001-07-09  Katsumi Yamaoka  <yamaoka@jpl.org>

	* mule/kinsoku.el (kinsoku-ascii-eol, kinsoku-gb-bol,
	kinsoku-gb-eol, kinsoku-big5-bol, kinsoku-big5-eol): Assign
	characters as the category `s' or `e' correctly.

<yz17kyxzij2.fsf@milhouse.cs.cornell.edu>
./src/Changelog
2001-05-31  Paul Stodghill  <stodghil@cs.cornell.edu>

	* event-msw.c:
	Cygwin does not define WM_IME_xxx. Modify the #if's accordingly.

<003601c0e020$67f10d40$6401a8c0@paulkrause>
./src/ChangeLog
2001-05-19  Paul Krause  <paulkrause1@mediaone.net>

	* scrollbar-msw.c: Fixes a crash that occurs on Windows when an
	attempt is made to scroll when no scroll bar is available.

<005f01c10fbc$6c61edb0$090a050a@soundbite.com>
./nt/ChangeLog
2001-07-18  Paul Krause  <paulkrause1@mediaone.net>

	xemacs.mak:  Improved detection for cygwin perl.

	Supercedes <FENWAYUfKRfcjcMzfoV00000f4e@fenway.corp.soundbite.com>

<15133.17889.988505.202517@tyranny.hsys.msk.ru>
./man/ChangeLog
2001-06-06  Alexey Mahotkin  <alexm@hsys.msk.ru>

	* xemacs/mule.texi: Typo fixes and describe CCL and fonts.
	* lispref/mule.texi: Typo fixes and describe set-charset-registry.

<15133.17889.988505.202517@tyranny.hsys.msk.ru>
./lisp/ChangeLog
2001-06-06  Alexey Mahotkin  <alexm@hsys.msk.ru>

	* mule/cyrillic.el: Uncomment definition of ccl-encode-koi8-r-font.

./lisp/ChangeLog
2001-06-14  Alexey Mahotkin  <alexm@hsys.msk.ru>

	* mule/cyrillic.el:  Set up case table.

<y9lofrz77zt.fsf@informatik.uni-tuebingen.de>
./lisp/ChangeLog
2001-06-08  Mike Sperber <mike@xemacs.org>

	* files.el (save-some-buffers-1): Don't zap the help window right
	after `map-y-or-n-p' has popped it up.

<15142.14867.525787.322728@turnbull.sk.tsukuba.ac.jp>
./nt/ChangeLog
2001-06-12  Stephen J. Turnbull  <stephen@xemacs.org>

	* xemacs.mak (HAVE_ZLIB): New, defaults to HAVE_PNG.
	(USE_MINITAR): Default to HAVE_ZLIB.
	(MSW_LIBS): Add comctl32.lib if HAVE_WIDGETS.
	(mostlyclean, nicenclean, distclean, versionclean): Only one target
	per invocation of $(DEL); don't use unneeded switches (WinME support).

UI and API CHANGES

<y9lwv966j49.fsf@sams.informatik.uni-tuebingen.de>
./src/ChangeLog
2001-03-31  Mike Sperber <mike@xemacs.org>

	* search.c (Freplace_match): Support FSF-style specification of
	match subexpression when applied to a buffer.

<15160.50052.863645.73187@europe.nortel.com>
./lisp/ChangeLog
2001-06-26  Robert Pluim  <rpluim@bigfoot.com>

	* packages.el (locate-library): Use read-library-name for completion.

<15160.50790.460079.416332@europe.nortel.com>
./lisp/ChangeLog
2001-06-26  Robert Pluim  <rpluim@bigfoot.com>

	* package-ui.el (pui-install-selected-packages): reverse the lists
	of packages so that they get handled in the same order as they
	were selected.

<microsoft-free.x4pub3lxg4.fsf@slackware.mynet.pc>
./src/ChangeLog
2001-07-14  Sean MacLennan  <seanm@storm.ca>

	* package-admin.el (package-install-hook): New.
	(package-delete-hook): New.
	(package-admin-add-single-file-package): Use package-delete-hook.

	* package-get.el (package-get): Use package-install-hook.

<sxsoftm4b29.fsf@florida.arsdigita.de>
./lisp/ChangeLog
2001-04-24  Hrvoje Niksic  <hniksic@arsdigita.com>

	* about.el (about-mailto-link): Use compose-mail for sending mail.

<muxy9sz343m.fsf@uzeb.lrde.epita.fr>
./lisp/ChangeLog
2001-04-17  Didier Verna  <didier@xemacs.org>

	* startup.el (load-user-init-file): define `custom-file' before
	loading the user's init file.

<mux1yqqdqbq.fsf@uzeb.lrde.epita.fr>
./lisp/ChangeLog
2001-04-18  Didier Verna  <didier@xemacs.org>

	* cus-edit.el (Custom-reset-standard): reset to standard settings
	not only when the buffer's :custom-state is 'modified, but also
	when it is 'set or 'saved.

GENERAL BUG FIXES

<uofrqvxzn.fsf@ispras.ru>
./lisp/ChangeLog
2001-06-15  Nick Pakoulin  <npak@ispras.ru>

	* help.el (frob-help-extents): Require 'hyper-apropos for faces.

<mqqoftzthg6.fsf@eng.cam.ac.uk>
./ChangeLog
2001-04-14  Gordon Sadler  <gbsadler1@lcisp.com>

	* configure.in: Add GTK_CFLAGS to CPPFLAGS for glade.h check.

<15167.31192.971882.809294@tyranny.hsys.msk.ru>
./ChangeLog
2001-07-01  Alexey Mahotkin  <alexm@hsys.msk.ru>

	* configure.in (option processing):  with_widgets=m is ambiguous;
	don't allow it.
	(AC_CHECKING for the Athena widgets): Don't check for Athena when
	with_widgets=no.

<5020000.994949898@flashingchance>
./src/ChangeLog
2001-07-11  Matt Tucker  <tuck@whistlingfish.net>

	* syntax.c (find_start_of_comment):
	Fix `unbalanced parentheses' bug when dealing with mixed comment
	styles in c++/java/etc. mode

<15111.24585.586600.484683@gargle.gargle.HOWL>
./lisp/ChangeLog
2001-05-20  Martin Buchholz  <martin@xemacs.org>

	* bytecomp.el (byte-compile-arithcompare):
	Only optimize (= x) ==> t if byte-compile-delete-errors is not nil.

<15112.31246.180077.975624@gargle.gargle.HOWL>
./lisp/ChangeLog
2001-05-21  Martin Buchholz  <martin@xemacs.org>

	* byte-optimize.el (=): `=' is not a binary predicate!
	Fix incorrect optimization: (= 0 0 (random 2)) ==> 0 or 1.
	Use byte-optimize-predicate, not byte-optimize-binary-predicate,

<15123.9022.247285.42002@gargle.gargle.HOWL>
./ChangeLog
2001-05-29  Martin Buchholz  <martin@xemacs.org>

	* configure.in: Remove stray backslash.

<15127.8885.609982.512779@gargle.gargle.HOWL>
./tests/ChangeLog
2001-05-29  Martin Buchholz  <martin@xemacs.org>

	* automated/mule-tests.el:
	Avoid test failure if (temp-directory) is a symlink.

<B72977D8.45533%abegel@eecs.berkeley.edu>
./src/ChangeLog
2001-05-17  Andrew Begel  <abegel@eecs.berkeley.edu>

	* lrecord.h (INIT_EXTERNAL_LRECORD_IMPLEMENTATION): Add needed cast.

<B729780C.45534%abegel@eecs.berkeley.edu>
./ChangeLog
2001-05-17  Andrew Begel  <abegel@eecs.berkeley.edu>

	* aclocal.m4 (LTLD): Don't use "gcc", use the ld reported by gcc.

<87u22s1ffj.fsf@u.sanpo.t.u-tokyo.ac.jp>
./src/ChangeLog
2001-05-11  Yoshiki Hayashi  <yoshiki@xemacs.org>

	* lisp.h (EMACS_INT_MAX): This should be one bit less since
	EMACS_INT is signed.

<200104180223.WAA13090@mclean.mail.mindspring.net>
2001-04-17  Isaac Hollander  <ysh@mindspring.com>

	* gnuserv.c (setup_table): fix 2 signed/unsigned mismatches
	* gnuslib.c (connect_to_internet_server): fix signed/unsigned mismatch

<200106220151.VAA31665@gwyn.tux.org>
./src/ChangeLog

2001-06-21  Ben Wing  <ben@xemacs.org>

	* dired-msw.c (Fmswindows_insert_directory):
	Fix problem noted by Michael Sperber with directories containing
	[] and code that destructively modifies an existing string.

<20010409161535.B15607@ool-18b88ad6.dyn.optonline.net>
./lisp/ChangeLog
2001-04-09  Danny Colascione  <qtmstr@optonline.net>

	* menubar.el (popup-mode-menu): Make it work with
	popup-menu-titles turned off.
	
<200105121126.HAA26657@gwyn.tux.org>
./lisp/ChangeLog
2001-05-12  Ben Wing  <ben@xemacs.org>

	* find-paths.el (paths-find-recursive-path):
	fix error with null EXCLUDE-REGEXP.
	
	* font-lock.el (font-lock-mode):
	fix problem reported by hrvoje with buffers starting with a space.
	
<200106220151.VAA31665@gwyn.tux.org>
./lisp/ChangeLog
2001-06-21  Ben Wing  <ben@xemacs.org>

	* help.el (frob-help-extents): Fix problem with undefined face.
	* update-elc.el (update-elc-files-to-compile): Compile in proper order.

	* keydefs.el (global-map): Add a defn for M-?, previously
	undefined, to access help -- in case the terminal is not set up
	right, or f1 gets redefined.

MS WINDOWS - printing

<200105060838.EAA10366@gwyn.tux.org>
./src/ChangeLog
2001-05-06  Ben Wing  <ben@xemacs.org>

	* console-msw.h:
	* device-msw.c:
	* device-msw.c (print_dialog_worker):
	* device-msw.c (mswindows_handle_print_dialog_box):
	* device-msw.c (syms_of_device_mswindows):
	* dialog-msw.c (mswindows_make_dialog_box_internal):
	* general-slots.h:
	implement printing the selection when it's selected.

<200105060838.EAA10366@gwyn.tux.org>
./lisp/ChangeLog
2001-05-06  Ben Wing  <ben@xemacs.org>

	* dialog.el (make-dialog-box):
	* menubar-items.el (default-menubar):
	* printer.el (generic-print-buffer):
	* printer.el (generic-print-region):
	implement printing the selection when it's selected.

MS WINDOWS - set_file_times

<1yp8gt63.fsf@rapier.ecf.teradyne.com>
./src/ChangeLog
2001-05-29  Adrian Aichner  <adrian@xemacs.org>

	* fileio.c: Include nt.h.  Remove lisp_string_set_file_times()
	because set_file_times() now takes Lisp_Object path, instead of
	char*.
	* nt.c: Include buffer.h.
	* nt.c (convert_from_time_t): New.
	* nt.c (mswindows_utime): New.  Use utime, since SetFileTime does
	not set mtime correctly.
	* nt.h: Declare mswindows_utime().
	* sysdep.c (set_file_times): set_file_times() now takes Lisp_Object
	path, instead of char*.
	* systime.h: Include <sys/utime.h> on WIN32_NATIVE.

<200106020618.CAA12498@gwyn.tux.org>
./src/ChangeLog
2001-06-01  Ben Wing  <ben@xemacs.org>

	* nt.c (mswindows_utime):
	* nt.c (close_file_data):
	fix off-by-one-indirection error.

MS WINDOWS - C-g handling

<200105311247.IAA28237@gwyn.tux.org>
./src/ChangeLog addition:
2001-05-30  Ben Wing  <ben@xemacs.org>

	For 21.4:

	(Stephen, just take all event-msw.c patches.  This includes
	the "iconify" fix below.)

	* event-msw.c:
	* event-msw.c (mswindows_dequeue_dispatch_event):
	* event-msw.c (assert):
	* event-msw.c (emacs_mswindows_quit_p):
	* event-msw.c (debug_mswin_messages):
	* event-msw.c (debug_output_mswin_message):
	* event-msw.c (vars_of_event_mswindows):
	Fix yet more problems with C-g handling.
	Implement debug-mswindows-events.

MS WINDOWS - miscellaneous

<15119.11444.70000.574489@gargle.gargle.HOWL>
./src/ChangeLog
2001-05-25  Craig Lanning  <CraigL@Knology.net>

	* s\mingw32.h:
	Properly find MinGW's <process.h> inside Cygwin's restructured
	include directories.  Don't try to include <cygwin/version.h>
	since we are dropping support for MinGW in versions of Cygwin
	earlier than b21.
	* nt.c:
	Drop support for MinGW in versions of Cygwin before b21.
	* sysdep.c:
	Properly find MinGW's <process.h> inside Cygwin's restructured
	include directories.
	* syswindows.h:
	Drop support for MinGW in versions of Cygwin before b21.
	* unexcw.c:
	Even though a.out.h is no longer detected by configure, allow
	MinGW to use it until we figure out how to do the job with Win32.

<FENWAYUfKRfcjcMzfoV00000f4e@fenway.corp.soundbite.com>
./nt/ChangeLog
2001-05-28  Paul Krause  <pkrause@soundbite.com>

	* xemacs.mak (DEPEND): defined(_) isn't a reliable method for
	detecting if perl is from cygwin. Check $OSNAME as a backup.

	DISCARDED: Superseded <005f01c10fbc$6c61edb0$090a050a@soundbite.com>

<4.3.2.7.2.20010517121830.00b0a920@san-francisco.beasys.com>
./netinstall/ChangeLog
2001-05-17  Andy Piper  <andy@xemacs.org>

	* sysfile.h: don't assume that file attributes are boolean

2001-05-17  Andy Piper  <andy@xemacs.org>

	* win32.h:
	* win32.h (NOCOMATTRIBUTE): sync with latest cygwin version.

<62532263.3200087799@[148.59.233.133]>
./src/ChangeLog
2001-05-29  Mike Alexander  <mta@arbortext.com>

	* console-msw.h (FRAME_MSPRINTER_CHARHEIGHT): Unswap
	FRAME_MSPRINTER_CHARWIDTH and FRAME_MSPRINTER_CHARHEIGHT

<200105121126.HAA26657@gwyn.tux.org>
./src/ChangeLog
2001-05-12  Ben Wing  <ben@xemacs.org>

	* event-msw.c (mswindows_dde_callback):
	* event-msw.c (mswindows_wnd_proc):
	eliminate cygwin warnings.

<200105231035.GAA13007@gwyn.tux.org>
./src/ChangeLog
2001-05-23  Ben Wing  <ben@xemacs.org>

	* device-msw.c (msprinter_init_device):
	signal an error rather than crash with an unavailable network
	printer (from Mike Alexander).
	
	* event-msw.c:
	* event-msw.c (struct winsock_stream):
	* event-msw.c (winsock_writer):
	* event-msw.c (winsock_closer):
	* event-msw.c (make_winsock_stream_1):
	cleanup headers.  fix (hopefully) an error with data corruption
	when sending to a network connection.

	* fileio.c (Fexpand_file_name): Fix evil code that attempts
	to handle the ~user prefix by (a) always assuming we're referencing
	ourselves and not even verifying the user -- hence any file with
	a tilde as its first char is invalid! (b) if there wasn't a slash
	following the filename, the pointer was set *past* the end of
	file and we started reading from uninitialized memory.  Now we
	simply treat these as files, always.

	* buffer.c (common_init_complex_vars_of_buffer): comment change.
	
<200105231147.HAA15653@gwyn.tux.org>
./src/ChangeLog
2001-05-23  Ben Wing  <ben@xemacs.org>

	* event-msw.c (winsock_writer):
	* event-msw.c (winsock_closer):
	prior kludgy code was clobbering the buffer, thinking it was
	"unused" space to store an unneeded return value; instead, use
	the variable we've already got staring us in the face.

<4.3.2.7.2.20010524160839.02dfa610@pop>
./src/ChangeLog
2001-05-24  Kirill 'Big K' Katsnelson  <kkm@dtmx.com>

	* event-msw.c (WM_DROPFILES): Use correct type for OLE characters.
	
GTK

<86snhme1pz.fsf@hel.bp.aventail.com>
./src/ChangeLog
2001-05-30  William M. Perry  <wmperry@gnu.org>

	* event-gtk.c: Check for buttons as modifier keys.

<8666eh375k.fsf@hel.bp.aventail.com>
./lisp/ChangeLog
2001-05-31  William M. Perry  <wmperry@gnu.org>

	* font-menu.el: Avoid arithmetic with 'nil' when using the font menu
	in XEmacs/GTK.

<863d9hf0rd.fsf@hel.bp.aventail.com>
./lisp/ChangeLog
2001-06-03  William M. Perry  <wmperry@gnu.org>

	* dialog-gtk.el (popup-builtin-open-dialog): Don't forget to
	return the filename selected by the user!

<987338379.7732.0.camel@loki.lausch.at>
./src/ChangeLog
2001-04-15  Michael Lausch  <mla@1012surf.net>

	* scrollbar-gtk.c (gtk_create_scrollbar_instance): Call
	gtk_widget_request_size() to give scrollbar >0 width for
	GTK >1.2.8.

<86ae3t378p.fsf@hel.bp.aventail.com>
./src/ChangeLog
2001-05-20  Drazen Kacar  <dave@arsdigita.com>

	* glyphs-gtk.c (gtk_resource_instantiate): C++ comment -> #if 0

<15189.33914.633203.591427@turnbull.sk.tsukuba.ac.jp>
./lisp/ChangeLog
2001-07-18  Stephen J. Turnbull  <stephen@xemacs.org>

	* specifier.el: define-specifier-tag 'gtk.

MISCELLANEOUS

<200105230148.VAA13292@mclean.mail.mindspring.net>
./src/ChangeLog
2001-05-22  Isaac Hollander  <ysh@mindspring.com>

	* Makefile.in.in: Use TAR macro instead of hardcoding
	  tar.  Allows use of GNU tar instead of system tar

DOCUMENTATION

A bunch of typo fixes from the late Beta Release Engineer with no
ChangeLogs; leave them that way in memorium.

<iluk82vvtx8.fsf@barbar.josefsson.org>
./man/ChangeLog
2001-06-02  Simon Josefsson  <simon@josefsson.org>

	* internals/internals.texi (Techniques for XEmacs Developers): Fix
	typo in ./configure line.

<87bsof9zbk.fsf@n-pl.org>
./ChangeLog
2001-05-27  Kazuo Oishi  <oishi@n-pl.org>

	* etc/xemacs-ja.1: Replace with new translation.

<20010529193619.2664.qmail@hsys.msk.ru>
./man/ChangeLog
2001-05-29  Alexey Mahotkin  <alexm@hsys.msk.ru>

	* xemacs/custom.texi: Documented keyboard shortcut.

	* xemacs/mule.texi: Updated to match reality; tiny fixes.

<20010529193619.2664.qmail@hsys.msk.ru>
./lisp/ChangeLog
2001-05-29  Alexey Mahotkin  <alexm@hsys.msk.ru>

	* coding.el: Tiny typo fixed.

<200106081225.IAA31075@gwyn.tux.org>
./man/ChangeLog
2001-06-08  Ben Wing  <ben@xemacs.org>

	* xemacs-faq.texi (Top):
	* xemacs-faq.texi (MS Windows):
	* xemacs-faq.texi (Q6.2.1):
	* xemacs-faq.texi (Q6.2.2):
	* xemacs-faq.texi (Q6.2.3):
	* xemacs-faq.texi (Q6.2.4):
	* xemacs-faq.texi (Q6.2.5):
	* xemacs-faq.texi (Q6.3.1):
	* xemacs-faq.texi (Q6.3.2):
	* xemacs-faq.texi (Q6.3.3):
	* xemacs-faq.texi (Q6.3.4):
	* xemacs-faq.texi (Q6.4.1):
	* xemacs-faq.texi (Q6.4.2):
	* xemacs-faq.texi (Current Events):
	* xemacs-faq.texi (Q7.0.1):
	* xemacs-faq.texi (Q7.0.2):
	* xemacs-faq.texi (Q7.0.3):
	* xemacs-faq.texi (Q7.0.4):
	* xemacs-faq.texi (Q7.0.5):
	* xemacs-faq.texi (Q7.0.6):
	Merge in the rest of Hrvoje's Windows FAQ.  Redo section 7
	to update current reality and add condensed versions of
	new changes for 21.1 and 21.4. (Not quite done for 21.4.)
	Lots more Windows updates.

<200106101053.GAA12271@gwyn.tux.org>
./man/ChangeLog
2001-06-10  Ben Wing  <ben@xemacs.org>

	* xemacs-faq.texi (Q1.0.10):
	* xemacs-faq.texi (Q1.0.11):
	* xemacs-faq.texi (Q1.0.12):
	Update sections on Windows and MacOS availability.

<8zi7hxlo.fsf@ecf.teradyne.com>
./man/ChangeLog
2001-07-02  Adrian Aichner  <adrian@xemacs.org>

	* lispref\windows.texi (Window Configurations): Fix typos.
	* lispref\x-windows.texi (Resources): Ditto.
	* internals\internals.texi (XEmacs From the Inside): Ditto.
	* emodules.texi (Initialization Mode): Ditto.
	* xemacs-faq.texi (Q6.3.2): Ditto.

<1ynzhwt3.fsf@ecf.teradyne.com>
./man/ChangeLog
2001-07-02  Adrian Aichner  <adrian@xemacs.org>

	* xemacs-faq.texi (Q1.0.14): Update information following a
	request by Tom Mostyn.

./man/ChangeLog
2001-06-24  Stephen J. Turnbull  <stephen@xemacs.org>

	* xemacs/programs.texi: Add node name (Top) to Ebrowse xref.

[Long since committed; added ChangeLog]
<scm66jlgfkm.fsf@hookah.kazbek.ispras.ru>
./lisp/ChangeLog
2001-01-12  Nick V. Pakoulin  <npak@ispras.ru>

	* cl-macs.el (cl-upcase-arg): New function.
	(cl-function-arglist): New function.
	(cl-transform-lambda): Automatically add CL-style lambda list to
	documentation string using functions above.

<200105170631.CAA32586@gwyn.tux.org>
./man/ChangeLog
2001-05-16  Ben Wing  <ben@xemacs.org>

	* xemacs-faq.texi (Top):
	* xemacs-faq.texi (Installation):
	* xemacs-faq.texi (Q2.1.15):
	* xemacs-faq.texi (Q2.1.18):
	* xemacs-faq.texi (Q2.1.19):
	document how to debug X errors
	
<200105200118.VAA32224@gwyn.tux.org>
./src/ChangeLog
2001-05-19  Ben Wing  <ben@xemacs.org>

	* eval.c: doc comment about gcpro'ing in record_unwind_protect.

	* process-nt.c:
	* process-nt.c (vars_of_process_nt):
	remove unused mswindows-quote-process-args.  rec for 21.4.
	
<200105231035.GAA13007@gwyn.tux.org>
./nt/ChangeLog
2001-05-23  Ben Wing  <ben@xemacs.org>

	* xemacs.mak (installation):
	call `ver' to get the exact os version and put it in the
	installation; suggestion from adrian.

<200105231035.GAA13007@gwyn.tux.org>
./ChangeLog addition
2001-05-23  Ben Wing  <ben@xemacs.org>

	* etc\sample.init.el:
	* etc\sample.init.el (Init-safe-require): New.
	* etc\sample.init.el ((fboundp 'pending-delete-mode)):
	* etc\sample.init.el ((eq system-type 'windows-nt)):
	* etc\sample.init.el (dired):
	* etc\sample.init.el ((Init-safe-require 'efs-auto)):
	* etc\sample.init.el (completer):
	* etc\sample.init.el (crypt):
	* etc\sample.init.el (filladapt):
	* etc\sample.init.el ((fboundp 'turn-on-lazy-lock)):
	* etc\sample.init.el ((fboundp 'resize-minibuffer-mode)):
	* etc\sample.init.el ((Init-safe-require 'scroll-in-place)):
	Rewrite to be much more careful about loading features -- now
	it decays gracefully even in the complete absence of packages.
	Also avoid doing obnoxious things when loading efs.

<200105311247.IAA28237@gwyn.tux.org>
./man/ChangeLog
2001-05-30  Ben Wing  <ben@xemacs.org>

	* xemacs-faq.texi (Top):
	* xemacs-faq.texi (MS Windows):
	* xemacs-faq.texi (Q6.0.1):
	* xemacs-faq.texi (Q6.0.2):
	* xemacs-faq.texi (Q6.0.3):
	* xemacs-faq.texi (Q6.0.4):
	* xemacs-faq.texi (Q6.1.1):
	* xemacs-faq.texi (Q6.1.4):
	* xemacs-faq.texi (Q6.1.5):
	* xemacs-faq.texi (Q6.1.6):
	* xemacs-faq.texi (Q6.2.1):
	* xemacs-faq.texi (Q6.2.2):
	* xemacs-faq.texi (Q6.3.1):
	* xemacs-faq.texi (Q6.3.2):
	* xemacs-faq.texi (Q6.3.3):
	* xemacs-faq.texi (Q6.4.1):
	* xemacs-faq.texi (Current Events):
	Major rewrite.
	Update all MS Windows info to current.
	Redo section 6.1 almost completely.
	Incorporate sections 1 and 2 of Hrvoje's FAQ.

<8zhqhahu.fsf@ecf.teradyne.com>
./lisp/ChangeLog
2001-07-15  Adrian Aichner  <adrian@xemacs.org>

	* about.el (about-personal-info): Fix word duplication typos.
	* dialog.el (make-dialog-box): Ditto.
	* lisp-mode.el (lisp-indent-function): Ditto.
	* package-admin.el (package-admin-delete-binary-package): Ditto.
	* package-get.el (package-get-staging-dir): Ditto.