Mercurial > hg > xemacs-beta
view src/dialog.c @ 5745:f9e4d44504a4
Document #'events-to-keys some more, use it less.
lisp/ChangeLog addition:
2013-07-10 Aidan Kehoe <kehoea@parhasard.net>
* minibuf.el (get-user-response):
* cmdloop.el (y-or-n-p-minibuf):
No need to call #'events-to-keys in these two functions,
#'lookup-key accepts events directly.
* keymap.el:
* keymap.el (events-to-keys):
Document this function some more.
Stop passing strings through unexamined, treat them as vectors of
characters.
Event keys are never integers, remove some code that only ran if
(integerp (event-key ce)).
Event keys are never numbers, don't check for that.
Don't create (menu-selection call-interactively function-name)
keystrokes for menu choices, #'character-to-event doesn't
understand that syntax, so nothing uses it.
Don't ever accept mouse events, #'character-to-event doesn't
accept our synthesising of them.
src/ChangeLog addition:
2013-07-10 Aidan Kehoe <kehoea@parhasard.net>
* keymap.c:
* keymap.c (key_desc_list_to_event):
Drop the allow_menu_events argument.
Don't accept lists starting with Qmenu_selection as describing
keys, nothing generates them in a way this function
understands. The intention is reasonable but the implementation
was never documented and never finished.
* keymap.c (syms_of_keymap):
Drop Qmenu_selection.
* events.c (Fcharacter_to_event):
* keymap.h:
Drop the allow_menu_events argument to key_desc_list_to_event.
author | Aidan Kehoe <kehoea@parhasard.net> |
---|---|
date | Wed, 10 Jul 2013 14:14:30 +0100 |
parents | 308d34e9f07d |
children |
line wrap: on
line source
/* Implements elisp-programmable dialog boxes -- generic. Copyright (C) 1993, 1994 Free Software Foundation, Inc. Copyright (C) 1995 Tinker Systems and INS Engineering Corp. Copyright (C) 2000 Ben Wing. This file is part of XEmacs. XEmacs is free software: you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation, either version 3 of the License, or (at your option) any later version. XEmacs is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details. You should have received a copy of the GNU General Public License along with XEmacs. If not, see <http://www.gnu.org/licenses/>. */ /* Synched up with: Not in FSF. */ #include <config.h> #include "lisp.h" #include "frame-impl.h" Lisp_Object Vdelete_dialog_box_hook; Lisp_Object Qdelete_dialog_box_hook; DEFUN ("make-dialog-box-internal", Fmake_dialog_box_internal, 2, 2, 0, /* Internal helper function for `make-dialog-box'. This handles all dialog-box types except `general'. TYPE is the same as the first argument to `make-dialog-box', and KEYS a list of the remaining arguments. */ (type, keys)) { struct frame *f = selected_frame (); CHECK_SYMBOL (type); if (!HAS_FRAMEMETH_P (f, make_dialog_box_internal)) signal_error (Qunimplemented, "Device does not support dialogs", FRAME_DEVICE (f)); return FRAMEMETH (f, make_dialog_box_internal, (f, type, keys)); } void syms_of_dialog (void) { DEFSUBR (Fmake_dialog_box_internal); DEFSYMBOL (Qdelete_dialog_box_hook); } void vars_of_dialog (void) { Fprovide (intern ("dialog")); DEFVAR_LISP ("delete-dialog-box-hook", &Vdelete_dialog_box_hook /* Function or functions to call when a dialog box is about to be deleted. One arg, the dialog box id. */ ); Vdelete_dialog_box_hook = Qnil; }