Mercurial > hg > xemacs-beta
view modules/sample/internal/sample.c @ 4686:cdabd56ce1b5
Fix various small issues with the multiple-value implementation.
lisp/ChangeLog addition:
2009-08-31 Aidan Kehoe <kehoea@parhasard.net>
* byte-optimize.el (byte-optimize-form-code-walker):
Be careful about discarding multiple values when optimising
#'prog1 calls.
(byte-optimize-or):
Preserve any trailing nil, as this is a supported way to
explicitly discard multiple values.
(byte-optimize-cond-1):
Discard multiple values with a singleton followed by no more
clauses.
* bytecomp.el (progn):
(prog1):
(prog2):
Be careful about discarding multiple values in the byte-hunk
handler of these three forms.
* bytecomp.el (byte-compile-prog1, byte-compile-prog2):
Don't call #'values explicitly, use `(or ,(pop form) nil) instead,
since that compiles to bytecode, not a funcall.
* bytecomp.el (byte-compile-values):
With one non-const argument, byte-compile to `(or ,(second form)
nil), not an explicit #'values call.
* bytecomp.el (byte-compile-insert-header):
Be nicer in the error message to emacs versions that don't
understand our bytecode.
src/ChangeLog addition:
2009-08-31 Aidan Kehoe <kehoea@parhasard.net>
* eval.c (For, Fand):
Don't declare val as REGISTER in these functions, for some reason
it breaks the non-DEBUG union build. These functions are only
called from interpreted code, the performance implication doesn't
matter. Thank you Robert Delius Royar!
* eval.c (Fmultiple_value_list_internal):
Error on too many arguments.
tests/ChangeLog addition:
2009-08-31 Aidan Kehoe <kehoea@parhasard.net>
* automated/lisp-tests.el (Assert-rounding):
Remove an overly-verbose failure message here.
Correct a couple of tests which were buggy in themselves. Add
three new tests, checking the behaviour of #'or and #'and when
passed zero arguments, and a Known-Bug-Expect-Failure call
involving letf and values. (The bug predates the C-level
multiple-value implementation.)
| author | Aidan Kehoe <kehoea@parhasard.net> |
|---|---|
| date | Sun, 06 Sep 2009 19:36:02 +0100 |
| parents | 25e260cb7994 |
| children | dce479915b74 |
line wrap: on
line source
/* * Very simple sample module. Illustrates most of the salient features * of Emacs dynamic modules. * (C) Copyright 1998, 1999 J. Kean Johnston. All rights reserved. * (C) Copyright 2002 Jerry James. */ #include <config.h> #include "lisp.h" /* * This sample introduces three new Lisp objects to the Lisp reader. * The first, a simple boolean value, and the second a string. The * Third is a sample function that simply prints a message. */ int sample_bool; Lisp_Object Vsample_string; DEFUN ("sample-function", Fsample_function, 0, 0, "", /* This is a sample function loaded dynamically. You will notice in the source code for this module that the declaration is identical to internal Emacs functions. This makes it possible to use the exact same code in a dumped version of Emacs. */ ()) { message ("Eureka! It worked"); return Qt; } /* * Each dynamically loaded Emacs module is given a name at compile * time. This is a short name, and must be a valid part of a C * identifier. This name is used to construct the name of several * functions which must appear in the module source code. * The first such function, modules_of_XXXX, should load in any dependent * modules. This function is optional, and the module will still load if * it is not present in the module. * * The second function, which is NOT optional, is syms_of_XXXX, in which * all functions that the module will be provided are declared. This * function will contain calls to DEFSUBR(). * * The third function, which is also NOT optional, is vars_of_XXXX, in * which you declare all variables that the module provides. This * function will contain calls to DEFVAR_LISP(), DEFVAR_BOOL() etc. * * When declaring functions and variables in the syms_of_XXXX and * vars_of_XXXX functions, you use the exact same syntax that you * would as if this module were being compiled into the pure Emacs. * * The fourth function, which is optional, is unload_XXXX, in which actions * that must be taken to unload the module are listed. XEmacs will unbind * functions and variables for you. Anything else that must be done should * appear in this function. * * All four of these functions are declared as void functions, * taking no parameters. Since this sample module is called 'sample', * the functions will be named 'modules_of_sample', 'syms_of_sample', * 'vars_of_sample', and 'unload_sample'. */ void modules_of_sample() { /* * This function isn't actually required as we will not be loading * in any dependent modules, but if we were, we would do something like: * emodules_load ("dependent.ell", "sample2", "1.0.0"); */ } void syms_of_sample() { DEFSUBR(Fsample_function); } void vars_of_sample() { DEFVAR_LISP ("sample-string", &Vsample_string /* This is a sample string, declared in a dynamic module. The syntax and conventions used for all normal Emacs variables apply equally to modules, using an identical syntax. */ ); DEFVAR_BOOL ("sample-boolean", &sample_bool /* *Sample boolean value, in a dynamic module. This is a user-settable variable, as indicated by the * as the first character of the description. Declared in a module exactly as it would be internally in Emacs. */ ); } #ifdef HAVE_SHLIB void unload_sample() { /* We don't need to do anything here in the sample case. However, if you create any new types with INIT_LRECORD_IMPLEMENTATION (sample_type), then UNDEF_LRECORD_IMPLEMENTATION (sample_type) must appear here. Also, any symbols declared with DEFSYMBOL (Qsample_var), or one of its variants, must have a corresponding unstaticpro_nodump (&Qsample_var) here. */ } #endif
