Mercurial > hg > xemacs-beta
view lisp/wid-browse.el @ 5882:bbe4146603db
Reduce regexp usage, now CL-oriented non-regexp code available, core Lisp
lisp/ChangeLog addition:
2015-04-01 Aidan Kehoe <kehoea@parhasard.net>
When calling #'string-match with a REGEXP without regular
expression special characters, call #'search, #'mismatch, #'find,
etc. instead, making our code less likely to side-effect other
functions' match data and a little faster.
* apropos.el (apropos-command):
* apropos.el (apropos):
Call (position ?\n ...) rather than (string-match "\n" ...) here.
* buff-menu.el:
* buff-menu.el (buffers-menu-omit-invisible-buffers):
Don't fire up the regexp engine just to check if a string starts
with a space.
* buff-menu.el (select-buffers-tab-buffers-by-mode):
Don't fire up the regexp engine just to compare mode basenames.
* buff-menu.el (format-buffers-tab-line):
* buff-menu.el (build-buffers-tab-internal): Moved to being a
label within the following.
* buff-menu.el (buffers-tab-items): Use the label.
* bytecomp.el (byte-compile-log-1):
Don't fire up the regexp engine just to look for a newline.
* cus-edit.el (get):
Ditto.
* cus-edit.el (custom-variable-value-create):
Ditto, but for a colon.
* descr-text.el (describe-text-sexp):
Ditto.
* descr-text.el (describe-char-unicode-data):
Use #'split-string-by-char given that we're just looking for a
semicolon.
* descr-text.el (describe-char):
Don't fire up the regexp engine just to look for a newline.
* disass.el (disassemble-internal):
Ditto.
* files.el (file-name-sans-extension):
Implement this using #'position.
* files.el (file-name-extension):
Correct this function's docstring, implement it in terms of
#'position.
* files.el (insert-directory):
Don't fire up the regexp engine to split a string by space; don't
reverse the list of switches, this is actually a longstand bug as
far as I can see.
* gnuserv.el (gnuserv-process-filter):
Use #'position here, instead of consing inside #'split-string
needlessly.
* gtk-file-dialog.el (gtk-file-dialog-update-dropdown):
Use #'split-string-by-char here, don't fire up #'split-string for
directory-sep-char.
* gtk-font-menu.el (hack-font-truename):
Implement this more cheaply in terms of #'find,
#'split-string-by-char, #'equal, rather than #'string-match,
#'split-string, #'string-equal.
* hyper-apropos.el (hyper-apropos-grok-functions):
* hyper-apropos.el (hyper-apropos-grok-variables):
Look for a newline using #'position rather than #'string-match in
these functions.
* info.el (Info-insert-dir):
* info.el (Info-insert-file-contents):
* info.el (Info-follow-reference):
* info.el (Info-extract-menu-node-name):
* info.el (Info-menu):
Look for fixed strings using #'position or #'search as appropriate
in this file.
* ldap.el (ldap-decode-string):
* ldap.el (ldap-encode-string):
#'encode-coding-string, #'decode-coding-string are always
available, don't check if they're fboundp.
* ldap.el (ldap-decode-address):
* ldap.el (ldap-encode-address):
Use #'split-string-by-char in these functions.
* lisp-mnt.el (lm-creation-date):
* lisp-mnt.el (lm-last-modified-date):
Don't fire up the regexp engine just to look for spaces in this file.
* menubar-items.el (default-menubar):
Use (not (mismatch ...)) rather than #'string-match here, for
simple regexp.
Use (search "beta" ...) rather than (string-match "beta" ...)
* menubar-items.el (sort-buffers-menu-alphabetically):
* menubar-items.el (sort-buffers-menu-by-mode-then-alphabetically):
* menubar-items.el (group-buffers-menu-by-mode-then-alphabetically):
Don't fire up the regexp engine to check if a string starts with
a space or an asterisk.
Use the more fine-grained results of #'compare-strings; compare
case-insensitively for the buffer menu.
* menubar-items.el (list-all-buffers):
* menubar-items.el (tutorials-menu-filter):
Use #'equal rather than #'string-equal, which, in this context,
has the drawback of not having a bytecode, and no redeeming
features.
* minibuf.el:
* minibuf.el (un-substitute-in-file-name):
Use #'count, rather than counting the occurences of $ using the
regexp engine.
* minibuf.el (read-file-name-internal-1):
Don't fire up the regexp engine to search for ?=.
* mouse.el (mouse-eval-sexp):
Check for newline with #'find.
* msw-font-menu.el (mswindows-reset-device-font-menus):
Split a string by newline with #'split-string-by-char.
* mule/japanese.el:
* mule/japanese.el ("Japanese"):
Use #'search rather than #'string-match; canoncase before
comparing; fix a bug I had introduced where I had been making case
insensitive comparisons where the case mattered.
* mule/korea-util.el (default-korean-keyboard):
Look for ?3 using #'find, not #'string-march.
* mule/korea-util.el (quail-hangul-switch-hanja):
Search for a fixed string using #'search.
* mule/mule-cmds.el (set-locale-for-language-environment):
#'position, #'substitute rather than #'string-match,
#'replace-in-string.
* newcomment.el (comment-make-extra-lines):
Use #'search rather than #'string-match for a simple string.
* package-get.el (package-get-remote-filename):
Use #'position when looking for ?@
* process.el (setenv):
* process.el (read-envvar-name):
Use #'position when looking for ?=.
* replace.el (map-query-replace-regexp):
Use #'split-string-by-char instead of using an inline
implementation of it.
* select.el (select-convert-from-cf-text):
* select.el (select-convert-from-cf-unicodetext):
Use #'position rather than #'string-match in these functions.
* setup-paths.el (paths-emacs-data-root-p):
Use #'search when looking for simple string.
* sound.el (load-sound-file):
Use #'split-string-by-char rather than an inline reimplementation
of same.
* startup.el (splash-screen-window-body):
* startup.el (splash-screen-tty-body):
Search for simple strings using #'search.
* version.el (emacs-version):
Ditto.
* x-font-menu.el (hack-font-truename):
Implement this more cheaply in terms of #'find,
#'split-string-by-char, #'equal, rather than #'string-match,
#'split-string, #'string-equal.
* x-font-menu.el (x-reset-device-font-menus-core):
Use #'split-string-by-char here.
* x-init.el (x-initialize-keyboard):
Search for a simple string using #'search.
author | Aidan Kehoe <kehoea@parhasard.net> |
---|---|
date | Wed, 01 Apr 2015 14:28:20 +0100 |
parents | 308d34e9f07d |
children |
line wrap: on
line source
;;; wid-browse.el --- Functions for browsing widgets. ;; ;; Copyright (C) 1997 Free Software Foundation, Inc. ;; ;; Author: Per Abrahamsen <abraham@dina.kvl.dk> ;; Keywords: extensions ;; Version: 1.9960 ;; X-URL: http://www.dina.kvl.dk/~abraham/custom/ ;; This file is part of XEmacs. ;; XEmacs is free software: you can redistribute it and/or modify it ;; under the terms of the GNU General Public License as published by the ;; Free Software Foundation, either version 3 of the License, or (at your ;; option) any later version. ;; XEmacs is distributed in the hope that it will be useful, but WITHOUT ;; ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or ;; FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License ;; for more details. ;; You should have received a copy of the GNU General Public License ;; along with XEmacs. If not, see <http://www.gnu.org/licenses/>. ;;; Commentary: ;; ;; Widget browser. See `widget.el'. ;;; Code: (require 'easymenu) (require 'custom) (require 'wid-edit) (eval-when-compile (require 'cl)) (defgroup widget-browse nil "Customization support for browsing widgets." :group 'widgets) ;;; The Mode. (defvar widget-browse-mode-map nil "Keymap for `widget-browse-mode'.") (unless widget-browse-mode-map (setq widget-browse-mode-map (make-sparse-keymap)) (set-keymap-parent widget-browse-mode-map widget-keymap) (define-key widget-browse-mode-map "q" 'bury-buffer)) (easy-menu-define widget-browse-mode-customize-menu widget-browse-mode-map "Menu used in widget browser buffers." (customize-menu-create 'widgets)) (easy-menu-define widget-browse-mode-menu widget-browse-mode-map "Menu used in widget browser buffers." '("Widget" ["Browse" widget-browse t] ["Browse At" widget-browse-at t])) (defcustom widget-browse-mode-hook nil "Hook called when entering widget-browse-mode." :type 'hook :group 'widget-browse) (defun widget-browse-mode () "Major mode for widget browser buffers. The following commands are available: \\[widget-forward] Move to next button or editable field. \\[widget-backward] Move to previous button or editable field. \\[widget-button-click] Activate button under the mouse pointer. \\[widget-button-press] Activate button under point. Entry to this mode calls the value of `widget-browse-mode-hook' if that value is non-nil." (kill-all-local-variables) (setq major-mode 'widget-browse-mode mode-name "Widget") (use-local-map widget-browse-mode-map) (easy-menu-add widget-browse-mode-customize-menu) (easy-menu-add widget-browse-mode-menu) (run-hooks 'widget-browse-mode-hook)) ;;; Commands. ;;;###autoload (defun widget-browse-at (pos) "Browse the widget under point." (interactive "d") (let* ((field (get-char-property pos 'field)) (button (get-char-property pos 'button)) (doc (get-char-property pos 'widget-doc)) (text (cond (field "This is an editable text area.") (button "This is an active area.") (doc "This is documentation text.") (t "This is unidentified text."))) (widget (or field button doc))) (when widget (widget-browse widget)) (message text))) (defvar widget-browse-history nil) ;;;###autoload (defun widget-browse (widget) "Create a widget browser for WIDGET." (interactive (list (completing-read "Widget: " obarray (lambda (symbol) (get symbol 'widget-type)) t nil 'widget-browse-history))) (if (stringp widget) (setq widget (intern widget))) (unless (if (symbolp widget) (get widget 'widget-type) (and (consp widget) (get (widget-type widget) 'widget-type))) (error "Not a widget.")) ;; Create the buffer. (if (symbolp widget) (let ((buffer (format "*Browse %s Widget*" widget))) (kill-buffer (get-buffer-create buffer)) (switch-to-buffer (get-buffer-create buffer))) (kill-buffer (get-buffer-create "*Browse Widget*")) (switch-to-buffer (get-buffer-create "*Browse Widget*"))) (widget-browse-mode) ;; Quick way to get out. ;; (widget-create 'push-button ;; :action (lambda (widget &optional event) ;; (bury-buffer)) ;; "Quit") ;; (widget-insert "\n") ;; Top text indicating whether it is a class or object browser. (if (listp widget) (widget-insert "Widget object browser.\n\nClass: ") (widget-insert "Widget class browser.\n\n") (widget-create 'widget-browse :format "%[%v%]\n%d" :doc (get widget 'widget-documentation) widget) (unless (eq (preceding-char) ?\n) (widget-insert "\n")) (widget-insert "\nSuper: ") (setq widget (get widget 'widget-type))) ;; Now show the attributes. (let ((name (car widget)) (items (cdr widget)) key value printer) (widget-create 'widget-browse :format "%[%v%]" name) (widget-insert "\n") (while items (setq key (nth 0 items) value (nth 1 items) printer (or (get key 'widget-keyword-printer) 'widget-browse-sexp) items (cdr (cdr items))) (widget-insert "\n" (symbol-name key) "\n\t") (funcall printer widget key value) (widget-insert "\n"))) (widget-setup) (goto-char (point-min))) ;;;###autoload (defun widget-browse-other-window (&optional widget) "Show widget browser for WIDGET in other window." (interactive) (let ((window (selected-window))) (switch-to-buffer-other-window "*Browse Widget*") (if widget (widget-browse widget) (call-interactively 'widget-browse)) (select-window window))) ;;; The `widget-browse' Widget. (define-widget 'widget-browse 'push-button "Button for creating a widget browser. The :value of the widget shuld be the widget to be browsed." :format "%[[%v]%]" :value-create 'widget-browse-value-create :action 'widget-browse-action) (defun widget-browse-action (widget &optional event) ;; Create widget browser for WIDGET's :value. (widget-browse (widget-get widget :value))) (defun widget-browse-value-create (widget) ;; Insert type name. (let ((value (widget-get widget :value))) (cond ((symbolp value) (insert (symbol-name value))) ((consp value) (insert (symbol-name (widget-type value)))) (t (insert "strange"))))) ;;; Keyword Printer Functions. (defun widget-browse-widget (widget key value) "Insert description of WIDGET's KEY VALUE. VALUE is assumed to be a widget." (widget-create 'widget-browse value)) (defun widget-browse-widgets (widget key value) "Insert description of WIDGET's KEY VALUE. VALUE is assumed to be a list of widgets." (while value (widget-create 'widget-browse (car value)) (setq value (cdr value)) (when value (widget-insert " ")))) (defun widget-browse-sexp (widget key value) "Insert description of WIDGET's KEY VALUE. Nothing is assumed about value." (let ((pp (condition-case signal (declare-fboundp (pp-to-string value)) (error (prin1-to-string signal))))) (when (string-match "\n\\'" pp) (setq pp (substring pp 0 (1- (length pp))))) (if (cond ((string-match "\n" pp) nil) ((> (length pp) (- (window-width) (current-column))) nil) (t t)) (widget-insert pp) (widget-create 'push-button :tag "show" :action (lambda (widget &optional event) (with-output-to-temp-buffer "*Pp Eval Output*" (princ (widget-get widget :value)))) pp)))) (defun widget-browse-sexps (widget key value) "Insert description of WIDGET's KEY VALUE. VALUE is assumed to be a list of widgets." (let ((target (current-column))) (while value (widget-browse-sexp widget key (car value)) (setq value (cdr value)) (when value (widget-insert "\n" (make-string target ?\ )))))) ;;; Keyword Printers. (put :parent 'widget-keyword-printer 'widget-browse-widget) (put :children 'widget-keyword-printer 'widget-browse-widgets) (put :buttons 'widget-keyword-printer 'widget-browse-widgets) (put :button 'widget-keyword-printer 'widget-browse-widget) (put :args 'widget-keyword-printer 'widget-browse-sexps) ;;; Widget Minor Mode. (defvar widget-minor-mode nil "I non-nil, we are in Widget Minor Mode.") (make-variable-buffer-local 'widget-minor-mode) (defvar widget-minor-mode-map nil "Keymap used in Widget Minor Mode.") (unless widget-minor-mode-map (setq widget-minor-mode-map (make-sparse-keymap)) (set-keymap-parent widget-minor-mode-map widget-keymap)) ;;;###autoload (defun widget-minor-mode (&optional arg) "Togle minor mode for traversing widgets. With arg, turn widget mode on if and only if arg is positive." (interactive "P") (cond ((null arg) (setq widget-minor-mode (not widget-minor-mode))) ((<= arg 0) (setq widget-minor-mode nil)) (t (setq widget-minor-mode t))) (force-mode-line-update)) (add-to-list 'minor-mode-alist '(widget-minor-mode " Widget")) (add-to-list 'minor-mode-map-alist (cons 'widget-minor-mode widget-minor-mode-map)) ;;; The End: (provide 'wid-browse) ;; wid-browse.el ends here