Mercurial > hg > xemacs-beta
view src/profile.c @ 617:af57a77cbc92
[xemacs-hg @ 2001-06-18 07:09:50 by ben]
---------------------------------------------------------------
DOCUMENTATION FIXES:
---------------------------------------------------------------
eval.c: Correct documentation.
elhash.c: Doc correction.
---------------------------------------------------------------
LISP OBJECT CLEANUP:
---------------------------------------------------------------
bytecode.h, buffer.h, casetab.h, chartab.h, console-msw.h, console.h, database.c, device.h, eldap.h, elhash.h, events.h, extents.h, faces.h, file-coding.h, frame.h, glyphs.h, gui-x.h, gui.h, keymap.h, lisp-disunion.h, lisp-union.h, lisp.h, lrecord.h, lstream.h, mule-charset.h, objects.h, opaque.h, postgresql.h, process.h, rangetab.h, specifier.h, toolbar.h, tooltalk.h, ui-gtk.h: Add wrap_* to all objects (it was already there for a few of them)
-- an expression to encapsulate a pointer into a Lisp object,
rather than the inconvenient XSET*. "wrap" was chosen because
"make" as in make_int(), make_char() is not appropriate. (It
implies allocation. The issue does not exist for ints and chars
because they are not allocated.)
Full error checking has been added to these expressions. When
used without error checking, non-union build, use of these
expressions will incur no loss of efficiency. (In fact, XSET* is
now defined in terms of wrap_* in a non-union build.) In a union
build, you will also get no loss of efficiency provided that you
have a decent optimizing compiler, and a compiler that either
understands inlines or automatically inlines those particular
functions. (And since people don't normally do their production
builds on union, it doesn't matter.)
Update the sample Lisp object definition in lrecord.h accordingly.
dumper.c: Fix places in dumper that referenced wrap_object to reference
its new name, wrap_pointer_1.
buffer.c, bufslots.h, conslots.h, console.c, console.h, devslots.h, device.c, device.h, frame.c, frame.h, frameslots.h, window.c, window.h, winslots.h: -- Extract out the Lisp objects of `struct device' into devslots.h,
just like for the other structures.
-- Extract out the remaining (not copied into the window config)
Lisp objects in `struct window' into winslots.h; use different
macros (WINDOW_SLOT vs. WINDOW_SAVED_SLOT) to differentiate them.
-- Eliminate the `dead' flag of `struct frame', since it
duplicates information already available in `framemeths', and fix
FRAME_LIVE_P accordingly. (Devices and consoles already work this
way.)
-- In *slots.h, switch to system where MARKED_SLOT is automatically
undef'd at the end of the file. (Follows what winslots.h already
does.)
-- Update the comments at the beginning of *slots.h to be accurate.
-- When making any of the above objects dead, zero it out entirely
and reset all Lisp object slots to Qnil. (We were already doing
this somewhat, but not consistently.) This (1) Eliminates the
possibility of extra objects hanging around that ought to be
GC'd, (2) Causes an immediate crash if anyone tries to access a
structure in one of these objects, (3) Ensures consistent behavior
wrt dead objects.
dialog-msw.c: Use internal_object_printer, since this object should not escape.
---------------------------------------------------------------
FIXING A CRASH THAT I HIT ONCE (AND A RELATED BAD BEHAVIOR):
---------------------------------------------------------------
eval.c: Fix up some comments about the FSF implementation.
Fix two nasty bugs:
(1) condition_case_unwind frees the conses sitting in the
catch->tag slot too quickly, resulting in a crash that I hit.
(2) catches need to be unwound one at a time when calling
unwind-protect code, rather than all at once at the end; otherwise,
incorrect behavior can result. (A comment shows exactly how.)
backtrace.h: Improve comment about FSF differences in the handler stack.
---------------------------------------------------------------
FIXING A CRASH THAT I REPEATEDLY HIT WHEN USING THE MOUSE WHEEL
UNDER MSWINDOWS:
---------------------------------------------------------------
Basic idea: My crash is due either to a dead, non-marked,
GC-collected frame inside of a window mirror, or a prematurely
freed window mirror. We need to mark the Lisp objects inside of
window mirrors. Tracking the lifespan of window mirrors and
scrollbar instances is extremely hard, and there may well be
lurking bugs where such objects are freed too soon. The only safe
way to fix these problems (and it fixes both problems at once) is
to make both of these structures Lisp objects.
lrecord.h, emacs.c, inline.c, scrollbar-gtk.c, scrollbar-msw.c, scrollbar-x.c, scrollbar.c, scrollbar.h, symsinit.h: Make scrollbar instances actual Lisp objects. Mark the window
mirrors in them. inline.c needs to know about scrollbar.h now.
Record the new type in lrecord.h. Fix up scrollbar-*.c
appropriately. Create a hash table in scrollbar-msw.c so that the
scrollbar instances stored in scrollbar HWND's are properly
GC-protected. Create complex_vars_of_scrollbar_mswindows() to
create the hash table at startup, and call it from emacs.c. Don't
store the scrollbar instance as a property of the GTK scrollbar,
as it's not used and if we did this, we'd have to separately
GC-protect it in a hash table, like in MS Windows.
lrecord.h, frame.h, frame.c, frameslots.h, redisplay.c, window.c, window.h: Move mark_window_mirror from redisplay.c to window.c. Make window
mirrors actual Lisp objects. Tell lrecord.h about them. Change
the window mirror member of struct frame from a pointer to a Lisp
object, and add XWINDOW_MIRROR in appropriate places. Mark the
scrollbar instances in the window mirror.
redisplay.c, redisplay.h, alloc.c: Delete mark_redisplay. Don't call mark_redisplay. We now mark
frame-specific structures in mark_frame.
NOTE: I also deleted an extremely questionable call to
update_frame_window_mirrors(). It was extremely questionable
before, and now totally impossible, since it will create
Lisp objects during redisplay.
frame.c: Mark the scrollbar instances, which are now Lisp objects.
Call mark_gutter() here, not in mark_redisplay().
gutter.c: Update comments about correct marking.
---------------------------------------------------------------
ISSUES BROUGHT UP BY MARTIN:
---------------------------------------------------------------
buffer.h: Put back these macros the way Steve T and I think they ought to be.
I already explained in a previous changelog entry why I think these
macros should be the way I'd defined them. Once again:
We fix these macros so they don't care about the type of their
lvalues. The non-C-string equivalents of these already function
in the same way, and it's correct because it should be OK to pass
in a CBufbyte *, a BufByte *, a Char_Binary *, an UChar_Binary *,
etc. The whole reason for these different types is to work around
errors caused by signed-vs-unsigned non-matching types. Any
possible error that might be caught in a DFC macro would also be
caught wherever the argument is used elsewhere. So creating
multiple macro versions would add no useful error-checking and
just further complicate an already complicated area.
As for Martin's "ANSI aliasing" bug, XEmacs is not ANSI-aliasing
clean and probably never will be. Unless the board agrees to
change XEmacs in this way (and we really don't want to go down
that road), this is not a bug.
sound.h: Undo Martin's type change.
signal.c: Fix problem identified by Martin with Linux and g++ due to
non-standard declaration of setitimer().
systime.h: Update the docs for "qxe_" to point out why making the
encapsulation explicit is always the right way to go. (setitimer()
itself serves as an example.)
For 21.4:
update-elc-2.el: Correct misplaced parentheses, making lisp/mule not get
recompiled.
author | ben |
---|---|
date | Mon, 18 Jun 2001 07:10:32 +0000 |
parents | 023b83f4e54b |
children | 943eaba38521 |
line wrap: on
line source
/* Why the hell is XEmacs so fucking slow? Copyright (C) 1996 Ben Wing. Copyright (C) 1998 Free Software Foundation, Inc. This file is part of XEmacs. XEmacs is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation; either version 2, or (at your option) any later version. XEmacs is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details. You should have received a copy of the GNU General Public License along with XEmacs; see the file COPYING. If not, write to the Free Software Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #include <config.h> #include "lisp.h" #include "backtrace.h" #include "bytecode.h" #include "elhash.h" #include "hash.h" #include "syssignal.h" #include "systime.h" #ifndef HAVE_SETITIMER #error Sorry charlie. We need a scalpel and all we have is a lawnmower. #endif /* We implement our own profiling scheme so that we can determine things like which Lisp functions are occupying the most time. Any standard OS-provided profiling works on C functions, which is somewhat useless. The basic idea is simple. We set a profiling timer using setitimer (ITIMER_PROF), which generates a SIGPROF every so often. (This runs not in real time but rather when the process is executing or the system is running on behalf of the process.) When the signal goes off, we see what we're in, and add 1 to the count associated with that function. It would be nice to use the Lisp allocation mechanism etc. to keep track of the profiling information, but we can't because that's not safe, and trying to make it safe would be much more work than it's worth. Jan 1998: In addition to this, I have added code to remember call counts of Lisp funcalls. The profile_increase_call_count() function is called from Ffuncall(), and serves to add data to Vcall_count_profile_table. This mechanism is much simpler and independent of the SIGPROF-driven one. It uses the Lisp allocation mechanism normally, since it is not called from a handler. It may even be useful to provide a way to turn on only one profiling mechanism, but I haven't done so yet. --hniksic */ static struct hash_table *big_profile_table; Lisp_Object Vcall_count_profile_table; Fixnum default_profiling_interval; int profiling_active; /* The normal flag in_display is used as a critical-section flag and is not set the whole time we're in redisplay. */ int profiling_redisplay_flag; static Lisp_Object QSin_redisplay; static Lisp_Object QSin_garbage_collection; static Lisp_Object QSprocessing_events_at_top_level; static Lisp_Object QSunknown; /* We use inside_profiling to prevent the handler from writing to the table while another routine is operating on it. We also set inside_profiling in case the timeout between signal calls is short enough to catch us while we're already in there. */ static volatile int inside_profiling; /* Increase the value of OBJ in Vcall_count_profile_table hash table. If the hash table is nil, create it first. */ void profile_increase_call_count (Lisp_Object obj) { Lisp_Object count; if (NILP (Vcall_count_profile_table)) Vcall_count_profile_table = make_lisp_hash_table (100, HASH_TABLE_NON_WEAK, HASH_TABLE_EQ); count = Fgethash (obj, Vcall_count_profile_table, Qzero); if (!INTP (count)) count = Qzero; Fputhash (obj, make_int (1 + XINT (count)), Vcall_count_profile_table); } static SIGTYPE sigprof_handler (int signo) { /* Don't do anything if we are shutting down, or are doing a maphash or clrhash on the table. */ if (!inside_profiling && !preparing_for_armageddon) { Lisp_Object fun; /* If something below causes an error to be signaled, we'll not correctly reset this flag. But we'll be in worse shape than that anyways, since we'll longjmp back to the last condition case. */ inside_profiling = 1; if (profiling_redisplay_flag) fun = QSin_redisplay; else if (gc_in_progress) fun = QSin_garbage_collection; else if (backtrace_list) { fun = *backtrace_list->function; if (!SYMBOLP (fun) && !COMPILED_FUNCTIONP (fun) && !SUBRP (fun) && !CONSP (fun)) fun = QSunknown; } else fun = QSprocessing_events_at_top_level; { /* #### see comment about memory allocation in start-profiling. Allocating memory in a signal handler is BAD BAD BAD. If you are using the non-mmap rel-alloc code, you might lose because of this. Even worse, if the memory allocation fails, the `error' generated whacks everything hard. */ long count; const void *vval; if (gethash (LISP_TO_VOID (fun), big_profile_table, &vval)) count = (long) vval; else count = 0; count++; vval = (const void *) count; puthash (LISP_TO_VOID (fun), (void *) vval, big_profile_table); } inside_profiling = 0; } } DEFUN ("start-profiling", Fstart_profiling, 0, 1, 0, /* Start profiling, with profile queries every MICROSECS. If MICROSECS is nil or omitted, the value of `default-profiling-interval' is used. You can retrieve the recorded profiling info using `get-profiling-info'. Starting and stopping profiling does not clear the currently recorded info. Thus you can start and stop as many times as you want and everything will be properly accumulated. */ (microsecs)) { /* This function can GC */ int msecs; struct itimerval foo; /* #### The hash code can safely be called from a signal handler except when it has to grow the hash table. In this case, it calls realloc(), which is not (in general) re-entrant. We'll just be sleazy and make the table large enough that it (hopefully) won't need to be realloc()ed. */ if (!big_profile_table) big_profile_table = make_hash_table (10000); if (NILP (microsecs)) msecs = default_profiling_interval; else { CHECK_NATNUM (microsecs); msecs = XINT (microsecs); } if (msecs <= 0) msecs = 1000; set_timeout_signal (SIGPROF, sigprof_handler); foo.it_value.tv_sec = 0; foo.it_value.tv_usec = msecs; EMACS_NORMALIZE_TIME (foo.it_value); foo.it_interval = foo.it_value; profiling_active = 1; inside_profiling = 0; qxe_setitimer (ITIMER_PROF, &foo, 0); return Qnil; } DEFUN ("stop-profiling", Fstop_profiling, 0, 0, 0, /* Stop profiling. */ ()) { /* This function does not GC */ struct itimerval foo; foo.it_value.tv_sec = 0; foo.it_value.tv_usec = 0; foo.it_interval = foo.it_value; qxe_setitimer (ITIMER_PROF, &foo, 0); profiling_active = 0; set_timeout_signal (SIGPROF, fatal_error_signal); return Qnil; } static Lisp_Object profile_lock_unwind (Lisp_Object ignore) { inside_profiling = 0; return Qnil; } struct get_profiling_info_closure { Lisp_Object accum; }; static int get_profiling_info_maphash (const void *void_key, void *void_val, void *void_closure) { /* This function does not GC */ Lisp_Object key; struct get_profiling_info_closure *closure = (struct get_profiling_info_closure *) void_closure; EMACS_INT val; CVOID_TO_LISP (key, void_key); val = (EMACS_INT) void_val; closure->accum = Fcons (Fcons (key, make_int (val)), closure->accum); return 0; } DEFUN ("get-profiling-info", Fget_profiling_info, 0, 0, 0, /* Return the profiling info as an alist. */ ()) { /* This function does not GC */ struct get_profiling_info_closure closure; closure.accum = Qnil; if (big_profile_table) { int count = specpdl_depth (); record_unwind_protect (profile_lock_unwind, Qnil); inside_profiling = 1; maphash (get_profiling_info_maphash, big_profile_table, &closure); unbind_to (count, Qnil); } return closure.accum; } static int mark_profiling_info_maphash (const void *void_key, void *void_val, void *void_closure) { Lisp_Object key; CVOID_TO_LISP (key, void_key); mark_object (key); return 0; } void mark_profiling_info (void) { /* This function does not GC */ if (big_profile_table) { inside_profiling = 1; maphash (mark_profiling_info_maphash, big_profile_table, 0); inside_profiling = 0; } } DEFUN ("clear-profiling-info", Fclear_profiling_info, 0, 0, "", /* Clear out the recorded profiling info. */ ()) { /* This function does not GC */ if (big_profile_table) { inside_profiling = 1; clrhash (big_profile_table); inside_profiling = 0; } if (!NILP (Vcall_count_profile_table)) Fclrhash (Vcall_count_profile_table); return Qnil; } DEFUN ("profiling-active-p", Fprofiling_active_p, 0, 0, 0, /* Return non-nil if profiling information is currently being recorded. */ ()) { return profiling_active ? Qt : Qnil; } void syms_of_profile (void) { DEFSUBR (Fstart_profiling); DEFSUBR (Fstop_profiling); DEFSUBR (Fget_profiling_info); DEFSUBR (Fclear_profiling_info); DEFSUBR (Fprofiling_active_p); } void vars_of_profile (void) { DEFVAR_INT ("default-profiling-interval", &default_profiling_interval /* Default CPU time in microseconds between profiling sampling. Used when the argument to `start-profiling' is nil or omitted. Note that the time in question is CPU time (when the program is executing or the kernel is executing on behalf of the program) and not real time. */ ); default_profiling_interval = 1000; DEFVAR_LISP ("call-count-profile-table", &Vcall_count_profile_table /* The table where call-count information is stored by the profiling primitives. This is a hash table whose keys are funcallable objects, and whose values are their call counts (integers). */ ); Vcall_count_profile_table = Qnil; inside_profiling = 0; QSin_redisplay = build_string ("(in redisplay)"); staticpro (&QSin_redisplay); QSin_garbage_collection = build_string ("(in garbage collection)"); staticpro (&QSin_garbage_collection); QSunknown = build_string ("(unknown)"); staticpro (&QSunknown); QSprocessing_events_at_top_level = build_string ("(processing events at top level)"); staticpro (&QSprocessing_events_at_top_level); }