Mercurial > hg > xemacs-beta
view src/backtrace.h @ 617:af57a77cbc92
[xemacs-hg @ 2001-06-18 07:09:50 by ben]
---------------------------------------------------------------
DOCUMENTATION FIXES:
---------------------------------------------------------------
eval.c: Correct documentation.
elhash.c: Doc correction.
---------------------------------------------------------------
LISP OBJECT CLEANUP:
---------------------------------------------------------------
bytecode.h, buffer.h, casetab.h, chartab.h, console-msw.h, console.h, database.c, device.h, eldap.h, elhash.h, events.h, extents.h, faces.h, file-coding.h, frame.h, glyphs.h, gui-x.h, gui.h, keymap.h, lisp-disunion.h, lisp-union.h, lisp.h, lrecord.h, lstream.h, mule-charset.h, objects.h, opaque.h, postgresql.h, process.h, rangetab.h, specifier.h, toolbar.h, tooltalk.h, ui-gtk.h: Add wrap_* to all objects (it was already there for a few of them)
-- an expression to encapsulate a pointer into a Lisp object,
rather than the inconvenient XSET*. "wrap" was chosen because
"make" as in make_int(), make_char() is not appropriate. (It
implies allocation. The issue does not exist for ints and chars
because they are not allocated.)
Full error checking has been added to these expressions. When
used without error checking, non-union build, use of these
expressions will incur no loss of efficiency. (In fact, XSET* is
now defined in terms of wrap_* in a non-union build.) In a union
build, you will also get no loss of efficiency provided that you
have a decent optimizing compiler, and a compiler that either
understands inlines or automatically inlines those particular
functions. (And since people don't normally do their production
builds on union, it doesn't matter.)
Update the sample Lisp object definition in lrecord.h accordingly.
dumper.c: Fix places in dumper that referenced wrap_object to reference
its new name, wrap_pointer_1.
buffer.c, bufslots.h, conslots.h, console.c, console.h, devslots.h, device.c, device.h, frame.c, frame.h, frameslots.h, window.c, window.h, winslots.h: -- Extract out the Lisp objects of `struct device' into devslots.h,
just like for the other structures.
-- Extract out the remaining (not copied into the window config)
Lisp objects in `struct window' into winslots.h; use different
macros (WINDOW_SLOT vs. WINDOW_SAVED_SLOT) to differentiate them.
-- Eliminate the `dead' flag of `struct frame', since it
duplicates information already available in `framemeths', and fix
FRAME_LIVE_P accordingly. (Devices and consoles already work this
way.)
-- In *slots.h, switch to system where MARKED_SLOT is automatically
undef'd at the end of the file. (Follows what winslots.h already
does.)
-- Update the comments at the beginning of *slots.h to be accurate.
-- When making any of the above objects dead, zero it out entirely
and reset all Lisp object slots to Qnil. (We were already doing
this somewhat, but not consistently.) This (1) Eliminates the
possibility of extra objects hanging around that ought to be
GC'd, (2) Causes an immediate crash if anyone tries to access a
structure in one of these objects, (3) Ensures consistent behavior
wrt dead objects.
dialog-msw.c: Use internal_object_printer, since this object should not escape.
---------------------------------------------------------------
FIXING A CRASH THAT I HIT ONCE (AND A RELATED BAD BEHAVIOR):
---------------------------------------------------------------
eval.c: Fix up some comments about the FSF implementation.
Fix two nasty bugs:
(1) condition_case_unwind frees the conses sitting in the
catch->tag slot too quickly, resulting in a crash that I hit.
(2) catches need to be unwound one at a time when calling
unwind-protect code, rather than all at once at the end; otherwise,
incorrect behavior can result. (A comment shows exactly how.)
backtrace.h: Improve comment about FSF differences in the handler stack.
---------------------------------------------------------------
FIXING A CRASH THAT I REPEATEDLY HIT WHEN USING THE MOUSE WHEEL
UNDER MSWINDOWS:
---------------------------------------------------------------
Basic idea: My crash is due either to a dead, non-marked,
GC-collected frame inside of a window mirror, or a prematurely
freed window mirror. We need to mark the Lisp objects inside of
window mirrors. Tracking the lifespan of window mirrors and
scrollbar instances is extremely hard, and there may well be
lurking bugs where such objects are freed too soon. The only safe
way to fix these problems (and it fixes both problems at once) is
to make both of these structures Lisp objects.
lrecord.h, emacs.c, inline.c, scrollbar-gtk.c, scrollbar-msw.c, scrollbar-x.c, scrollbar.c, scrollbar.h, symsinit.h: Make scrollbar instances actual Lisp objects. Mark the window
mirrors in them. inline.c needs to know about scrollbar.h now.
Record the new type in lrecord.h. Fix up scrollbar-*.c
appropriately. Create a hash table in scrollbar-msw.c so that the
scrollbar instances stored in scrollbar HWND's are properly
GC-protected. Create complex_vars_of_scrollbar_mswindows() to
create the hash table at startup, and call it from emacs.c. Don't
store the scrollbar instance as a property of the GTK scrollbar,
as it's not used and if we did this, we'd have to separately
GC-protect it in a hash table, like in MS Windows.
lrecord.h, frame.h, frame.c, frameslots.h, redisplay.c, window.c, window.h: Move mark_window_mirror from redisplay.c to window.c. Make window
mirrors actual Lisp objects. Tell lrecord.h about them. Change
the window mirror member of struct frame from a pointer to a Lisp
object, and add XWINDOW_MIRROR in appropriate places. Mark the
scrollbar instances in the window mirror.
redisplay.c, redisplay.h, alloc.c: Delete mark_redisplay. Don't call mark_redisplay. We now mark
frame-specific structures in mark_frame.
NOTE: I also deleted an extremely questionable call to
update_frame_window_mirrors(). It was extremely questionable
before, and now totally impossible, since it will create
Lisp objects during redisplay.
frame.c: Mark the scrollbar instances, which are now Lisp objects.
Call mark_gutter() here, not in mark_redisplay().
gutter.c: Update comments about correct marking.
---------------------------------------------------------------
ISSUES BROUGHT UP BY MARTIN:
---------------------------------------------------------------
buffer.h: Put back these macros the way Steve T and I think they ought to be.
I already explained in a previous changelog entry why I think these
macros should be the way I'd defined them. Once again:
We fix these macros so they don't care about the type of their
lvalues. The non-C-string equivalents of these already function
in the same way, and it's correct because it should be OK to pass
in a CBufbyte *, a BufByte *, a Char_Binary *, an UChar_Binary *,
etc. The whole reason for these different types is to work around
errors caused by signed-vs-unsigned non-matching types. Any
possible error that might be caught in a DFC macro would also be
caught wherever the argument is used elsewhere. So creating
multiple macro versions would add no useful error-checking and
just further complicate an already complicated area.
As for Martin's "ANSI aliasing" bug, XEmacs is not ANSI-aliasing
clean and probably never will be. Unless the board agrees to
change XEmacs in this way (and we really don't want to go down
that road), this is not a bug.
sound.h: Undo Martin's type change.
signal.c: Fix problem identified by Martin with Linux and g++ due to
non-standard declaration of setitimer().
systime.h: Update the docs for "qxe_" to point out why making the
encapsulation explicit is always the right way to go. (setitimer()
itself serves as an example.)
For 21.4:
update-elc-2.el: Correct misplaced parentheses, making lisp/mule not get
recompiled.
author | ben |
---|---|
date | Mon, 18 Jun 2001 07:10:32 +0000 |
parents | 8de8e3f6228a |
children | b39c14581166 |
line wrap: on
line source
/* The lisp stack. Copyright (C) 1985, 1986, 1987, 1992, 1993 Free Software Foundation, Inc. This file is part of XEmacs. XEmacs is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation; either version 2, or (at your option) any later version. XEmacs is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details. You should have received a copy of the GNU General Public License along with XEmacs; see the file COPYING. If not, write to the Free Software Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ /* Synched up with: FSF 19.30. Contained redundantly in various C files in FSFmacs. */ /* Authorship: FSF: Original version; a long time ago. XEmacs: split out of some C files. (For some obscure reason, a header file couldn't be used in FSF Emacs, but XEmacs doesn't have that problem.) Mly (probably) or JWZ: Some changes. */ #ifndef INCLUDED_backtrace_h_ #define INCLUDED_backtrace_h_ #include <setjmp.h> /* These definitions are used in eval.c and alloc.c */ struct backtrace { struct backtrace *next; Lisp_Object *function; Lisp_Object *args; /* Points to vector of args. */ int nargs; /* Length of vector. If nargs is UNEVALLED, args points to slot holding list of unevalled args */ int pdlcount; /* specpdl_depth () when invoked */ char evalargs; /* Nonzero means call value of debugger when done with this operation. */ char debug_on_exit; }; /* This structure helps implement the `catch' and `throw' control structure. A struct catchtag contains all the information needed to restore the state of the interpreter after a non-local jump. Handlers for error conditions (represented by `struct handler' structures) just point to a catch tag to do the cleanup required for their jumps. catchtag structures are chained together in the C calling stack; the `next' member points to the next outer catchtag. A call like (throw TAG VAL) searches for a catchtag whose `tag' member is TAG, and then unbinds to it. The `val' member is used to hold VAL while the stack is unwound; `val' is returned as the value of the catch form. All the other members are concerned with restoring the interpreter state. */ struct catchtag { Lisp_Object tag; Lisp_Object val; struct catchtag *next; struct gcpro *gcpro; JMP_BUF jmp; struct backtrace *backlist; #if 0 /* FSFmacs */ /* FSF uses a separate handler stack to hold condition-cases, where we use Vcondition_handlers. We should switch to their system becaue it avoids the need to mess around with consing up stuff and then dangerously freeing it. See comment in condition_case_unwind(). */ struct handler *handlerlist; #endif int lisp_eval_depth; int pdlcount; #if 0 /* FSFmacs */ /* This is the equivalent of async_timer_suppress_count. We probably don't have to bother with this. */ int poll_suppress_count; #endif }; /* Dynamic-binding-o-rama */ /* Structure for recording Lisp call stack for backtrace purposes. */ /* The special binding stack holds the outer values of variables while they are bound by a function application or a let form, stores the code to be executed for Lisp unwind-protect forms, and stores the C functions to be called for record_unwind_protect. If func is non-zero, undoing this binding applies func to old_value; This implements record_unwind_protect. If func is zero and symbol is nil, undoing this binding evaluates the list of forms in old_value; this implements Lisp's unwind-protect form. Otherwise, undoing this binding stores old_value as symbol's value; this undoes the bindings made by a let form or function call. */ struct specbinding { Lisp_Object symbol; Lisp_Object old_value; Lisp_Object (*func) (Lisp_Object); /* for unwind-protect */ }; #if 0 /* FSFmacs */ /* #### */ /* Everything needed to describe an active condition case. */ struct handler { /* The handler clauses and variable from the condition-case form. */ Lisp_Object handler; Lisp_Object var; /* Fsignal stores here the condition-case clause that applies, and Fcondition_case thus knows which clause to run. */ Lisp_Object chosen_clause; /* Used to effect the longjmp() out to the handler. */ struct catchtag *tag; /* The next enclosing handler. */ struct handler *next; }; extern struct handler *handlerlist; #endif /* These are extern because GC needs to mark them */ extern struct specbinding *specpdl; extern struct specbinding *specpdl_ptr; extern struct catchtag *catchlist; extern struct backtrace *backtrace_list; /* Most callers should simply use specbind() and unbind_to(), but if speed is REALLY IMPORTANT, you can use the faster macros below */ void specbind_magic (Lisp_Object, Lisp_Object); void grow_specpdl (size_t reserved); void unbind_to_hairy (int); extern int specpdl_size; /* Inline version of specbind(). Use this instead of specbind() if speed is sufficiently important to save the overhead of even a single function call. */ #define SPECBIND(symbol_object, value_object) do { \ Lisp_Object SB_symbol = (symbol_object); \ Lisp_Object SB_newval = (value_object); \ Lisp_Object SB_oldval; \ Lisp_Symbol *SB_sym; \ \ SPECPDL_RESERVE (1); \ \ CHECK_SYMBOL (SB_symbol); \ SB_sym = XSYMBOL (SB_symbol); \ SB_oldval = SB_sym->value; \ \ if (!SYMBOL_VALUE_MAGIC_P (SB_oldval) || UNBOUNDP (SB_oldval)) \ { \ /* #### the following test will go away when we have a constant \ symbol magic object */ \ if (EQ (SB_symbol, Qnil) || \ EQ (SB_symbol, Qt) || \ SYMBOL_IS_KEYWORD (SB_symbol)) \ reject_constant_symbols (SB_symbol, SB_newval, 0, \ UNBOUNDP (SB_newval) ? \ Qmakunbound : Qset); \ \ specpdl_ptr->symbol = SB_symbol; \ specpdl_ptr->old_value = SB_oldval; \ specpdl_ptr->func = 0; \ specpdl_ptr++; \ specpdl_depth_counter++; \ \ SB_sym->value = (SB_newval); \ } \ else \ specbind_magic (SB_symbol, SB_newval); \ } while (0) /* An even faster, but less safe inline version of specbind(). Caller guarantees that: - SYMBOL is a non-constant symbol (i.e. not Qnil, Qt, or keyword). - specpdl_depth_counter >= specpdl_size. Else we crash. */ #define SPECBIND_FAST_UNSAFE(symbol_object, value_object) do { \ Lisp_Object SFU_symbol = (symbol_object); \ Lisp_Object SFU_newval = (value_object); \ Lisp_Symbol *SFU_sym = XSYMBOL (SFU_symbol); \ Lisp_Object SFU_oldval = SFU_sym->value; \ if (!SYMBOL_VALUE_MAGIC_P (SFU_oldval) || UNBOUNDP (SFU_oldval)) \ { \ specpdl_ptr->symbol = SFU_symbol; \ specpdl_ptr->old_value = SFU_oldval; \ specpdl_ptr->func = 0; \ specpdl_ptr++; \ specpdl_depth_counter++; \ \ SFU_sym->value = (SFU_newval); \ } \ else \ specbind_magic (SFU_symbol, SFU_newval); \ } while (0) /* Request enough room for SIZE future entries on special binding stack */ #define SPECPDL_RESERVE(size) do { \ size_t SR_size = (size); \ if (specpdl_depth() + SR_size >= specpdl_size) \ grow_specpdl (SR_size); \ } while (0) /* Inline version of unbind_to(). Use this instead of unbind_to() if speed is sufficiently important to save the overhead of even a single function call. Most of the time, unbind_to() is called only on ordinary variables, so optimize for that. */ #define UNBIND_TO_GCPRO(count, value) do { \ int UNBIND_TO_count = (count); \ while (specpdl_depth_counter != UNBIND_TO_count) \ { \ Lisp_Symbol *sym; \ --specpdl_ptr; \ --specpdl_depth_counter; \ \ if (specpdl_ptr->func != 0 || \ ((sym = XSYMBOL (specpdl_ptr->symbol)), \ SYMBOL_VALUE_MAGIC_P (sym->value))) \ { \ struct gcpro gcpro1; \ GCPRO1 (value); \ unbind_to_hairy (UNBIND_TO_count); \ UNGCPRO; \ break; \ } \ \ sym->value = specpdl_ptr->old_value; \ } \ } while (0) /* A slightly faster inline version of unbind_to, that doesn't offer GCPROing services. */ #define UNBIND_TO(count) do { \ int UNBIND_TO_count = (count); \ while (specpdl_depth_counter != UNBIND_TO_count) \ { \ Lisp_Symbol *sym; \ --specpdl_ptr; \ --specpdl_depth_counter; \ \ if (specpdl_ptr->func != 0 || \ ((sym = XSYMBOL (specpdl_ptr->symbol)), \ SYMBOL_VALUE_MAGIC_P (sym->value))) \ { \ unbind_to_hairy (UNBIND_TO_count); \ break; \ } \ \ sym->value = specpdl_ptr->old_value; \ } \ } while (0) #ifdef ERROR_CHECK_TYPECHECK #define CHECK_SPECBIND_VARIABLE assert (specpdl_ptr->func == 0) #else #define CHECK_SPECBIND_VARIABLE DO_NOTHING #endif #if 0 /* Unused. It's too hard to guarantee that the current bindings contain only variables. */ /* Another inline version of unbind_to(). VALUE is GC-protected. Caller guarantees that: - all of the elements on the binding stack are variable bindings. Else we crash. */ #define UNBIND_TO_GCPRO_VARIABLES_ONLY(count, value) do { \ int UNBIND_TO_count = (count); \ while (specpdl_depth_counter != UNBIND_TO_count) \ { \ Lisp_Symbol *sym; \ --specpdl_ptr; \ --specpdl_depth_counter; \ \ CHECK_SPECBIND_VARIABLE; \ sym = XSYMBOL (specpdl_ptr->symbol); \ if (!SYMBOL_VALUE_MAGIC_P (sym->value)) \ sym->value = specpdl_ptr->old_value; \ else \ { \ struct gcpro gcpro1; \ GCPRO1 (value); \ unbind_to_hairy (UNBIND_TO_count); \ UNGCPRO; \ break; \ } \ } \ } while (0) #endif /* unused */ /* A faster, but less safe inline version of Fset(). Caller guarantees that: - SYMBOL is a non-constant symbol (i.e. not Qnil, Qt, or keyword). Else we crash. */ #define FSET_FAST_UNSAFE(sym, newval) do { \ Lisp_Object FFU_sym = (sym); \ Lisp_Object FFU_newval = (newval); \ Lisp_Symbol *FFU_symbol = XSYMBOL (FFU_sym); \ Lisp_Object FFU_oldval = FFU_symbol->value; \ if (!SYMBOL_VALUE_MAGIC_P (FFU_oldval) || UNBOUNDP (FFU_oldval)) \ FFU_symbol->value = FFU_newval; \ else \ Fset (FFU_sym, FFU_newval); \ } while (0) #endif /* INCLUDED_backtrace_h_ */