changes to VOID_TO_LISP et al. -------------------- ChangeLog entries follow: -------------------- src/ChangeLog addition: 2010-02-08 Ben Wing <ben@xemacs.org> * casetab.c (compute_canon_mapper): * casetab.c (initialize_identity_mapper): * casetab.c (compute_up_or_eqv_mapper): * casetab.c (recompute_case_table): * casetab.c (set_case_table): * chartab.c (copy_mapper): * chartab.c (copy_char_table_range): * chartab.c (get_range_char_table_1): * console.c (find_nonminibuffer_frame_not_on_console_predicate): * console.c (find_nonminibuffer_frame_not_on_console): * console.c (nuke_all_console_slots): * device.c: * device.c (find_nonminibuffer_frame_not_on_device_predicate): * device.c (find_nonminibuffer_frame_not_on_device): * dialog-msw.c (dialog_proc): * dialog-msw.c (handle_question_dialog_box): * dialog-x.c (maybe_run_dbox_text_callback): * eval.c: * eval.c (safe_run_hook_trapping_problems_1): * eval.c (safe_run_hook_trapping_problems): * event-msw.c: * event-msw.c (mswindows_wnd_proc): * event-msw.c (mswindows_find_frame): * faces.c (update_face_inheritance_mapper): * frame-msw.c (mswindows_init_frame_1): * frame-msw.c (mswindows_get_mouse_position): * frame-msw.c (mswindows_get_frame_parent): * glade.c (connector): * glade.c (Fglade_xml_signal_connect): * glade.c (Fglade_xml_signal_autoconnect): * glade.c (Fglade_xml_textdomain): * glyphs-msw.c (mswindows_subwindow_instantiate): * glyphs-msw.c (mswindows_widget_instantiate): * glyphs.c (check_instance_cache_mapper): * glyphs.c (check_window_subwindow_cache): * glyphs.c (check_image_instance_structure): * gui-x.c (snarf_widget_value_mapper): * gui-x.c (popup_selection_callback): * gui-x.c (button_item_to_widget_value): * keymap.c (map_keymap_mapper): * keymap.c (Fmap_keymap): * menubar-gtk.c (__torn_off_sir): * menubar-gtk.c (__activate_menu): * menubar-gtk.c (menu_convert): * menubar-gtk.c (__generic_button_callback): * menubar-gtk.c (menu_descriptor_to_widget_1): * menubar-msw.c: * menubar-msw.c (EMPTY_ITEM_ID): * menubar-x.c (menu_item_descriptor_to_widget_value_1): * menubar-x.c (pre_activate_callback): * menubar-x.c (command_builder_operate_menu_accelerator): * menubar-x.c (command_builder_find_menu_accelerator): * print.c (print_internal): * process-unix.c (close_process_descs_mapfun): * process.c (get_process_from_usid): * process.c (init_process_io_handles): * profile.c (sigprof_handler): * profile.c (get_profiling_info_timing_maphash): * profile.c (Fget_profiling_info): * profile.c (set_profiling_info_timing_maphash): * profile.c (mark_profiling_info_maphash): * scrollbar-msw.c (mswindows_create_scrollbar_instance): * scrollbar-msw.c (mswindows_free_scrollbar_instance): * scrollbar-msw.c (mswindows_handle_scrollbar_event): * specifier.c (recompute_cached_specifier_everywhere_mapfun): * specifier.c (recompute_cached_specifier_everywhere): * syntax.c (copy_to_mirrortab): * syntax.c (copy_if_not_already_present): * syntax.c (update_just_this_syntax_table): * text.c (new_dfc_convert_now_damn_it): * text.h (LISP_STRING_TO_EXTERNAL): * tooltalk.c: * tooltalk.c (tooltalk_message_callback): * tooltalk.c (tooltalk_pattern_callback): * tooltalk.c (Fcreate_tooltalk_message): * tooltalk.c (Fcreate_tooltalk_pattern): * ui-byhand.c (__generic_toolbar_callback): * ui-byhand.c (generic_toolbar_insert_item): * ui-byhand.c (__emacs_gtk_ctree_recurse_internal): * ui-byhand.c (Fgtk_ctree_recurse): * ui-gtk.c (__internal_callback_destroy): * ui-gtk.c (__internal_callback_marshal): * ui-gtk.c (Fgtk_signal_connect): * ui-gtk.c (gtk_type_to_lisp): * ui-gtk.c (lisp_to_gtk_type): * ui-gtk.c (lisp_to_gtk_ret_type): * lisp-disunion.h: * lisp-disunion.h (NON_LVALUE): * lisp-union.h: * lisp.h (LISP_HASH): Rename: LISP_TO_VOID -> STORE_LISP_IN_VOID VOID_TO_LISP -> GET_LISP_FROM_VOID These new names are meant to clearly identify that the Lisp object is the source and void the sink, and that they can't be used the other way around -- they aren't exact opposites despite the old names. The names are also important given the new functions created just below. Also, clarify comments in lisp-union.h and lisp-disunion.h about the use of the functions. * lisp.h: New functions STORE_VOID_IN_LISP and GET_VOID_FROM_LISP. These are different from the above in that the source is a void * (previously, you had to use make_opaque_ptr()). * eval.c (restore_lisp_object): * eval.c (record_unwind_protect_restoring_lisp_object): * eval.c (struct restore_int): * eval.c (restore_int): * eval.c (record_unwind_protect_restoring_int): * eval.c (free_pointer): * eval.c (record_unwind_protect_freeing): * eval.c (free_dynarr): * eval.c (record_unwind_protect_freeing_dynarr): * eval.c (unbind_to_1): Use STORE_VOID_IN_LISP and GET_VOID_FROM_LISP to eliminate the use of make_opaque_ptr() and mostly eliminate Lisp consing entirely in the use of these various record_unwind_protect_* functions as well as internal_bind_* (e.g. internal_bind_int). * tests.c: * tests.c (Ftest_store_void_in_lisp): * tests.c (syms_of_tests): * tests.c (vars_of_tests): Add an C-assert-style test to test STORE_VOID_IN_LISP and GET_VOID_FROM_LISP to make sure the same value comes back that was put in.

This directory contains the source files for the C component of XEmacs.
Nothing in this directory is needed for using XEmacs once it is built
and installed, if the dumped Emacs is copied elsewhere.

See the files ../README and then ../INSTALL for installation instructions.

Under Unix, the file `Makefile.in.in' is used as a template by the script
`../configure' to produce `Makefile.in'.  The same script then uses `cpp'
to produce the machine-dependent `Makefile' from `Makefile.in';
`Makefile' is the file which actually controls the compilation of
Emacs.  Most of this should work transparently to the user; you should
only need to run `../configure', and then type `make'.

General changes for XEmacs:
---------------------------
1. Lisp objects.

   -- XFASTINT has been eliminated.  Use of this expression as an lvalue
      is incompatible with the union form of Lisp objects, and use as
      an rvalue is likely to lead to errors and doesn't really save much
      time.  Expressions of the form `XFASTINT (obj) = num;' get replaced
      by `obj = make_int (num);' or `XSETINT (obj, num);' and
      expressions of the form `num = XFASTINT (obj);' get replaced by
      `num = XINT (obj);'.  Use Qzero in place of `make_int (0)'.

   -- Use of XTYPE gets replaced by the appropriate predicate.  Using
      XTYPE only works for the small number of types that are not stored
      using the Lisp_Record type (int, cons, string, and vector).  For
      example, `(XTYPE (foo) == Lisp_Buffer)' gets replaced by
      `(BUFFERP (foo))'.

   -- `XSET (obj, Lisp_Int, num)' gets replaced by `XSETINT (obj, num)',
      for consistency.

   -- Some occurrences of XSET need to get replaced by XSETR --
      specifically, those where the type is not a primitive type
      (primitive types are int, cons, string, and vector).

   -- References to `XSTRING (obj)->size' get replaced with
      `XSTRING_LENGTH (obj)'.  This is currently for cosmetic reasons
      but there may be other reasons in the future.  (This change is
      currently incomplete in the source files.)


2. Storage classes:

   -- All occurrences of `register' should be replaced by `REGISTER'.
      It interferes with backtraces so we disable it if DEBUG_XEMACS
      is defined.


3. Errors, messages, I18N3 snarfing:

   -- Errors are continuable in XEmacs but are not in FSF Emacs.
      Therefore, it's important that functions do something reasonable
      if an error gets continued.  If you want to signal a non-
      continuable error, the call to Fsignal() gets put inside a
      `while (1)' loop.  To facilitate this, and also for proper I18N3
      message snarfing, most calls to Fsignal() have been replaced by
      calls to signal_error(), signal_simple_error(), etc.  Look at
      eval.c for a classification of various error functions.

   -- Constant strings occurring in source files need to get wrapped
      in a call to GETTEXT (or if inside of a call to `build_ascstring',
      change that function to `build_translated_string') if they don't
      occur in certain places where the I18N3 message snarfer will see
      them.  For a complete discussion of this, see the file
      lib-src/make-msgfile.lex.

      NOTE: I18N3 support is not currently working, so the above may
      or may not apply.  Thus it is not a good idea to add random
      GETTEXTs, unless you really know what you are doing.

   -- Calls to `fprintf (stderr, ...)' and `printf (...)' get replaced
      with calls to `stderr_out' and `stdout_out'.  This is for I18N3
      message snarfing.

4. Initialization:

   -- FSF constructs like `obj = intern ("string"); staticpro (&obj);'
      get replaced by `defsymbol (&obj);'.  This is for code cleanness
      and better purespace usage.
   -- FSF constructs like
        obj = intern ("error");
        Fput (obj, Qerror_message, "message");
	Fput (obj, Qerror_conditions, some list);
      get replaced by calls to deferror().  See the definition of
      deferror() for how the correct arguments to pass.  This is for
      code cleanness and I18N3 message snarfing.
   -- Code in keys_of_foo() functions has been moved into Lisp.