Mercurial > hg > xemacs-beta
view tests/automated/regexp-tests.el @ 4792:95b04754ea8c
Make #'equalp more compatible with CL; add a compiler macro, test & doc it.
lisp/ChangeLog addition:
2009-11-08 Aidan Kehoe <kehoea@parhasard.net>
* cl-extra.el (cl-string-vector-equalp)
(cl-bit-vector-vector-equalp, cl-vector-array-equalp)
(cl-hash-table-contents-equalp): New functions, to implement
equalp treating arrays with identical contents as equivalent, as
specified by Common Lisp.
(equalp): Revise this function to implement array equivalence,
and the hash-table equalp behaviour specified by CL.
* cl-macs.el (equalp): Add a compiler macro for this function,
used when one of the arguments is constant, and as such, its type
is known at compile time.
man/ChangeLog addition:
2009-11-08 Aidan Kehoe <kehoea@parhasard.net>
* lispref/objects.texi (Equality Predicates):
Document #'equalp here, as well as #'equal and #'eq.
tests/ChangeLog addition:
2009-12-31 Aidan Kehoe <kehoea@parhasard.net>
* automated/lisp-tests.el:
Test much of the functionality of equalp; add a pointer to Paul
Dietz' ANSI test suite for this function, converted to Emacs
Lisp. Not including the tests themselves in XEmacs because who
owns the copyright on the files is unclear and the GCL people
didn't respond to my queries.
author | Aidan Kehoe <kehoea@parhasard.net> |
---|---|
date | Thu, 31 Dec 2009 15:09:41 +0000 |
parents | e0a8c796f955 |
children | 189fb67ca31a |
line wrap: on
line source
;;; -*- coding: iso-8859-1 -*- ;; Copyright (C) 2000, 2002, 2003 Free Software Foundation, Inc. ;; Author: Yoshiki Hayashi <yoshiki@xemacs.org> ;; Maintainer: Stephen J. Turnbull <stephen@xemacs.org> ;; Created: 2000 ;; Keywords: tests ;; This file is part of XEmacs. ;; XEmacs is free software; you can redistribute it and/or modify it ;; under the terms of the GNU General Public License as published by ;; the Free Software Foundation; either version 2, or (at your option) ;; any later version. ;; XEmacs is distributed in the hope that it will be useful, but ;; WITHOUT ANY WARRANTY; without even the implied warranty of ;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU ;; General Public License for more details. ;; You should have received a copy of the GNU General Public License ;; along with XEmacs; see the file COPYING. If not, write to the Free ;; Software Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA ;; 02111-1307, USA. ;;; Synched up with: Not in FSF. ;;; Commentary: ;; Test regular expression. (Check-Error-Message error "Trailing backslash" (string-match "\\" "a")) (Check-Error-Message error "Invalid preceding regular expression" (string-match "a++" "a")) (Check-Error-Message error "Invalid preceding regular expression" (string-match "a**" "a")) (Check-Error-Message error "Invalid preceding regular expression" (string-match "a???" "a")) (Check-Error-Message error "Unmatched \\[ or \\[^" (string-match "[" "a")) (Check-Error-Message error "Unmatched \\[ or \\[^" (string-match "[abc" "a")) (Check-Error-Message error "Unmatched ) or \\\\)" (string-match "\\)" "a")) (Check-Error-Message error "Invalid regular expression" (string-match "\\(?.\\)" "a")) (Check-Error-Message error "Unmatched \\\\{" (string-match "a\\{" "a")) (Check-Error-Message error "Invalid content of \\\\{\\\\}" (string-match "a\\{a\\}" "a")) ;; exactn ;; string-match (with-temp-buffer ;; case-insensitive (Assert (string-match "ä" "ä")) (Assert (string-match "ä" "Ä")) (Assert (string-match "Ä" "Ä")) (Assert (string-match "Ä" "ä")) ;; case-sensitive (setq case-fold-search nil) (Assert (string-match "ä" "ä")) (Assert (not (string-match "ä" "Ä"))) (Assert (string-match "Ä" "Ä")) (Assert (not (string-match "Ä" "ä")))) ;; looking-at (with-temp-buffer (insert "äÄ") ;; case-insensitive (goto-char (point-min)) (Assert (looking-at "ä")) (Assert (looking-at "Ä")) (forward-char) (Assert (looking-at "ä")) (Assert (looking-at "Ä")) ;; case-sensitive (setq case-fold-search nil) (goto-char (point-min)) (Assert (looking-at "ä")) (Assert (not (looking-at "Ä"))) (forward-char) (Assert (not (looking-at "ä"))) (Assert (looking-at "Ä"))) ;; re-search-forward and re-search-backward (with-temp-buffer (insert "äÄ") ;; case insensitive ;; forward (goto-char (point-min)) ;; Avoid trivial regexp. (Assert (eq 2 (re-search-forward "ä\\|a" nil t))) (goto-char (point-min)) (Assert (eq 2 (re-search-forward "Ä\\|a" nil t))) (goto-char (1+ (point-min))) (Assert (eq 3 (re-search-forward "ä\\|a" nil t))) (goto-char (1+ (point-min))) (Assert (eq 3 (re-search-forward "Ä\\|a" nil t))) ;; backward (goto-char (point-max)) (Assert (eq 2 (re-search-backward "ä\\|a" nil t))) (goto-char (point-max)) (Assert (eq 2 (re-search-backward "Ä\\|a" nil t))) (goto-char (1- (point-max))) (Assert (eq 1 (re-search-backward "ä\\|a" nil t))) (goto-char (1- (point-max))) (Assert (eq 1 (re-search-backward "Ä\\|a" nil t))) ;; case sensitive (setq case-fold-search nil) ;; forward (goto-char (point-min)) (Assert (eq 2 (re-search-forward "ä\\|a" nil t))) (goto-char (point-min)) (Assert (eq 3 (re-search-forward "Ä\\|a" nil t))) (goto-char (1+ (point-min))) (Assert (not (re-search-forward "ä\\|a" nil t))) (goto-char (1+ (point-min))) (Assert (eq 3 (re-search-forward "Ä\\|a" nil t))) ;; backward (goto-char (point-max)) (Assert (eq 1 (re-search-backward "ä\\|a" nil t))) (goto-char (point-max)) (Assert (eq 2 (re-search-backward "Ä\\|a" nil t))) (goto-char (1- (point-max))) (Assert (eq 1 (re-search-backward "ä\\|a" nil t))) (goto-char (1- (point-max))) (Assert (not (re-search-backward "Ä\\|a" nil t)))) ;; duplicate (with-temp-buffer ;; case insensitive (Assert (string-match "^\\(ä\\)\\1$" "ää")) (Assert (string-match "^\\(ä\\)\\1$" "äÄ")) (Assert (string-match "^\\(ä\\)\\1$" "ÄÄ")) (Assert (string-match "^\\(ä\\)\\1$" "Ää")) (Assert (string-match "^\\(Ä\\)\\1$" "ää")) (Assert (string-match "^\\(Ä\\)\\1$" "äÄ")) (Assert (string-match "^\\(Ä\\)\\1$" "ÄÄ")) (Assert (string-match "^\\(Ä\\)\\1$" "Ää")) ;; case sensitive (setq case-fold-search nil) (Assert (string-match "^\\(ä\\)\\1$" "ää")) (Assert (not (string-match "^\\(ä\\)\\1$" "äÄ"))) (Assert (not (string-match "^\\(ä\\)\\1$" "ÄÄ"))) (Assert (not (string-match "^\\(ä\\)\\1$" "Ää"))) (Assert (not (string-match "^\\(Ä\\)\\1$" "ää"))) (Assert (not (string-match "^\\(Ä\\)\\1$" "äÄ"))) (Assert (string-match "^\\(Ä\\)\\1$" "ÄÄ")) (Assert (not (string-match "^\\(Ä\\)\\1$" "Ää")))) ;; multiple-match ;; Thanks to Manfred Bartz <MBartz@xix.com> ;; c.e.x <vn4rkkm7ouf3b5@corp.supernews.com> ;; #### Need to do repetitions of more complex regexps ;; #### WASH ME! (with-temp-buffer (Assert (not (string-match "^a\\{4,4\\}$" "aaa"))) (Assert (string-match "^a\\{4,4\\}$" "aaaa")) (Assert (not (string-match "^a\\{4,4\\}$" "aaaaa"))) (Assert (not (string-match "^[a]\\{4,4\\}$" "aaa"))) (Assert (string-match "^[a]\\{4,4\\}$" "aaaa")) (Assert (not (string-match "^[a]\\{4,4\\}$" "aaaaa"))) (Assert (not (string-match "^\\(a\\)\\{4,4\\}$" "aaa"))) (Assert (string-match "^\\(a\\)\\{4,4\\}$" "aaaa")) (Assert (not (string-match "^\\(a\\)\\{4,4\\}$" "aaaaa"))) ;; Use class because repetition of single char broken in 21.5.15 (Assert (not (string-match "^[a]\\{3,5\\}$" "aa"))) (Assert (string-match "^[a]\\{3,5\\}$" "aaa")) (Assert (string-match "^[a]\\{3,5\\}$" "aaaa")) (Assert (string-match "^[a]\\{3,5\\}$" "aaaaa")) (Assert (not (string-match "^[a]\\{3,5\\}$" "aaaaaa"))) (insert "\ aa aaa aaaa aaaaa aaaaaa baaaa ") (goto-char (point-min)) (forward-line 1) (Assert (not (looking-at "^a\\{4,4\\}$"))) (forward-line 1) (Assert (looking-at "^a\\{4,4\\}$")) (forward-line 1) (Assert (not (looking-at "^a\\{4,4\\}$"))) (goto-char (point-min)) (forward-line 1) (Assert (not (looking-at "^[a]\\{4,4\\}$"))) (forward-line 1) (Assert (looking-at "^[a]\\{4,4\\}$")) (forward-line 1) (Assert (not (looking-at "^[a]\\{4,4\\}$"))) (goto-char (point-min)) (forward-line 1) (Assert (not (looking-at "^\\(a\\)\\{4,4\\}$"))) (forward-line 1) (Assert (looking-at "^\\(a\\)\\{4,4\\}$")) (forward-line 1) (Assert (not (looking-at "^\\(a\\)\\{4,4\\}$"))) ;; Use class because repetition of single char broken in 21.5.15 (goto-char (point-min)) (Assert (not (looking-at "^[a]\\{3,5\\}$"))) (forward-line 1) (Assert (looking-at "^[a]\\{3,5\\}$")) (forward-line 1) (Assert (looking-at "^[a]\\{3,5\\}$")) (forward-line 1) (Assert (looking-at "^[a]\\{3,5\\}$")) (forward-line 1) (Assert (not (looking-at "^[a]\\{3,5\\}$"))) (goto-char (point-min)) (Assert (= 12 (re-search-forward "a\\{4,4\\}"))) (goto-char (point-min)) (Assert (= 12 (re-search-forward "b?a\\{4,4\\}"))) (goto-char (point-min)) (Assert (= 31 (re-search-forward "ba\\{4,4\\}"))) (goto-char (point-min)) (Assert (= 31 (re-search-forward "[b]a\\{4,4\\}"))) (goto-char (point-min)) (Assert (= 31 (re-search-forward "\\(b\\)a\\{4,4\\}"))) (goto-char (point-min)) (Assert (= 12 (re-search-forward "^a\\{4,4\\}"))) (goto-char (point-min)) (Assert (= 12 (re-search-forward "^a\\{4,4\\}$"))) (goto-char (point-min)) (Assert (= 12 (re-search-forward "[a]\\{4,4\\}"))) (goto-char (point-min)) (Assert (= 12 (re-search-forward "^[a]\\{4,4\\}"))) (goto-char (point-min)) (Assert (= 12 (re-search-forward "^[a]\\{4,4\\}$"))) ) ;; charset, charset_not ;; Not called because it takes too much time. (defun test-regexp-charset-paranoid () (let ((i 0) (max (expt 2 (if (featurep 'mule) 19 8))) (range "[a-z]") (range-not "[^a-z]") char string) (while (< i max) (when (setq char (int-to-char i)) (setq string (char-to-string char)) (if (or (and (<= 65 i) (<= i 90)) (and (<= 97 i) (<= i 122))) (progn (Assert (string-match range string)) (Assert (not (string-match range-not string)))) (Assert (not (string-match range string))) (Assert (string-match range-not string)))) (setq i (1+ i))))) ;; (test-regexp-charset-paranoid) ;; charset_mule, charset_mule_not ;; Not called because it takes too much time. (defun test-regex-charset-mule-paranoid () (if (featurep 'mule) (let ((i 0) (max (expt 2 19)) (range (format "[%c-%c]" (make-char 'japanese-jisx0208 36 34) (make-char 'japanese-jisx0208 36 42))) (range-not (format "[^%c-%c]" (make-char 'japanese-jisx0208 36 34) (make-char 'japanese-jisx0208 36 42))) (min-int (char-to-int (make-char 'japanese-jisx0208 36 34))) (max-int (char-to-int (make-char 'japanese-jisx0208 36 42))) char string) (while (< i max) (when (setq char (int-to-char i)) (setq string (char-to-string char)) (if (and (<= min-int i) (<= i max-int)) (progn (Assert (string-match range string)) (Assert (not (string-match range-not string)))) (Assert (not (string-match range string))) (Assert (string-match range-not string)))) (setq i (1+ i)))))) ;; (test-regex-charset-mule-paranoid) ;; Test that replace-match does not clobber registers after a failed match (with-temp-buffer (insert "This is a test buffer.") (goto-char (point-min)) (search-forward "this is a test ") (looking-at "Unmatchable text") (replace-match "") (Assert (looking-at "^buffer.$"))) ;; Test that trivial regexps reset unused registers ;; Thanks to Martin Sternholm for the report. ;; xemacs-beta <5blm6h2ki5.fsf@lister.roxen.com> (with-temp-buffer (insert "ab") (goto-char (point-min)) (re-search-forward "\\(a\\)") ;; test the whole-match data, too -- one attempted fix scotched that, too! (Assert (string= (match-string 0) "a")) (Assert (string= (match-string 1) "a")) (re-search-forward "b") (Assert (string= (match-string 0) "b")) (Assert (string= (match-string 1) nil))) ;; Test word boundaries (Assert (= (string-match "\\<a" " a") 1)) (Assert (= (string-match "a\\>" "a ") 0)) (Assert (= (string-match "\\ba" " a") 1)) (Assert (= (string-match "a\\b" "a ") 0)) ;; should work at target boundaries (Assert (= (string-match "\\<a" "a") 0)) (Assert (= (string-match "a\\>" "a") 0)) (Assert (= (string-match "\\ba" "a") 0)) (Assert (= (string-match "a\\b" "a") 0)) ;; Check for weirdness (Assert (not (string-match " \\> " " "))) (Assert (not (string-match " \\< " " "))) (Assert (not (string-match " \\b " " "))) ;; but not if the "word" would be on the null side of the boundary! (Assert (not (string-match "\\<" ""))) (Assert (not (string-match "\\>" ""))) (Assert (not (string-match " \\<" " "))) (Assert (not (string-match "\\> " " "))) (Assert (not (string-match "a\\<" "a"))) (Assert (not (string-match "\\>a" "a"))) ;; Added Known-Bug 2002-09-09 sjt ;; Fixed bug 2003-03-21 sjt (Assert (not (string-match "\\b" ""))) (Assert (not (string-match "\\b" " "))) (Assert (not (string-match " \\b" " "))) (Assert (not (string-match "\\b " " "))) ;; Character classes are broken in Mule as of 21.5.9 ;; Added Known-Bug 2002-12-27 ;; Fixed by Daiki Ueno 2003-03-24 (if (featurep 'mule) ;; note: (int-to-char 65) => ?A (let ((ch0 (make-char 'japanese-jisx0208 52 65)) (ch1 (make-char 'japanese-jisx0208 51 65))) (Assert (not (string-match "A" (string ch0)))) (Assert (not (string-match "[A]" (string ch0)))) (Assert (eq (string-match "[^A]" (string ch0)) 0)) (Assert (not (string-match "@A" (string ?@ ch0)))) (Assert (not (string-match "@[A]" (string ?@ ch0)))) (Assert (eq (string-match "@[^A]" (string ?@ ch0)) 0)) (Assert (not (string-match "@?A" (string ?@ ch0)))) (Assert (not (string-match "A" (string ch1)))) (Assert (not (string-match "[A]" (string ch1)))) (Assert (eq (string-match "[^A]" (string ch1)) 0)) (Assert (not (string-match "@A" (string ?@ ch1)))) (Assert (not (string-match "@[A]" (string ?@ ch1)))) (Assert (eq (string-match "@[^A]" (string ?@ ch1)) 0)) (Assert (not (string-match "@?A" (string ?@ ch1)))) ) ) ;; More stale match data tests. ;; Thanks to <bjacob@ca.metsci.com>. ;; These tests used to fail because we cleared match data only on success. ;; Fixed 2003-04-17. ;; Must change sense of failing tests 2003-05-09. Too much code depends on ;; failed matches preserving match-data. (let ((a "a")) (Assert (string= (progn (string-match "a" a) (string-match "b" a) (match-string 0 a)) a)) (Assert (not (progn (string-match "a" a) (string-match "b" a) (match-string 1 a)))) ;; test both for the second match is a plain string match and a regexp match (Assert (string= (progn (string-match "\\(a\\)" a) (string-match "\\(b\\)" a) (match-string 0 a)) a)) (Assert (string= (progn (string-match "\\(a\\)" a) (string-match "b" a) (match-string 0 a)) a)) (Assert (string= (progn (string-match "\\(a\\)" a) (string-match "\\(b\\)" a) (match-string 1 a)) a)) (Assert (string= (progn (string-match "\\(a\\)" a) (string-match "b" a) (match-string 1 a)) a)) ;; in 21.4.16, registers from num_shy_groups to num_groups were not cleared, ;; resulting in stale match data (Assert (progn (string-match "\\(a\\)" a) (string-match "\\(?:a\\)" a) (not (match-beginning 1)))) ) ;; bug identified by Katsumi Yamaoka 2004-09-03 <b9ywtzbbpue.fsf_-_@jpl.org> ;; fix submitted by sjt 2004-09-08 ;; trailing comments are values from buggy 21.4.15 (let ((text "abc")) (Assert (eq 0 (string-match "\\(?:ab+\\)*c" text))) ; 2 (Assert (eq 0 (string-match "^\\(?:ab+\\)*c" text))) ; nil (Assert (eq 0 (string-match "^\\(?:ab+\\)*" text))) ; 0 (Assert (eq 0 (string-match "^\\(?:ab+\\)c" text))) ; 0 (Assert (eq 0 (string-match "^\\(?:ab\\)*c" text))) ; 0 (Assert (eq 0 (string-match "^\\(?:a+\\)*b" text))) ; nil (Assert (eq 0 (string-match "^\\(?:a\\)*b" text))) ; 0 ) ;; per Steve Youngs 2004-09-30 <microsoft-free.87ekkjhj7t.fsf@youngs.au.com> ;; fix submitted by sjt 2004-10-07 ;; trailing comments are values from buggy 21.4.pre16 (let ((text "abc")) (Assert (eq 0 (string-match "\\(?:a\\(b\\)\\)" text))) ; 0 (Assert (string= (match-string 1 text) "b")) ; ab (Assert (null (match-string 2 text))) ; b (Assert (null (match-string 3 text))) ; nil (Assert (eq 0 (string-match "\\(?:a\\(?:b\\(c\\)\\)\\)" text))) ; 0 (Assert (string= (match-string 1 text) "c")) ; abc (Assert (null (match-string 2 text))) ; ab (Assert (null (match-string 3 text))) ; c (Assert (null (match-string 4 text))) ; nil ) ;; trivial subpatterns and backreferences with shy groups (let ((text1 "abb") (text2 "aba") (re0 "\\(a\\)\\(b\\)\\2") (re1 "\\(?:a\\)\\(b\\)\\2") (re2 "\\(?:a\\)\\(b\\)\\1") (re3 "\\(a\\)\\(?:b\\)\\1")) (Assert (eq 0 (string-match re0 text1))) (Assert (string= text1 (match-string 0 text1))) (Assert (string= "a" (match-string 1 text1))) (Assert (string= "b" (match-string 2 text1))) (Assert (null (string-match re0 text2))) (Check-Error-Message 'invalid-regexp "Invalid back reference" (string-match re1 text1)) (Assert (eq 0 (string-match re2 text1))) (Assert (string= text1 (match-string 0 text1))) (Assert (string= "b" (match-string 1 text1))) (Assert (null (match-string 2 text1))) (Assert (null (string-match re2 text2))) (Assert (null (string-match re3 text1))) (Assert (eq 0 (string-match re3 text2))) (Assert (string= text2 (match-string 0 text2))) (Assert (string= "a" (match-string 1 text2))) (Assert (null (match-string 2 text2))) ) ;; replace-regexp-in-string (regexp rep source ;; fixedcase literal buf-or-subexp start) ;; Currently we test the following cases: ;; where `cbuf' and `bar-or-empty' are bound below. ;; #### Tests for the various functional features (fixedcase, literal, start) ;; should be added. (with-temp-buffer (flet ((bar-or-empty (subexp) (if (string= subexp "foo") "bar" ""))) (let ((cbuf (current-buffer))) (dolist (test-case ;; REP BUF-OR-SUBEXP EXPECTED RESULT `(("bar" nil " bar") ("bar" ,cbuf " bar") ("bar" 0 " bar") ("bar" 1 " bar foo") (bar-or-empty nil " ") (bar-or-empty ,cbuf " ") (bar-or-empty 0 " ") (bar-or-empty 1 " bar foo"))) (Assert (string= (nth 2 test-case) (replace-regexp-in-string "\\(foo\\).*\\'" (nth 0 test-case) " foo foo" nil nil (nth 1 test-case))))) ;; #### Why doesn't this loop work right? ; (dolist (test-case ; ;; REP BUF-OR-SUBEXP EXPECTED ERROR EXPECTED MESSAGE ; `(;; expected message was "bufferp, symbol" up to 21.5.28 ; ("bar" 'symbol wrong-type-argument "integerp, symbol") ; ("bar" -1 invalid-argument ; "match data register invalid, -1") ; ("bar" 2 invalid-argument ; "match data register not set, 2") ; )) ; (eval ; `(Check-Error-Message ,(nth 2 test-case) ,(nth 3 test-case) ; (replace-regexp-in-string "\\(foo\\).*\\'" ,(nth 0 test-case) ; " foo foo" nil nil ,(nth 1 test-case))))) ;; #### Can't test the message with w-t-a, see test-harness.el. (Check-Error wrong-type-argument (replace-regexp-in-string "\\(foo\\).*\\'" "bar" " foo foo" nil nil 'symbol)) ;; #### Can't test the FROB (-1), see test-harness.el. (Check-Error-Message invalid-argument "match data register invalid" (replace-regexp-in-string "\\(foo\\).*\\'" "bar" " foo foo" nil nil -1)) ;; #### Can't test the FROB (-1), see test-harness.el. (Check-Error-Message invalid-argument "match data register not set" (replace-regexp-in-string "\\(foo\\).*\\'" "bar" " foo foo" nil nil 2)) ))) ;; Not very comprehensive tests of skip-chars-forward, skip-chars-background: (with-string-as-buffer-contents "-]-----------------------------][]]------------------------" (goto-char (point-min)) (skip-chars-forward (skip-chars-quote "-[]")) (Assert (= (point) (point-max))) (skip-chars-backward (skip-chars-quote "-[]")) (Assert (= (point) (point-min))) ;; Testing in passing for an old bug in #'skip-chars-forward where I ;; thought it was impossible to call it with a string containing only ?- ;; and ?]: (Assert (= (skip-chars-forward (skip-chars-quote "-]")) (position ?[ (buffer-string) :test #'=))) ;; This used to error, incorrectly: (Assert (skip-chars-quote "[-"))) ;; replace-match (REPLACEMENT &optional FIXEDCASE LITERAL STRING STRBUFFER) ;; #### Write some tests! Much functionality is implicitly tested above ;; via `replace-regexp-in-string', but we should specifically test bogus ;; combinations of STRING and STRBUFFER. ;; empty string at point ;; Thanks Julian Bradford on XEmacs Beta ;; <18652.54975.894512.880956@krk.inf.ed.ac.uk> (with-string-as-buffer-contents "aáa" (goto-char (point-min)) (Assert (looking-at "\\=")) (Assert (= (re-search-forward "\\=") 1)) (forward-char 1) (Assert (looking-at "\\=")) (Assert (= (re-search-forward "\\=") 2)) (forward-char 1) (Assert (looking-at "\\=")) (Assert (= (re-search-forward "\\=") 3)) (forward-char 1) (Assert (looking-at "\\=")) (Assert (= (re-search-forward "\\=") 4)))