Mercurial > hg > xemacs-beta
view src/extents-impl.h @ 5169:6c6d78781d59
cleanup of code related to xfree(), better KKCC backtrace capabilities, document XD_INLINE_LISP_OBJECT_BLOCK_PTR, fix some memory leaks, other code cleanup
-------------------- ChangeLog entries follow: --------------------
src/ChangeLog addition:
2010-03-24 Ben Wing <ben@xemacs.org>
* array.h:
* array.h (XD_LISP_DYNARR_DESC):
* dumper.c (pdump_register_sub):
* dumper.c (pdump_store_new_pointer_offsets):
* dumper.c (pdump_reloc_one_mc):
* elhash.c:
* gc.c (lispdesc_one_description_line_size):
* gc.c (kkcc_marking):
* lrecord.h:
* lrecord.h (IF_NEW_GC):
* lrecord.h (enum memory_description_type):
* lrecord.h (enum data_description_entry_flags):
* lrecord.h (struct opaque_convert_functions):
Rename XD_LISP_OBJECT_BLOCK_PTR to XD_INLINE_LISP_OBJECT_BLOCK_PTR
and document it in lrecord.h.
* data.c:
* data.c (finish_marking_weak_lists):
* data.c (continue_marking_ephemerons):
* data.c (finish_marking_ephemerons):
* elhash.c (MARK_OBJ):
* gc.c:
* gc.c (lispdesc_indirect_count_1):
* gc.c (struct):
* gc.c (kkcc_bt_push):
* gc.c (kkcc_gc_stack_push):
* gc.c (kkcc_gc_stack_push_lisp_object):
* gc.c (kkcc_gc_stack_repush_dirty_object):
* gc.c (KKCC_DO_CHECK_FREE):
* gc.c (mark_object_maybe_checking_free):
* gc.c (mark_struct_contents):
* gc.c (mark_lisp_object_block_contents):
* gc.c (register_for_finalization):
* gc.c (mark_object):
* gc.h:
* lisp.h:
* profile.c:
* profile.c (mark_profiling_info_maphash):
Clean up KKCC code related to DEBUG_XEMACS. Rename
kkcc_backtrace() to kkcc_backtrace_1() and add two params: a
`size' arg to control how many stack elements to print and a
`detailed' arg to control whether Lisp objects are printed using
`debug_print()'. Create front-ends to kkcc_backtrace_1() --
kkcc_detailed_backtrace(), kkcc_short_backtrace(),
kkcc_detailed_backtrace_full(), kkcc_short_backtrace_full(), as
well as shortened versions kbt(), kbts(), kbtf(), kbtsf() -- to
call it with various parameter values. Add an `is_lisp' field to
the stack and backtrace structures and use it to keep track of
whether an object pushed onto the stack is a Lisp object or a
non-Lisp structure; in kkcc_backtrace_1(), don't try to print a
non-Lisp structure as a Lisp object.
* elhash.c:
* extents.c:
* file-coding.c:
* lrecord.h:
* lrecord.h (IF_NEW_GC):
* marker.c:
* marker.c (Fmarker_buffer):
* mule-coding.c:
* number.c:
* rangetab.c:
* specifier.c:
New macros IF_OLD_GC(), IF_NEW_GC() to simplify declaration of
Lisp objects when a finalizer may exist in one but not the other.
Use them appropriately.
* extents.c (finalize_extent_info):
Don't zero out data->soe and data->extents before trying to free,
else we get memory leaks.
* lrecord.h (enum lrecord_type):
Make the first lrecord type have value 1 not 0 so that 0 remains
without implementation and attempts to interpret zeroed memory
as a Lisp object will be more obvious.
* array.c (Dynarr_free):
* device-msw.c (msprinter_delete_device):
* device-tty.c (free_tty_device_struct):
* device-tty.c (tty_delete_device):
* dialog-msw.c (handle_directory_dialog_box):
* dialog-x.c:
* emacs.c (free_argc_argv):
* emodules.c (attempt_module_delete):
* file-coding.c (chain_finalize_coding_stream_1):
* file-coding.c (chain_finalize_coding_stream):
* glyphs-eimage.c:
* glyphs-eimage.c (jpeg_instantiate_unwind):
* glyphs-eimage.c (gif_instantiate_unwind):
* glyphs-eimage.c (png_instantiate_unwind):
* glyphs-eimage.c (tiff_instantiate_unwind):
* imgproc.c:
* imgproc.c (build_EImage_quantable):
* insdel.c (uninit_buffer_text):
* mule-coding.c (iso2022_finalize_detection_state):
* objects-tty.c (tty_finalize_color_instance):
* objects-tty.c (tty_finalize_font_instance):
* objects-tty.c (tty_font_list):
* process.c:
* process.c (finalize_process):
* redisplay.c (add_propagation_runes):
* scrollbar-gtk.c:
* scrollbar-gtk.c (gtk_free_scrollbar_instance):
* scrollbar-gtk.c (gtk_release_scrollbar_instance):
* scrollbar-msw.c:
* scrollbar-msw.c (mswindows_free_scrollbar_instance):
* scrollbar-msw.c (unshow_that_mofo):
* scrollbar-x.c (x_free_scrollbar_instance):
* scrollbar-x.c (x_release_scrollbar_instance):
* select-x.c:
* select-x.c (x_handle_selection_request):
* syntax.c:
* syntax.c (uninit_buffer_syntax_cache):
* text.h (eifree):
If possible, whenever we call xfree() on a field in a structure,
set the field to 0 afterwards. A lot of code is written so that
it checks the value being freed to see if it is non-zero before
freeing it -- doing this and setting the value to 0 afterwards
ensures (a) we won't try to free twice if the cleanup code is
called twice; (b) if the object itself stays around, KKCC won't
crash when attempting to mark the freed field.
* rangetab.c:
Add a finalization method when not NEW_GC to avoid memory leaks.
(#### We still get memory leaks when NEW_GC; need to convert gap
array to Lisp object).
author | Ben Wing <ben@xemacs.org> |
---|---|
date | Wed, 24 Mar 2010 01:22:51 -0500 |
parents | a9c41067dd88 |
children | 308d34e9f07d |
line wrap: on
line source
/* Copyright (c) 1994, 1995 Free Software Foundation. Copyright (c) 1995, 1996, 2002, 2010 Ben Wing. This file is part of XEmacs. XEmacs is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation; either version 2, or (at your option) any later version. XEmacs is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details. You should have received a copy of the GNU General Public License along with XEmacs; see the file COPYING. If not, write to the Free Software Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ /* Synched up with: Not in FSF. */ #ifndef INCLUDED_extents_impl_h_ #define INCLUDED_extents_impl_h_ #include "extents.h" struct extent { FROB_BLOCK_LISP_OBJECT_HEADER lheader; Memxpos start; Memxpos end; Lisp_Object object; /* A buffer, string, Qnil (extent detached from no buffer), Qt (destroyed extent) */ /* Extent properties are conceptually a plist, but the most common props are implemented as bits instead of conses. */ struct { Lisp_Object face; /* These flags are simply an optimization for common boolean properties which go onto the extent's property list. Any of them would work if done in the normal way, but the space savings of doing these in this way is significant. Note that if you add a flag, there are numerous places in extents.c that need to know about it. Another consideration is that some of these properties are accessed during redisplay, so it's good for access to them to be fast (a bit reference instead of a search down a plist). `begin_glyph_layout' and `end_glyph_layout' are unusual in that they have 4 states instead of 2. Other special extent properties are stored in an auxiliary structure that sits at the beginning of the plist. The has_aux flag indicates whether this structure exists. The has_parent flag is an optimization indicating whether the extent has a parent (this could also be determined by looking in the aux structure). */ enum_field (glyph_layout) begin_glyph_layout :2; /* 2 text, margins, or whitespace */ enum_field (glyph_layout) end_glyph_layout :2; /* 4 text, margins, or whitespace */ unsigned int has_parent :1; /* 5 extent has a parent */ unsigned int has_aux :1; /* 6 extent has an aux. structure */ unsigned int start_open :1; /* 7 insertion behavior at start */ unsigned int end_open :1; /* 8 insertion behavior at end */ unsigned int unique :1; /* 9 there may be only one attached */ unsigned int duplicable :1; /* 10 copied to strings by kill/undo */ unsigned int detachable :1; /* 11 extent detaches if text deleted */ unsigned int internal :1; /* 12 used by map-extents etc. */ unsigned int in_red_event :1; /* 13 An event has been spawned for initial redisplay. (not exported to lisp) */ unsigned int unused16 :1; /* 16 unused bits */ /* --- Adding more flags will cause the extent struct to grow by another word. It's not clear that this would make a difference, however, because on 32-bit machines things tend to get allocated in chunks of 4 bytes. */ } flags; /* The plist may have an auxiliary structure as its first element */ Lisp_Object plist; }; /* Basic properties of an extent (not affected by the extent's parent) */ #define extent_object(e) ((e)->object) #define extent_start(e) ((e)->start + 0) #define extent_end(e) ((e)->end + 0) #define set_extent_start(e, val) ((void) ((e)->start = (val))) #define set_extent_end(e, val) ((void) ((e)->end = (val))) #define extent_endpoint(e, endp) ((endp) ? extent_end (e) : extent_start (e)) #define set_extent_endpoint(e, val, endp) \ ((endp) ? set_extent_end (e, val) : set_extent_start (e, val)) #define extent_detached_p(e) (extent_start (e) < 0) /* Additional information that may be present in an extent. The idea is that fast access is provided to this information, but since (hopefully) most extents won't have this set on them, we usually don't need to have this structure around and thus the size of an extent is smaller. */ typedef struct extent_auxiliary extent_auxiliary; #define EXTENT_AUXILIARY_SLOTS \ SLOT (begin_glyph) \ SLOT (end_glyph) \ SLOT (parent) \ /* We use a weak list here. Originally I didn't do this and \ depended on having the extent's finalization method remove \ itself from its parent's children list. This runs into \ lots and lots of problems though because everything is in \ a really really bizarre state when an extent's finalization \ method is called (it happens in sweep_extents() by way of \ ADDITIONAL_FREE_extent()) and it's extremely difficult to \ avoid getting hosed by just-freed objects. */ \ SLOT (children) \ SLOT (invisible) \ SLOT (read_only) \ SLOT (mouse_face) \ SLOT (initial_redisplay_function) \ SLOT (before_change_functions) \ SLOT (after_change_functions) struct extent_auxiliary { NORMAL_LISP_OBJECT_HEADER header; #define SLOT(x) Lisp_Object x; EXTENT_AUXILIARY_SLOTS #undef SLOT int priority; }; extern Lisp_Object Vextent_auxiliary_defaults; struct extent_info { NORMAL_LISP_OBJECT_HEADER header; struct extent_list *extents; struct stack_of_extents *soe; }; /* A "normal" field is one that is stored in the `struct flags' structure in an extent. an "aux" field is one that is stored in the extent's auxiliary structure. The functions below that have `extent_no_chase' in their name operate on an extent directly (ignoring its parent), and should normally only be used on extents known not to have a parent. The other versions chase down any parent links. */ #define extent_no_chase_normal_field(e, field) ((e)->flags.field) DECLARE_INLINE_HEADER ( struct extent_auxiliary * extent_aux_or_default (EXTENT e) ) { return e->flags.has_aux ? XEXTENT_AUXILIARY (XCAR (e->plist)) : XEXTENT_AUXILIARY (Vextent_auxiliary_defaults); } #define extent_no_chase_aux_field(e, field) (extent_aux_or_default(e)->field) #define extent_normal_field(e, field) \ extent_no_chase_normal_field (extent_ancestor (e), field) #define extent_aux_field(e, field) \ extent_no_chase_aux_field (extent_ancestor (e), field) #define set_extent_no_chase_aux_field(e, field, value) do { \ EXTENT sencaf_e = (e); \ if (! sencaf_e->flags.has_aux) \ attach_extent_auxiliary (sencaf_e); \ XEXTENT_AUXILIARY (XCAR (sencaf_e->plist))->field = (value); \ } while (0) #define set_extent_no_chase_normal_field(e, field, value) \ extent_no_chase_normal_field (e, field) = (value) #define set_extent_aux_field(e, field, value) \ set_extent_no_chase_aux_field (extent_ancestor (e), field, value) #define set_extent_normal_field(e, field, value) \ set_extent_no_chase_normal_field (extent_ancestor (e), field, value) /* The `parent' and `children' fields are not affected by any parent links. We don't provide any settors for these fields because they need special handling and it's cleaner just to do this in the particular functions that need to do this. */ #define extent_parent(e) extent_no_chase_aux_field (e, parent) #define extent_children(e) extent_no_chase_aux_field (e, children) EXTENT extent_ancestor_1 (EXTENT e); /* extent_ancestor() chases all the parent links until there aren't any more. extent_ancestor_1() does the same thing but it a function; the following optimizes the most common case. */ DECLARE_INLINE_HEADER ( EXTENT extent_ancestor (EXTENT e) ) { return e->flags.has_parent ? extent_ancestor_1 (e) : e; } #define extent_begin_glyph(e) extent_aux_field (e, begin_glyph) #define extent_end_glyph(e) extent_aux_field (e, end_glyph) #define extent_priority(e) extent_aux_field (e, priority) #define extent_invisible(e) extent_aux_field (e, invisible) #define extent_read_only(e) extent_aux_field (e, read_only) #define extent_mouse_face(e) extent_aux_field (e, mouse_face) #define extent_initial_redisplay_function(e) extent_aux_field (e, initial_redisplay_function) #define extent_before_change_functions(e) extent_aux_field (e, before_change_functions) #define extent_after_change_functions(e) extent_aux_field (e, after_change_functions) #define set_extent_begin_glyph(e, value) \ set_extent_aux_field (e, begin_glyph, value) #define set_extent_end_glyph(e, value) \ set_extent_aux_field (e, end_glyph, value) #define set_extent_priority(e, value) \ set_extent_aux_field (e, priority, value) #define set_extent_invisible_1(e, value) \ set_extent_aux_field (e, invisible, value) #define set_extent_read_only(e, value) \ set_extent_aux_field (e, read_only, value) #define set_extent_mouse_face(e, value) \ set_extent_aux_field (e, mouse_face, value) /* Use Fset_extent_initial_redisplay_function unless you know what you're doing */ #define set_extent_initial_redisplay_function(e, value) \ set_extent_aux_field (e, initial_redisplay_function, value) #define set_extent_before_change_functions(e, value) \ set_extent_aux_field (e, before_change_functions, value) #define set_extent_after_change_functions(e, value) \ set_extent_aux_field (e, after_change_functions, value) #define extent_face(e) extent_normal_field (e, face) #define extent_begin_glyph_layout(e) ((enum glyph_layout) extent_normal_field (e, begin_glyph_layout)) #define extent_end_glyph_layout(e) ((enum glyph_layout) extent_normal_field (e, end_glyph_layout)) #define extent_start_open_p(e) extent_normal_field (e, start_open) #define extent_end_open_p(e) extent_normal_field (e, end_open) #define extent_unique_p(e) extent_normal_field (e, unique) #define extent_duplicable_p(e) extent_normal_field (e, duplicable) #define extent_detachable_p(e) extent_normal_field (e, detachable) #define extent_internal_p(e) extent_normal_field (e, internal) #define extent_in_red_event_p(e) extent_normal_field (e, in_red_event) #define set_extent_face(e, val) \ set_extent_normal_field (e, face, val) #define set_extent_begin_glyph_layout(e, val) \ set_extent_normal_field (e, begin_glyph_layout, val) #define set_extent_end_glyph_layout(e, val) \ set_extent_normal_field (e, end_glyph_layout, val) #define set_extent_start_open_p(e, val) \ set_extent_normal_field (e, start_open, val) #define set_extent_end_open_p(e, val) \ set_extent_normal_field (e, end_open, val) #define set_extent_unique_p(e, val) \ set_extent_normal_field (e, unique, val) #define set_extent_duplicable_p(e, val) \ set_extent_normal_field (e, duplicable, val) #define set_extent_detachable_p(e, val) \ set_extent_normal_field (e, detachable, val) #define set_extent_internal_p(e, val) \ set_extent_normal_field (e, internal, val) #define set_extent_in_red_event_p(e, val) \ set_extent_normal_field (e, in_red_event, val) DECLARE_INLINE_HEADER ( Lisp_Object * extent_no_chase_plist_addr (EXTENT e) ) { return e->flags.has_aux ? &XCDR (e->plist) : &e->plist; } #define extent_no_chase_plist(e) (*extent_no_chase_plist_addr (e)) #define extent_plist_addr(e) extent_no_chase_plist_addr (extent_ancestor (e)) #define extent_plist_slot(e) extent_no_chase_plist (extent_ancestor (e)) #define EXTENT_LIVE_P(e) (!EQ (extent_object (e), Qt)) #define CHECK_LIVE_EXTENT(x) do { \ CHECK_EXTENT (x); \ if (!EXTENT_LIVE_P (XEXTENT (x))) \ dead_wrong_type_argument (Qextent_live_p, (x)); \ } while (0) #define CONCHECK_LIVE_EXTENT(x) do { \ CONCHECK_EXTENT (x); \ if (!EXTENT_LIVE_P (XEXTENT (x))) \ x = wrong_type_argument (Qextent_live_p, (x)); \ } while (0) #endif /* INCLUDED_extents_impl_h_ */