view src/dialog-msw.c @ 5353:38e24b8be4ea

Improve the lexical scoping in #'block, #'return-from. lisp/ChangeLog addition: 2011-02-07 Aidan Kehoe <kehoea@parhasard.net> * bytecomp.el: * bytecomp.el (byte-compile-initial-macro-environment): Shadow `block', `return-from' here, we implement them differently when byte-compiling. * bytecomp.el (byte-compile-active-blocks): New. * bytecomp.el (byte-compile-block-1): New. * bytecomp.el (byte-compile-return-from-1): New. * bytecomp.el (return-from-1): New. * bytecomp.el (block-1): New. These are two aliases that exist to have their own associated byte-compile functions, which functions implement `block' and `return-from'. * cl-extra.el (cl-macroexpand-all): Fix a bug here when macros in the environment have been compiled. * cl-macs.el (block): * cl-macs.el (return): * cl-macs.el (return-from): Be more careful about lexical scope in these macros. * cl.el: * cl.el ('cl-block-wrapper): Removed. * cl.el ('cl-block-throw): Removed. These aren't needed in code generated by this XEmacs. They shouldn't be needed in code generated by XEmacs 21.4, but if it turns out the packages do need them, we can put them back. 2011-01-30 Mike Sperber <mike@xemacs.org> * font-lock.el (font-lock-fontify-pending-extents): Don't fail if `font-lock-mode' is unset, which can happen in the middle of `revert-buffer'. 2011-01-23 Aidan Kehoe <kehoea@parhasard.net> * cl-macs.el (delete): * cl-macs.el (delq): * cl-macs.el (remove): * cl-macs.el (remq): Don't use the compiler macro if these functions were given the wrong number of arguments, as happens in lisp-tests.el. * cl-seq.el (remove, remq): Removed. I added these to subr.el, and forgot to remove them from here. 2011-01-22 Aidan Kehoe <kehoea@parhasard.net> * bytecomp.el (byte-compile-setq, byte-compile-set): Remove kludge allowing keywords' values to be set, all the code that does that is gone. * cl-compat.el (elt-satisfies-test-p): * faces.el (set-face-parent): * faces.el (face-doc-string): * gtk-font-menu.el: * gtk-font-menu.el (gtk-reset-device-font-menus): * msw-font-menu.el: * msw-font-menu.el (mswindows-reset-device-font-menus): * package-get.el (package-get-installedp): * select.el (select-convert-from-image-data): * sound.el: * sound.el (load-sound-file): * x-font-menu.el (x-reset-device-font-menus-core): Don't quote keywords, they're self-quoting, and the win from backward-compatibility is sufficiently small now that the style problem overrides it. 2011-01-22 Aidan Kehoe <kehoea@parhasard.net> * cl-macs.el (block, return-from): Require that NAME be a symbol in these macros, as always documented in the #'block docstring and as required by Common Lisp. * descr-text.el (unidata-initialize-unihan-database): Correct the use of non-symbols in #'block and #'return-from in this function. 2011-01-15 Aidan Kehoe <kehoea@parhasard.net> * cl-extra.el (concatenate): Accept more complicated TYPEs in this function, handing the sequences over to #'coerce if we don't understand them here. * cl-macs.el (inline): Don't proclaim #'concatenate as inline, its compiler macro is more useful than doing that. 2011-01-11 Aidan Kehoe <kehoea@parhasard.net> * subr.el (delete, delq, remove, remq): Move #'remove, #'remq here, they don't belong in cl-seq.el; move #'delete, #'delq here from fns.c, implement them in terms of #'delete*, allowing support for sequences generally. * update-elc.el (do-autoload-commands): Use #'delete*, not #'delq here, now the latter's no longer dumped. * cl-macs.el (delete, delq): Add compiler macros transforming #'delete and #'delq to #'delete* calls. 2011-01-10 Aidan Kehoe <kehoea@parhasard.net> * dialog.el (make-dialog-box): Correct a misplaced parenthesis here, thank you Mats Lidell in 87zkr9gqrh.fsf@mail.contactor.se ! 2011-01-02 Aidan Kehoe <kehoea@parhasard.net> * dialog.el (make-dialog-box): * list-mode.el (display-completion-list): These functions used to use cl-parsing-keywords; change them to use defun* instead, fixing the build. (Not sure what led to me not including this change in d1b17a33450b!) 2011-01-02 Aidan Kehoe <kehoea@parhasard.net> * cl-macs.el (define-star-compiler-macros): Make sure the form has ITEM and LIST specified before attempting to change to calls with explicit tests; necessary for some tests in lisp-tests.el to compile correctly. (stable-union, stable-intersection): Add compiler macros for these functions, in the same way we do for most of the other functions in cl-seq.el. 2011-01-01 Aidan Kehoe <kehoea@parhasard.net> * cl-macs.el (dolist, dotimes, do-symbols, macrolet) (symbol-macrolet): Define these macros with defmacro* instead of parsing the argument list by hand, for the sake of style and readability; use backquote where appropriate, instead of calling #'list and and friends, for the same reason. 2010-12-30 Aidan Kehoe <kehoea@parhasard.net> * x-misc.el (device-x-display): Provide this function, documented in the Lispref for years, but not existing previously. Thank you Julian Bradfield, thank you Jeff Mincy. 2010-12-30 Aidan Kehoe <kehoea@parhasard.net> * cl-seq.el: Move the heavy lifting from this file to C. Dump the cl-parsing-keywords macro, but don't use defun* for the functions we define that do take keywords, dynamic scope lossage makes that not practical. * subr.el (sort, fillarray): Move these aliases here. (map-plist): #'nsublis is now built-in, but at this point #'eql isn't necessarily available as a test; use #'eq. * obsolete.el (cl-delete-duplicates): Make this available for old compiler macros and old code. (memql): Document that this is equivalent to #'member*, and worse. * cl.el (adjoin, subst): Removed. These are in C. 2010-12-30 Aidan Kehoe <kehoea@parhasard.net> * simple.el (assoc-ignore-case): Remove a duplicate definition of this function (it's already in subr.el). * iso8859-1.el (char-width): On non-Mule, make this function equivalent to that produced by (constantly 1), but preserve its docstring. * subr.el (subst-char-in-string): Define this in terms of #'substitute, #'nsubstitute. (string-width): Define this using #'reduce and #'char-width. (char-width): Give this a simpler definition, it makes far more sense to check for mule at load time and redefine, as we do in iso8859-1.el. (store-substring): Implement this in terms of #'replace, now #'replace is cheap. 2010-12-30 Aidan Kehoe <kehoea@parhasard.net> * update-elc.el (lisp-files-needed-for-byte-compilation) (lisp-files-needing-early-byte-compilation): cl-macs belongs in the former, not the latter, it is as fundamental as bytecomp.el. 2010-12-30 Aidan Kehoe <kehoea@parhasard.net> * cl.el: Provde the Common Lisp program-error, type-error as error symbols. This doesn't nearly go far enough for anyone using the Common Lisp errors. 2010-12-29 Aidan Kehoe <kehoea@parhasard.net> * cl-macs.el (delete-duplicates): If the form has an incorrect number of arguments, don't attempt a compiler macroexpansion. 2010-12-29 Aidan Kehoe <kehoea@parhasard.net> * cl-macs.el (cl-safe-expr-p): Forms that start with the symbol lambda are also safe. 2010-12-29 Aidan Kehoe <kehoea@parhasard.net> * cl-macs.el (= < > <= >=): For these functions' compiler macros, the optimisation is safe even if the first and the last arguments have side effects, since they're only used the once. 2010-12-29 Aidan Kehoe <kehoea@parhasard.net> * cl-macs.el (inline-side-effect-free-compiler-macros): Unroll a loop here at macro-expansion time, so these compiler macros are compiled. Use #'eql instead of #'eq in a couple of places for better style. 2010-12-29 Aidan Kehoe <kehoea@parhasard.net> * cl-extra.el (notany, notevery): Avoid some dynamic scope stupidity with local variable names in these functions, when they weren't prefixed with cl-; go into some more detail in the doc strings. 2010-12-29 Aidan Kehoe <kehoea@parhasard.net> * byte-optimize.el (side-effect-free-fns): #'remove, #'remq are free of side-effects. (side-effect-and-error-free-fns): Drop dot, dot-marker from the list. 2010-11-17 Aidan Kehoe <kehoea@parhasard.net> * cl-extra.el (coerce): In the argument list, name the first argument OBJECT, not X; the former name was always used in the doc string and is clearer. Handle vector type specifications which include the length of the target sequence, error if there's a mismatch. * cl-macs.el (cl-make-type-test): Handle type specifications starting with the symbol 'eql. 2010-11-14 Aidan Kehoe <kehoea@parhasard.net> * cl-macs.el (eql): Don't remove the byte-compile property of this symbol. That was necessary to override a bug in bytecomp.el where #'eql was confused with #'eq, which bug we no longer have. If neither expression is constant, don't attempt to handle the expression in this compiler macro, leave it to byte-compile-eql, which produces better code anyway. * bytecomp.el (eq): #'eql is not the function associated with the byte-eq byte code. (byte-compile-eql): Add an explicit compile method for this function, for cases where the cl-macs compiler macro hasn't reduced it to #'eq or #'equal. 2010-10-25 Aidan Kehoe <kehoea@parhasard.net> Add compiler macros and compilation sanity-checking for various functions that take keywords. * byte-optimize.el (side-effect-free-fns): #'symbol-value is side-effect free and not error free. * bytecomp.el (byte-compile-normal-call): Check keyword argument lists for sanity; store information about the positions where keyword arguments start using the new byte-compile-keyword-start property. * cl-macs.el (cl-const-expr-val): Take a new optional argument, cl-not-constant, defaulting to nil, in this function; return it if the expression is not constant. (cl-non-fixnum-number-p): Make this into a separate function, we want to pass it to #'every. (eql): Use it. (define-star-compiler-macros): Use the same code to generate the member*, assoc* and rassoc* compiler macros; special-case some code in #'add-to-list in subr.el. (remove, remq): Add compiler macros for these two functions, in preparation for #'remove being in C. (define-foo-if-compiler-macros): Transform (remove-if-not ...) calls to (remove ... :if-not) at compile time, which will be a real win once the latter is in C. (define-substitute-if-compiler-macros) (define-subst-if-compiler-macros): Similarly for these functions. (delete-duplicates): Change this compiler macro to use #'plists-equal; if we don't have information about the type of SEQUENCE at compile time, don't bother attempting to inline the call, the function will be in C soon enough. (equalp): Remove an old commented-out compiler macro for this, if we want to see it it's in version control. (subst-char-in-string): Transform this to a call to nsubstitute or nsubstitute, if that is appropriate. * cl.el (ldiff): Don't call setf here, this makes for a load-time dependency problem in cl-macs.el 2010-06-14 Stephen J. Turnbull <stephen@xemacs.org> * term/vt100.el: Refer to XEmacs, not GNU Emacs, in permissions. * term/bg-mouse.el: * term/sup-mouse.el: Put copyright notice in canonical "Copyright DATE AUTHOR" form. Refer to XEmacs, not GNU Emacs, in permissions. * site-load.el: Add permission boilerplate. * mule/canna-leim.el: * alist.el: Refer to XEmacs, not APEL/this program, in permissions. * mule/canna-leim.el: Remove my copyright, I've assigned it to the FSF. 2010-06-14 Stephen J. Turnbull <stephen@xemacs.org> * gtk.el: * gtk-widget-accessors.el: * gtk-package.el: * gtk-marshal.el: * gtk-compose.el: * gnome.el: Add copyright notice based on internal evidence. 2010-06-14 Stephen J. Turnbull <stephen@xemacs.org> * easymenu.el: Add reference to COPYING to permission notice. * gutter.el: * gutter-items.el: * menubar-items.el: Fix typo "Xmacs" in permissions notice. 2010-06-14 Stephen J. Turnbull <stephen@xemacs.org> * auto-save.el: * font.el: * fontconfig.el: * mule/kinsoku.el: Add "part of XEmacs" text to permission notice. 2010-10-14 Aidan Kehoe <kehoea@parhasard.net> * byte-optimize.el (side-effect-free-fns): * cl-macs.el (remf, getf): * cl-extra.el (tailp, cl-set-getf, cl-do-remf): * cl.el (ldiff, endp): Tighten up Common Lisp compatibility for #'ldiff, #'endp, #'tailp; add circularity checking for the first two. #'cl-set-getf and #'cl-do-remf were Lisp implementations of #'plist-put and #'plist-remprop; change the names to aliases, changes the macros that use them to using #'plist-put and #'plist-remprop directly. 2010-10-12 Aidan Kehoe <kehoea@parhasard.net> * abbrev.el (fundamental-mode-abbrev-table, global-abbrev-table): Create both these abbrev tables using the usual #'define-abbrev-table calls, rather than attempting to special-case them. * cl-extra.el: Force cl-macs to be loaded here, if cl-extra.el is being loaded interpreted. Previously other, later files would redundantly call (load "cl-macs") when interpreted, it's more reasonable to do it here, once. * cmdloop.el (read-quoted-char-radix): Use defcustom here, we don't have any dump-order dependencies that would prevent that. * custom.el (eval-when-compile): Don't load cl-macs when interpreted or when byte-compiling, rely on cl-extra.el in the former case and the appropriate entry in bytecomp-load-hook in the latter. Get rid of custom-declare-variable-list, we have no dump-time dependencies that would require it. * faces.el (eval-when-compile): Don't load cl-macs when interpreted or when byte-compiling. * packages.el: Remove some inaccurate comments. * post-gc.el (cleanup-simple-finalizers): Use #'delete-if-not here, now the order of preloaded-file-list has been changed to make it available. * subr.el (custom-declare-variable-list): Remove. No need for it. Also remove a stub define-abbrev-table from this file, given the current order of preloaded-file-list there's no need for it. 2010-10-10 Aidan Kehoe <kehoea@parhasard.net> * bytecomp.el (byte-compile-constp) Forms quoted with FUNCTION are also constant. (byte-compile-initial-macro-environment): In #'the, if FORM is constant and does not match TYPE, warn at byte-compile time. 2010-10-10 Aidan Kehoe <kehoea@parhasard.net> * backquote.el (bq-vector-contents, bq-list*): Remove; the former is equivalent to (append VECTOR nil), the latter to (list* ...). (bq-process-2): Use (append VECTOR nil) instead of using #'bq-vector-contents to convert to a list. (bq-process-1): Now we use list* instead of bq-list * subr.el (list*): Moved from cl.el, since it is now required to be available the first time a backquoted form is encountered. * cl.el (list*): Move to subr.el. 2010-09-16 Aidan Kehoe <kehoea@parhasard.net> * test-harness.el (Check-Message): Add an omitted comma here, thank you the buildbot. 2010-09-16 Aidan Kehoe <kehoea@parhasard.net> * hash-table.el (hash-table-key-list, hash-table-value-list) (hash-table-key-value-alist, hash-table-key-value-plist): Remove some useless #'nreverse calls in these files; our hash tables have no order, it's not helpful to pretend they do. * behavior.el (read-behavior): Do the same in this file, in some code evidently copied from hash-table.el. 2010-09-16 Aidan Kehoe <kehoea@parhasard.net> * info.el (Info-insert-dir): * format.el (format-deannotate-region): * files.el (cd, save-buffers-kill-emacs): Use #'some, #'every and related functions for applying boolean operations to lists, instead of rolling our own ones that cons and don't short-circuit. 2010-09-16 Aidan Kehoe <kehoea@parhasard.net> * bytecomp.el (byte-compile-initial-macro-environment): * cl-macs.el (the): Rephrase the docstring, make its implementation when compiling files a little nicer. 2010-09-16 Aidan Kehoe <kehoea@parhasard.net> * descr-text.el (unidata-initialize-unicodedata-database) (unidata-initialize-unihan-database, describe-char-unicode-data) (describe-char-unicode-data): Wrap calls to the database functions with (with-fboundp ...), avoiding byte compile warnings on builds without support for the database functions. (describe-char): (reduce #'max ...), not (apply #'max ...), no need to cons needlessly. (describe-char): Remove a redundant lambda wrapping #'extent-properties. (describe-char-unicode-data): Call #'nsubst when replacing "" with nil in the result of #'split-string, instead of consing inside mapcar. 2010-09-16 Aidan Kehoe <kehoea@parhasard.net> * x-faces.el (x-available-font-sizes): * specifier.el (let-specifier): * package-ui.el (pui-add-required-packages): * msw-faces.el (mswindows-available-font-sizes): * modeline.el (modeline-minor-mode-menu): * minibuf.el (minibuf-directory-files): Replace the O2N (delq nil (mapcar (lambda (W) (and X Y)) Z)) with the ON (mapcan (lambda (W) (and X (list Y))) Z) in these files. 2010-09-16 Aidan Kehoe <kehoea@parhasard.net> * cl-macs.el (= < > <= >=): When these functions are handed more than two arguments, and those arguments have no side effects, transform to a series of two argument calls, avoiding funcall in the byte-compiled code. * mule/mule-cmds.el (finish-set-language-environment): Take advantage of this change in a function called 256 times at startup. 2010-09-16 Aidan Kehoe <kehoea@parhasard.net> * bytecomp.el (byte-compile-function-form, byte-compile-quote) (byte-compile-quote-form): Warn at compile time, and error at runtime, if a (quote ...) or a (function ...) form attempts to quote more than one object. 2010-09-16 Aidan Kehoe <kehoea@parhasard.net> * byte-optimize.el (byte-optimize-apply): Transform (apply 'nconc (mapcar ...)) to (mapcan ...); warn about use of the first idiom. * update-elc.el (do-autoload-commands): * packages.el (packages-find-package-library-path): * frame.el (frame-list): * extents.el (extent-descendants): * etags.el (buffer-tag-table-files): * dumped-lisp.el (preloaded-file-list): * device.el (device-list): * bytecomp-runtime.el (proclaim-inline, proclaim-notinline) Use #'mapcan, not (apply #'nconc (mapcar ...) in all these files. * bytecomp-runtime.el (eval-when-compile, eval-and-compile): In passing, mention that these macros also evaluate the body when interpreted. tests/ChangeLog addition: 2011-02-07 Aidan Kehoe <kehoea@parhasard.net> * automated/lisp-tests.el: Test lexical scope for `block', `return-from'; add a Known-Bug-Expect-Failure for a contorted example that fails when byte-compiled.
author Aidan Kehoe <kehoea@parhasard.net>
date Mon, 07 Feb 2011 12:01:24 +0000
parents 6c6d78781d59
children 308d34e9f07d
line wrap: on
line source

/* Implements elisp-programmable dialog boxes -- MS Windows interface.
   Copyright (C) 1998 Kirill M. Katsnelson <kkm@kis.ru>
   Copyright (C) 2000, 2001, 2002, 2003, 2004, 2010 Ben Wing.

This file is part of XEmacs.

XEmacs is free software; you can redistribute it and/or modify it
under the terms of the GNU General Public License as published by the
Free Software Foundation; either version 2, or (at your option) any
later version.

XEmacs is distributed in the hope that it will be useful, but WITHOUT
ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
for more details.

You should have received a copy of the GNU General Public License
along with XEmacs; see the file COPYING.  If not, write to
the Free Software Foundation, Inc., 59 Temple Place - Suite 330,
Boston, MA 02111-1307, USA.  */

/* Synched up with: Not in FSF. */

/* This file essentially Mule-ized (except perhaps some Unicode splitting).
   5-2000. */

/* Author:
   Initially written by kkm, May 1998
*/

#include <config.h>
#include "lisp.h"

#include "buffer.h"
#include "frame-impl.h"
#include "gui.h"
#include "opaque.h"

#include "console-msw-impl.h"

#include "sysfile.h"

Lisp_Object Qdialog_box_error;

static Lisp_Object Q_initial_directory;
static Lisp_Object Q_initial_filename;
static Lisp_Object Q_filter_list;
static Lisp_Object Q_allow_multi_select;
static Lisp_Object Q_create_prompt_on_nonexistent;
static Lisp_Object Q_overwrite_prompt;
static Lisp_Object Q_file_must_exist;
static Lisp_Object Q_no_network_button;
static Lisp_Object Q_no_read_only_return;

/* List containing all dialog data structures of currently popped up
   dialogs. */
static Lisp_Object Vdialog_data_list;

/* List of popup frames wanting keyboard traversal handled */
static Lisp_Object Vpopup_frame_list;

Lisp_Object Vdefault_file_dialog_filter_alist;

/* DLUs per character metrics */
#define X_DLU_PER_CHAR	     4
#define Y_DLU_PER_CHAR	     8

/*
  Button metrics
  --------------
  All buttons have height of 15 DLU. The minimum width for a button is 32 DLU, 
  but it can be expanded to accommodate its text, so the width is calculated as
  8 DLU per button plus 4 DLU per character.
  max (32, 6 * text_length). The factor of six is rather empirical, but it
  works better than 8 which comes from the definition of a DLU. Buttons are
  spaced with 6 DLU gap. Minimum distance from the button to the left or right 
  dialog edges is 6 DLU, and the distance between the dialog bottom edge and
  buttons is 7 DLU.
*/

#define X_MIN_BUTTON	    32
#define X_BUTTON_MARGIN	     8
#define Y_BUTTON	    15
#define X_BUTTON_SPACING     6
#define X_BUTTON_FROM_EDGE   6
#define Y_BUTTON_FROM_EDGE   7

/* 
   Text field metrics
   ------------------
   Text distance from left and right edges is the same as for buttons, and the
   top margin is 11 DLU. The static control has height of 2 DLU per control
   plus 8 DLU per each line of text. Distance between the bottom edge of the
   control and the button row is 15 DLU. Minimum width of the static control
   is 100 DLU, thus giving minimum dialog weight of 112 DLU. Maximum width is
   300 DLU, and, if the text is wider than that, the text is wrapped on the
   next line. Each character in the text is considered 4 DLU wide.
*/

#define X_MIN_TEXT	   100
#define X_AVE_TEXT	   200
#define X_MAX_TEXT	   300
#define X_TEXT_FROM_EDGE      X_BUTTON_FROM_EDGE
#define Y_TEXT_FROM_EDGE    11
#define Y_TEXT_MARGIN	     2
#define Y_TEXT_FROM_BUTTON  15

#define X_MIN_TEXT_CHAR	   (X_MIN_TEXT / X_DLU_PER_CHAR)
#define X_AVE_TEXT_CHAR	   (X_AVE_TEXT / X_DLU_PER_CHAR)
#define X_MAX_TEXT_CHAR	   (X_MAX_TEXT / X_DLU_PER_CHAR)

/*
  Layout algorithm
  ----------------
  First we calculate the minimum width of the button row, excluding "from
  edge" distances. Note that the static control text can be narrower than
  X_AVE_TEXT only if both text and button row are narrower than that (so,
  even if text *can* be wrapped into 2 rows narrower than ave width, it is not 
  done). Let WBR denote the width of the button row.

  Next, the width of the static field is determined.
  First, if all lines of text fit into max (WBR, X_MAX_TEXT), the width of the
  control is the same as the width of the longest line. 
  Second, if all lines of text are narrower than X_MIN_TEXT, then width of
  the control is set to X_MIN_TEXT.
  Otherwise, width is set to max(WBR, X_AVE_TEXT). In this case, line wrapping will
  happen.

  If width of the text control is larger than that of the button row, then the
  latter is centered across the dialog, by giving it extra edge
  margins. Otherwise, minimal margins are given to the button row.
*/

#define ID_ITEM_BIAS 32

void
mswindows_register_popup_frame (Lisp_Object frame)
{
  Vpopup_frame_list = Fcons (frame, Vpopup_frame_list);
}

void
mswindows_unregister_popup_frame (Lisp_Object frame)
{
  Vpopup_frame_list = delq_no_quit (frame, Vpopup_frame_list);
}

/* Dispatch message to any dialog boxes.  Return non-zero if dispatched. */
int
mswindows_is_dialog_msg (MSG *msg)
{
  LIST_LOOP_2 (data, Vdialog_data_list)
    {
      if (qxeIsDialogMessage (XMSWINDOWS_DIALOG_ID (data)->hwnd, msg))
	return 1;
    }

  {
    LIST_LOOP_2 (popup, Vpopup_frame_list)
      {
	HWND hwnd = FRAME_MSWINDOWS_HANDLE (XFRAME (popup));
	/* This is a windows feature that allows dialog type
	   processing to be applied to standard windows containing
	   controls. */
	if (qxeIsDialogMessage (hwnd, msg))
	  return 1;
      }
  }
  return 0;
}

static const struct memory_description mswindows_dialog_id_description [] = {
  { XD_LISP_OBJECT, offsetof (struct mswindows_dialog_id, frame) },
  { XD_LISP_OBJECT, offsetof (struct mswindows_dialog_id, callbacks) },
  { XD_END }
};

static Lisp_Object
mark_mswindows_dialog_id (Lisp_Object obj)
{
  struct mswindows_dialog_id *data = XMSWINDOWS_DIALOG_ID (obj);
  mark_object (data->frame);
  return data->callbacks;
}

DEFINE_NODUMP_INTERNAL_LISP_OBJECT ("mswindows-dialog-id",
				    mswindows_dialog_id,
				    mark_mswindows_dialog_id,
				    mswindows_dialog_id_description,
				    struct mswindows_dialog_id);

/* Dialog procedure */
static BOOL CALLBACK 
dialog_proc (HWND hwnd, UINT msg, WPARAM w_param, LPARAM l_param)
{
  switch (msg)
    {
    case WM_INITDIALOG:
      qxeSetWindowLong (hwnd, DWL_USER, l_param);
      break;
      
    case WM_DESTROY:
      {
	Lisp_Object data;
	data = GET_LISP_FROM_VOID ((void *) qxeGetWindowLong (hwnd, DWL_USER));
	Vdialog_data_list = delq_no_quit (data, Vdialog_data_list);
      }
      break;

    case WM_COMMAND:
      {
	Lisp_Object fn, arg, data;
	struct mswindows_dialog_id *did;

	data = GET_LISP_FROM_VOID ((void *) qxeGetWindowLong (hwnd, DWL_USER));
	did = XMSWINDOWS_DIALOG_ID (data);
	if (w_param != IDCANCEL) /* user pressed escape */
	  {
	    assert (w_param >= ID_ITEM_BIAS 
		    && (EMACS_INT) w_param
		    < XVECTOR_LENGTH (did->callbacks) + ID_ITEM_BIAS);
	    
	    get_gui_callback (XVECTOR_DATA (did->callbacks)
			      [w_param - ID_ITEM_BIAS],
			      &fn, &arg);
	    mswindows_enqueue_misc_user_event (did->frame, fn, arg);
	  }
	else
	  mswindows_enqueue_misc_user_event (did->frame, Qrun_hooks,
					     Qmenu_no_selection_hook);
	va_run_hook_with_args_trapping_problems
	  (Qdialog, Qdelete_dialog_box_hook, 1, data, 0);

	DestroyWindow (hwnd);
      }
      break;

    default:
      return FALSE;
    }
  return TRUE;
}

/* Helper function which converts the supplied string STRING into Unicode and
   pushes it at the end of DYNARR */
static void
push_lisp_string_as_unicode (unsigned_char_dynarr *dynarr, Lisp_Object string)
{
  int length;
  Extbyte *uni_string;

  LISP_STRING_TO_SIZED_EXTERNAL (string, uni_string, length,
				 Qmswindows_unicode);
  Dynarr_add_many (dynarr, uni_string, length);
  Dynarr_add (dynarr, '\0');
  Dynarr_add (dynarr, '\0');
}

/* Given button TEXT, return button width in DLU */
static int
button_width (Lisp_Object text)
{
  /* !!#### do Japanese chars count as two? */
  int width =
    X_DLU_PER_CHAR *
      ibyte_string_displayed_columns (XSTRING_DATA (text),
					XSTRING_LENGTH (text));
  return max (X_MIN_BUTTON, width);
}

/* Unwind protection routine frees a dynarr opaqued into arg */
static Lisp_Object
free_dynarr_opaque_ptr (Lisp_Object arg)
{
  Dynarr_free (get_opaque_ptr (arg));
  return arg;
}

/* Unwind protection decrements dialog count */
static Lisp_Object
dialog_popped_down (Lisp_Object UNUSED (arg))
{
  popup_up_p--;
  return Qnil;
}


#define ALIGN_TEMPLATE					\
{							\
  int slippage = Dynarr_length (template_) & 3;		\
  if (slippage)						\
    Dynarr_add_many (template_, &zeroes, slippage);	\
}

static struct
{
  DWORD errmess;
  const Ascbyte *errname;
} common_dialog_errors[] =
{
  { CDERR_DIALOGFAILURE, "CDERR_DIALOGFAILURE" },
  { CDERR_FINDRESFAILURE, "CDERR_FINDRESFAILURE" },
  { CDERR_INITIALIZATION, "CDERR_INITIALIZATION" },
  { CDERR_LOADRESFAILURE, "CDERR_LOADRESFAILURE" },
  { CDERR_LOADSTRFAILURE, "CDERR_LOADSTRFAILURE" },
  { CDERR_LOCKRESFAILURE, "CDERR_LOCKRESFAILURE" },
  { CDERR_MEMALLOCFAILURE, "CDERR_MEMALLOCFAILURE" },
  { CDERR_MEMLOCKFAILURE, "CDERR_MEMLOCKFAILURE" },
  { CDERR_NOHINSTANCE, "CDERR_NOHINSTANCE" },
  { CDERR_NOHOOK, "CDERR_NOHOOK" },
  { CDERR_NOTEMPLATE, "CDERR_NOTEMPLATE" },
  { CDERR_REGISTERMSGFAIL, "CDERR_REGISTERMSGFAIL" },
  { CDERR_STRUCTSIZE, "CDERR_STRUCTSIZE" },
  { PDERR_CREATEICFAILURE, "PDERR_CREATEICFAILURE" },
  { PDERR_DEFAULTDIFFERENT, "PDERR_DEFAULTDIFFERENT" },
  { PDERR_DNDMMISMATCH, "PDERR_DNDMMISMATCH" },
  { PDERR_GETDEVMODEFAIL, "PDERR_GETDEVMODEFAIL" },
  { PDERR_INITFAILURE, "PDERR_INITFAILURE" },
  { PDERR_LOADDRVFAILURE, "PDERR_LOADDRVFAILURE" },
  { PDERR_NODEFAULTPRN, "PDERR_NODEFAULTPRN" },
  { PDERR_NODEVICES, "PDERR_NODEVICES" },
  { PDERR_PARSEFAILURE, "PDERR_PARSEFAILURE" },
  { PDERR_PRINTERNOTFOUND, "PDERR_PRINTERNOTFOUND" },
  { PDERR_RETDEFFAILURE, "PDERR_RETDEFFAILURE" },
  { PDERR_SETUPFAILURE, "PDERR_SETUPFAILURE" },
  { CFERR_MAXLESSTHANMIN, "CFERR_MAXLESSTHANMIN" },
  { CFERR_NOFONTS, "CFERR_NOFONTS" },
  { FNERR_BUFFERTOOSMALL, "FNERR_BUFFERTOOSMALL" },
  { FNERR_INVALIDFILENAME, "FNERR_INVALIDFILENAME" },
  { FNERR_SUBCLASSFAILURE, "FNERR_SUBCLASSFAILURE" },
  { FRERR_BUFFERLENGTHZERO, "FRERR_BUFFERLENGTHZERO" },
};

struct param_data
{
  Extbyte *fname;
  Extbyte *unknown_fname;
  int validate;
};

static int
CALLBACK handle_directory_proc (HWND hwnd, UINT msg,
				LPARAM lParam, LPARAM lpData)
{
  Extbyte szDir[PATH_MAX_TCHAR];
  struct param_data *pd = (struct param_data *) lpData;
  
  switch (msg)
    {
    case BFFM_INITIALIZED:
      /* WParam is TRUE since you are passing a path. 
	 It would be FALSE if you were passing a pidl. */
      qxeSendMessage (hwnd, BFFM_SETSELECTION, TRUE, (LPARAM) pd->fname);
      break;
      
    case BFFM_SELCHANGED:
      /* Set the status window to the currently selected path. */
      if (qxeSHGetPathFromIDList ((LPITEMIDLIST) lParam, szDir))
	qxeSendMessage (hwnd, BFFM_SETSTATUSTEXT, 0, (LPARAM) szDir);
      break;
      
    case BFFM_VALIDATEFAILED:
      if (pd->validate)
	return TRUE;
      else
	pd->unknown_fname = qxetcsdup ((Extbyte *) lParam);
      break;
      
    default:
      break;
    }
  return 0;
}

static Lisp_Object
handle_directory_dialog_box (struct frame *f, Lisp_Object keys)
{
  Lisp_Object ret = Qnil;
  BROWSEINFOW bi;
  LPITEMIDLIST pidl;
  LPMALLOC pMalloc;
  struct param_data pd;
  
  xzero (pd);
  xzero (bi);
  
  bi.lParam = (LPARAM) &pd;
  bi.hwndOwner = FRAME_MSWINDOWS_HANDLE (f);
  bi.pszDisplayName = 0;
  bi.pidlRoot = 0;
  bi.ulFlags =
    BIF_RETURNONLYFSDIRS | BIF_STATUSTEXT | BIF_EDITBOX | BIF_NEWDIALOGSTYLE;
  bi.lpfn = handle_directory_proc;
  
  LISP_LOCAL_FILE_FORMAT_TO_TSTR (Fexpand_file_name (build_ascstring (""), Qnil),
			     pd.fname);
  
  {
    EXTERNAL_PROPERTY_LIST_LOOP_3 (key, value, keys)
      {
	if (EQ (key, Q_title))
	  {
	    CHECK_STRING (value);
	    bi.lpszTitle = (XELPTSTR) LISP_STRING_TO_TSTR (value);
	  }
	else if (EQ (key, Q_initial_directory))
	  LISP_LOCAL_FILE_FORMAT_TO_TSTR (Fexpand_file_name (value, Qnil),
				     pd.fname);
	else if (EQ (key, Q_initial_filename))
	  ;			/* do nothing */
	else if (EQ (key, Q_file_must_exist))
	  {
	    if (!NILP (value))
	      {
		pd.validate = TRUE;
		bi.ulFlags |= BIF_VALIDATE;
	      }
	    else
	      bi.ulFlags &= ~BIF_VALIDATE;
	  }
	else
	  invalid_constant ("Unrecognized directory-dialog keyword", key);
      }
  }
  
  if (SHGetMalloc (&pMalloc) == NOERROR)
    {
      pidl = qxeSHBrowseForFolder (&bi);
      if (pidl)
	{
	  Extbyte *szDir = alloca_extbytes (PATH_MAX_TCHAR);
	  
	  if (qxeSHGetPathFromIDList (pidl, szDir))
	    ret = tstr_to_local_file_format (szDir);
	  
	  XECOMCALL1 (pMalloc, Free, pidl);
	  XECOMCALL0 (pMalloc, Release);
	  return ret;
	}
      else if (pd.unknown_fname != 0)
	{
	  ret = tstr_to_local_file_format (pd.unknown_fname);
	  xfree (pd.unknown_fname);
	  pd.unknown_fname = 0;
	}
      else while (1)
	signal_quit ();
    }
  else
    signal_error (Qdialog_box_error,
		  "Unable to create folder browser",
		  make_int (0));
  return ret;
}

static Lisp_Object
handle_file_dialog_box (struct frame *f, Lisp_Object keys)
{
  OPENFILENAMEW ofn;
  Extbyte fnbuf[8000];
  
  xzero (ofn);
  ofn.lStructSize = sizeof (ofn);
  ofn.Flags = OFN_EXPLORER;
  ofn.hwndOwner = FRAME_MSWINDOWS_HANDLE (f);
  ofn.lpstrFile = (XELPTSTR) fnbuf;
  ofn.nMaxFile = sizeof (fnbuf) / XETCHAR_SIZE;
  qxetcscpy (fnbuf, XETEXT (""));
  
  LISP_LOCAL_FILE_FORMAT_TO_TSTR (Fexpand_file_name (build_ascstring (""),
						     Qnil),
				  ofn.lpstrInitialDir);
  
  {
    EXTERNAL_PROPERTY_LIST_LOOP_3 (key, value, keys)
      {
	if (EQ (key, Q_initial_filename))
	  {
	    Extbyte *fnout;
	    
	    CHECK_STRING (value);
	    LISP_LOCAL_FILE_FORMAT_TO_TSTR (value, fnout);
	    qxetcscpy (fnbuf, fnout);
	  }
	else if (EQ (key, Q_title))
	  {
	    CHECK_STRING (value);
	    ofn.lpstrTitle = (XELPTSTR) LISP_STRING_TO_TSTR (value);
	  }
	else if (EQ (key, Q_initial_directory))
	  LISP_LOCAL_FILE_FORMAT_TO_TSTR (Fexpand_file_name (value, Qnil),
					  ofn.lpstrInitialDir);
	else if (EQ (key, Q_file_must_exist))
	  {
	    if (!NILP (value))
	      ofn.Flags |= OFN_FILEMUSTEXIST | OFN_PATHMUSTEXIST;
	    else
	      ofn.Flags &= ~(OFN_FILEMUSTEXIST | OFN_PATHMUSTEXIST);
	  }
	else
	  invalid_constant ("Unrecognized file-dialog keyword", key);
      }
  }
  
  if (!qxeGetOpenFileName (&ofn))
    {
      DWORD err = CommDlgExtendedError ();
      if (!err)
	{
	  while (1)
	    signal_quit ();
	}
      else
	{
	  int i;
	  
	  for (i = 0; i < countof (common_dialog_errors); i++)
	    {
	      if (common_dialog_errors[i].errmess == err)
		signal_error (Qdialog_box_error,
			      "Creating file-dialog-box",
			      build_msg_string
			      (common_dialog_errors[i].errname));
	    }
	  
	  signal_error (Qdialog_box_error,
			"Unknown common dialog box error???",
			make_int (err));
	}
    }
  
  return tstr_to_local_file_format ((Extbyte *) ofn.lpstrFile);
}

static Lisp_Object
handle_question_dialog_box (struct frame *f, Lisp_Object keys)
{
  Lisp_Object_dynarr *dialog_items = Dynarr_new (Lisp_Object);
  unsigned_char_dynarr *template_ = Dynarr_new (unsigned_char);
  int button_row_width = 0;
  int text_width, text_height;
  Lisp_Object question = Qnil, title = Qnil;
  
  int unbind_count = specpdl_depth ();
  record_unwind_protect (free_dynarr_opaque_ptr,
			 make_opaque_ptr (dialog_items));
  record_unwind_protect (free_dynarr_opaque_ptr,
			 make_opaque_ptr (template_));
  
  /* A big NO NEED to GCPRO gui_items stored in the array: they are just
     pointers into KEYS list, which is GC-protected by the caller */
  
  {
    EXTERNAL_PROPERTY_LIST_LOOP_3 (key, value, keys)
      {
	if (EQ (key, Q_question))
	  {
	    CHECK_STRING (value);
	    question = value;
	  }
	else if (EQ (key, Q_title))
	  {
	    CHECK_STRING (value);
	    title = value;
	  }
	else if (EQ (key, Q_buttons))
	  {
	    /* Parse each item in the dialog into gui_item structs,
	       and stuff a dynarr of these. Calculate button row width
	       in this loop too */
	    EXTERNAL_LIST_LOOP_2 (item, value)
	      {
		if (!NILP (item))
		  {
		    Lisp_Object gitem = gui_parse_item_keywords (item);
		    Dynarr_add (dialog_items, gitem);
		    button_row_width += button_width (XGUI_ITEM (gitem)->name) 
		      + X_BUTTON_MARGIN;
		  }
	      }
	    
	    button_row_width -= X_BUTTON_MARGIN;
	  }
	else
	  invalid_constant ("Unrecognized question-dialog keyword", key);
      }
  }
  
  if (Dynarr_length (dialog_items) == 0)
    sferror ("Dialog descriptor provides no buttons", keys);
  
  if (NILP (question))
    sferror ("Dialog descriptor provides no question", keys);
  
  /* Determine the final width layout */
  {
    Ibyte *p = XSTRING_DATA (question);
    Charcount string_max = 0, this_length = 0;
    while (1)
      {
	Ichar ch = itext_ichar (p);
	INC_IBYTEPTR (p);
	
	if (ch == (Ichar)'\n' || ch == (Ichar)'\0')
	  {
	    string_max = max (this_length, string_max);
	    this_length = 0;
	  }
	else
	  ++this_length;
	
	if (ch == (Ichar)'\0')
	  break;
      }
    
    if (string_max * X_DLU_PER_CHAR > max (X_MAX_TEXT, button_row_width))
      text_width = X_AVE_TEXT;
    else if (string_max * X_DLU_PER_CHAR < X_MIN_TEXT)
      text_width = X_MIN_TEXT;
    else
      text_width = string_max * X_DLU_PER_CHAR;
    text_width = max (text_width, button_row_width);
  }
  
  /* Now calculate the height for the text control */
  {
    Ibyte *p = XSTRING_DATA (question);
    Charcount break_at = text_width / X_DLU_PER_CHAR;
    Charcount char_pos = 0;
    int num_lines = 1;
    Ichar ch;
    
    while ((ch = itext_ichar (p)) != (Ichar) '\0')
      {
	INC_IBYTEPTR (p);
	char_pos += ch != (Ichar) '\n';
	if (ch == (Ichar) '\n' || char_pos == break_at)
	  {
	    ++num_lines;
	    char_pos = 0;
	  }
      }
    text_height = Y_TEXT_MARGIN + Y_DLU_PER_CHAR * num_lines;
  }
  
  /* Ok, now we are ready to stuff the dialog template and lay out controls */
  {
    DLGTEMPLATE dlg_tem;
    DLGITEMTEMPLATE item_tem;
    int i;
    const unsigned int zeroes = 0;
    const unsigned int ones = 0xFFFFFFFF;
    const WORD static_class_id = 0x0082;
    const WORD button_class_id = 0x0080;
    
    /* Create and stuff in DLGTEMPLATE header */
    dlg_tem.style = (DS_CENTER | DS_MODALFRAME
		     | WS_CAPTION | WS_POPUP | WS_VISIBLE);
    dlg_tem.dwExtendedStyle = 0;
    dlg_tem.cdit = Dynarr_length (dialog_items) + 1;
    dlg_tem.x = 0;
    dlg_tem.y = 0;
    dlg_tem.cx = text_width + 2 * X_TEXT_FROM_EDGE;
    dlg_tem.cy = (Y_TEXT_FROM_EDGE + text_height + Y_TEXT_FROM_BUTTON
		  + Y_BUTTON + Y_BUTTON_FROM_EDGE);
    Dynarr_add_many (template_, &dlg_tem, sizeof (dlg_tem));
    
    /* We want no menu and standard class */
    Dynarr_add_many (template_, &zeroes, 4);
    
    /* And the third is the dialog title. "XEmacs" unless one is supplied.
       Note that the string must be in Unicode. */
    if (NILP (title))
      Dynarr_add_many (template_, L"XEmacs", 14);
    else
      push_lisp_string_as_unicode (template_, title);
    
    /* Next add text control. */
    item_tem.style = WS_CHILD | WS_VISIBLE | SS_LEFT | SS_NOPREFIX;
    item_tem.dwExtendedStyle = 0;
    item_tem.x = X_TEXT_FROM_EDGE;
    item_tem.y = Y_TEXT_FROM_EDGE;
    item_tem.cx = text_width;
    item_tem.cy = text_height;
    item_tem.id = 0xFFFF;
    
    ALIGN_TEMPLATE;
    Dynarr_add_many (template_, &item_tem, sizeof (item_tem));
    
    /* Right after class id follows */
    Dynarr_add_many (template_, &ones, 2);
    Dynarr_add_many (template_, &static_class_id, sizeof (static_class_id));
    
    /* Next thing to add is control text, as Unicode string */
    push_lisp_string_as_unicode (template_, question);
    
    /* Specify 0 length creation data */
    Dynarr_add_many (template_, &zeroes, 2);
    
    /* Now it's the button time */
    item_tem.y = Y_TEXT_FROM_EDGE + text_height + Y_TEXT_FROM_BUTTON;
    item_tem.x = X_BUTTON_FROM_EDGE + (button_row_width < text_width
				       ? (text_width - button_row_width) / 2
				       : 0);
    item_tem.cy = Y_BUTTON;
    item_tem.dwExtendedStyle = 0;
    
    for (i = 0; i < Dynarr_length (dialog_items); ++i)
      {
	Lisp_Object *gui_item = Dynarr_atp (dialog_items, i);
	Lisp_Gui_Item *pgui_item = XGUI_ITEM (*gui_item);
	
	item_tem.style = (WS_CHILD | WS_VISIBLE | WS_TABSTOP | BS_PUSHBUTTON
			  | (gui_item_active_p (*gui_item) ? 0 : WS_DISABLED));
	item_tem.cx = button_width (pgui_item->name);
	/* Item ids are indices into dialog_items plus offset, to avoid having
           items by reserved ids (IDOK, IDCANCEL) */
	item_tem.id = i + ID_ITEM_BIAS;
	
	ALIGN_TEMPLATE;
	Dynarr_add_many (template_, &item_tem, sizeof (item_tem));
	
	/* Right after 0xFFFF and class id atom follows */
	Dynarr_add_many (template_, &ones, 2);
	Dynarr_add_many (template_, &button_class_id,
			 sizeof (button_class_id));
	
	/* Next thing to add is control text, as Unicode string */
	{
	  Ichar accel_unused;
	  
	  push_lisp_string_as_unicode
	    (template_,
	     mswindows_translate_menu_or_dialog_item
	     (pgui_item->name, &accel_unused));
	}
	
	/* Specify 0 length creation data. */
	Dynarr_add_many (template_, &zeroes, 2);
	
	item_tem.x += item_tem.cx + X_BUTTON_SPACING;
      }
  }
  
  /* Now the Windows dialog structure is ready. We need to prepare a
     data structure for the new dialog, which will contain callbacks
     and the frame for these callbacks.  This structure has to be
     GC-protected and thus it is put into a statically protected
     list. */
  {
    int i;
    Lisp_Object obj = ALLOC_NORMAL_LISP_OBJECT (mswindows_dialog_id);
    struct mswindows_dialog_id *did = XMSWINDOWS_DIALOG_ID (obj);
    
    did->frame = wrap_frame (f);
    did->callbacks = make_vector (Dynarr_length (dialog_items), Qunbound);
    for (i = 0; i < Dynarr_length (dialog_items); i++)
      XVECTOR_DATA (did->callbacks) [i] =
	XGUI_ITEM (*Dynarr_atp (dialog_items, i))->callback;
    
    /* Woof! Everything is ready. Pop pop pop in now! */
    did->hwnd =
      qxeCreateDialogIndirectParam (NULL,
				    (LPDLGTEMPLATE) Dynarr_begin (template_),
				    FRAME_MSWINDOWS_HANDLE (f), dialog_proc,
				    (LPARAM) STORE_LISP_IN_VOID (obj));
    if (!did->hwnd)
      /* Something went wrong creating the dialog */
      signal_error (Qdialog_box_error, "Creating dialog", keys);
    
    Vdialog_data_list = Fcons (obj, Vdialog_data_list);
    
    /* Cease protection and free dynarrays */
    unbind_to (unbind_count);
    return obj;
  }
}

static Lisp_Object
mswindows_make_dialog_box_internal (struct frame* f, Lisp_Object type,
				    Lisp_Object keys)
{
  int unbind_count = specpdl_depth ();
  record_unwind_protect (dialog_popped_down, Qnil);
  popup_up_p++;

  if (EQ (type, Qfile))
    return unbind_to_1 (unbind_count, handle_file_dialog_box (f, keys));
  else if (EQ (type, Qdirectory))
    return unbind_to_1 (unbind_count, handle_directory_dialog_box (f, keys));
  else if (EQ (type, Qquestion))
    return unbind_to_1 (unbind_count, handle_question_dialog_box (f, keys));
  else if (EQ (type, Qprint))
    return unbind_to_1 (unbind_count,
			mswindows_handle_print_dialog_box (f, keys));
  else if (EQ (type, Qpage_setup))
    return unbind_to_1 (unbind_count, 
		        mswindows_handle_page_setup_dialog_box (f, keys));
  else
    signal_error (Qunimplemented, "Dialog box type", type);
  return Qnil;
}

void
console_type_create_dialog_mswindows (void)
{
  CONSOLE_HAS_METHOD (mswindows, make_dialog_box_internal);
}

void
syms_of_dialog_mswindows (void)
{
  INIT_LISP_OBJECT (mswindows_dialog_id);
  
  DEFKEYWORD (Q_initial_directory);
  DEFKEYWORD (Q_initial_filename);
  DEFKEYWORD (Q_filter_list);
  DEFKEYWORD (Q_title);
  DEFKEYWORD (Q_allow_multi_select);
  DEFKEYWORD (Q_create_prompt_on_nonexistent);
  DEFKEYWORD (Q_overwrite_prompt);
  DEFKEYWORD (Q_file_must_exist);
  DEFKEYWORD (Q_no_network_button);
  DEFKEYWORD (Q_no_read_only_return);
  
  /* Errors */
  DEFERROR_STANDARD (Qdialog_box_error, Qgui_error);
}

void
vars_of_dialog_mswindows (void)
{
  Vpopup_frame_list = Qnil;
  staticpro (&Vpopup_frame_list);
  
  Vdialog_data_list = Qnil;
  staticpro (&Vdialog_data_list);
  
  DEFVAR_LISP ("default-file-dialog-filter-alist",
	       &Vdefault_file_dialog_filter_alist /*
						   */ );
  Vdefault_file_dialog_filter_alist =
    list5 (Fcons (build_defer_string ("Text Files"), build_ascstring ("*.txt")),
	   Fcons (build_defer_string ("C Files"), build_ascstring ("*.c;*.h")),
	   Fcons (build_defer_string ("Elisp Files"), build_ascstring ("*.el")),
	   Fcons (build_defer_string ("HTML Files"), build_ascstring ("*.html;*.html")),
	   Fcons (build_defer_string ("All Files"), build_ascstring ("*.*")));
}