Mercurial > hg > xemacs-beta
view src/README @ 4921:17362f371cc2
add more byte-code assertions and better failure output
-------------------- ChangeLog entries follow: --------------------
src/ChangeLog addition:
2010-02-03 Ben Wing <ben@xemacs.org>
* alloc.c (Fmake_byte_code):
* bytecode.h:
* lisp.h:
* lread.c:
* lread.c (readevalloop):
* lread.c (Fread):
* lread.c (Fread_from_string):
* lread.c (read_list_conser):
* lread.c (read_list):
* lread.c (vars_of_lread):
* symbols.c:
* symbols.c (Fdefine_function):
Turn on the "compiled-function annotation hack". Implement it
properly by hooking into Fdefalias(). Note in the docstring to
`defalias' that we do this. Remove some old broken code and
change code that implemented the old kludgy way of hooking into
the Lisp reader into bracketed by `#ifdef
COMPILED_FUNCTION_ANNOTATION_HACK_OLD_WAY', which is not enabled.
Also enable byte-code metering when DEBUG_XEMACS -- this is a form
of profiling for computing histograms of which sequences of two
bytecodes are used most often.
* bytecode-ops.h:
* bytecode-ops.h (OPCODE):
New file. Extract out all the opcodes and declare them using
OPCODE(), a bit like frame slots and such. This way the file can
be included multiple times if necessary to iterate multiple times
over the byte opcodes.
* bytecode.c:
* bytecode.c (NUM_REMEMBERED_BYTE_OPS):
* bytecode.c (OPCODE):
* bytecode.c (assert_failed_with_remembered_ops):
* bytecode.c (READ_UINT_2):
* bytecode.c (READ_INT_1):
* bytecode.c (READ_INT_2):
* bytecode.c (PEEK_INT_1):
* bytecode.c (PEEK_INT_2):
* bytecode.c (JUMP_RELATIVE):
* bytecode.c (JUMP_NEXT):
* bytecode.c (PUSH):
* bytecode.c (POP_WITH_MULTIPLE_VALUES):
* bytecode.c (DISCARD):
* bytecode.c (UNUSED):
* bytecode.c (optimize_byte_code):
* bytecode.c (optimize_compiled_function):
* bytecode.c (Fbyte_code):
* bytecode.c (vars_of_bytecode):
* bytecode.c (init_opcode_table_multi_op):
* bytecode.c (reinit_vars_of_bytecode):
* emacs.c (main_1):
* eval.c (funcall_compiled_function):
* symsinit.h:
Any time we change either the instruction pointer or the stack
pointer, assert that we're going to move it to a valid location.
This should catch failures right when they occur rather than
sometime later. This requires that we pass in another couple of
parameters into some functions (only with error-checking enabled,
see below).
Also keep track, using a circular queue, of the last 100 byte
opcodes seen, and when we hit an assert failure during byte-code
execution, output the contents of the queue in a nice readable
fashion. This requires that bytecode-ops.h be included a second
time so that a table mapping opcodes to the name of their operation
can be constructed. This table is constructed in new function
reinit_vars_of_bytecode().
Everything in the last two paras happens only when
ERROR_CHECK_BYTE_CODE.
Add some longish comments describing how the arrays that hold the
stack and instructions, and the pointers used to access them, work.
* gc.c:
Import some code from my `latest-fix' workspace to mark the
staticpro's in order from lowest to highest, rather than highest to
lowest, so it's easier to debug when something goes wrong.
* lisp.h (abort_with_message): Renamed from abort_with_msg().
* symbols.c (defsymbol_massage_name_1):
* symbols.c (defsymbol_nodump):
* symbols.c (defsymbol):
* symbols.c (defkeyword):
* symeval.h (DEFVAR_SYMVAL_FWD_OBJECT):
Make the various calls to staticpro() instead call staticpro_1(),
passing in the name of the C var being staticpro'ed, so that it
shows up in staticpro_names. Otherwise staticpro_names just has
1000+ copies of the word `location'.
author | Ben Wing <ben@xemacs.org> |
---|---|
date | Wed, 03 Feb 2010 08:01:55 -0600 |
parents | abe6d1db359e |
children | 304aebb79cd3 |
line wrap: on
line source
This directory contains the source files for the C component of XEmacs. Nothing in this directory is needed for using XEmacs once it is built and installed, if the dumped Emacs is copied elsewhere. See the files ../README and then ../INSTALL for installation instructions. Under Unix, the file `Makefile.in.in' is used as a template by the script `../configure' to produce `Makefile.in'. The same script then uses `cpp' to produce the machine-dependent `Makefile' from `Makefile.in'; `Makefile' is the file which actually controls the compilation of Emacs. Most of this should work transparently to the user; you should only need to run `../configure', and then type `make'. General changes for XEmacs: --------------------------- 1. Lisp objects. -- XFASTINT has been eliminated. Use of this expression as an lvalue is incompatible with the union form of Lisp objects, and use as an rvalue is likely to lead to errors and doesn't really save much time. Expressions of the form `XFASTINT (obj) = num;' get replaced by `obj = make_int (num);' or `XSETINT (obj, num);' and expressions of the form `num = XFASTINT (obj);' get replaced by `num = XINT (obj);'. Use Qzero in place of `make_int (0)'. -- Use of XTYPE gets replaced by the appropriate predicate. Using XTYPE only works for the small number of types that are not stored using the Lisp_Record type (int, cons, string, and vector). For example, `(XTYPE (foo) == Lisp_Buffer)' gets replaced by `(BUFFERP (foo))'. -- `XSET (obj, Lisp_Int, num)' gets replaced by `XSETINT (obj, num)', for consistency. -- Some occurrences of XSET need to get replaced by XSETR -- specifically, those where the type is not a primitive type (primitive types are int, cons, string, and vector). -- References to `XSTRING (obj)->size' get replaced with `XSTRING_LENGTH (obj)'. This is currently for cosmetic reasons but there may be other reasons in the future. (This change is currently incomplete in the source files.) 2. Storage classes: -- All occurrences of `register' should be replaced by `REGISTER'. It interferes with backtraces so we disable it if DEBUG_XEMACS is defined. 3. Errors, messages, I18N3 snarfing: -- Errors are continuable in XEmacs but are not in FSF Emacs. Therefore, it's important that functions do something reasonable if an error gets continued. If you want to signal a non- continuable error, the call to Fsignal() gets put inside a `while (1)' loop. To facilitate this, and also for proper I18N3 message snarfing, most calls to Fsignal() have been replaced by calls to signal_error(), signal_simple_error(), etc. Look at eval.c for a classification of various error functions. -- Constant strings occurring in source files need to get wrapped in a call to GETTEXT (or if inside of a call to `build_string', change that function to `build_translated_string') if they don't occur in certain places where the I18N3 message snarfer will see them. For a complete discussion of this, see the file lib-src/make-msgfile.lex. NOTE: I18N3 support is not currently working, so the above may or may not apply. Thus it is not a good idea to add random GETTEXTs, unless you really know what you are doing. -- Calls to `fprintf (stderr, ...)' and `printf (...)' get replaced with calls to `stderr_out' and `stdout_out'. This is for I18N3 message snarfing. 4. Initialization: -- FSF constructs like `obj = intern ("string"); staticpro (&obj);' get replaced by `defsymbol (&obj);'. This is for code cleanness and better purespace usage. -- FSF constructs like obj = intern ("error"); Fput (obj, Qerror_message, "message"); Fput (obj, Qerror_conditions, some list); get replaced by calls to deferror(). See the definition of deferror() for how the correct arguments to pass. This is for code cleanness and I18N3 message snarfing. -- Code in keys_of_foo() functions has been moved into Lisp.