Mercurial > hg > xemacs-beta
diff src/event-gtk.c @ 1268:fffe735e63ee
[xemacs-hg @ 2003-02-07 11:50:50 by ben]
fixes for menu crashes + better preemption behavior
This contains two related changes:
(1) Fix problems with reentrant calling of lwlib and associated
crashes when selecting menu items.
(2) Improve redisplay handling of preemption. Turn on lazy lock
and hold down page-down or page-up and you'll see what I mean.
They are related because they both touch on the code that retrieves
events and handles the internal queues.
console-msw.h, event-msw.c, event-stream.c, events.h, menubar-msw.c, menubar-x.c, menubar.h: mswindows_protect_modal_loop() has been generalized to
event_stream_protect_modal_loop(), and moved to event-stream.c.
mswindows_in_modal_loop ->in_modal_loop likewise. Changes in
event-msw.c and menubar-msw.c for the new names and calling format
(use structures instead of static variables in menubar-msw.c).
Delete former in_menu_callback and use in_modal_loop in its place.
Remove emacs_mswindows_quit_check_disallowed_p(), superseded by
in_modal_loop. Use event_stream_protect_modal_loop() in
pre_activate_callback() so that we get no lwlib reentrancy.
Rearrange some of the code in event-msw.c to be grouped better.
Make mswindows_drain_windows_queue() respect in_modal_loop and
do nothing if so.
cmdloop.c, event-stream.c: Don't conditionalize on LWLIB_MENUBARS_LUCID when giving error when
in_modal_loop, and give better error.
event-Xt.c, event-gtk.c: If in_modal_loop, only retrieve process and timeout events.
Don't retrieve any X events because processing them can lead
to reentrancy in lwlib -> death.
event-stream.c: Remove unused parameter to check_event_stream_ok() and change
all callers.
lisp.h, event-stream.c: Rearrange some functions for increased clarity -- in particular,
group all the input-pending/QUIT-related stuff together, and
put right next to next-event stuff, to which it's related.
Add the concept of "HOW_MANY" -- when asking whether user input
is pending, you can ask if at least HOW_MANY events are pending,
not just if any are. Add parameter to detect_input_pending()
for this. Change recursive_sit_for from a Lisp_Object (which
could only be Qt or Qnil) to an int, like it should be.
event-Xt.c, event-gtk.c, event-xlike-inc.c: New file.
Abstract out similar code in event_{Xt/gtk}_pending_p() and write
only once, using include-file tricks. Rewrite this function to
implement HOW_MANY and only process events when not in_modal_loop.
event-msw.c: Implement HOW_MANY and only process events when not in_modal_loop.
event-tty.c: Implement HOW_MANY.
redisplay.c: Add var `max-preempts' to control maximum number of preempts.
(#### perhaps not useful) Rewrite preemption check so that,
rather than preempting when any user events are available, only
preempt when a certain number (currently 4) of them are backed up.
This effectively allows redisplay to proceed to completion in the
presence of a fast auto-repeat (usually the auto-repeating is
generated dynamically as necessary), and you get much better
display behavior with lazy-lock active.
event-unixoid.c: Comment changes.
event-stream.c: Rewrite discard-input much more simply and safely using the
drain-queue functions. I think the old version might loop
forever if called when in_modal_loop.
SEMI-UNRELATED CHANGES:
-----------------------
event-stream.c: Turn QUIT-checking back on when running the pre-idle hook so it
can be quit out of.
indent.c: Document exact functioning of `vertical-motion' better, and its
differences from GNU Emacs.
author | ben |
---|---|
date | Fri, 07 Feb 2003 11:50:54 +0000 |
parents | e22b0213b713 |
children | f3437b56874d |
line wrap: on
line diff
--- a/src/event-gtk.c Fri Feb 07 01:43:07 2003 +0000 +++ b/src/event-gtk.c Fri Feb 07 11:50:54 2003 +0000 @@ -1,7 +1,7 @@ /* The event_stream interface for X11 with gtk, and/or tty frames. Copyright (C) 1991-5, 1997 Free Software Foundation, Inc. Copyright (C) 1995 Sun Microsystems, Inc. - Copyright (C) 1996, 2001, 2002 Ben Wing. + Copyright (C) 1996, 2001, 2002, 2003 Ben Wing. Copyright (C) 2000 William Perry. This file is part of XEmacs. @@ -93,6 +93,8 @@ || ((keysym) == GDK_Mode_switch) \ || ((keysym) == GDK_Num_Lock)) +#define THIS_IS_GTK +#include "event-xlike-inc.c" /************************************************************************/ @@ -1556,120 +1558,9 @@ while (gdk_events_pending ()) gtk_main_iteration (); +#ifdef HAVE_TTY drain_tty_devices (); -} - -static int -emacs_gtk_event_pending_p (int user_p) -{ - Lisp_Object event; - int tick_count_val; - - /* If `user_p' is false, then this function returns whether there are any - X, timeout, or fd events pending (that is, whether emacs_gtk_next_event() - would return immediately without blocking). - - if `user_p' is true, then this function returns whether there are any - *user generated* events available (that is, whether there are keyboard - or mouse-click events ready to be read). This also implies that - emacs_Xt_next_event() would not block. - - In a non-SIGIO world, this also checks whether the user has typed ^G, - since this is a convenient place to do so. We don't need to do this - in a SIGIO world, since input causes an interrupt. - */ - - /* This function used to simply check whether there were any X - events (or if user_p was 1, it iterated over all the pending - X events using XCheckIfEvent(), looking for keystrokes and - button events). That worked in the old cheesoid event loop, - which didn't go through XtAppDispatchEvent(), but it doesn't - work any more -- X events may not result in anything. For - example, a button press in a blank part of the menubar appears - as an X event but will not result in any Emacs events (a - button press that activates the menubar results in an Emacs - event through the stop_next_event mechanism). - - The only accurate way of determining whether these X events - translate into Emacs events is to go ahead and dispatch them - until there's something on the dispatch queue. */ - - /* See if there are any user events already on the queue. */ - EVENT_CHAIN_LOOP (event, dispatch_event_queue) - if (!user_p || command_event_p (event)) - return 1; - - /* See if there's any TTY input available. - */ - if (poll_fds_for_input (tty_only_mask)) - return 1; - - if (!user_p) - { - /* If not user_p and there are any timer or file-desc events - pending, we know there will be an event so we're through. */ -/* XtInputMask pending_value; */ - - /* Note that formerly we just checked the value of XtAppPending() - to determine if there was file-desc input. This doesn't - work any more with the signal_event_pipe; XtAppPending() - will says "yes" in this case but there isn't really any - input. Another way of fixing this problem is for the - signal_event_pipe to generate actual input in the form - of an identity eval event or something. (#### maybe this - actually happens?) */ - - if (poll_fds_for_input (process_only_mask)) - return 1; - - /* #### Is there any way to do this in Gtk? I don't think there - is a 'peek' for events */ -#if 0 - pending_value = XtAppPending (Xt_app_con); - - if (pending_value & XtIMTimer) - return 1; #endif - } - - /* XtAppPending() can be super-slow, esp. over a network connection. - Quantify results have indicated that in some cases the - call to detect_input_pending() completely dominates the - running time of redisplay(). Fortunately, in a SIGIO world - we can more quickly determine whether there are any X events: - if an event has happened since the last time we checked, then - a SIGIO will have happened. On a machine with broken SIGIO, - we'll still be in an OK state -- the sigio_happened flag - will get set at least once a second, so we'll be no more than - one second behind reality. (In general it's OK if we - erroneously report no input pending when input is actually - pending() -- preemption is just a bit less efficient, that's - all. It's bad bad bad if you err the other way -- you've - promised that `next-event' won't block but it actually will, - and some action might get delayed until the next time you - hit a key.) - */ - - /* quit_check_signal_tick_count is volatile so try to avoid race conditions - by using a temporary variable */ - tick_count_val = quit_check_signal_tick_count; - if (last_quit_check_signal_tick_count != tick_count_val) - { - last_quit_check_signal_tick_count = tick_count_val; - - /* We need to drain the entire queue now -- if we only - drain part of it, we may later on end up with events - actually pending but detect_input_pending() returning - false because there wasn't another SIGIO. */ - - emacs_gtk_drain_queue (); - - EVENT_CHAIN_LOOP (event, dispatch_event_queue) - if (!user_p || command_event_p (event)) - return 1; - } - - return 0; } static void