Mercurial > hg > xemacs-beta
diff lisp/bytecomp.el @ 4783:e29fcfd8df5f
Eliminate most core code byte-compile warnings.
2009-12-18 Aidan Kehoe <kehoea@parhasard.net>
* alist.el (modify-alist):
* autoload.el (update-autoload-files, autoload-print-form):
* bytecomp.el (batch-byte-compile-1)
(byte-compile-multiple-value-call, byte-compile-funcall)
(byte-compile-insert, byte-compile-concat, byte-compile-list)
(byte-compile-normal-call, byte-compile-flush-pending):
* cl-macs.el (letf):
* cl.el:
* disass.el (disassemble-1):
* easy-mmode.el (easy-mmode-define-syntax):
* faces.el (set-face-parent):
* files.el (cd):
* finder.el (finder-list-matches, finder-list-keywords)
(finder-compile-keywords):
* frame.el (frame-notice-user-settings)
(frame-remove-geometry-props):
* ldap.el (ldap-delete-entries, ldap-modify-entries)
(ldap-add-entries):
* loadhist.el (unload-feature):
* map-ynp.el (map-y-or-n-p):
* menubar-items.el (default-menubar):
* mouse.el (default-mouse-track-next-move-rect)
(default-mouse-track-next-move-rect)
(default-mouse-track-cleanup-hook)
(default-mouse-track-cleanup-extent):
* mule/ethio-util.el (ethio-fidel-to-sera-buffer)
(ethio-modify-vowel):
* obsolete.el:
* package-get.el (package-get-update-all):
* package-ui.el (pui-list-packages)
(pui-install-selected-packages, pui-install-selected-packages):
* select.el (select-make-extent-for-selection)
(dehilight-selection):
* simple.el (clone-buffer):
* term/tvi970.el:
* term/wyse50.el:
* unicode.el:
(load-unicode-tables):
* x-font-menu.el (fc-make-font-menu-entry)
(x-reset-device-font-menus-xft):
* x-misc.el (x-init-specifier-from-resources):
Eliminate byte-compile warnings, with the exception of Stephen's
various non-defined fontconfig functions, as I don't know if he
plans to add them and is keeping the warnings around as a
reminder. The warnings actually eliminated involve i) using mapcar
instead of mapc where the result is discarded and ii) using a
lambda quoted as data in a context where it is unequivocally used
as a function.
author | Aidan Kehoe <kehoea@parhasard.net> |
---|---|
date | Fri, 18 Dec 2009 17:49:43 +0000 |
parents | 1d61580e0cf7 |
children | 6772ce4d982b |
line wrap: on
line diff
--- a/lisp/bytecomp.el Fri Dec 18 10:09:54 2009 -0700 +++ b/lisp/bytecomp.el Fri Dec 18 17:49:43 2009 +0000 @@ -2071,7 +2071,7 @@ (if byte-compile-output (let ((form (byte-compile-out-toplevel t 'file))) (cond ((eq (car-safe form) 'progn) - (mapcar 'byte-compile-output-file-form (cdr form))) + (mapc 'byte-compile-output-file-form (cdr form))) (form (byte-compile-output-file-form form))) (setq byte-compile-constants nil @@ -2862,7 +2862,7 @@ (if byte-compile-generate-call-tree (byte-compile-annotate-call-tree form)) (byte-compile-push-constant (car form)) - (mapcar 'byte-compile-form (cdr form)) ; wasteful, but faster. + (mapc 'byte-compile-form (cdr form)) ; wasteful, but faster. (byte-compile-out 'byte-call (length (cdr form)))) ;; kludge added to XEmacs to work around the bogosities of a nonlexical lisp. @@ -3392,12 +3392,12 @@ ((= nargs 0) (byte-compile-constant nil)) ((< nargs 5) - (mapcar 'byte-compile-form args) + (mapc 'byte-compile-form args) (byte-compile-out (aref [byte-list1 byte-list2 byte-list3 byte-list4] (1- nargs)) 0)) ((< nargs 256) - (mapcar 'byte-compile-form args) + (mapc 'byte-compile-form args) (byte-compile-out 'byte-listN nargs)) (t (byte-compile-normal-call form))))) @@ -3407,14 +3407,14 @@ ;; Concat of one arg is not a no-op if arg is not a string. (cond ((memq nargs '(2 3 4)) - (mapcar 'byte-compile-form args) + (mapc 'byte-compile-form args) (byte-compile-out (aref [byte-concat2 byte-concat3 byte-concat4] (- nargs 2)) 0)) ((eq nargs 0) (byte-compile-form "")) ((< nargs 256) - (mapcar 'byte-compile-form args) + (mapc 'byte-compile-form args) (byte-compile-out 'byte-concatN nargs)) ((byte-compile-normal-call form))))) @@ -3588,7 +3588,7 @@ (cond ((null (cdr form)) (byte-compile-constant nil)) ((<= (length form) 256) - (mapcar 'byte-compile-form (cdr form)) + (mapc 'byte-compile-form (cdr form)) (if (cdr (cdr form)) (byte-compile-out 'byte-insertN (length (cdr form))) (byte-compile-out 'byte-insert 0))) @@ -3945,7 +3945,7 @@ (setq for-effect nil))) (defun byte-compile-funcall (form) - (mapcar 'byte-compile-form (cdr form)) + (mapc 'byte-compile-form (cdr form)) (byte-compile-out 'byte-call (length (cdr (cdr form))))) @@ -4148,7 +4148,7 @@ ;; and pushes a new value, the specpdl_depth() at the time it was ;; called. (byte-compile-out 'byte-bind-multiple-value-limits 0) - (mapcar 'byte-compile-form (cdr form)) + (mapc 'byte-compile-form (cdr form)) ;; Most of the other code puts this sort of value in the program stream, ;; not pushing it on the stack. (byte-compile-push-constant (+ 3 (length form))) @@ -4580,7 +4580,7 @@ (if (fboundp 'display-error) ; XEmacs 19.8+ (display-error err nil) (princ (or (get (car err) 'error-message) (car err))) - (mapcar #'(lambda (x) (princ " ") (prin1 x)) (cdr err))) + (mapc #'(lambda (x) (princ " ") (prin1 x)) (cdr err))) (princ "\n") nil)))