Mercurial > hg > xemacs-beta
diff src/minibuf.c @ 5666:daf5accfe973
Use #'test-completion, minibuf.el, instead of implementing same.
lisp/ChangeLog addition:
2012-05-14 Aidan Kehoe <kehoea@parhasard.net>
Update minibuf.el to use #'test-completion, use the generality of
recent completion changes to avoid some unnecessary consing when
reading.
* behavior.el (read-behavior):
* cus-edit.el (custom-face-prompt):
* cus-edit.el (widget-face-action):
* faces.el (read-face-name):
* minibuf.el:
* minibuf.el (minibuffer-completion-table):
* minibuf.el (exact-minibuffer-completion-p):
Removed. #'test-completion is equivalent to this, but more
general.
* minibuf.el (minibuffer-do-completion-1): Use #'test-completion.
* minibuf.el (completing-read): Update the documentation of the
arguments used for completion.
* minibuf.el (minibuffer-complete-and-exit): Use #'test-completion.
* minibuf.el (exit-minibuffer): Use #'test-completion.
* minibuf.el (minibuffer-smart-mouse-tracker): Use #'test-completion.
* minibuf.el (read-color): No need to construct a completion table
separate from the colour list.
src/ChangeLog addition:
2012-05-14 Aidan Kehoe <kehoea@parhasard.net>
* minibuf.c (Ftest_completion):
Correct some documentation here.
author | Aidan Kehoe <kehoea@parhasard.net> |
---|---|
date | Mon, 14 May 2012 08:46:05 +0100 |
parents | 2014ff433daf |
children | b79e1e02bf01 |
line wrap: on
line diff
--- a/src/minibuf.c Sat May 12 18:12:13 2012 +0100 +++ b/src/minibuf.c Mon May 14 08:46:05 2012 +0100 @@ -688,13 +688,12 @@ } DEFUN ("test-completion", Ftest_completion, 2, 3, 0, /* -Return non-nil if STRING is a valid completion in COLLECTION. +Return non-nil if STRING is an exact completion in COLLECTION. COLLECTION must be a list, a hash table, an obarray, or a function. Each string (or symbol) in COLLECTION is tested to see if it (or its -name) begins with STRING. The value is a list of all the strings from -COLLECTION that match. +name) begins with STRING, until a valid, exact completion is found. If COLLECTION is a list, the elements of the list that are not cons cells and the cars of the elements of the list that are cons cells @@ -755,7 +754,7 @@ lookup, 0) ? Qnil : Qt; /* It would be reasonable to do something similar for the hash - tables, except, both symbol and string keys are vaild + tables, except, both symbol and string keys are valid completions there. So a negative #'gethash for the string (with #'equal as the hash table tests) still means you have to do the linear search, for any symbols with that string