diff src/unicode.c @ 1318:b531bf8658e9

[xemacs-hg @ 2003-02-21 06:56:46 by ben] redisplay fixes et al. PROBLEMS: Add comment about Cygwin, unexec and sysmalloc. Move some non-general stuff out of general. Make a section for x86. configure.in: Add check for broken alloca in funcalls. mule/mule-cmds.el: Alias file-name to native not vice-versa. Do set EOL of native but not of process output to fix various problems and be consistent with code-init.el. code-cmds.el: Return a name not a coding system. code-init.el: Reindent. Remove `file-name' since it should always be the same as native. unicode.el: Rename to load-unicode-mapping-table as suggested by the anonymous (but rather Turnbullian) comment in unicode.c. xemacs.dsp: Add /k to default build. alloc.c: Make gc_currently_forbidden static. config.h.in, lisp.h: Move some stuff to lisp.h. console-gtk.h, console-impl.h, console-msw.h, console-x.h, event-Xt.c, event-msw.c, redisplay-gtk.c, redisplay-msw.c, redisplay-output.c, redisplay-x.c, gtk-xemacs.c: Remove duplicated code to redraw exposed area. Add deadbox method needed by the generalized redraw code. Defer redrawing if already in redisplay. frame-msw.c, event-stream.c, frame.c: Add comments about calling Lisp. debug.c, general-slots.h: Move generalish symbols to general-slots.h. doprnt.c: reindent. lisp.h, dynarr.c: Add debug code for locking a dynarr to catch invalid mods. Use in redisplay.c. eval.c: file-coding.c: Define file-name as alias for native not vice-versa. frame-gtk.c, frame-x.c: Move Qwindow_id to general-slots. dialog-msw.c, glyphs-gtk.c, glyphs-msw.c, glyphs-widget.c, glyphs-x.c, gui.c, gui.h, menubar-msw.c, menubar.c: Ensure that various glyph functions that eval within redisplay protect the evals. Same for calls to internal_equal(). Modify various functions, e.g. gui_item_*(), to protect evals within redisplay, taking an in_redisplay parameter if it's possible for them to be called both inside and outside of redisplay. gutter.c: Defer specifier-changed updating till after redisplay, if necessary, since we need to enter redisplay to do it. gutter.c: Do nothing if in redisplay. lisp.h: Add version of alloca() for use in function calls. lisp.h: Add XCAD[D+]R up to 6 D's, and aliases X1ST, X2ND, etc. frame.c, frame.h, redisplay.c, redisplay.h, signal.c, toolbar.c: Redo critical-section code and move from frame.c to redisplay.c. Require that every place inside of redisplay catch errors itself, not at the edge of the critical section (thereby bypassing the rest of redisplay and leaving things in an inconsistent state). Introduce separate means of holding frame-size changes without entering a complete critical section. Introduce "post-redisplay" methods for deferring things till after redisplay. Abort if we enter redisplay reentrantly. Disable all quit checking in redisplay since it's too dangerous. Ensure that all calls to QUIT trigger an abort if unprotected. redisplay.c, scrollbar-gtk.c, scrollbar-x.c, scrollbar.c: Create enter/exit_redisplay_critical_section_maybe() for code that needs to ensure it's in a critical section but doesn't interfere with an existing critical section. sysdep.c: Use _wexecve() when under Windows NT for Unicode correctness. text.c, text.h: Add new_dfc() functions, which return an alloca()ed value rather than requiring an lvalue. (Not really used yet; used in another workspace, to come.) Add some macros for SIZED_EXTERNAL. Update the encoding aliases after involved scrutinization of the X manual. unicode.c: Answer the anonymous but suspiciously Turnbullian questions. Rename parse-unicode-translation-table to load-unicode-mapping-table, as suggested.
author ben
date Fri, 21 Feb 2003 06:57:21 +0000
parents 70921960b980
children 969b7290edca
line wrap: on
line diff
--- a/src/unicode.c	Thu Feb 20 22:52:51 2003 +0000
+++ b/src/unicode.c	Fri Feb 21 06:57:21 2003 +0000
@@ -54,7 +54,11 @@
    something evil and unpredictable?  Signaling an error is OK: for
    all national standards, the national to Unicode map is an inclusion
    (1-to-1).  Any character set that does not behave that way is
-   broken according to the Unicode standard. */
+   broken according to the Unicode standard.
+
+   Answer: You will get an abort(), since the purpose of the sledgehammer
+   routines is self-checking.  The above problem with non-1-to-1 mapping
+   occurs in the Big5 tables, as provided by the Unicode Consortium. */
 
 /* #define SLEDGEHAMMER_CHECK_UNICODE */
 
@@ -164,7 +168,10 @@
 #ifdef MULE 
 
 /* #### Using ints for to_unicode is OK (as long as they are >= 32 bits).
-   However, shouldn't the shorts below be unsigned? */
+   However, shouldn't the shorts below be unsigned?
+
+   Answer: Doesn't matter because the values being converted to are only
+   96x96. */
 static int *to_unicode_blank_1;
 static int **to_unicode_blank_2;
 
@@ -299,7 +306,11 @@
   for (i = 0; i < 256; i++)
     {
       /* #### IMWTK: Why does using -1 here work? Simply because there are
-         no existing 96x96 charsets? */
+         no existing 96x96 charsets?
+
+         Answer: I don't understand the concern.  -1 indicates there is no
+         entry for this particular codepoint, which is always the case for
+	 blank tables. */
       from_unicode_blank_1[i] = (short) -1;
       from_unicode_blank_2[i] = from_unicode_blank_1;
       from_unicode_blank_3[i] = from_unicode_blank_2;
@@ -354,7 +365,7 @@
 }
 
 /* Allocate and blank the tables.
-   Loading them up is done by parse-unicode-translation-table. */
+   Loading them up is done by load-unicode-mapping-table. */
 void
 init_charset_unicode_tables (Lisp_Object charset)
 {
@@ -1055,6 +1066,8 @@
 The language-specific precedence list is meant to be set as part of the
 language environment initialization; the default precedence list is meant
 to be set by the user.
+
+#### NOTE: This interface may be changed.
 */
        ())
 {
@@ -1073,13 +1086,17 @@
    precedence, respectively.  This means that users are sometimes going to
    want to set Vlanguage_unicode_precedence_list.
    Furthermore, this should be language-local (buffer-local would be a
-   reasonable approximation). */
+   reasonable approximation).
+
+   Answer: You are right, this needs rethinking. */
 DEFUN ("set-language-unicode-precedence-list",
        Fset_language_unicode_precedence_list,
        1, 1, 0, /*
 Set the language-specific precedence of charsets in Unicode decoding.
 LIST is a list of charsets.
 See `unicode-precedence-list' for more information.
+
+#### NOTE: This interface may be changed.
 */
        (list))
 {
@@ -1098,6 +1115,8 @@
        0, 0, 0, /*
 Return the language-specific precedence list used for Unicode decoding.
 See `unicode-precedence-list' for more information.
+
+#### NOTE: This interface may be changed.
 */
        ())
 {
@@ -1110,6 +1129,8 @@
 Set the default precedence list used for Unicode decoding.
 This is intended to be set by the user.  See
 `unicode-precedence-list' for more information.
+
+#### NOTE: This interface may be changed.
 */
        (list))
 {
@@ -1128,6 +1149,8 @@
        0, 0, 0, /*
 Return the default precedence list used for Unicode decoding.
 See `unicode-precedence-list' for more information.
+
+#### NOTE: This interface may be changed.
 */
        ())
 {
@@ -1259,9 +1282,7 @@
   return Qnil;
 }
 
-/* #### shouldn't this interface be called load-unicode-mapping-table
-   for consistency with Unicode Consortium terminology? */
-DEFUN ("parse-unicode-translation-table", Fparse_unicode_translation_table,
+DEFUN ("load-unicode-mapping-table", Fload_unicode_mapping_table,
        2, 6, 0, /*
 Load Unicode tables with the Unicode mapping data in FILENAME for CHARSET.
 Data is text, in the form of one translation per line -- charset
@@ -1331,7 +1352,7 @@
 	  big5 = 1;
 	else
 	  invalid_constant
-	    ("Unrecognized `parse-unicode-translation-table' flag", elt);
+	    ("Unrecognized `load-unicode-mapping-table' flag", elt);
       }
   }
 
@@ -2315,7 +2336,7 @@
   DEFSUBR (Fdefault_unicode_precedence_list);
   DEFSUBR (Fset_unicode_conversion);
 
-  DEFSUBR (Fparse_unicode_translation_table);
+  DEFSUBR (Fload_unicode_mapping_table);
 
   DEFSYMBOL (Qignore_first_column);
 #endif /* MULE */