Use better types when ESCAPECHAR is specified, split_string_by_ichar_1 src/ChangeLog addition: 2010-02-19 Aidan Kehoe <kehoea@parhasard.net> * fns.c (split_string_by_ichar_1): Use better types (e.g., not an Ichar for a buffer size) in this function when dealing with ESCAPECHAR. tests/ChangeLog addition: 2010-02-19 Aidan Kehoe <kehoea@parhasard.net> * automated/lisp-tests.el: Change the #'split-string-by-char text to use US federal government information instead of a couple of sentences from the OED; the latter would probably have qualified as non-infringement, but with the former the question won't arise. (The German text in the same tests is from a very public domain 19th-century work.)

--- a/src/fns.c	Sun Feb 07 12:24:03 2010 +0000
+++ b/src/fns.c	Fri Feb 19 23:46:53 2010 +0000
@@ -1070,10 +1070,10 @@
     {
       Ibyte unescape_buffer[64], *unescape_buffer_ptr = unescape_buffer,
         escaped[MAX_ICHAR_LEN], *unescape_cursor;
-      int deleting_escapes, previous_escaped, escaped_len; 
-      Ichar pchar, unescape_buffer_size = countof (unescape_buffer);
-
-      escaped_len = set_itext_ichar (escaped, escapechar);
+      Bytecount unescape_buffer_size = countof (unescape_buffer),
+        escaped_len = set_itext_ichar (escaped, escapechar);
+      Boolint deleting_escapes, previous_escaped;
+      Ichar pchar;
 
       while (1)
         {