error-checking, Windows shutdown changes -------------------- ChangeLog entries follow: -------------------- src/ChangeLog addition: 2010-02-09 Ben Wing <ben@xemacs.org> * dynarr.c (Dynarr_insert_many): * dynarr.c (Dynarr_delete_many): * emacs.c: * emacs.c (pause_so_user_can_read_messages): * emacs.c (Fkill_emacs): * emacs.c (guts_of_fatal_error_signal): * lisp.h: * lisp.h (INLINE_ERROR_CHECK_ARGS): * lisp.h (Dynarr_set_length_1): * lisp.h (Dynarr_set_length): * lisp.h (Dynarr_pop): Add ERROR_CHECK_DYNARR, dynarr_checking_assert(). Use it. Sort existing error-check categories in lisp.h, remove most of the (unused) assert variations from most categories. Add a long comment about reorganizing the system by categories and subcategories. Create ERROR_CHECK_ANY if any error-checking categories defined, and use it in emacs.c to define USER_IS_DEVELOPING_XEMACS. In emacs.c and cmdloop.c, don't display a message at early shutdown or fatal shutdown when on Cygwin, only Windows native -- Cygwin has a working stderr that shows error output. Update comment in Dynarr_verify_pos_atp().

--- a/src/dynarr.c	Tue Feb 09 19:07:36 2010 -0600
+++ b/src/dynarr.c	Tue Feb 09 19:13:44 2010 -0600
@@ -245,7 +245,7 @@
 
   /* #### This could conceivably be wrong, if code wants to access stuff
      between len and largest. */
-  structure_checking_assert (start >= 0 && start <= Dynarr_length (dy));
+  dynarr_checking_assert (start >= 0 && start <= Dynarr_length (dy));
 
   if (start != Dynarr_length (dy))
     {
@@ -267,8 +267,8 @@
 {
   Dynarr *dy = Dynarr_verify_mod (d);
 
-  structure_checking_assert (start >= 0 && len >= 0 &&
-			     start + len <= Dynarr_length (dy));
+  dynarr_checking_assert (start >= 0 && len >= 0 &&
+			  start + len <= Dynarr_length (dy));
 
   memmove ((char *) dy->base + start*dy->elsize,
 	   (char *) dy->base + (start + len)*dy->elsize,