diff src/events.c @ 5736:3192994c49ca

Convert C (un)signed long long values to bignums properly. This patch also does the following: - Uses make_fixnum instead of make_integer when the argument is guaranteed to be in the fixnum range. - Introduces make_unsigned_integer so that we handle unsigned values with the high bit set correctly. - Introduces conversions between bignums and (un)signed long long values. - Uses mp_set_memory_functions with the BSD MP code, if it exists. - Eliminates some unnecessary consing in the Lisp + and * implementations. - Fixes a problem with check_valid_xbm_inline(). This function is called during intialization. It calls Ftimes. When using pdump, this is a problem, because (a) the bignum code is not initialized until *after* dumping, so we don't try to dump any bignums, and (b) multiplication of integers is done inside bignums so we handle fixnum overflow correctly. I decided that an XBM file with dimensions that don't fit into fixnums is probably not something we want to try to handle anyway, and did the arithmetic with C values instead of Lisp values. Doing that broke one test, which started getting a different error message from the one it expected, so I adjusted the test to match the new reality. - Fixes a few miscellaneous bugs in the BSD MP code. See <CAHCOHQk0u0=eD1fUMHTNWi2Yh=1WgiYyCXdMbsGzHBNhdqYz4w@mail.gmail.com> in xemacs-patches, as well as followup messages.
author Jerry James <james@xemacs.org>
date Mon, 17 Jun 2013 10:23:00 -0600
parents 56144c8593a8
children f9e4d44504a4
line wrap: on
line diff
--- a/src/events.c	Wed Apr 24 20:16:14 2013 -0400
+++ b/src/events.c	Mon Jun 17 10:23:00 2013 -0600
@@ -735,13 +735,13 @@
 	else if (EQ (keyword, Qtimestamp))
 	  {
 #ifdef HAVE_BIGNUM
-            check_integer_range (value, Qzero, make_integer (UINT_MAX));
+            check_integer_range (value, Qzero, make_unsigned_integer (UINT_MAX));
             if (BIGNUMP (value))
               {
                 SET_EVENT_TIMESTAMP (e, bignum_to_uint (XBIGNUM_DATA (value)));
               }
 #else
-            check_integer_range (value, Qzero, make_integer (MOST_POSITIVE_FIXNUM));
+            check_integer_range (value, Qzero, make_fixnum (MOST_POSITIVE_FIXNUM));
 #endif
             if (FIXNUMP (value))
               {
@@ -1777,8 +1777,8 @@
 {
   EMACS_INT t1, t2;
 
-  check_integer_range (time1, Qzero, make_integer (MOST_POSITIVE_FIXNUM));
-  check_integer_range (time2, Qzero, make_integer (MOST_POSITIVE_FIXNUM));
+  check_integer_range (time1, Qzero, make_fixnum (MOST_POSITIVE_FIXNUM));
+  check_integer_range (time2, Qzero, make_fixnum (MOST_POSITIVE_FIXNUM));
 
   t1 = XFIXNUM (time1);
   t2 = XFIXNUM (time2);