diff tests/automated/keymap-tests.el @ 5822:21b5725c6a45

Reformat loops for readability and maintainability.
author Stephen J. Turnbull <stephen@xemacs.org>
date Sun, 19 Oct 2014 17:54:50 +0900
parents e34c3557e14e
children
line wrap: on
line diff
--- a/tests/automated/keymap-tests.el	Sun Oct 19 17:54:46 2014 +0900
+++ b/tests/automated/keymap-tests.el	Sun Oct 19 17:54:50 2014 +0900
@@ -27,43 +27,74 @@
        (help-map-copy t)
        (minor-mode-map-alist (acons 'help-map-copy map minor-mode-map-alist)))
   (set-keymap-parent map parent-map)
-  (loop for (keys def) on '((shift tab) help-prev-symbol tab
-                            help-next-symbol c customize-variable V
-                            find-variable-at-point q
-                            help-mode-quit f find-function-at-point d
-                            describe-function-at-point D
-                            describe-function-at-point v
-                            describe-variable-at-point i Info-elisp-ref F
-                            find-function-at-point Q help-mode-bury button2
-                            help-mouse-find-source-or-track p
-                            help-prev-section n help-next-section return
-                            help-activate-function-or-scroll-up)
+  ;; Take care in choosing commands for these tests!  Many of the commands
+  ;; here are defined in packages, which may not be available to make check.
+  (loop for (keys def) on '((shift tab) help-prev-symbol
+			    tab help-next-symbol
+			    c customize-variable
+			    V find-variable-at-point
+			    q help-mode-quit
+			    f find-function-at-point
+			    d describe-function-at-point
+			    D describe-function-at-point
+			    v describe-variable-at-point
+			    i Info-elisp-ref
+			    F find-function-at-point
+			    Q help-mode-bury
+			    button2 help-mouse-find-source-or-track
+			    p help-prev-section
+			    n help-next-section
+			    return help-activate-function-or-scroll-up)
         by #'cddr
         do (define-key map (vector keys) def))
-  (loop for (keys def) on '(u view-scroll-some-lines-down % view-goto-percent
-                            \2 digit-argument p view-goto-percent \? 
-                            view-search-backward - negative-argument k
-                            view-scroll-lines-down backspace scroll-down G
-                            view-last-windowful f scroll-up \5
-                            digit-argument s view-repeat-search \0
-                            digit-argument n view-repeat-search = what-line
-                            \\ view-search-backward delete scroll-down \8
-                            digit-argument E view-file d
-                            view-scroll-some-lines-up \3 digit-argument q
-                            view-quit ! shell-command (control j)
-                            view-scroll-lines-up (control m)
-                            view-scroll-lines-up y view-scroll-lines-down
-                            linefeed view-scroll-lines-up g view-goto-line
-                            \6 digit-argument t toggle-truncate-lines C
-                            view-cleanup-backspaces b scroll-down \1
-                            digit-argument P view-buffer return
-                            view-scroll-lines-up | shell-command-on-region j
-                            view-scroll-lines-up \9 digit-argument \'
-                            register-to-point e view-scroll-lines-up \4
-                            digit-argument r recenter space scroll-up /
-                            view-search-forward N view-buffer m
-                            point-to-register h view-mode-describe \7
-                            digit-argument
+  (loop for (keys def) on '(u view-scroll-some-lines-down
+			    % view-goto-percent
+                            \2 digit-argument
+			    p view-goto-percent
+			    \?  view-search-backward
+			    - negative-argument
+			    k view-scroll-lines-down
+			    backspace scroll-down
+			    G view-last-windowful
+			    f scroll-up
+			    \5 digit-argument
+			    s view-repeat-search
+			    \0 digit-argument
+			    n view-repeat-search
+			    = what-line
+                            \\ view-search-backward
+			    delete scroll-down
+			    \8 digit-argument
+			    E view-file
+			    d view-scroll-some-lines-up
+			    \3 digit-argument
+			    q view-quit
+			    ! shell-command
+			    (control j) view-scroll-lines-up
+			    (control m) view-scroll-lines-up
+			    y view-scroll-lines-down
+                            linefeed view-scroll-lines-up
+			    g view-goto-line
+                            \6 digit-argument
+			    t toggle-truncate-lines
+			    C view-cleanup-backspaces
+			    b scroll-down
+			    \1 digit-argument
+			    P view-buffer
+			    return view-scroll-lines-up
+			    | shell-command-on-region
+			    j view-scroll-lines-up
+			    \9 digit-argument
+			    \' register-to-point
+			    e view-scroll-lines-up
+			    \4 digit-argument
+			    r recenter
+			    space scroll-up
+			    / view-search-forward
+			    N view-buffer
+			    m point-to-register
+			    h view-mode-describe
+			    \7 digit-argument
                             describe-function-at-point view-mode-describe)
         by #'cddr
         do (define-key parent-map (vector keys) def))