Mercurial > hg > xemacs-beta
diff src/mule-charset.c @ 4745:0c54de4c4b9d
Resolve the unregistered-CCL-programs-get-garbage-collected problem correctly
src/ChangeLog addition:
2009-11-15 Aidan Kehoe <kehoea@parhasard.net>
* mule-ccl.c (CCL_CALL_FOR_MAP_INSTRUCTION): Assert that we always
have a symbol in this macro.
(setup_ccl_program): Ensure we're not allocating unreachable
memory in this function; all symbols must have been resolved in a
given CCL program before this function is called.
(find_ccl_program): New function, return a CCL program with all
its symbols resolved if it is valid (possibly allocating memory),
Qnil otherwise.
(get_ccl_program): New function, exported to other files; call
find_ccl_program, and error if it gives nil.
(Fccl_program_p): Call find_ccl_program from this function instead
of implementing the bulk of it here.
(Fccl_execute): Call get_ccl_program instead of implementing the
bulk of it here.
(Fccl_execute_on_string): Ditto.
* mule-ccl.h (Vfont_ccl_encoder_alist): Remove this declaration,
it hasn't been used in years.
(get_ccl_program): Declare this function.
* mule-coding.c (ccl_putprop): Use get_ccl_program on any
specified encode or decode CCL program property.
(fixed_width_putprop): Ditto.
* mule-charset.c (Fmake_charset): Use get_ccl_program on any
specified ccl-program.
(Fset_charset_ccl_program): Ditto.
author | Aidan Kehoe <kehoea@parhasard.net> |
---|---|
date | Sun, 15 Nov 2009 16:53:14 +0000 |
parents | 3ba90c659d01 |
children | 980575c76541 fd36a980d701 c12b646d84ee e0db3c197671 |
line wrap: on
line diff
--- a/src/mule-charset.c Sun Nov 15 14:59:53 2009 +0000 +++ b/src/mule-charset.c Sun Nov 15 16:53:14 2009 +0000 @@ -587,11 +587,8 @@ } else if (EQ (keyword, Qccl_program)) { - struct ccl_program test_ccl; - - if (setup_ccl_program (&test_ccl, value) < 0) - invalid_argument ("Invalid value for `ccl-program'", value); - ccl_program = value; + /* This errors if VALUE is not a valid CCL program. */ + ccl_program = get_ccl_program (value); } else invalid_constant ("Unrecognized property", keyword); @@ -874,9 +871,8 @@ struct ccl_program test_ccl; charset = Fget_charset (charset); - if (setup_ccl_program (&test_ccl, ccl_program) < 0) - invalid_argument ("Invalid ccl-program", ccl_program); - XCHARSET_CCL_PROGRAM (charset) = ccl_program; + XCHARSET_CCL_PROGRAM (charset) = get_ccl_program (ccl_program); + face_property_was_changed (Vdefault_face, Qfont, Qglobal); return Qnil; }