comparison lisp/ChangeLog @ 5745:f9e4d44504a4

Document #'events-to-keys some more, use it less. lisp/ChangeLog addition: 2013-07-10 Aidan Kehoe <kehoea@parhasard.net> * minibuf.el (get-user-response): * cmdloop.el (y-or-n-p-minibuf): No need to call #'events-to-keys in these two functions, #'lookup-key accepts events directly. * keymap.el: * keymap.el (events-to-keys): Document this function some more. Stop passing strings through unexamined, treat them as vectors of characters. Event keys are never integers, remove some code that only ran if (integerp (event-key ce)). Event keys are never numbers, don't check for that. Don't create (menu-selection call-interactively function-name) keystrokes for menu choices, #'character-to-event doesn't understand that syntax, so nothing uses it. Don't ever accept mouse events, #'character-to-event doesn't accept our synthesising of them. src/ChangeLog addition: 2013-07-10 Aidan Kehoe <kehoea@parhasard.net> * keymap.c: * keymap.c (key_desc_list_to_event): Drop the allow_menu_events argument. Don't accept lists starting with Qmenu_selection as describing keys, nothing generates them in a way this function understands. The intention is reasonable but the implementation was never documented and never finished. * keymap.c (syms_of_keymap): Drop Qmenu_selection. * events.c (Fcharacter_to_event): * keymap.h: Drop the allow_menu_events argument to key_desc_list_to_event.
author Aidan Kehoe <kehoea@parhasard.net>
date Wed, 10 Jul 2013 14:14:30 +0100
parents f6af091ac654
children 52b9fe8f44c0
comparison
equal deleted inserted replaced
5738:f6af091ac654 5745:f9e4d44504a4
1 2013-07-10 Aidan Kehoe <kehoea@parhasard.net>
2
3 * minibuf.el (get-user-response):
4 * cmdloop.el (y-or-n-p-minibuf):
5 No need to call #'events-to-keys in these two functions,
6 #'lookup-key accepts events directly.
7 * keymap.el:
8 * keymap.el (events-to-keys):
9 Document this function some more.
10 Stop passing strings through unexamined, treat them as vectors of
11 characters.
12 Event keys are never integers, remove some code that only ran if
13 (integerp (event-key ce)).
14 Event keys are never numbers, don't check for that.
15 Don't create (menu-selection call-interactively function-name)
16 keystrokes for menu choices, #'character-to-event doesn't
17 understand that syntax, so nothing uses it.
18 Don't ever accept mouse events, #'character-to-event doesn't
19 accept our synthesising of them.
20
1 2013-06-17 Aidan Kehoe <kehoea@parhasard.net> 21 2013-06-17 Aidan Kehoe <kehoea@parhasard.net>
2 22
3 * process.el (process-synchronize-point): Moved to a label. 23 * process.el (process-synchronize-point): Moved to a label.
4 * process.el (call-process-internal): 24 * process.el (call-process-internal):
5 Now we have better language features, use them rather than 25 Now we have better language features, use them rather than