Mercurial > hg > xemacs-beta
comparison src/menubar-gtk.c @ 2367:ecf1ebac70d8
[xemacs-hg @ 2004-11-04 23:05:23 by ben]
commit mega-patch
configure.in: Turn off -Winline and -Wchar-subscripts.
Use the right set of cflags when compiling modules.
Rewrite ldap configuration to separate the inclusion of lber
(needed in recent Cygwin) from the basic checks for the
needed libraries.
add a function for MAKE_JUNK_C; initially code was added to
generate xemacs.def using this, but it will need to be rewritten.
add an rm -f for junk.c to avoid weird Cygwin bug with cp -f onto
an existing file.
Sort list of auto-detected functions and eliminate unused checks for
stpcpy, setlocale and getwd.
Add autodetection of Cygwin scanf problems
BETA: Rewrite section on configure to indicate what flags are important
and what not.
digest-doc.c, make-dump-id.c, profile.c, sorted-doc.c: Add proper decls for main().
make-msgfile.c: Document that this is old junk.
Move proposal to text.c.
make-msgfile.lex: Move proposal to text.c.
make-mswin-unicode.pl: Convert error-generating code so that the entire message will
be seen as a single unrecognized token.
mule/mule-ccl.el: Update docs.
lispref/mule.texi: Update CCL docs.
ldap/eldap.c: Mule-ize.
Use EXTERNAL_LIST_LOOP_2 instead of deleted EXTERNAL_LIST_LOOP.
* XEmacs 21.5.18 "chestnut" is released.
---------------------------------------------------------------
MULE-RELATED WORK:
---------------------------------------------------------------
---------------------------
byte-char conversion
---------------------------
buffer.c, buffer.h, insdel.c, text.c: Port FSF algorithm for byte-char conversion, replacing broken
previous version. Track the char position of the gap. Add
functions to do char-byte conversion downwards as well as upwards.
Move comments about algorithm workings to internals manual.
---------------------------
work on types
---------------------------
alloc.c, console-x-impl.h, dump-data.c, dump-data.h, dumper.c, dialog-msw.c, dired-msw.c, doc.c, editfns.c, esd.c, event-gtk.h, event-msw.c, events.c, file-coding.c, file-coding.h, fns.c, glyphs-eimage.c, glyphs-gtk.c, glyphs-msw.c, glyphs-shared.c, glyphs-x.c, glyphs.c, glyphs.h, gui.c, hpplay.c, imgproc.c, intl-win32.c, lrecord.h, lstream.c, keymap.c, lisp.h, libsst.c, linuxplay.c, miscplay.c, miscplay.h, mule-coding.c, nas.c, nt.c, ntheap.c, ntplay.c, objects-msw.c, objects-tty.c, objects-x.c, print.c, process-nt.c, process.c, redisplay.h, select-common.h, select-gtk.c, select-x.c, sgiplay.c, sound.c, sound.h, sunplay.c, sysfile.h, sysdep.c, syswindows.h, text.c, unexnt.c, win32.c, xgccache.c: Further work on types. This creates a full set of types for all
the basic semantics of `char' that I have so far identified, so that
its semantics can always be identified for the purposes of proper
Mule-safe code, and the raw use of `char' always avoided.
(1) More type renaming, for consistency of naming.
Char_ASCII -> Ascbyte
UChar_ASCII -> UAscbyte
Char_Binary -> CBinbyte
UChar_Binary -> Binbyte
SChar_Binary -> SBinbyte
(2) Introduce Rawbyte, CRawbyte, Boolbyte, Chbyte, UChbyte, and
Bitbyte and use them.
(3) New types Itext, Wexttext and Textcount for separating out
the concepts of bytes and textual units (different under UTF-16
and UTF-32, which are potential internal encodings).
(4) qxestr*_c -> qxestr*_ascii.
lisp.h: New; goes with other qxe() functions. #### Maybe goes in a
different section.
lisp.h: Group generic int-type defs together with EMACS_INT defs.
lisp.h: * lisp.h (WEXTTEXT_IS_WIDE)
New defns.
lisp.h: New type to replace places where int occurs as a boolean.
It's signed because occasionally people may want to use -1 as
an error value, and because unsigned ints are viral -- see comments
in the internals manual against using them.
dynarr.c: int -> Bytecount.
---------------------------
Mule-izing
---------------------------
device-x.c: Partially Mule-ize.
dumper.c, dumper.h: Mule-ize. Use Rawbyte. Use stderr_out not printf. Use wext_*().
sysdep.c, syswindows.h, text.c: New Wexttext API for manipulation of external text that may be
Unicode (e.g. startup code under Windows).
emacs.c: Mule-ize. Properly deal with argv in external encoding.
Use wext_*() and Wexttext. Use Rawbyte.
#if 0 some old junk on SCO that is unlikely to be correct.
Rewrite allocation code in run-temacs.
emacs.c, symsinit.h, win32.c: Rename win32 init function and call it even earlier, to
initialize mswindows_9x_p even earlier, for use in startup code
(XEUNICODE_P).
process.c: Use _wenviron not environ under Windows, to get Unicode environment
variables.
event-Xt.c: Mule-ize drag-n-drop related stuff.
dragdrop.c, dragdrop.h, frame-x.c: Mule-ize.
text.h: Add some more stand-in defines for particular kinds of conversion;
use in Mule-ization work in frame-x.c etc.
---------------------------
Freshening
---------------------------
intl-auto-encap-win32.c, intl-auto-encap-win32.h: Regenerate.
---------------------------
Unicode-work
---------------------------
intl-win32.c, syswindows.h: Factor out common options to MultiByteToWideChar and
WideCharToMultiByte. Add convert_unicode_to_multibyte_malloc()
and convert_unicode_to_multibyte_dynarr() and use. Add stuff for
alloca() conversion of multibyte/unicode.
alloc.c: Use dfc_external_data_len() in case of unicode coding system.
alloc.c, mule-charset.c: Don't zero out and reinit charset Unicode tables. This fucks up
dump-time loading. Anyway, either we load them at dump time or
run time, never both.
unicode.c: Dump the blank tables as well.
---------------------------------------------------------------
DOCUMENTATION, MOSTLY MULE-RELATED:
---------------------------------------------------------------
EmacsFrame.c, emodules.c, event-Xt.c, fileio.c, input-method-xlib.c, mule-wnnfns.c, redisplay-gtk.c, redisplay-tty.c, redisplay-x.c, regex.c, sysdep.c: Add comment about Mule work needed.
text.h: Add more documentation describing why DFC routines were not written
to return their value. Add some other DFC documentation.
console-msw.c, console-msw.h: Add pointer to docs in win32.c.
emacs.c: Add comments on sources of doc info.
text.c, charset.h, unicode.c, intl-win32.c, intl-encap-win32.c, text.h, file-coding.c, mule-coding.c: Collect background comments and related to text matters and
internationalization, and proposals for work to be done, in text.c
or Internals manual, stuff related to specific textual API's in
text.h, and stuff related to internal implementation of Unicode
conversion in unicode.c. Put lots of pointers to the comments to
make them easier to find.
s/mingw32.h, s/win32-common.h, s/win32-native.h, s/windowsnt.h, win32.c: Add bunches of new documentation on the different kinds of
builds and environments under Windows and how they work.
Collect this info in win32.c. Add pointers to these docs in
the relevant s/* files.
emacs.c: Document places with long comments.
Remove comment about exiting, move to internals manual, put
in pointer.
event-stream.c: Move docs about event queues and focus to internals manual, put
in pointer.
events.h: Move docs about event stream callbacks to internals manual, put
in pointer.
profile.c, redisplay.c, signal.c: Move documentation to the Internals manual.
process-nt.c: Add pointer to comment in win32-native.el.
lisp.h: Add comments about some comment conventions.
lisp.h: Add comment about the second argument.
device-msw.c, redisplay-msw.c: @@#### comments are out-of-date.
---------------------------------------------------------------
PDUMP WORK (MOTIVATED BY UNICODE CHANGES)
---------------------------------------------------------------
alloc.c, buffer.c, bytecode.c, console-impl.h, console.c, device.c, dumper.c, lrecord.h, elhash.c, emodules.h, events.c, extents.c, frame.c, glyphs.c, glyphs.h, mule-charset.c, mule-coding.c, objects.c, profile.c, rangetab.c, redisplay.c, specifier.c, specifier.h, window.c, lstream.c, file-coding.h, file-coding.c: PDUMP:
Properly implement dump_add_root_block(), which never worked before,
and is necessary for dumping Unicode tables.
Pdump name changes for accuracy:
XD_STRUCT_PTR -> XD_BLOCK_PTR.
XD_STRUCT_ARRAY -> XD_BLOCK_ARRAY.
XD_C_STRING -> XD_ASCII_STRING.
*_structure_* -> *_block_*.
lrecord.h: some comments added about
dump_add_root_block() vs dump_add_root_block_ptr().
extents.c: remove incorrect comment about pdump problems with gap array.
---------------------------------------------------------------
ALLOCATION
---------------------------------------------------------------
abbrev.c, alloc.c, bytecode.c, casefiddle.c, device-msw.c, device-x.c, dired-msw.c, doc.c, doprnt.c, dragdrop.c, editfns.c, emodules.c, file-coding.c, fileio.c, filelock.c, fns.c, glyphs-eimage.c, glyphs-gtk.c, glyphs-msw.c, glyphs-x.c, gui-msw.c, gui-x.c, imgproc.c, intl-win32.c, lread.c, menubar-gtk.c, menubar.c, nt.c, objects-msw.c, objects-x.c, print.c, process-nt.c, process-unix.c, process.c, realpath.c, redisplay.c, search.c, select-common.c, symbols.c, sysdep.c, syswindows.h, text.c, text.h, ui-byhand.c: New macros {alloca,xnew}_{itext,{i,ext,raw,bin,asc}bytes} for
more convenient allocation of these commonly requested items.
Modify functions to use alloca_ibytes, alloca_array, alloca_extbytes,
xnew_ibytes, etc. also XREALLOC_ARRAY, xnew.
alloc.c: Rewrite the allocation functions to factor out repeated code.
Add assertions for freeing dumped data.
lisp.h: Moved down and consolidated with other allocation stuff.
lisp.h, dynarr.c: New functions for allocation that's very efficient when mostly in
LIFO order.
lisp.h, text.c, text.h: Factor out some stuff for general use by alloca()-conversion funs.
text.h, lisp.h: Fill out convenience routines for allocating various kinds of
bytes and put them in lisp.h. Use them in place of xmalloc(),
ALLOCA().
text.h: Fill out the convenience functions so the _MALLOC() kinds match
the alloca() kinds.
---------------------------------------------------------------
ERROR-CHECKING
---------------------------------------------------------------
text.h: Create ASSERT_ASCTEXT_ASCII() and ASSERT_ASCTEXT_ASCII_LEN()
from similar Eistring checkers and change the Eistring checkers to
use them instead.
---------------------------------------------------------------
MACROS IN LISP.H
---------------------------------------------------------------
lisp.h: Redo GCPRO declarations. Create a "base" set of functions that can
be used to generate any kind of gcpro sets -- regular, ngcpro,
nngcpro, private ones used in GC_EXTERNAL_LIST_LOOP_2.
buffer.c, callint.c, chartab.c, console-msw.c, device-x.c, dialog-msw.c, dired.c, extents.c, ui-gtk.c, rangetab.c, nt.c, mule-coding.c, minibuf.c, menubar-msw.c, menubar.c, menubar-gtk.c, lread.c, lisp.h, gutter.c, glyphs.c, glyphs-widget.c, fns.c, fileio.c, file-coding.c, specifier.c: Eliminate EXTERNAL_LIST_LOOP, which does not check for circularities.
Use EXTERNAL_LIST_LOOP_2 instead or EXTERNAL_LIST_LOOP_3
or EXTERNAL_PROPERTY_LIST_LOOP_3 or GC_EXTERNAL_LIST_LOOP_2
(new macro). Removed/redid comments on EXTERNAL_LIST_LOOP.
---------------------------------------------------------------
SPACING FIXES
---------------------------------------------------------------
callint.c, hftctl.c, number-gmp.c, process-unix.c: Spacing fixes.
---------------------------------------------------------------
FIX FOR GEOMETRY PROBLEM IN FIRST FRAME
---------------------------------------------------------------
unicode.c: Add workaround for newlib bug in sscanf() [should be fixed by
release 1.5.12 of Cygwin].
toolbar.c: bug fix for problem of initial frame being 77 chars wide on Windows.
will be overridden by my other ws.
---------------------------------------------------------------
FIX FOR LEAKING PROCESS HANDLES:
---------------------------------------------------------------
process-nt.c: Fixes for leaking handles. Inspired by work done by Adrian Aichner
<adrian@xemacs.org>.
---------------------------------------------------------------
FIX FOR CYGWIN BUG (Unicode-related):
---------------------------------------------------------------
unicode.c: Add workaround for newlib bug in sscanf() [should be fixed by
release 1.5.12 of Cygwin].
---------------------------------------------------------------
WARNING FIXES:
---------------------------------------------------------------
console-stream.c: `reinit' is unused.
compiler.h, event-msw.c, frame-msw.c, intl-encap-win32.c, text.h: Add stuff to deal with ANSI-aliasing warnings I got.
regex.c: Gather includes together to avoid warning.
---------------------------------------------------------------
CHANGES TO INITIALIZATION ROUTINES:
---------------------------------------------------------------
buffer.c, emacs.c, console.c, debug.c, device-x.c, device.c, dragdrop.c, emodules.c, eval.c, event-Xt.c, event-gtk.c, event-msw.c, event-stream.c, event-tty.c, events.c, extents.c, faces.c, file-coding.c, fileio.c, font-lock.c, frame-msw.c, glyphs-widget.c, glyphs.c, gui-x.c, insdel.c, lread.c, lstream.c, menubar-gtk.c, menubar-x.c, minibuf.c, mule-wnnfns.c, objects-msw.c, objects.c, print.c, scrollbar-x.c, search.c, select-x.c, text.c, undo.c, unicode.c, window.c, symsinit.h: Call reinit_*() functions directly from emacs.c, for clarity.
Factor out some redundant init code. Move disallowed stuff
that had crept into vars_of_glyphs() into complex_vars_of_glyphs().
Call init_eval_semi_early() from eval.c not in the middle of
vars_of_() in emacs.c since there should be no order dependency
in the latter calls.
---------------------------------------------------------------
ARMAGEDDON:
---------------------------------------------------------------
alloc.c, emacs.c, lisp.h, print.c: Rename inhibit_non_essential_printing_operations to
inhibit_non_essential_conversion_operations.
text.c: Assert on !inhibit_non_essential_conversion_operations.
console-msw.c, print.c: Don't do conversion in SetConsoleTitle or FindWindow to avoid
problems during armageddon. Put #errors for NON_ASCII_INTERNAL_FORMAT
in places where problems would arise.
---------------------------------------------------------------
CHANGES TO THE BUILD PROCEDURE:
---------------------------------------------------------------
config.h.in, s/cxux.h, s/usg5-4-2.h, m/powerpc.h: Add comment about correct ordering of this file.
Rearrange everything to follow this -- put all #undefs together
and before the s&m files. Add undefs for HAVE_ALLOCA, C_ALLOCA,
BROKEN_ALLOCA_IN_FUNCTION_CALLS, STACK_DIRECTION. Remove unused
HAVE_STPCPY, HAVE_GETWD, HAVE_SETLOCALE.
m/gec63.h: Deleted; totally broken, not used at all, not in FSF.
m/7300.h, m/acorn.h, m/alliant-2800.h, m/alliant.h, m/altos.h, m/amdahl.h, m/apollo.h, m/att3b.h, m/aviion.h, m/celerity.h, m/clipper.h, m/cnvrgnt.h, m/convex.h, m/cydra5.h, m/delta.h, m/delta88k.h, m/dpx2.h, m/elxsi.h, m/ews4800r.h, m/gould.h, m/hp300bsd.h, m/hp800.h, m/hp9000s300.h, m/i860.h, m/ibmps2-aix.h, m/ibmrs6000.h, m/ibmrt-aix.h, m/ibmrt.h, m/intel386.h, m/iris4d.h, m/iris5d.h, m/iris6d.h, m/irist.h, m/isi-ov.h, m/luna88k.h, m/m68k.h, m/masscomp.h, m/mg1.h, m/mips-nec.h, m/mips-siemens.h, m/mips.h, m/news.h, m/nh3000.h, m/nh4000.h, m/ns32000.h, m/orion105.h, m/pfa50.h, m/plexus.h, m/pmax.h, m/powerpc.h, m/pyrmips.h, m/sequent-ptx.h, m/sequent.h, m/sgi-challenge.h, m/symmetry.h, m/tad68k.h, m/tahoe.h, m/targon31.h, m/tekxd88.h, m/template.h, m/tower32.h, m/tower32v3.h, m/ustation.h, m/vax.h, m/wicat.h, m/xps100.h: Delete C_ALLOCA, HAVE_ALLOCA, STACK_DIRECTION,
BROKEN_ALLOCA_IN_FUNCTION_CALLS. All of this is auto-detected.
When in doubt, I followed recent FSF sources, which also have
these things deleted.
author | ben |
---|---|
date | Thu, 04 Nov 2004 23:08:28 +0000 |
parents | 04bc9d2f42c7 |
children | 3d8143fc88e1 |
comparison
equal
deleted
inserted
replaced
2366:2a392e0c390a | 2367:ecf1ebac70d8 |
---|---|
873 Ibyte *label_buffer = NULL; | 873 Ibyte *label_buffer = NULL; |
874 char *temp_label = NULL; | 874 char *temp_label = NULL; |
875 | 875 |
876 if (STRINGP (suffix) && XSTRING_LENGTH (suffix)) | 876 if (STRINGP (suffix) && XSTRING_LENGTH (suffix)) |
877 { | 877 { |
878 label_buffer = (Ibyte*) ALLOCA (XSTRING_LENGTH (name) + 15 + XSTRING_LENGTH (suffix)); | 878 /* !!#### */ |
879 sprintf ((char*) label_buffer, "%s %s ", XSTRING_DATA (name), XSTRING_DATA (suffix)); | 879 label_buffer = alloca_ibytes (XSTRING_LENGTH (name) + 15 + XSTRING_LENGTH (suffix)); |
880 qxesprintf (label_buffer, "%s %s ", XSTRING_DATA (name), | |
881 XSTRING_DATA (suffix)); | |
880 } | 882 } |
881 else | 883 else |
882 { | 884 { |
883 label_buffer = (Ibyte*) ALLOCA (XSTRING_LENGTH (name) + 15); | 885 label_buffer = alloca_ibytes (XSTRING_LENGTH (name) + 15); |
884 sprintf ((char*) label_buffer, "%s ", XSTRING_DATA (name)); | 886 qxesprintf (label_buffer, "%s ", XSTRING_DATA (name)); |
885 } | 887 } |
886 | 888 |
887 temp_label = convert_underscores (label_buffer); | 889 temp_label = convert_underscores (label_buffer); |
888 main_label = gtk_xemacs_accel_label_new (NULL); | 890 main_label = gtk_xemacs_accel_label_new (NULL); |
889 accel_key = gtk_label_parse_uline (GTK_LABEL (main_label), temp_label); | 891 accel_key = gtk_label_parse_uline (GTK_LABEL (main_label), temp_label); |
1080 */ | 1082 */ |
1081 static void | 1083 static void |
1082 menu_create_menubar (struct frame *f, Lisp_Object descr) | 1084 menu_create_menubar (struct frame *f, Lisp_Object descr) |
1083 { | 1085 { |
1084 gboolean right_justify = FALSE; | 1086 gboolean right_justify = FALSE; |
1085 Lisp_Object tail = Qnil; | |
1086 Lisp_Object value = descr; | 1087 Lisp_Object value = descr; |
1087 Lisp_Object item_descr = Qnil; | |
1088 GtkWidget *menubar = FRAME_GTK_MENUBAR_WIDGET (f); | 1088 GtkWidget *menubar = FRAME_GTK_MENUBAR_WIDGET (f); |
1089 GUI_ID id = (GUI_ID) gtk_object_get_data (GTK_OBJECT (menubar), XEMACS_MENU_GUIID_TAG); | 1089 GUI_ID id = (GUI_ID) gtk_object_get_data (GTK_OBJECT (menubar), XEMACS_MENU_GUIID_TAG); |
1090 guint menu_position = 0; | 1090 guint menu_position = 0; |
1091 GtkAccelGroup *menubar_accel_group; | 1091 GtkAccelGroup *menubar_accel_group; |
1092 | 1092 |
1096 /* GCPRO the whole damn thing */ | 1096 /* GCPRO the whole damn thing */ |
1097 gcpro_popup_callbacks (id, descr); | 1097 gcpro_popup_callbacks (id, descr); |
1098 | 1098 |
1099 menubar_accel_group = gtk_accel_group_new(); | 1099 menubar_accel_group = gtk_accel_group_new(); |
1100 | 1100 |
1101 EXTERNAL_LIST_LOOP (tail, value) | 1101 { |
1102 { | 1102 EXTERNAL_LIST_LOOP_2 (item_descr, value) |
1103 gpointer current_child = g_list_nth_data (GTK_MENU_SHELL (menubar)->children, menu_position); | 1103 { |
1104 | 1104 gpointer current_child = g_list_nth_data (GTK_MENU_SHELL (menubar)->children, menu_position); |
1105 item_descr = XCAR (tail); | 1105 |
1106 | 1106 if (NILP (item_descr)) |
1107 if (NILP (item_descr)) | 1107 { |
1108 { | 1108 /* Need to start right-justifying menus */ |
1109 /* Need to start right-justifying menus */ | 1109 right_justify = TRUE; |
1110 right_justify = TRUE; | 1110 menu_position--; |
1111 menu_position--; | 1111 } |
1112 } | 1112 else if (VECTORP (item_descr)) |
1113 else if (VECTORP (item_descr)) | 1113 { |
1114 { | 1114 /* It is a button description */ |
1115 /* It is a button description */ | 1115 GtkWidget *item; |
1116 GtkWidget *item; | 1116 |
1117 | 1117 item = menu_descriptor_to_widget (item_descr, menubar_accel_group); |
1118 item = menu_descriptor_to_widget (item_descr, menubar_accel_group); | 1118 gtk_widget_set_name (item, "XEmacsMenuButton"); |
1119 gtk_widget_set_name (item, "XEmacsMenuButton"); | 1119 |
1120 | 1120 if (!item) |
1121 if (!item) | 1121 { |
1122 { | 1122 item = gtk_menu_item_new_with_label ("ITEM CREATION ERROR"); |
1123 item = gtk_menu_item_new_with_label ("ITEM CREATION ERROR"); | 1123 } |
1124 } | 1124 |
1125 | 1125 gtk_widget_show_all (item); |
1126 gtk_widget_show_all (item); | 1126 if (current_child) gtk_widget_destroy (GTK_WIDGET (current_child)); |
1127 if (current_child) gtk_widget_destroy (GTK_WIDGET (current_child)); | 1127 gtk_menu_bar_insert (GTK_MENU_BAR (menubar), item, menu_position); |
1128 gtk_menu_bar_insert (GTK_MENU_BAR (menubar), item, menu_position); | 1128 } |
1129 } | 1129 else if (LISTP (item_descr)) |
1130 else if (LISTP (item_descr)) | 1130 { |
1131 { | 1131 /* Need to actually convert it into a menu and slap it in */ |
1132 /* Need to actually convert it into a menu and slap it in */ | 1132 GtkWidget *widget; |
1133 GtkWidget *widget; | 1133 gboolean reused_p = FALSE; |
1134 gboolean reused_p = FALSE; | 1134 |
1135 | 1135 /* We may be able to reuse the widget, let's at least check. */ |
1136 /* We may be able to reuse the widget, let's at least check. */ | 1136 if (current_child && menu_can_reuse_widget (GTK_WIDGET (current_child), |
1137 if (current_child && menu_can_reuse_widget (GTK_WIDGET (current_child), | 1137 XSTRING_DATA (XCAR (item_descr)))) |
1138 XSTRING_DATA (XCAR (item_descr)))) | 1138 { |
1139 { | 1139 widget = menu_convert (item_descr, GTK_WIDGET (current_child), |
1140 widget = menu_convert (item_descr, GTK_WIDGET (current_child), | 1140 menubar_accel_group); |
1141 menubar_accel_group); | 1141 reused_p = TRUE; |
1142 reused_p = TRUE; | 1142 } |
1143 } | 1143 else |
1144 else | 1144 { |
1145 { | 1145 widget = menu_convert (item_descr, NULL, menubar_accel_group); |
1146 widget = menu_convert (item_descr, NULL, menubar_accel_group); | 1146 if (current_child) gtk_widget_destroy (GTK_WIDGET (current_child)); |
1147 if (current_child) gtk_widget_destroy (GTK_WIDGET (current_child)); | 1147 gtk_menu_bar_insert (GTK_MENU_BAR (menubar), widget, menu_position); |
1148 gtk_menu_bar_insert (GTK_MENU_BAR (menubar), widget, menu_position); | 1148 } |
1149 } | 1149 |
1150 | 1150 if (widget) |
1151 if (widget) | 1151 { |
1152 { | 1152 if (right_justify) gtk_menu_item_right_justify (GTK_MENU_ITEM (widget)); |
1153 if (right_justify) gtk_menu_item_right_justify (GTK_MENU_ITEM (widget)); | 1153 } |
1154 } | 1154 else |
1155 else | 1155 { |
1156 { | 1156 widget = gtk_menu_item_new_with_label ("ERROR"); |
1157 widget = gtk_menu_item_new_with_label ("ERROR"); | 1157 /* abort() */ |
1158 /* abort() */ | 1158 } |
1159 } | 1159 gtk_widget_show_all (widget); |
1160 gtk_widget_show_all (widget); | 1160 } |
1161 } | 1161 else if (STRINGP (item_descr)) |
1162 else if (STRINGP (item_descr)) | 1162 { |
1163 { | 1163 /* Do I really want to be this careful? Anything else in a |
1164 /* Do I really want to be this careful? Anything else in a | 1164 menubar description is illegal */ |
1165 menubar description is illegal */ | 1165 } |
1166 } | 1166 menu_position++; |
1167 menu_position++; | 1167 } |
1168 } | 1168 } |
1169 | 1169 |
1170 /* Need to delete any menu items that were past the bounds of the new one */ | 1170 /* Need to delete any menu items that were past the bounds of the new one */ |
1171 { | 1171 { |
1172 GList *l = NULL; | 1172 GList *l = NULL; |
1173 | 1173 |
1493 #ifdef TEAR_OFF_MENUS | 1493 #ifdef TEAR_OFF_MENUS |
1494 DEFVAR_BOOL ("menubar-tearable-p", &tear_off_menus /* | 1494 DEFVAR_BOOL ("menubar-tearable-p", &tear_off_menus /* |
1495 If non-nil, menus can be torn off into their own top-level windows. | 1495 If non-nil, menus can be torn off into their own top-level windows. |
1496 */ ); | 1496 */ ); |
1497 #endif | 1497 #endif |
1498 reinit_vars_of_menubar_gtk (); | |
1499 } | 1498 } |
1500 | 1499 |
1501 /*---------------------------------------------------------------------------*/ | 1500 /*---------------------------------------------------------------------------*/ |
1502 | 1501 |