comparison src/device-x.c @ 4477:e34711681f30

Don't determine whether to call general device-type code at startup, rather decide in the device-specific code itself. lisp/ChangeLog addition: 2008-07-07 Aidan Kehoe <kehoea@parhasard.net> Patch to make it up to the device-specific code whether various Lisp functions should be called during device creation, not relying on the startup code to decide this. Also, rename initial-window-system to initial-device-type (which makes more sense in this scheme), always set it. * startup.el (command-line): Use initial-device-type, not initial-window-system; just call #'make-device, leave the special behaviour to be done the first time a console type is initialised to be decided on by the respective console code. * x-init.el (x-app-defaults-directory): Declare that it should be bound. (x-define-dead-key): Have the macro take a DEVICE argument. (x-initialize-compose): Have the function take a DEVICE argument, and use it when checking if various keysyms are available on the keyboard. (x-initialize-keyboard): Have the function take a DEVICE argument, allowing device-specific keyboard initialisation. (make-device-early-x-entry-point-called-p): New. (make-device-late-x-entry-point-called-p): New. Rename pre-x-win-initted, x-win-initted. (make-device-early-x-entry-point): Rename init-pre-x-win, take the call to make-x-device out (it should be called from the device-creation code, not vice-versa). (make-device-late-x-entry-point): Rename init-post-x-win, have it take a DEVICE argument, use that DEVICE argument when working out what device-specific things need doing. Don't use create-console-hook in core code. * x-win-xfree86.el (x-win-init-xfree86): Take a DEVICE argument; use it. * x-win-sun.el (x-win-init-sun): Take a DEVICE argument; use it. * mule/mule-x-init.el: Remove #'init-mule-x-win, an empty function. * tty-init.el (make-device-early-tty-entry-point-called-p): New. Rename pre-tty-win-initted. (make-device-early-tty-entry-point): New. Rename init-pre-tty-win. (make-frame-after-init-entry-point): New. Rename init-post-tty-win to better reflect when it's called. * gtk-init.el (gtk-early-lisp-options-file): New. Move this path to a documented variable. (gtk-command-switch-alist): Wrap the docstring to fewer than 79 columns. (make-device-early-gtk-entry-point-called-p): New. (make-device-late-gtk-entry-point-called-p): New. Renamed gtk-pre-win-initted, gtk-post-win-initted to these. (make-device-early-gtk-entry-point): New. (make-device-late-gtk-entry-point): New. Renamed init-pre-gtk-win, init-post-gtk-win to these. Have make-device-late-gtk-entry-point take a device argument, and use it; have make-device-early-gtk-entry-point load the GTK-specific startup code, instead of doing that in C. (init-gtk-win): Deleted, functionality moved to the GTK device creation code. (gtk-define-dead-key): Have it take a DEVICE argument; use this argument. (gtk-initialize-compose): Ditto. * coding.el (set-terminal-coding-system): Correct the docstring; the function isn't broken. src/ChangeLog addition: 2008-07-07 Aidan Kehoe <kehoea@parhasard.net> Patch to make it up to the device-specific code whether various Lisp functions should be called during device creation, not relying on the startup code to decide this. Also, rename initial-window-system to initial-device-type (which makes more sense in this scheme), always set it. * redisplay.c (Vinitial_device_type): New. (Vinitial_window_system): Removed. Rename initial-window-system to initial-device type, making it a stream if we're noninteractive. Update its docstring. * device-x.c (Qmake_device_early_x_entry_point, Qmake_device_late_x_entry_point): New. Rename Qinit_pre_x_win, Qinit_post_x_win. (x_init_device): Call #'make-device-early-x-entry-point earlier, now we rely on it to find the application class and the app-defaults directory. (x_finish_init_device): Call #'make-device-late-x-entry-point with the created device. (Vx_app_defaults_directory): Always make this available, to simplify code in x-init.el. * device-tty.c (Qmake_device_early_tty_entry_point): New. Rename Qinit_pre_tty_win, rename Qinit_post_tty_win and move to frame-tty.c as Qmake_frame_after_init_entry_point. (tty_init_device): Call #'make-device-early-tty-entry-point before doing anything. * frame-tty.c (Qmake_frame_after_init_entry_point): New. * frame-tty.c (tty_after_init_frame): Have it call the better-named #'make-frame-after-init-entry-point function instead of #'init-post-tty-win (since it's called after frame, not device, creation). * device-msw.c (Qmake_device_early_mswindows_entry_point, Qmake_device_late_mswindows_entry_point): New. Rename Qinit_pre_mswindows_win, Qinit_post_mswindows_win. (mswindows_init_device): Call #'make-device-early-mswindows-entry-point here, instead of having its predecessor call us. (mswindows_finish_init_device): Call #'make-device-early-mswindows-entry-point, for symmetry with the other device types (though it's an empty function). * device-gtk.c (Qmake_device_early_gtk_entry_point, Qmake_device_late_gtk_entry_point): New. Rename Qinit_pre_gtk_win, Qinit_post_gtk_win. (gtk_init_device): Call #'make-device-early-gtk-entry-point; don't load ~/.xemacs/gtk-options.el ourselves, leave that to lisp. (gtk_finish_init_device): Call #'make-device-late-gtk-entry-point with the created device as an argument.
author Aidan Kehoe <kehoea@parhasard.net>
date Wed, 09 Jul 2008 20:46:22 +0200
parents 80e07b006f9c
children 383ab474a241
comparison
equal deleted inserted replaced
4475:86283c809984 4477:e34711681f30
63 63
64 #ifdef HAVE_OFFIX_DND 64 #ifdef HAVE_OFFIX_DND
65 #include "offix.h" 65 #include "offix.h"
66 #endif 66 #endif
67 67
68 Lisp_Object Vx_app_defaults_directory;
68 #ifdef MULE 69 #ifdef MULE
69 Lisp_Object Vx_app_defaults_directory;
70 Lisp_Object Qget_coding_system_from_locale; 70 Lisp_Object Qget_coding_system_from_locale;
71 #endif 71 #endif
72 72
73 /* Qdisplay in general.c */ 73 /* Qdisplay in general.c */
74 Lisp_Object Qx_error; 74 Lisp_Object Qx_error;
75 Lisp_Object Qinit_pre_x_win, Qinit_post_x_win; 75 Lisp_Object Qmake_device_early_x_entry_point, Qmake_device_late_x_entry_point;
76 76
77 /* The application class of Emacs. */ 77 /* The application class of Emacs. */
78 Lisp_Object Vx_emacs_application_class; 78 Lisp_Object Vx_emacs_application_class;
79 79
80 Lisp_Object Vx_initial_argv_list; /* #### ugh! */ 80 Lisp_Object Vx_initial_argv_list; /* #### ugh! */
539 int depth = 8; /* shut up the compiler */ 539 int depth = 8; /* shut up the compiler */
540 Colormap cmap; 540 Colormap cmap;
541 int screen; 541 int screen;
542 /* */ 542 /* */
543 int best_visual_found = 0; 543 int best_visual_found = 0;
544
545 /* Run the elisp side of the X device initialization, allowing it to set
546 x-emacs-application-class and x-app-defaults-directory. */
547 call0 (Qmake_device_early_x_entry_point);
544 548
545 #if defined(HAVE_SHLIB) && defined(LWLIB_USES_ATHENA) && !defined(HAVE_ATHENA_3D) 549 #if defined(HAVE_SHLIB) && defined(LWLIB_USES_ATHENA) && !defined(HAVE_ATHENA_3D)
546 /* 550 /*
547 * In order to avoid the lossage with flat Athena widgets dynamically 551 * In order to avoid the lossage with flat Athena widgets dynamically
548 * linking to one of the ThreeD variants, using the dynamic symbol helpers 552 * linking to one of the ThreeD variants, using the dynamic symbol helpers
919 DEVICE_X_GRAY_PIXMAP (d) = None; 923 DEVICE_X_GRAY_PIXMAP (d) = None;
920 Xatoms_of_device_x (d); 924 Xatoms_of_device_x (d);
921 Xatoms_of_select_x (d); 925 Xatoms_of_select_x (d);
922 Xatoms_of_objects_x (d); 926 Xatoms_of_objects_x (d);
923 x_init_device_class (d); 927 x_init_device_class (d);
924
925 /* Run the elisp side of the X device initialization. */
926 call0 (Qinit_pre_x_win);
927 } 928 }
928 929
929 static void 930 static void
930 x_finish_init_device (struct device *UNUSED (d), Lisp_Object UNUSED (props)) 931 x_finish_init_device (struct device *d, Lisp_Object UNUSED (props))
931 { 932 {
932 call0 (Qinit_post_x_win); 933 call1 (Qmake_device_late_x_entry_point, wrap_device (d));
933 } 934 }
934 935
935 static void 936 static void
936 x_mark_device (struct device *d) 937 x_mark_device (struct device *d)
937 { 938 {
2131 2132
2132 DEFSUBR (Fx_get_font_path); 2133 DEFSUBR (Fx_get_font_path);
2133 DEFSUBR (Fx_set_font_path); 2134 DEFSUBR (Fx_set_font_path);
2134 2135
2135 DEFSYMBOL (Qx_error); 2136 DEFSYMBOL (Qx_error);
2136 DEFSYMBOL (Qinit_pre_x_win); 2137 DEFSYMBOL (Qmake_device_early_x_entry_point);
2137 DEFSYMBOL (Qinit_post_x_win); 2138 DEFSYMBOL (Qmake_device_late_x_entry_point);
2138 2139
2139 #ifdef MULE 2140 #ifdef MULE
2140 DEFSYMBOL (Qget_coding_system_from_locale); 2141 DEFSYMBOL (Qget_coding_system_from_locale);
2141 #endif 2142 #endif
2142 } 2143 }
2205 `command-line-args-left'. Perhaps `command-line-args-left' should 2206 `command-line-args-left'. Perhaps `command-line-args-left' should
2206 just reside in C. 2207 just reside in C.
2207 */ ); 2208 */ );
2208 Vx_initial_argv_list = Qnil; 2209 Vx_initial_argv_list = Qnil;
2209 2210
2210 #ifdef MULE
2211 DEFVAR_LISP ("x-app-defaults-directory", &Vx_app_defaults_directory /* 2211 DEFVAR_LISP ("x-app-defaults-directory", &Vx_app_defaults_directory /*
2212 Used by the Lisp code to communicate to the low level X initialization 2212 Used by the Lisp code to communicate to the low level X initialization
2213 where the localized init files are. 2213 where the localized init files are.
2214 */ ); 2214 */ );
2215 Vx_app_defaults_directory = Qnil; 2215 Vx_app_defaults_directory = Qnil;
2216 #endif
2217 2216
2218 Fprovide (Qx); 2217 Fprovide (Qx);
2219 } 2218 }