comparison lisp/msw-init.el @ 4477:e34711681f30

Don't determine whether to call general device-type code at startup, rather decide in the device-specific code itself. lisp/ChangeLog addition: 2008-07-07 Aidan Kehoe <kehoea@parhasard.net> Patch to make it up to the device-specific code whether various Lisp functions should be called during device creation, not relying on the startup code to decide this. Also, rename initial-window-system to initial-device-type (which makes more sense in this scheme), always set it. * startup.el (command-line): Use initial-device-type, not initial-window-system; just call #'make-device, leave the special behaviour to be done the first time a console type is initialised to be decided on by the respective console code. * x-init.el (x-app-defaults-directory): Declare that it should be bound. (x-define-dead-key): Have the macro take a DEVICE argument. (x-initialize-compose): Have the function take a DEVICE argument, and use it when checking if various keysyms are available on the keyboard. (x-initialize-keyboard): Have the function take a DEVICE argument, allowing device-specific keyboard initialisation. (make-device-early-x-entry-point-called-p): New. (make-device-late-x-entry-point-called-p): New. Rename pre-x-win-initted, x-win-initted. (make-device-early-x-entry-point): Rename init-pre-x-win, take the call to make-x-device out (it should be called from the device-creation code, not vice-versa). (make-device-late-x-entry-point): Rename init-post-x-win, have it take a DEVICE argument, use that DEVICE argument when working out what device-specific things need doing. Don't use create-console-hook in core code. * x-win-xfree86.el (x-win-init-xfree86): Take a DEVICE argument; use it. * x-win-sun.el (x-win-init-sun): Take a DEVICE argument; use it. * mule/mule-x-init.el: Remove #'init-mule-x-win, an empty function. * tty-init.el (make-device-early-tty-entry-point-called-p): New. Rename pre-tty-win-initted. (make-device-early-tty-entry-point): New. Rename init-pre-tty-win. (make-frame-after-init-entry-point): New. Rename init-post-tty-win to better reflect when it's called. * gtk-init.el (gtk-early-lisp-options-file): New. Move this path to a documented variable. (gtk-command-switch-alist): Wrap the docstring to fewer than 79 columns. (make-device-early-gtk-entry-point-called-p): New. (make-device-late-gtk-entry-point-called-p): New. Renamed gtk-pre-win-initted, gtk-post-win-initted to these. (make-device-early-gtk-entry-point): New. (make-device-late-gtk-entry-point): New. Renamed init-pre-gtk-win, init-post-gtk-win to these. Have make-device-late-gtk-entry-point take a device argument, and use it; have make-device-early-gtk-entry-point load the GTK-specific startup code, instead of doing that in C. (init-gtk-win): Deleted, functionality moved to the GTK device creation code. (gtk-define-dead-key): Have it take a DEVICE argument; use this argument. (gtk-initialize-compose): Ditto. * coding.el (set-terminal-coding-system): Correct the docstring; the function isn't broken. src/ChangeLog addition: 2008-07-07 Aidan Kehoe <kehoea@parhasard.net> Patch to make it up to the device-specific code whether various Lisp functions should be called during device creation, not relying on the startup code to decide this. Also, rename initial-window-system to initial-device-type (which makes more sense in this scheme), always set it. * redisplay.c (Vinitial_device_type): New. (Vinitial_window_system): Removed. Rename initial-window-system to initial-device type, making it a stream if we're noninteractive. Update its docstring. * device-x.c (Qmake_device_early_x_entry_point, Qmake_device_late_x_entry_point): New. Rename Qinit_pre_x_win, Qinit_post_x_win. (x_init_device): Call #'make-device-early-x-entry-point earlier, now we rely on it to find the application class and the app-defaults directory. (x_finish_init_device): Call #'make-device-late-x-entry-point with the created device. (Vx_app_defaults_directory): Always make this available, to simplify code in x-init.el. * device-tty.c (Qmake_device_early_tty_entry_point): New. Rename Qinit_pre_tty_win, rename Qinit_post_tty_win and move to frame-tty.c as Qmake_frame_after_init_entry_point. (tty_init_device): Call #'make-device-early-tty-entry-point before doing anything. * frame-tty.c (Qmake_frame_after_init_entry_point): New. * frame-tty.c (tty_after_init_frame): Have it call the better-named #'make-frame-after-init-entry-point function instead of #'init-post-tty-win (since it's called after frame, not device, creation). * device-msw.c (Qmake_device_early_mswindows_entry_point, Qmake_device_late_mswindows_entry_point): New. Rename Qinit_pre_mswindows_win, Qinit_post_mswindows_win. (mswindows_init_device): Call #'make-device-early-mswindows-entry-point here, instead of having its predecessor call us. (mswindows_finish_init_device): Call #'make-device-early-mswindows-entry-point, for symmetry with the other device types (though it's an empty function). * device-gtk.c (Qmake_device_early_gtk_entry_point, Qmake_device_late_gtk_entry_point): New. Rename Qinit_pre_gtk_win, Qinit_post_gtk_win. (gtk_init_device): Call #'make-device-early-gtk-entry-point; don't load ~/.xemacs/gtk-options.el ourselves, leave that to lisp. (gtk_finish_init_device): Call #'make-device-late-gtk-entry-point with the created device as an argument.
author Aidan Kehoe <kehoea@parhasard.net>
date Wed, 09 Jul 2008 20:46:22 +0200
parents f3244b2b4053
children 308d34e9f07d
comparison
equal deleted inserted replaced
4475:86283c809984 4477:e34711681f30
21 ;; You should have received a copy of the GNU General Public License 21 ;; You should have received a copy of the GNU General Public License
22 ;; along with XEmacs; see the file COPYING. If not, write to the 22 ;; along with XEmacs; see the file COPYING. If not, write to the
23 ;; Free Software Foundation, 59 Temple Place - Suite 330, 23 ;; Free Software Foundation, 59 Temple Place - Suite 330,
24 ;; Boston, MA 02111-1307, USA. 24 ;; Boston, MA 02111-1307, USA.
25 25
26 (defvar mswindows-win-initted nil) 26 (defvar make-device-early-mswindows-entry-point-called-p nil
27 (defvar mswindows-pre-win-initted nil) 27 "Whether `make-device-early-mswindows-entry-point' has been called")
28 (defvar mswindows-post-win-initted nil)
29 28
30 (defun init-pre-mswindows-win () 29 (defvar make-device-late-mswindows-entry-point-called-p nil
31 "Initialize mswindows GUI at startup (pre). Don't call this." 30 "Whether `make-device-late-mswindows-entry-point' has been called")
32 (unless mswindows-pre-win-initted
33 (setq mswindows-pre-win-initted t)))
34 31
35 (defun init-mswindows-win () 32 (defun make-device-early-mswindows-entry-point ()
36 "Initialize mswindows GUI at startup. Don't call this." 33 "Lisp code called before an `mswindows' device is created."
37 (unless mswindows-win-initted 34 (unless make-device-early-mswindows-entry-point-called-p
38 (init-pre-mswindows-win)
39 (make-mswindows-device)
40 (init-post-mswindows-win (selected-console))
41 (setq mswindows-win-initted t)))
42
43 (defun init-post-mswindows-win (console)
44 "Initialize mswindows GUI at startup (post). Don't call this."
45 (unless mswindows-post-win-initted
46 ;; Old-style mswindows bindings. The new-style mswindows bindings 35 ;; Old-style mswindows bindings. The new-style mswindows bindings
47 ;; (namely Ctrl-X, Ctrl-C and Ctrl-V) are already spoken for by XEmacs. 36 ;; (namely Ctrl-X, Ctrl-C and Ctrl-V) are already spoken for by XEmacs.
48 (global-set-key '(shift delete) 'kill-primary-selection) 37 (global-set-key '(shift delete) 'kill-primary-selection)
49 (global-set-key '(shift insert) 'yank-clipboard-selection) 38 (global-set-key '(shift insert) 'yank-clipboard-selection)
50 (global-set-key '(control insert) 'copy-primary-selection) 39 (global-set-key '(control insert) 'copy-primary-selection)
51 40
52 (global-set-key '(meta f4) 'save-buffers-kill-emacs) 41 (global-set-key '(meta f4) 'save-buffers-kill-emacs)
42 (setq make-device-early-mswindows-entry-point-called-p t)))
53 43
54 (setq mswindows-post-win-initted t))) 44 (defun make-device-late-mswindows-entry-point (device)
45 "Lisp code called after an `mswindows' device is created."
46 (unless make-device-late-mswindows-entry-point-called-p
47 (setq make-device-late-mswindows-entry-point-called-p t)))
55 48