comparison lisp/select.el @ 4783:e29fcfd8df5f

Eliminate most core code byte-compile warnings. 2009-12-18 Aidan Kehoe <kehoea@parhasard.net> * alist.el (modify-alist): * autoload.el (update-autoload-files, autoload-print-form): * bytecomp.el (batch-byte-compile-1) (byte-compile-multiple-value-call, byte-compile-funcall) (byte-compile-insert, byte-compile-concat, byte-compile-list) (byte-compile-normal-call, byte-compile-flush-pending): * cl-macs.el (letf): * cl.el: * disass.el (disassemble-1): * easy-mmode.el (easy-mmode-define-syntax): * faces.el (set-face-parent): * files.el (cd): * finder.el (finder-list-matches, finder-list-keywords) (finder-compile-keywords): * frame.el (frame-notice-user-settings) (frame-remove-geometry-props): * ldap.el (ldap-delete-entries, ldap-modify-entries) (ldap-add-entries): * loadhist.el (unload-feature): * map-ynp.el (map-y-or-n-p): * menubar-items.el (default-menubar): * mouse.el (default-mouse-track-next-move-rect) (default-mouse-track-next-move-rect) (default-mouse-track-cleanup-hook) (default-mouse-track-cleanup-extent): * mule/ethio-util.el (ethio-fidel-to-sera-buffer) (ethio-modify-vowel): * obsolete.el: * package-get.el (package-get-update-all): * package-ui.el (pui-list-packages) (pui-install-selected-packages, pui-install-selected-packages): * select.el (select-make-extent-for-selection) (dehilight-selection): * simple.el (clone-buffer): * term/tvi970.el: * term/wyse50.el: * unicode.el: (load-unicode-tables): * x-font-menu.el (fc-make-font-menu-entry) (x-reset-device-font-menus-xft): * x-misc.el (x-init-specifier-from-resources): Eliminate byte-compile warnings, with the exception of Stephen's various non-defined fontconfig functions, as I don't know if he plans to add them and is keeping the warnings around as a reminder. The warnings actually eliminated involve i) using mapcar instead of mapc where the result is discarded and ii) using a lambda quoted as data in a context where it is unequivocally used as a function.
author Aidan Kehoe <kehoea@parhasard.net>
date Fri, 18 Dec 2009 17:49:43 +0000
parents 38ef5a6da799
children 2a54dfbe434f 308d34e9f07d
comparison
equal deleted inserted replaced
4782:1523f1d28be1 4783:e29fcfd8df5f
229 "for use as a value of `lost-selection-hooks'." 229 "for use as a value of `lost-selection-hooks'."
230 (cond ((eq selection 'PRIMARY) 230 (cond ((eq selection 'PRIMARY)
231 (if primary-selection-extent 231 (if primary-selection-extent
232 (let ((inhibit-quit t)) 232 (let ((inhibit-quit t))
233 (if (consp primary-selection-extent) 233 (if (consp primary-selection-extent)
234 (mapcar 'delete-extent primary-selection-extent) 234 (mapc 'delete-extent primary-selection-extent)
235 (delete-extent primary-selection-extent)) 235 (delete-extent primary-selection-extent))
236 (setq primary-selection-extent nil))) 236 (setq primary-selection-extent nil)))
237 (if zmacs-regions (zmacs-deactivate-region))) 237 (if zmacs-regions (zmacs-deactivate-region)))
238 ((eq selection 'SECONDARY) 238 ((eq selection 'SECONDARY)
239 (if secondary-selection-extent 239 (if secondary-selection-extent
240 (let ((inhibit-quit t)) 240 (let ((inhibit-quit t))
241 (if (consp secondary-selection-extent) 241 (if (consp secondary-selection-extent)
242 (mapcar 'delete-extent secondary-selection-extent) 242 (mapc 'delete-extent secondary-selection-extent)
243 (delete-extent secondary-selection-extent)) 243 (delete-extent secondary-selection-extent))
244 (setq secondary-selection-extent nil))))) 244 (setq secondary-selection-extent nil)))))
245 nil) 245 nil)
246 246
247 (setq lost-selection-hooks 'dehilight-selection) 247 (setq lost-selection-hooks 'dehilight-selection)
322 322
323 (if valid 323 (if valid
324 nil 324 nil
325 (condition-case () 325 (condition-case ()
326 (if (listp previous-extent) 326 (if (listp previous-extent)
327 (mapcar 'delete-extent previous-extent) 327 (mapc 'delete-extent previous-extent)
328 (delete-extent previous-extent)) 328 (delete-extent previous-extent))
329 (error nil))) 329 (error nil)))
330 330
331 (if (not buffer) 331 (if (not buffer)
332 ;; string case 332 ;; string case