comparison lisp/package-ui.el @ 4783:e29fcfd8df5f

Eliminate most core code byte-compile warnings. 2009-12-18 Aidan Kehoe <kehoea@parhasard.net> * alist.el (modify-alist): * autoload.el (update-autoload-files, autoload-print-form): * bytecomp.el (batch-byte-compile-1) (byte-compile-multiple-value-call, byte-compile-funcall) (byte-compile-insert, byte-compile-concat, byte-compile-list) (byte-compile-normal-call, byte-compile-flush-pending): * cl-macs.el (letf): * cl.el: * disass.el (disassemble-1): * easy-mmode.el (easy-mmode-define-syntax): * faces.el (set-face-parent): * files.el (cd): * finder.el (finder-list-matches, finder-list-keywords) (finder-compile-keywords): * frame.el (frame-notice-user-settings) (frame-remove-geometry-props): * ldap.el (ldap-delete-entries, ldap-modify-entries) (ldap-add-entries): * loadhist.el (unload-feature): * map-ynp.el (map-y-or-n-p): * menubar-items.el (default-menubar): * mouse.el (default-mouse-track-next-move-rect) (default-mouse-track-next-move-rect) (default-mouse-track-cleanup-hook) (default-mouse-track-cleanup-extent): * mule/ethio-util.el (ethio-fidel-to-sera-buffer) (ethio-modify-vowel): * obsolete.el: * package-get.el (package-get-update-all): * package-ui.el (pui-list-packages) (pui-install-selected-packages, pui-install-selected-packages): * select.el (select-make-extent-for-selection) (dehilight-selection): * simple.el (clone-buffer): * term/tvi970.el: * term/wyse50.el: * unicode.el: (load-unicode-tables): * x-font-menu.el (fc-make-font-menu-entry) (x-reset-device-font-menus-xft): * x-misc.el (x-init-specifier-from-resources): Eliminate byte-compile warnings, with the exception of Stephen's various non-defined fontconfig functions, as I don't know if he plans to add them and is keeping the warnings around as a reminder. The warnings actually eliminated involve i) using mapcar instead of mapc where the result is discarded and ii) using a lambda quoted as data in a context where it is unequivocally used as a function.
author Aidan Kehoe <kehoea@parhasard.net>
date Fri, 18 Dec 2009 17:49:43 +0000
parents 2f5d53e62972
children 2e528066e2fc
comparison
equal deleted inserted replaced
4782:1523f1d28be1 4783:e29fcfd8df5f
348 (display-buffer tmpbuf) 348 (display-buffer tmpbuf)
349 (setq do-delete (yes-or-no-p "Remove these packages? ")) 349 (setq do-delete (yes-or-no-p "Remove these packages? "))
350 (kill-buffer tmpbuf)) 350 (kill-buffer tmpbuf))
351 (when do-delete 351 (when do-delete
352 (message "Deleting selected packages ...") (sit-for 0) 352 (message "Deleting selected packages ...") (sit-for 0)
353 (mapcar (lambda (pkg) 353 (mapc (lambda (pkg)
354 (package-admin-delete-binary-package 354 (package-admin-delete-binary-package
355 pkg (package-admin-get-install-dir pkg))) 355 pkg (package-admin-get-install-dir pkg)))
356 (nreverse pui-deleted-packages)) 356 (nreverse pui-deleted-packages))
357 (message "Packages deleted")))) 357 (message "Packages deleted"))))
358 358
359 (let ((tmpbuf "*Packages-To-Install*") 359 (let ((tmpbuf "*Packages-To-Install*")
360 do-install) 360 do-install)
361 (if pui-selected-packages 361 (if pui-selected-packages
383 (set-buffer (get-buffer-create package-admin-temp-buffer)) 383 (set-buffer (get-buffer-create package-admin-temp-buffer))
384 (buffer-disable-undo package-admin-temp-buffer) 384 (buffer-disable-undo package-admin-temp-buffer)
385 (erase-buffer package-admin-temp-buffer)) 385 (erase-buffer package-admin-temp-buffer))
386 (message "Installing selected packages ...") (sit-for 0) 386 (message "Installing selected packages ...") (sit-for 0)
387 (if (catch 'done 387 (if (catch 'done
388 (mapcar (lambda (pkg) 388 (mapc (lambda (pkg)
389 (if (not (package-get pkg nil nil 389 (if (not (package-get pkg nil nil
390 pui-package-install-dest-dir)) 390 pui-package-install-dest-dir))
391 (throw 'done nil))) 391 (throw 'done nil)))
392 (nreverse pui-selected-packages)) 392 (nreverse pui-selected-packages))
393 t) 393 t)
394 (progn 394 (progn
395 (pui-list-packages) 395 (pui-list-packages)
396 (message "Packages installed")))) 396 (message "Packages installed"))))
397 (clear-message))) 397 (clear-message)))
613 (insert " Latest 613 (insert " Latest
614 Package name Vers. Description 614 Package name Vers. Description
615 ")) 615 "))
616 (insert sep-string) 616 (insert sep-string)
617 (setq start (point)) 617 (setq start (point))
618 (mapcar 618 (mapc
619 #'(lambda (pkg) 619 #'(lambda (pkg)
620 (let (pkg-sym info version desc 620 (let (pkg-sym info version desc
621 b e extent current-vers disp) 621 b e extent current-vers disp)
622 (setq pkg-sym (car pkg) 622 (setq pkg-sym (car pkg)
623 info (package-get-info-version (cdr pkg) nil)) 623 info (package-get-info-version (cdr pkg) nil))