comparison lisp/mouse.el @ 4783:e29fcfd8df5f

Eliminate most core code byte-compile warnings. 2009-12-18 Aidan Kehoe <kehoea@parhasard.net> * alist.el (modify-alist): * autoload.el (update-autoload-files, autoload-print-form): * bytecomp.el (batch-byte-compile-1) (byte-compile-multiple-value-call, byte-compile-funcall) (byte-compile-insert, byte-compile-concat, byte-compile-list) (byte-compile-normal-call, byte-compile-flush-pending): * cl-macs.el (letf): * cl.el: * disass.el (disassemble-1): * easy-mmode.el (easy-mmode-define-syntax): * faces.el (set-face-parent): * files.el (cd): * finder.el (finder-list-matches, finder-list-keywords) (finder-compile-keywords): * frame.el (frame-notice-user-settings) (frame-remove-geometry-props): * ldap.el (ldap-delete-entries, ldap-modify-entries) (ldap-add-entries): * loadhist.el (unload-feature): * map-ynp.el (map-y-or-n-p): * menubar-items.el (default-menubar): * mouse.el (default-mouse-track-next-move-rect) (default-mouse-track-next-move-rect) (default-mouse-track-cleanup-hook) (default-mouse-track-cleanup-extent): * mule/ethio-util.el (ethio-fidel-to-sera-buffer) (ethio-modify-vowel): * obsolete.el: * package-get.el (package-get-update-all): * package-ui.el (pui-list-packages) (pui-install-selected-packages, pui-install-selected-packages): * select.el (select-make-extent-for-selection) (dehilight-selection): * simple.el (clone-buffer): * term/tvi970.el: * term/wyse50.el: * unicode.el: (load-unicode-tables): * x-font-menu.el (fc-make-font-menu-entry) (x-reset-device-font-menus-xft): * x-misc.el (x-init-specifier-from-resources): Eliminate byte-compile warnings, with the exception of Stephen's various non-defined fontconfig functions, as I don't know if he plans to add them and is keeping the warnings around as a reminder. The warnings actually eliminated involve i) using mapcar instead of mapc where the result is discarded and ii) using a lambda quoted as data in a context where it is unequivocally used as a function.
author Aidan Kehoe <kehoea@parhasard.net>
date Fri, 18 Dec 2009 17:49:43 +0000
parents 8f1ee2d15784
children bc4f2511bbea
comparison
equal deleted inserted replaced
4782:1523f1d28be1 4783:e29fcfd8df5f
1001 (defun default-mouse-track-next-move-rect (start end extents &optional pad-p) 1001 (defun default-mouse-track-next-move-rect (start end extents &optional pad-p)
1002 (if (< end start) 1002 (if (< end start)
1003 (let ((tmp start)) (setq start end end tmp))) 1003 (let ((tmp start)) (setq start end end tmp)))
1004 (cond 1004 (cond
1005 ((= start end) ; never delete the last remaining extent 1005 ((= start end) ; never delete the last remaining extent
1006 (mapcar 'delete-extent (cdr extents)) 1006 (mapc 'delete-extent (cdr extents))
1007 (setcdr extents nil) 1007 (setcdr extents nil)
1008 (set-extent-endpoints (car extents) start start)) 1008 (set-extent-endpoints (car extents) start start))
1009 (t 1009 (t
1010 (let ((indent-tabs-mode nil) ; if pad-p, don't use tabs 1010 (let ((indent-tabs-mode nil) ; if pad-p, don't use tabs
1011 (rest extents) 1011 (rest extents)
1047 (if (not (eobp)) 1047 (if (not (eobp))
1048 (move-to-column left pad-p)) 1048 (move-to-column left pad-p))
1049 (setq last rest 1049 (setq last rest
1050 rest (cdr rest))) 1050 rest (cdr rest)))
1051 (cond (rest 1051 (cond (rest
1052 (mapcar 'delete-extent rest) 1052 (mapc 'delete-extent rest)
1053 (setcdr last nil)) 1053 (setcdr last nil))
1054 ((not (eobp)) 1054 ((not (eobp))
1055 (while (not (eobp)) 1055 (while (not (eobp))
1056 (setq p (point)) 1056 (setq p (point))
1057 (move-to-column right pad-p) 1057 (move-to-column right pad-p)
1318 (func #'(lambda (e) 1318 (func #'(lambda (e)
1319 (and (extent-live-p e) 1319 (and (extent-live-p e)
1320 (set-extent-face e 'primary-selection))))) 1320 (set-extent-face e 'primary-selection)))))
1321 (add-hook 'pre-command-hook 'default-mouse-track-cleanup-extents-hook) 1321 (add-hook 'pre-command-hook 'default-mouse-track-cleanup-extents-hook)
1322 (if (consp extent) ; rectangle-p 1322 (if (consp extent) ; rectangle-p
1323 (mapcar func extent) 1323 (mapc func extent)
1324 (if extent 1324 (if extent
1325 (funcall func extent))))) 1325 (funcall func extent)))))
1326 t) 1326 t)
1327 1327
1328 (defun default-mouse-track-cleanup-extent () 1328 (defun default-mouse-track-cleanup-extent ()
1332 (extent-detached-p x))))) 1332 (extent-detached-p x)))))
1333 (extent default-mouse-track-extent)) 1333 (extent default-mouse-track-extent))
1334 (if (consp extent) 1334 (if (consp extent)
1335 (if (funcall dead-func extent) 1335 (if (funcall dead-func extent)
1336 (let (newval) 1336 (let (newval)
1337 (mapcar (function (lambda (x) 1337 (mapc (function (lambda (x)
1338 (if (not (funcall dead-func x)) 1338 (if (not (funcall dead-func x))
1339 (setq newval (cons x newval))))) 1339 (setq newval (cons x newval)))))
1340 extent) 1340 extent)
1341 (setq default-mouse-track-extent (nreverse newval)))) 1341 (setq default-mouse-track-extent (nreverse newval))))
1342 (if (funcall dead-func extent) 1342 (if (funcall dead-func extent)
1343 (setq default-mouse-track-extent nil))))) 1343 (setq default-mouse-track-extent nil)))))
1344 1344
1345 (defun default-mouse-track-drag-hook (event click-count was-timeout) 1345 (defun default-mouse-track-drag-hook (event click-count was-timeout)