comparison lisp/ChangeLog @ 5753:dbd8305e13cb

Warn about non-string non-integer ARG to #'gensym, bytecomp.el. lisp/ChangeLog addition: 2013-08-21 Aidan Kehoe <kehoea@parhasard.net> * bytecomp.el: * bytecomp.el (gensym): * bytecomp.el (byte-compile-gensym): New. Warn that gensym called in a for-effect context is unlikely to be useful. Warn about non-string non-integer ARGs, this is incorrect. Am not changing the function to error with same, most code that makes the mistake is has no problems, which is why it has survived so long. * window-xemacs.el (save-window-excursion/mapping): * window.el (save-window-excursion): Call #'gensym with a string, not a symbol.
author Aidan Kehoe <kehoea@parhasard.net>
date Wed, 21 Aug 2013 19:02:59 +0100
parents 2b8edd304c2b
children b09e3b1b7424
comparison
equal deleted inserted replaced
5752:70a3f4ff8da8 5753:dbd8305e13cb
1 2013-08-21 Aidan Kehoe <kehoea@parhasard.net>
2
3 * bytecomp.el:
4 * bytecomp.el (gensym):
5 * bytecomp.el (byte-compile-gensym): New.
6 Warn that gensym called in a for-effect context is unlikely to be
7 useful.
8 Warn about non-string non-integer ARGs, this is incorrect.
9 Am not changing the function to error with same, most code that
10 makes the mistake is has no problems, which is why it has survived
11 so long.
12 * window-xemacs.el (save-window-excursion/mapping):
13 * window.el (save-window-excursion):
14 Call #'gensym with a string, not a symbol.
15
1 2013-08-05 Aidan Kehoe <kehoea@parhasard.net> 16 2013-08-05 Aidan Kehoe <kehoea@parhasard.net>
2 17
3 * isearch-mode.el (isearch-pre-command-hook): 18 * isearch-mode.el (isearch-pre-command-hook):
4 If this function is called and (this-command-keys) contains 19 If this function is called and (this-command-keys) contains
5 misc-user events, #'key-binding throws an error. 20 misc-user events, #'key-binding throws an error.