Mercurial > hg > xemacs-beta
comparison src/ChangeLog @ 5077:d372b17f63ce
clean up toolbar/gutter edge geometry
-------------------- ChangeLog entries follow: --------------------
src/ChangeLog addition:
2010-02-25 Ben Wing <ben@xemacs.org>
* EmacsFrame.c (EmacsFrameSetValues):
* frame-impl.h:
* frame-impl.h (struct frame):
* frame-impl.h (FRAME_THEORETICAL_TOP_TOOLBAR_HEIGHT):
* frame-impl.h (FRAME_THEORETICAL_TOP_TOOLBAR_BORDER_WIDTH):
* frame-impl.h (FRAME_REAL_TOP_TOOLBAR_HEIGHT):
* frame-impl.h (FRAME_REAL_TOP_TOOLBAR_BORDER_WIDTH):
* frame-impl.h (FRAME_REAL_TOP_TOOLBAR_VISIBLE):
* frame-impl.h (FRAME_REAL_TOP_TOOLBAR_BOUNDS):
* frame.h:
* frame.h (enum edge_pos):
* gutter.c:
* gutter.c (get_gutter_coords):
* gutter.c (display_boxes_in_gutter_p):
* gutter.c (construct_window_gutter_spec):
* gutter.c (calculate_gutter_size_from_display_lines):
* gutter.c (calculate_gutter_size):
* gutter.c (output_gutter):
* gutter.c (clear_gutter):
* gutter.c (mark_gutters):
* gutter.c (gutter_extent_signal_changed_region_maybe):
* gutter.c (update_gutter_geometry):
* gutter.c (update_frame_gutter_geometry):
* gutter.c (update_frame_gutters):
* gutter.c (reset_gutter_display_lines):
* gutter.c (redraw_exposed_gutter):
* gutter.c (redraw_exposed_gutters):
* gutter.c (free_frame_gutters):
* gutter.c (decode_gutter_position):
* gutter.c (Fset_default_gutter_position):
* gutter.c (Fgutter_pixel_width):
* gutter.c (Fgutter_pixel_height):
* gutter.c (recompute_overlaying_specifier):
* gutter.c (gutter_specs_changed_1):
* gutter.c (gutter_specs_changed):
* gutter.c (top_gutter_specs_changed):
* gutter.c (bottom_gutter_specs_changed):
* gutter.c (left_gutter_specs_changed):
* gutter.c (right_gutter_specs_changed):
* gutter.c (gutter_geometry_changed_in_window):
* gutter.c (init_frame_gutters):
* gutter.c (specifier_vars_of_gutter):
* gutter.h:
* gutter.h (WINDOW_REAL_TOP_GUTTER_BOUNDS):
* gutter.h (FRAME_TOP_GUTTER_BOUNDS):
* lisp.h (enum edge_style):
* native-gtk-toolbar.c:
* native-gtk-toolbar.c (gtk_output_toolbar):
* native-gtk-toolbar.c (gtk_clear_toolbar):
* native-gtk-toolbar.c (gtk_output_frame_toolbars):
* native-gtk-toolbar.c (gtk_initialize_frame_toolbars):
* toolbar-msw.c:
* toolbar-msw.c (TOOLBAR_HANDLE):
* toolbar-msw.c (allocate_toolbar_item_id):
* toolbar-msw.c (mswindows_clear_toolbar):
* toolbar-msw.c (mswindows_output_toolbar):
* toolbar-msw.c (mswindows_move_toolbar):
* toolbar-msw.c (mswindows_redraw_exposed_toolbars):
* toolbar-msw.c (mswindows_initialize_frame_toolbars):
* toolbar-msw.c (mswindows_output_frame_toolbars):
* toolbar-msw.c (mswindows_clear_frame_toolbars):
* toolbar-msw.c (DELETE_TOOLBAR):
* toolbar-msw.c (mswindows_free_frame_toolbars):
* toolbar-msw.c (mswindows_get_toolbar_button_text):
* toolbar-xlike.c:
* toolbar-xlike.c (__prepare_button_area):
* toolbar-xlike.c (XLIKE_OUTPUT_BUTTONS_LOOP):
* toolbar-xlike.c (xlike_output_toolbar):
* toolbar-xlike.c (xlike_clear_toolbar):
* toolbar-xlike.c (xlike_output_frame_toolbars):
* toolbar-xlike.c (xlike_clear_frame_toolbars):
* toolbar-xlike.c (xlike_redraw_exposed_toolbar):
* toolbar-xlike.c (xlike_redraw_exposed_toolbars):
* toolbar-xlike.c (xlike_redraw_frame_toolbars):
* toolbar.c:
* toolbar.c (decode_toolbar_position):
* toolbar.c (Fset_default_toolbar_position):
* toolbar.c (mark_frame_toolbar_buttons_dirty):
* toolbar.c (compute_frame_toolbar_buttons):
* toolbar.c (set_frame_toolbar):
* toolbar.c (compute_frame_toolbars_data):
* toolbar.c (update_frame_toolbars_geometry):
* toolbar.c (init_frame_toolbars):
* toolbar.c (get_toolbar_coords):
* toolbar.c (CHECK_TOOLBAR):
* toolbar.c (toolbar_buttons_at_pixpos):
* toolbar.c (CTB_ERROR):
* toolbar.c (recompute_overlaying_specifier):
* toolbar.c (specifier_vars_of_toolbar):
* toolbar.h:
* toolbar.h (SET_TOOLBAR_WAS_VISIBLE_FLAG):
Create new enum edge_pos with TOP_EDGE, BOTTOM_EDGE, LEFT_EDGE,
RIGHT_EDGE; subsume TOP_BORDER, TOP_GUTTER, enum toolbar_pos,
enum gutter_pos, etc.
Create EDGE_POS_LOOP, subsuming GUTTER_POS_LOOP.
Create NUM_EDGES, use in many places instead of hardcoded '4'.
Instead of top_toolbar_was_visible, bottom_toolbar_was_visible,
etc. make an array toolbar_was_visible[NUM_EDGES]. This increases
the frame size by 15 bytes or so (could be 3 if we use Boolbytes)
but hardly seems w to matter -- frames are heavy weight objects
anyway. Same with top_gutter_was_visible, etc.
Remove duplicated SET_TOOLBAR_WAS_VISIBLE_FLAG and put defn in
one place (toolbar.h).
| author | Ben Wing <ben@xemacs.org> |
|---|---|
| date | Thu, 25 Feb 2010 04:45:13 -0600 |
| parents | 14f0dd1fabdb |
| children | a04cf0fea770 |
comparison
equal
deleted
inserted
replaced
| 5076:d555581e3cba | 5077:d372b17f63ce |
|---|---|
| 1 2010-02-25 Ben Wing <ben@xemacs.org> | |
| 2 | |
| 3 * EmacsFrame.c (EmacsFrameSetValues): | |
| 4 * frame-impl.h: | |
| 5 * frame-impl.h (struct frame): | |
| 6 * frame-impl.h (FRAME_THEORETICAL_TOP_TOOLBAR_HEIGHT): | |
| 7 * frame-impl.h (FRAME_THEORETICAL_TOP_TOOLBAR_BORDER_WIDTH): | |
| 8 * frame-impl.h (FRAME_REAL_TOP_TOOLBAR_HEIGHT): | |
| 9 * frame-impl.h (FRAME_REAL_TOP_TOOLBAR_BORDER_WIDTH): | |
| 10 * frame-impl.h (FRAME_REAL_TOP_TOOLBAR_VISIBLE): | |
| 11 * frame-impl.h (FRAME_REAL_TOP_TOOLBAR_BOUNDS): | |
| 12 * frame.h: | |
| 13 * frame.h (enum edge_pos): | |
| 14 * gutter.c: | |
| 15 * gutter.c (get_gutter_coords): | |
| 16 * gutter.c (display_boxes_in_gutter_p): | |
| 17 * gutter.c (construct_window_gutter_spec): | |
| 18 * gutter.c (calculate_gutter_size_from_display_lines): | |
| 19 * gutter.c (calculate_gutter_size): | |
| 20 * gutter.c (output_gutter): | |
| 21 * gutter.c (clear_gutter): | |
| 22 * gutter.c (mark_gutters): | |
| 23 * gutter.c (gutter_extent_signal_changed_region_maybe): | |
| 24 * gutter.c (update_gutter_geometry): | |
| 25 * gutter.c (update_frame_gutter_geometry): | |
| 26 * gutter.c (update_frame_gutters): | |
| 27 * gutter.c (reset_gutter_display_lines): | |
| 28 * gutter.c (redraw_exposed_gutter): | |
| 29 * gutter.c (redraw_exposed_gutters): | |
| 30 * gutter.c (free_frame_gutters): | |
| 31 * gutter.c (decode_gutter_position): | |
| 32 * gutter.c (Fset_default_gutter_position): | |
| 33 * gutter.c (Fgutter_pixel_width): | |
| 34 * gutter.c (Fgutter_pixel_height): | |
| 35 * gutter.c (recompute_overlaying_specifier): | |
| 36 * gutter.c (gutter_specs_changed_1): | |
| 37 * gutter.c (gutter_specs_changed): | |
| 38 * gutter.c (top_gutter_specs_changed): | |
| 39 * gutter.c (bottom_gutter_specs_changed): | |
| 40 * gutter.c (left_gutter_specs_changed): | |
| 41 * gutter.c (right_gutter_specs_changed): | |
| 42 * gutter.c (gutter_geometry_changed_in_window): | |
| 43 * gutter.c (init_frame_gutters): | |
| 44 * gutter.c (specifier_vars_of_gutter): | |
| 45 * gutter.h: | |
| 46 * gutter.h (WINDOW_REAL_TOP_GUTTER_BOUNDS): | |
| 47 * gutter.h (FRAME_TOP_GUTTER_BOUNDS): | |
| 48 * lisp.h (enum edge_style): | |
| 49 * native-gtk-toolbar.c: | |
| 50 * native-gtk-toolbar.c (gtk_output_toolbar): | |
| 51 * native-gtk-toolbar.c (gtk_clear_toolbar): | |
| 52 * native-gtk-toolbar.c (gtk_output_frame_toolbars): | |
| 53 * native-gtk-toolbar.c (gtk_initialize_frame_toolbars): | |
| 54 * toolbar-msw.c: | |
| 55 * toolbar-msw.c (TOOLBAR_HANDLE): | |
| 56 * toolbar-msw.c (allocate_toolbar_item_id): | |
| 57 * toolbar-msw.c (mswindows_clear_toolbar): | |
| 58 * toolbar-msw.c (mswindows_output_toolbar): | |
| 59 * toolbar-msw.c (mswindows_move_toolbar): | |
| 60 * toolbar-msw.c (mswindows_redraw_exposed_toolbars): | |
| 61 * toolbar-msw.c (mswindows_initialize_frame_toolbars): | |
| 62 * toolbar-msw.c (mswindows_output_frame_toolbars): | |
| 63 * toolbar-msw.c (mswindows_clear_frame_toolbars): | |
| 64 * toolbar-msw.c (DELETE_TOOLBAR): | |
| 65 * toolbar-msw.c (mswindows_free_frame_toolbars): | |
| 66 * toolbar-msw.c (mswindows_get_toolbar_button_text): | |
| 67 * toolbar-xlike.c: | |
| 68 * toolbar-xlike.c (__prepare_button_area): | |
| 69 * toolbar-xlike.c (XLIKE_OUTPUT_BUTTONS_LOOP): | |
| 70 * toolbar-xlike.c (xlike_output_toolbar): | |
| 71 * toolbar-xlike.c (xlike_clear_toolbar): | |
| 72 * toolbar-xlike.c (xlike_output_frame_toolbars): | |
| 73 * toolbar-xlike.c (xlike_clear_frame_toolbars): | |
| 74 * toolbar-xlike.c (xlike_redraw_exposed_toolbar): | |
| 75 * toolbar-xlike.c (xlike_redraw_exposed_toolbars): | |
| 76 * toolbar-xlike.c (xlike_redraw_frame_toolbars): | |
| 77 * toolbar.c: | |
| 78 * toolbar.c (decode_toolbar_position): | |
| 79 * toolbar.c (Fset_default_toolbar_position): | |
| 80 * toolbar.c (mark_frame_toolbar_buttons_dirty): | |
| 81 * toolbar.c (compute_frame_toolbar_buttons): | |
| 82 * toolbar.c (set_frame_toolbar): | |
| 83 * toolbar.c (compute_frame_toolbars_data): | |
| 84 * toolbar.c (update_frame_toolbars_geometry): | |
| 85 * toolbar.c (init_frame_toolbars): | |
| 86 * toolbar.c (get_toolbar_coords): | |
| 87 * toolbar.c (CHECK_TOOLBAR): | |
| 88 * toolbar.c (toolbar_buttons_at_pixpos): | |
| 89 * toolbar.c (CTB_ERROR): | |
| 90 * toolbar.c (recompute_overlaying_specifier): | |
| 91 * toolbar.c (specifier_vars_of_toolbar): | |
| 92 * toolbar.h: | |
| 93 * toolbar.h (SET_TOOLBAR_WAS_VISIBLE_FLAG): | |
| 94 Create new enum edge_pos with TOP_EDGE, BOTTOM_EDGE, LEFT_EDGE, | |
| 95 RIGHT_EDGE; subsume TOP_BORDER, TOP_GUTTER, enum toolbar_pos, | |
| 96 enum gutter_pos, etc. | |
| 97 | |
| 98 Create EDGE_POS_LOOP, subsuming GUTTER_POS_LOOP. | |
| 99 | |
| 100 Create NUM_EDGES, use in many places instead of hardcoded '4'. | |
| 101 | |
| 102 Instead of top_toolbar_was_visible, bottom_toolbar_was_visible, | |
| 103 etc. make an array toolbar_was_visible[NUM_EDGES]. This increases | |
| 104 the frame size by 15 bytes or so (could be 3 if we use Boolbytes) | |
| 105 but hardly seems w to matter -- frames are heavy weight objects | |
| 106 anyway. Same with top_gutter_was_visible, etc. | |
| 107 | |
| 108 Remove duplicated SET_TOOLBAR_WAS_VISIBLE_FLAG and put defn in | |
| 109 one place (toolbar.h). | |
| 110 | |
| 1 2010-02-22 Ben Wing <ben@xemacs.org> | 111 2010-02-22 Ben Wing <ben@xemacs.org> |
| 2 | 112 |
| 3 * .gdbinit.in.in: | 113 * .gdbinit.in.in: |
| 4 * Makefile.in.in (batch_test_emacs): | 114 * Makefile.in.in (batch_test_emacs): |
| 5 test-harness.el is in lisp directory now so change how we call it. | 115 test-harness.el is in lisp directory now so change how we call it. |
