comparison lisp/ChangeLog @ 4686:cdabd56ce1b5

Fix various small issues with the multiple-value implementation. lisp/ChangeLog addition: 2009-08-31 Aidan Kehoe <kehoea@parhasard.net> * byte-optimize.el (byte-optimize-form-code-walker): Be careful about discarding multiple values when optimising #'prog1 calls. (byte-optimize-or): Preserve any trailing nil, as this is a supported way to explicitly discard multiple values. (byte-optimize-cond-1): Discard multiple values with a singleton followed by no more clauses. * bytecomp.el (progn): (prog1): (prog2): Be careful about discarding multiple values in the byte-hunk handler of these three forms. * bytecomp.el (byte-compile-prog1, byte-compile-prog2): Don't call #'values explicitly, use `(or ,(pop form) nil) instead, since that compiles to bytecode, not a funcall. * bytecomp.el (byte-compile-values): With one non-const argument, byte-compile to `(or ,(second form) nil), not an explicit #'values call. * bytecomp.el (byte-compile-insert-header): Be nicer in the error message to emacs versions that don't understand our bytecode. src/ChangeLog addition: 2009-08-31 Aidan Kehoe <kehoea@parhasard.net> * eval.c (For, Fand): Don't declare val as REGISTER in these functions, for some reason it breaks the non-DEBUG union build. These functions are only called from interpreted code, the performance implication doesn't matter. Thank you Robert Delius Royar! * eval.c (Fmultiple_value_list_internal): Error on too many arguments. tests/ChangeLog addition: 2009-08-31 Aidan Kehoe <kehoea@parhasard.net> * automated/lisp-tests.el (Assert-rounding): Remove an overly-verbose failure message here. Correct a couple of tests which were buggy in themselves. Add three new tests, checking the behaviour of #'or and #'and when passed zero arguments, and a Known-Bug-Expect-Failure call involving letf and values. (The bug predates the C-level multiple-value implementation.)
author Aidan Kehoe <kehoea@parhasard.net>
date Sun, 06 Sep 2009 19:36:02 +0100
parents 15c42a3f4065
children 02b7c7189041
comparison
equal deleted inserted replaced
4685:945247a8112f 4686:cdabd56ce1b5
1 2009-08-31 Aidan Kehoe <kehoea@parhasard.net>
2
3 * byte-optimize.el (byte-optimize-form-code-walker):
4 Be careful about discarding multiple values when optimising
5 #'prog1 calls.
6 (byte-optimize-or):
7 Preserve any trailing nil, as this is a supported way to
8 explicitly discard multiple values.
9 (byte-optimize-cond-1):
10 Discard multiple values with a singleton followed by no more
11 clauses.
12 * bytecomp.el (progn):
13 (prog1):
14 (prog2):
15 Be careful about discarding multiple values in the byte-hunk
16 handler of these three forms.
17 * bytecomp.el (byte-compile-prog1, byte-compile-prog2):
18 Don't call #'values explicitly, use `(or ,(pop form) nil) instead,
19 since that compiles to bytecode, not a funcall.
20 * bytecomp.el (byte-compile-values):
21 With one non-const argument, byte-compile to `(or ,(second form)
22 nil), not an explicit #'values call.
23 * bytecomp.el (byte-compile-insert-header):
24 Be nicer in the error message to emacs versions that don't
25 understand our bytecode.
26
1 2009-08-27 Aidan Kehoe <kehoea@parhasard.net> 27 2009-08-27 Aidan Kehoe <kehoea@parhasard.net>
2 28
3 * cl.el (bytecomp-load-hook): New. 29 * cl.el (bytecomp-load-hook): New.
4 * bytecomp.el (bytecomp-load-hook): Use id. 30 * bytecomp.el (bytecomp-load-hook): Use id.
5 Merge Dave Love's 2000-02-02 GNU (GPLv2) change, forcing the 31 Merge Dave Love's 2000-02-02 GNU (GPLv2) change, forcing the