Mercurial > hg > xemacs-beta
comparison src/free-hook.c @ 5146:88bd4f3ef8e4
make lrecord UID's have a separate UID space for each object, resurrect debug SOE code in extents.c
-------------------- ChangeLog entries follow: --------------------
src/ChangeLog addition:
2010-03-15 Ben Wing <ben@xemacs.org>
* alloc.c:
* alloc.c (c_readonly):
* alloc.c (deadbeef_memory):
* alloc.c (make_compiled_function):
* alloc.c (make_button_data):
* alloc.c (make_motion_data):
* alloc.c (make_process_data):
* alloc.c (make_timeout_data):
* alloc.c (make_magic_data):
* alloc.c (make_magic_eval_data):
* alloc.c (make_eval_data):
* alloc.c (make_misc_user_data):
* alloc.c (noseeum_make_marker):
* alloc.c (ADDITIONAL_FREE_string):
* alloc.c (common_init_alloc_early):
* alloc.c (init_alloc_once_early):
* bytecode.c (print_compiled_function):
* bytecode.c (mark_compiled_function):
* casetab.c:
* casetab.c (print_case_table):
* console.c:
* console.c (print_console):
* database.c (print_database):
* database.c (finalize_database):
* device-msw.c (sync_printer_with_devmode):
* device-msw.c (print_devmode):
* device-msw.c (finalize_devmode):
* device.c:
* device.c (print_device):
* elhash.c:
* elhash.c (print_hash_table):
* eval.c (print_multiple_value):
* eval.c (mark_multiple_value):
* events.c (deinitialize_event):
* events.c (print_event):
* events.c (event_equal):
* extents.c:
* extents.c (soe_dump):
* extents.c (soe_insert):
* extents.c (soe_delete):
* extents.c (soe_move):
* extents.c (extent_fragment_update):
* extents.c (print_extent_1):
* extents.c (print_extent):
* extents.c (vars_of_extents):
* frame.c:
* frame.c (print_frame):
* free-hook.c:
* free-hook.c (check_free):
* glyphs.c:
* glyphs.c (print_image_instance):
* glyphs.c (print_glyph):
* gui.c:
* gui.c (copy_gui_item):
* hash.c:
* hash.c (NULL_ENTRY):
* hash.c (KEYS_DIFFER_P):
* keymap.c (print_keymap):
* keymap.c (MARKED_SLOT):
* lisp.h:
* lrecord.h:
* lrecord.h (LISP_OBJECT_UID):
* lrecord.h (set_lheader_implementation):
* lrecord.h (struct old_lcrecord_header):
* lstream.c (print_lstream):
* lstream.c (finalize_lstream):
* marker.c (print_marker):
* marker.c (marker_equal):
* mc-alloc.c (visit_all_used_page_headers):
* mule-charset.c:
* mule-charset.c (print_charset):
* objects.c (print_color_instance):
* objects.c (print_font_instance):
* objects.c (finalize_font_instance):
* opaque.c (print_opaque):
* opaque.c (print_opaque_ptr):
* opaque.c (equal_opaque_ptr):
* print.c (internal_object_printer):
* print.c (enum printing_badness):
* rangetab.c (print_range_table):
* rangetab.c (range_table_equal):
* specifier.c (print_specifier):
* specifier.c (finalize_specifier):
* symbols.c:
* symbols.c (print_symbol_value_magic):
* tooltalk.c:
* tooltalk.c (print_tooltalk_message):
* tooltalk.c (print_tooltalk_pattern):
* window.c (print_window):
* window.c (debug_print_window):
(1) Make lrecord UID's have a separate UID space for each object.
Otherwise, with 20-bit UID's, we rapidly wrap around, especially
when common objects like conses and strings increment the UID value
for every object created. (Originally I tried making two UID spaces,
one for objects that always print readably and hence don't display
the UID, and one for other objects. But certain objects like markers
for which a UID is displayed are still generated rapidly enough that
UID overflow is a serious issue.) This also has the advantage of
making UID values smaller, hence easier to remember -- their main
purpose is to make it easier to keep track of different objects of
the same type when debugging code. Make sure we dump lrecord UID's
so that we don't have problems with pdumped and non-dumped objects
having the same UID.
(2) Display UID's consistently whenever an object (a) doesn't
consistently print readably (objects like cons and string, which
always print readably, can't display a UID), and (b) doesn't
otherwise have a unique property that makes objects of a
particular type distinguishable. (E.g. buffers didn't and still
don't print an ID, but the buffer name uniquely identifies the
buffer.) Some types, such as event, extent, compiled-function,
didn't always (or didn't ever) display an ID; others (such as
marker, extent, lstream, opaque, opaque-ptr, any object using
internal_object_printer()) used to display the actual machine
pointer instead.
(3) Rename NORMAL_LISP_OBJECT_UID to LISP_OBJECT_UID; make it work
over all Lisp objects and take a Lisp object, not a struct pointer.
(4) Some misc cleanups in alloc.c, elhash.c.
(5) Change code in events.c that "deinitializes" an event so that
it doesn't increment the event UID counter in the process. Also
use deadbeef_memory() to overwrite memory instead of doing the same
with custom code. In the process, make deadbeef_memory() in
alloc.c always available, and delete extraneous copy in mc-alloc.c.
Also capitalize all uses of 0xDEADBEEF. Similarly in elhash.c
call deadbeef_memory().
(6) Resurrect "debug SOE" code in extents.c. Make it conditional
on DEBUG_XEMACS and on a `debug-soe' variable, rather than on
SOE_DEBUG. Make it output to stderr, not stdout.
(7) Delete some custom print methods that were identical to
external_object_printer().
| author | Ben Wing <ben@xemacs.org> |
|---|---|
| date | Mon, 15 Mar 2010 16:35:38 -0500 |
| parents | 6f2158fa75ed |
| children | 308d34e9f07d |
comparison
equal
deleted
inserted
replaced
| 5145:0b0241ae382f | 5146:88bd4f3ef8e4 |
|---|---|
| 1 /* This file is part of XEmacs. | 1 /* Copyright (C) 2010 Ben Wing. |
| 2 This file is part of XEmacs. | |
| 2 | 3 |
| 3 XEmacs is free software; you can redistribute it and/or modify it | 4 XEmacs is free software; you can redistribute it and/or modify it |
| 4 under the terms of the GNU General Public License as published by the | 5 under the terms of the GNU General Public License as published by the |
| 5 Free Software Foundation; either version 2, or (at your option) any | 6 Free Software Foundation; either version 2, or (at your option) any |
| 6 later version. | 7 later version. |
| 24 | 25 |
| 25 * Freeing the same pointer twice. | 26 * Freeing the same pointer twice. |
| 26 * Trying to free a pointer not returned by malloc. | 27 * Trying to free a pointer not returned by malloc. |
| 27 * Trying to realloc a pointer not returned by malloc. | 28 * Trying to realloc a pointer not returned by malloc. |
| 28 | 29 |
| 29 In addition, every word of every block freed is set to 0xdeadbeef | 30 In addition, every word of every block freed is set to 0xDEADBEEF |
| 30 (-559038737). This causes many uses of freed storage to be trapped or | 31 (-559038737). This causes many uses of freed storage to be trapped or |
| 31 recognized. | 32 recognized. |
| 32 | 33 |
| 33 When you use this, the storage used by the last FREE_QUEUE_LIMIT | 34 When you use this, the storage used by the last FREE_QUEUE_LIMIT |
| 34 calls to free() is not recycled. When you call free for the Nth | 35 calls to free() is not recycled. When you call free for the Nth |
| 41 (gdb) p/a *find_backtrace (0x234000). If SAVE_ARGS is defined, | 42 (gdb) p/a *find_backtrace (0x234000). If SAVE_ARGS is defined, |
| 42 the first three arguments to each function are saved as well as the | 43 the first three arguments to each function are saved as well as the |
| 43 return addresses. | 44 return addresses. |
| 44 | 45 |
| 45 If UNMAPPED_FREE is defined, instead of setting every word of freed | 46 If UNMAPPED_FREE is defined, instead of setting every word of freed |
| 46 storage to 0xdeadbeef, every call to malloc goes on its own page(s). | 47 storage to 0xDEADBEEF, every call to malloc goes on its own page(s). |
| 47 When free() is called, the block is read and write protected. This | 48 When free() is called, the block is read and write protected. This |
| 48 is very useful when debugging, since it usually generates a bus error | 49 is very useful when debugging, since it usually generates a bus error |
| 49 when the deadbeef hack might only cause some garbage to be printed. | 50 when the DEADBEEF hack might only cause some garbage to be printed. |
| 50 However, this is too slow for everyday use, since it takes an enormous | 51 However, this is too slow for everyday use, since it takes an enormous |
| 51 number of pages. | 52 number of pages. |
| 52 | 53 |
| 53 | 54 |
| 54 Some other features that would be useful are: | 55 Some other features that would be useful are: |
| 168 rounded_up_size = ROUND_UP_TO_PAGE (size); | 169 rounded_up_size = ROUND_UP_TO_PAGE (size); |
| 169 /* Protect the pages freed from all access */ | 170 /* Protect the pages freed from all access */ |
| 170 if (strict_free_check) | 171 if (strict_free_check) |
| 171 mprotect (ptr, rounded_up_size, PROT_NONE); | 172 mprotect (ptr, rounded_up_size, PROT_NONE); |
| 172 #else | 173 #else |
| 173 /* Set every word in the block to 0xdeadbeef */ | 174 /* Set every word in the block to 0xDEADBEEF */ |
| 174 if (strict_free_check) | 175 if (strict_free_check) |
| 175 { | 176 { |
| 176 unsigned long long_length = (size + (sizeof (long) - 1)) | 177 unsigned long long_length = (size + (sizeof (long) - 1)) |
| 177 / sizeof (long); | 178 / sizeof (long); |
| 178 unsigned long i; | 179 unsigned long i; |
| 179 | 180 |
| 180 /* Not using the DEADBEEF_CONSTANT #define, since we don't know | 181 /* Not using the DEADBEEF_CONSTANT #define, since we don't know |
| 181 * that allocation sizes will be multiples of eight. */ | 182 * that allocation sizes will be multiples of eight. */ |
| 182 for (i = 0; i < long_length; i++) | 183 for (i = 0; i < long_length; i++) |
| 183 ((unsigned long *) ptr)[i] = 0xdeadbeef; | 184 ((unsigned long *) ptr)[i] = 0xDEADBEEF; |
| 184 } | 185 } |
| 185 #endif | 186 #endif |
| 186 free_queue[current_free].address = ptr; | 187 free_queue[current_free].address = ptr; |
| 187 free_queue[current_free].length = size; | 188 free_queue[current_free].length = size; |
| 188 | 189 |