Mercurial > hg > xemacs-beta
comparison lisp/cl-macs.el @ 4995:8431b52e43b1
Move the various map* functions to C; add #'map-into.
src/ChangeLog addition:
2010-01-31 Aidan Kehoe <kehoea@parhasard.net>
Move #'mapcar*, #'mapcan, #'mapc, #'map, #'mapl, #'mapcon to C;
extend #'mapvector, #'mapconcat, #'mapcar to support more
SEQUENCES; have them all error with circular lists.
* fns.c (Fsubseq): Call CHECK_SEQUENCE here; Flength can return
from the debugger if it errors with a non-sequence, leading to a
crash in Fsubseq if sequence really is *not* a sequence.
(mapcarX): Rename mapcar1 to mapcarX; rework it comprehensively to
take an optional lisp output argument, and a varying number of
sequences.
Special-case a single list argument, as we used to, saving its
elements in the stack space for the results before calling
FUNCTION, so FUNCTION can corrupt the list all it
wants. dead_wrong_type_argument() in the other cases if we
encounter a non-cons where we expected a cons.
(Fmapconcat):
Accept further SEQUENCES after separator here. Special-case
the idiom (mapconcat 'identity SEQUENCE), don't even funcall.
(FmapcarX): Rename this from Fmapcar. Accept optional SEQUENCES.
(Fmapvector): Accept optional SEQUENCES.
(Fmapcan, Fmapc, Fmap): Move these here from cl-extra.el.
(Fmap_into): New function, as specified by Common Lisp.
(maplist): New function, the guts of the implementation of
Fmaplist and Fmapl.
(Fmaplist, Fmapl, Fmapcon): Move these from cl-extra.el.
(syms_of_fns):
Add a few needed symbols here, for the type tests
used by #'map. Add the new subrs, with aliases for #'mapc-internal
and #'mapcar.
* general-slots.h: Declare Qcoerce here, now it's used in both
indent.c and fns.c
* indent.c (syms_of_indent): Qcoerce is gone from here.
* lisp.h: Add ARRAYP(), SEQUENCEP(), and the corresponding CHECK_*
macros. Declare Fbit_vector, Fstring, FmapcarX, now other files
need to use them.
* data.c (Farrayp, Fsequencep): Use ARRAYP and SEQUENCEP, just
added to lisp.h
* buffer.c (Fbuffer_list): Now Fmapcar has been renamed FmapcarX
and takes MANY arguments, update this function to reflect that.
lisp/ChangeLog addition:
2010-01-31 Aidan Kehoe <kehoea@parhasard.net>
* cl.el (mapcar*): Delete; this is now in fns.c.
Use #'mapc, not #'mapc-internal in a couple of places.
* cl-macs.el (mapc, mapcar*, map): Delete these compiler macros
now the corresponding functions are in fns.c; there's no run-time
advantage to the macros.
* cl-extra.el (coerce): Extend the possible conversions here a
little; it's not remotely comprehensive yet, though it does allow
running slightly more Common Lisp code than previously.
(cl-mapcar-many): Delete.
(map, maplist, mapc, mapl, mapcan, mapcon): Move these to fns.c.
* bytecomp.el (byte-compile-maybe-mapc):
Use #'mapc itself, not #'mapc-internal, now the former is in C.
(mapcar*): Use #'byte-compile-maybe-mapc as this function's
byte-compile method, now a #'mapc that can take more than one
sequence is in C.
* obsolete.el (cl-mapc): Move this compatibility alias to this file.
* update-elc.el (do-autoload-commands): Use #'mapc, not
#'mapc-internal here.
author | Aidan Kehoe <kehoea@parhasard.net> |
---|---|
date | Sun, 31 Jan 2010 18:29:48 +0000 |
parents | 6772ce4d982b |
children | c17c857e20bf |
comparison
equal
deleted
inserted
replaced
4904:e91e3e353805 | 4995:8431b52e43b1 |
---|---|
3335 ;; getting compiler-macroexpanded again: | 3335 ;; getting compiler-macroexpanded again: |
3336 (cl-delete-duplicates begin ',cl-keys nil)))) | 3336 (cl-delete-duplicates begin ',cl-keys nil)))) |
3337 (t | 3337 (t |
3338 form)))) | 3338 form)))) |
3339 | 3339 |
3340 ;; XEmacs change, the GNU mapc doesn't accept the Common Lisp args, so this | |
3341 ;; change isn't helpful. | |
3342 (define-compiler-macro mapc (&whole form cl-func cl-seq &rest cl-rest) | |
3343 (if cl-rest | |
3344 form | |
3345 (cons 'mapc-internal (cdr form)))) | |
3346 | |
3347 (define-compiler-macro mapcar* (&whole form cl-func cl-x &rest cl-rest) | |
3348 (if cl-rest | |
3349 form | |
3350 (cons 'mapcar (cdr form)))) | |
3351 | |
3352 ;; XEmacs; it's perfectly reasonable, and often much clearer to those | 3340 ;; XEmacs; it's perfectly reasonable, and often much clearer to those |
3353 ;; reading the code, to call regexp-quote on a constant string, which is | 3341 ;; reading the code, to call regexp-quote on a constant string, which is |
3354 ;; something we can optimise here easily. | 3342 ;; something we can optimise here easily. |
3355 (define-compiler-macro regexp-quote (&whole form string) | 3343 (define-compiler-macro regexp-quote (&whole form string) |
3356 (if (stringp string) | 3344 (if (stringp string) |
3466 ;; Neither side is a constant expression, do all our evaluation at | 3454 ;; Neither side is a constant expression, do all our evaluation at |
3467 ;; runtime (or both are, and equalp will be called from | 3455 ;; runtime (or both are, and equalp will be called from |
3468 ;; byte-optimize.el). | 3456 ;; byte-optimize.el). |
3469 (t form))))) | 3457 (t form))))) |
3470 | 3458 |
3471 (define-compiler-macro map (&whole form cl-type cl-func cl-seq | |
3472 &rest cl-rest) | |
3473 "If CL-TYPE is a constant expression that we know how to handle, transform | |
3474 the call to `map' to a more efficient expression." | |
3475 (cond | |
3476 ;; The first two here rely on the compiler macros for mapc and mapcar*, | |
3477 ;; to convert to mapc-internal and mapcar, where appropriate (that is, in | |
3478 ;; the absence of cl-rest.) | |
3479 ((null cl-type) | |
3480 `(prog1 nil (mapc ,@(nthcdr 2 form)))) | |
3481 ((equal '(quote list) cl-type) | |
3482 (cons 'mapcar* (nthcdr 2 form))) | |
3483 ((or (equal '(quote vector) cl-type) | |
3484 (equal '(quote array) cl-type)) | |
3485 (if cl-rest | |
3486 `(vconcat (mapcar* ,@(nthcdr 2 form))) | |
3487 (cons 'mapvector (nthcdr 2 form)))) | |
3488 ((equal '(quote string) cl-type) | |
3489 `(concat (mapcar* ,@(nthcdr 2 form)))) | |
3490 ((equal '(quote bit-vector) cl-type) | |
3491 `(bvconcat (mapcar* ,@(nthcdr 2 form)))) | |
3492 (t form))) | |
3493 | |
3494 (mapc | 3459 (mapc |
3495 #'(lambda (y) | 3460 #'(lambda (y) |
3496 (put (car y) 'side-effect-free t) | 3461 (put (car y) 'side-effect-free t) |
3497 (put (car y) 'byte-compile 'cl-byte-compile-compiler-macro) | 3462 (put (car y) 'byte-compile 'cl-byte-compile-compiler-macro) |
3498 (put (car y) 'cl-compiler-macro | 3463 (put (car y) 'cl-compiler-macro |