Mercurial > hg > xemacs-beta
comparison src/gutter.c @ 5879:77d7b77909c2
Move extents.c to working in byte positions only; fix a bug, extent_detach()
src/ChangeLog addition:
2015-03-27 Aidan Kehoe <kehoea@parhasard.net>
Fix a small bug, extent_detach(); minimise needless char-byte
conversion, extents.c, sticking to byte positions in general in
this file.
* extents.c:
* extents.c (signal_single_extent_changed):
Pass byte endpoints to
gutter_extent_signal_changed_region_maybe(),
buffer_extent_signal_changed_region().
* extents.c (extent_detach):
Call signal_extent_changed() correctly, pass both extent endpoints
rather than just the byte and character variants of the start.
* extents.c (struct report_extent_modification_closure):
Do this in terms of byte positions.
* extents.c (report_extent_modification_mapper):
Use byte positions, only converting to characters when we are
definitely calling Lisp.
* extents.c (report_extent_modification):
Use byte positions in this API, move the byte-char conversion to
our callers, simplifying extents.c (it all now works in byte
positions).
* extents.h:
Update report_extent_modification's prototype.
* gutter.c (gutter_extent_signal_changed_region_maybe):
Use byte positions here, avoids needless byte-char conversion.
* gutter.h:
Update the prototype here.
* insdel.c:
* insdel.c (buffer_extent_signal_changed_region):
Implement this in terms of byte positions.
* insdel.c (signal_before_change):
* insdel.c (signal_after_change):
Call report_extent_modification() with byte positions, doing the
char->byte conversion here rather than leaving it to extents.c.
* insdel.h:
* insdel.h (struct each_buffer_change_data):
The extent unchanged info now describes bytecounts.
| author | Aidan Kehoe <kehoea@parhasard.net> |
|---|---|
| date | Fri, 27 Mar 2015 23:39:49 +0000 |
| parents | 56144c8593a8 |
| children |
comparison
equal
deleted
inserted
replaced
| 5878:916187a03b82 | 5879:77d7b77909c2 |
|---|---|
| 520 | 520 |
| 521 /* This is called by extent_changed_for_redisplay, so that redisplay | 521 /* This is called by extent_changed_for_redisplay, so that redisplay |
| 522 knows exactly what extents have changed. */ | 522 knows exactly what extents have changed. */ |
| 523 void | 523 void |
| 524 gutter_extent_signal_changed_region_maybe (Lisp_Object obj, | 524 gutter_extent_signal_changed_region_maybe (Lisp_Object obj, |
| 525 Charbpos UNUSED (start), | 525 Bytexpos UNUSED (start), |
| 526 Charbpos UNUSED (end)) | 526 Bytexpos UNUSED (end)) |
| 527 { | 527 { |
| 528 /* #### Start and end are currently ignored but could be used by a | 528 /* #### Start and end are currently ignored but could be used by a |
| 529 more optimal gutter redisplay. We currently loop over all frames | 529 more optimal gutter redisplay. We currently loop over all frames |
| 530 here, this could be optimized. */ | 530 here, this could be optimized. */ |
| 531 Lisp_Object frmcons, devcons, concons; | 531 Lisp_Object frmcons, devcons, concons; |