Mercurial > hg > xemacs-beta

comparison src/ChangeLog @ 5782:7277cf461612

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
Use an explicit hexadecimal constant for READ_BUF_SIZE, correct ChangeLog. src/ChangeLog addition: 2014-01-20 Aidan Kehoe <kehoea@parhasard.net> * fileio.c [...] (READ_BUF_SIZE): Use an explicit hexadecimal constant for the 0x20000 value for this, don't left-shift 2 16 times. Correct the last ChangeLog entry after Jerry James pointed out a mistake on my part. Thank you for review and discussion, Jerry and Stephen Turnbull.
author Aidan Kehoe <kehoea@parhasard.net>
date Mon, 20 Jan 2014 18:13:15 +0000
parents 0853e1ec8529
children cfc6a8c144f1
comparison
equal deleted inserted replaced
5781:0853e1ec8529 5782:7277cf461612
4 Use alloca_{rawbytes,ibytes} here instead of the implicit alloca 4 Use alloca_{rawbytes,ibytes} here instead of the implicit alloca
5 on the stack; doesn't change where the buffers are allocated for 5 on the stack; doesn't change where the buffers are allocated for
6 these two functions, but does mean that decisions about alloca 6 these two functions, but does mean that decisions about alloca
7 vs. malloc based on buffer size are made in the same place 7 vs. malloc based on buffer size are made in the same place
8 (ultimately, the ALLOCA() macro). 8 (ultimately, the ALLOCA() macro).
9 (READ_BUF_SIZE): Use an explicit hexadecimal constant for the
10 0x20000 value for this, don't left-shift 2 16 times. Correct the
11 last ChangeLog entry after Jerry James pointed out a mistake on my
12 part. Thank you for review and discussion, Jerry and Stephen
13 Turnbull.
9 14
10 2014-01-16 Aidan Kehoe <kehoea@parhasard.net> 15 2014-01-16 Aidan Kehoe <kehoea@parhasard.net>
11 16
12 * fileio.c (READ_BUF_SIZE): 17 * fileio.c (READ_BUF_SIZE):
13 Stack sizes > 2**16 elicited bugs back in August 1996, but there's 18 Stack sizes > 2**16 elicited bugs back in August 1996, but there's
14 nothing to indicate this is still the case. GNU uses a block size 19 nothing to indicate this is still the case. GNU uses a block size
15 of #x10000, and that size works better with the coding system 20 of #x10000 without problems, we can afford to be a bit more
16 buffering, improving performance there; move to this value. 21 adventurous with a value of #x20000.
17 22
18 Use it in #'copy-file too, move its #define earlier to make that 23 Use it in #'copy-file too, move its #define earlier to make that
19 possible. Not relevant to the coding system buffering, but still 24 possible. Not relevant to the coding system buffering, but still
20 helpful. 25 helpful.
21 26