comparison src/ChangeLog @ 5050:6f2158fa75ed

Fix quick-build, use asserts() in place of ABORT() -------------------- ChangeLog entries follow: -------------------- ChangeLog addition: 2010-02-20 Ben Wing <ben@xemacs.org> * configure.ac (XE_COMPLEX_ARG): Correct doc of --quick-build: It also doesn't check for Lisp shadows. src/ChangeLog addition: 2010-02-20 Ben Wing <ben@xemacs.org> * EmacsFrame.c: * EmacsFrame.c (EmacsFrameRecomputeCellSize): * alloca.c (i00afunc): * buffer.c: * buffer.c (MARKED_SLOT): * buffer.c (complex_vars_of_buffer): * cm.c: * cm.c (cmcheckmagic): * console.c: * console.c (MARKED_SLOT): * device-x.c: * device-x.c (x_get_visual_depth): * emacs.c (sort_args): * eval.c (throw_or_bomb_out): * event-stream.c: * event-stream.c (Fadd_timeout): * event-stream.c (Fadd_async_timeout): * event-stream.c (Frecent_keys): * events.c: * events.c (Fdeallocate_event): * events.c (event_pixel_translation): * extents.c: * extents.c (process_extents_for_insertion_mapper): * fns.c (Fbase64_encode_region): * fns.c (Fbase64_encode_string): * fns.c (Fbase64_decode_region): * fns.c (Fbase64_decode_string): * font-lock.c: * font-lock.c (find_context): * frame-x.c: * frame-x.c (x_wm_mark_shell_size_user_specified): * frame-x.c (x_wm_mark_shell_position_user_specified): * frame-x.c (x_wm_set_shell_iconic_p): * frame-x.c (x_wm_set_cell_size): * frame-x.c (x_wm_set_variable_size): * frame-x.c (x_wm_store_class_hints): * frame-x.c (x_wm_maybe_store_wm_command): * frame-x.c (x_initialize_frame_size): * frame.c (delete_frame_internal): * frame.c (change_frame_size_1): * free-hook.c (check_free): * free-hook.c (note_block_input): * free-hook.c (log_gcpro): * gccache-gtk.c (gc_cache_lookup): * gccache-x.c: * gccache-x.c (gc_cache_lookup): * glyphs-gtk.c: * glyphs-gtk.c (init_image_instance_from_gdk_pixmap): * glyphs-x.c: * glyphs-x.c (extract_xpm_color_names): * insdel.c: * insdel.c (move_gap): * keymap.c: * keymap.c (keymap_lookup_directly): * keymap.c (keymap_delete_inverse_internal): * keymap.c (accessible_keymaps_mapper_1): * keymap.c (where_is_recursive_mapper): * lisp.h: * lstream.c (make_lisp_buffer_stream_1): * macros.c: * macros.c (pop_kbd_macro_event): * mc-alloc.c (remove_page_from_used_list): * menubar-x.c: * menubar-x.c (set_frame_menubar): * ralloc.c: * ralloc.c (obtain): * ralloc.c (relinquish): * ralloc.c (relocate_blocs): * ralloc.c (resize_bloc): * ralloc.c (r_alloc_free): * ralloc.c (r_re_alloc): * ralloc.c (r_alloc_thaw): * ralloc.c (init_ralloc): * ralloc.c (Free_Addr_Block): * scrollbar-x.c: * scrollbar-x.c (x_update_scrollbar_instance_status): * sunplay.c (init_device): * unexnt.c: * unexnt.c (read_in_bss): * unexnt.c (map_in_heap): * window.c: * window.c (real_window): * window.c (window_display_lines): * window.c (window_display_buffer): * window.c (set_window_display_buffer): * window.c (unshow_buffer): * window.c (Fget_lru_window): if (...) ABORT(); ---> assert(); More specifically: if (x == y) ABORT (); --> assert (x != y); if (x != y) ABORT (); --> assert (x == y); if (x > y) ABORT (); --> assert (x <= y); etc. if (!x) ABORT (); --> assert (x); if (x) ABORT (); --> assert (!x); DeMorgan's Law's applied and manually simplified: if (x && !y) ABORT (); --> assert (!x || y); if (!x || y >= z) ABORT (); --> assert (x && y < z); Checked to make sure that assert() of an expression with side effects ensures that the side effects get executed even when asserts are disabled, and add a comment about this being a requirement of any "disabled assert" expression. * depend: * make-src-depend: * make-src-depend (PrintDeps): Fix broken code in make-src-depend so it does what it was always supposed to do, which was separate out config.h and lisp.h and all the files they include into separate variables in the depend part of Makefile so that quick-build can turn off the lisp.h/config.h/text.h/etc. dependencies of the source files, to speed up recompilation.
author Ben Wing <ben@xemacs.org>
date Sat, 20 Feb 2010 05:05:54 -0600
parents 22179cd0fe15
children c3d372419e09
comparison
equal deleted inserted replaced
5030:422b4b4fb2a6 5050:6f2158fa75ed
1 2010-02-20 Ben Wing <ben@xemacs.org>
2
3 * EmacsFrame.c:
4 * EmacsFrame.c (EmacsFrameRecomputeCellSize):
5 * alloca.c (i00afunc):
6 * buffer.c:
7 * buffer.c (MARKED_SLOT):
8 * buffer.c (complex_vars_of_buffer):
9 * cm.c:
10 * cm.c (cmcheckmagic):
11 * console.c:
12 * console.c (MARKED_SLOT):
13 * device-x.c:
14 * device-x.c (x_get_visual_depth):
15 * emacs.c (sort_args):
16 * eval.c (throw_or_bomb_out):
17 * event-stream.c:
18 * event-stream.c (Fadd_timeout):
19 * event-stream.c (Fadd_async_timeout):
20 * event-stream.c (Frecent_keys):
21 * events.c:
22 * events.c (Fdeallocate_event):
23 * events.c (event_pixel_translation):
24 * extents.c:
25 * extents.c (process_extents_for_insertion_mapper):
26 * fns.c (Fbase64_encode_region):
27 * fns.c (Fbase64_encode_string):
28 * fns.c (Fbase64_decode_region):
29 * fns.c (Fbase64_decode_string):
30 * font-lock.c:
31 * font-lock.c (find_context):
32 * frame-x.c:
33 * frame-x.c (x_wm_mark_shell_size_user_specified):
34 * frame-x.c (x_wm_mark_shell_position_user_specified):
35 * frame-x.c (x_wm_set_shell_iconic_p):
36 * frame-x.c (x_wm_set_cell_size):
37 * frame-x.c (x_wm_set_variable_size):
38 * frame-x.c (x_wm_store_class_hints):
39 * frame-x.c (x_wm_maybe_store_wm_command):
40 * frame-x.c (x_initialize_frame_size):
41 * frame.c (delete_frame_internal):
42 * frame.c (change_frame_size_1):
43 * free-hook.c (check_free):
44 * free-hook.c (note_block_input):
45 * free-hook.c (log_gcpro):
46 * gccache-gtk.c (gc_cache_lookup):
47 * gccache-x.c:
48 * gccache-x.c (gc_cache_lookup):
49 * glyphs-gtk.c:
50 * glyphs-gtk.c (init_image_instance_from_gdk_pixmap):
51 * glyphs-x.c:
52 * glyphs-x.c (extract_xpm_color_names):
53 * insdel.c:
54 * insdel.c (move_gap):
55 * keymap.c:
56 * keymap.c (keymap_lookup_directly):
57 * keymap.c (keymap_delete_inverse_internal):
58 * keymap.c (accessible_keymaps_mapper_1):
59 * keymap.c (where_is_recursive_mapper):
60 * lisp.h:
61 * lstream.c (make_lisp_buffer_stream_1):
62 * macros.c:
63 * macros.c (pop_kbd_macro_event):
64 * mc-alloc.c (remove_page_from_used_list):
65 * menubar-x.c:
66 * menubar-x.c (set_frame_menubar):
67 * ralloc.c:
68 * ralloc.c (obtain):
69 * ralloc.c (relinquish):
70 * ralloc.c (relocate_blocs):
71 * ralloc.c (resize_bloc):
72 * ralloc.c (r_alloc_free):
73 * ralloc.c (r_re_alloc):
74 * ralloc.c (r_alloc_thaw):
75 * ralloc.c (init_ralloc):
76 * ralloc.c (Free_Addr_Block):
77 * scrollbar-x.c:
78 * scrollbar-x.c (x_update_scrollbar_instance_status):
79 * sunplay.c (init_device):
80 * unexnt.c:
81 * unexnt.c (read_in_bss):
82 * unexnt.c (map_in_heap):
83 * window.c:
84 * window.c (real_window):
85 * window.c (window_display_lines):
86 * window.c (window_display_buffer):
87 * window.c (set_window_display_buffer):
88 * window.c (unshow_buffer):
89 * window.c (Fget_lru_window):
90 if (...) ABORT(); ---> assert();
91
92 More specifically:
93
94 if (x == y) ABORT (); --> assert (x != y);
95 if (x != y) ABORT (); --> assert (x == y);
96 if (x > y) ABORT (); --> assert (x <= y);
97 etc.
98 if (!x) ABORT (); --> assert (x);
99 if (x) ABORT (); --> assert (!x);
100
101 DeMorgan's Law's applied and manually simplified:
102 if (x && !y) ABORT (); --> assert (!x || y);
103 if (!x || y >= z) ABORT (); --> assert (x && y < z);
104
105 Checked to make sure that assert() of an expression with side
106 effects ensures that the side effects get executed even when
107 asserts are disabled, and add a comment about this being a
108 requirement of any "disabled assert" expression.
109
110 * depend:
111 * make-src-depend:
112 * make-src-depend (PrintDeps):
113 Fix broken code in make-src-depend so it does what it was always
114 supposed to do, which was separate out config.h and lisp.h and
115 all the files they include into separate variables in the
116 depend part of Makefile so that quick-build can turn off the
117 lisp.h/config.h/text.h/etc. dependencies of the source files, to
118 speed up recompilation.
119
120
1 2010-02-10 Ben Wing <ben@xemacs.org> 121 2010-02-10 Ben Wing <ben@xemacs.org>
2 122
3 * text.h: 123 * text.h:
4 * text.h (VALIDATE_IBYTEPTR_BACKWARD): 124 * text.h (VALIDATE_IBYTEPTR_BACKWARD):
5 * text.h (EI_ALLOC): 125 * text.h (EI_ALLOC):